January 2017 - Wine-Devel - list.winehq.org

Re: [PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test

by Huw Davies

On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote: > It already works with a null-pointer, but will crash if len is -1. > Since null-pointer means no text, we just return to avoid crashes. > > v2: Followed suggestion by Nikolay Sivov, moved check and extend test Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where it was in your first version. However, the extended test is much better. Huw.

Jan. 9, 2017

Re: `setupapi` patch from staging

by Donat Enikeev

Hi Sebastian, > the patch you are asking about is most likely responsible for the > following regression: > https://bugs.winehq.org/show_bug.cgi?id=41653#c11 Yes, I has been following this bug, and was able to confirm flickering with 2.0-rc4 without StrictDrawOrdering Wine option. But not sure this is a true regression (as plain Wine seems affected as well) Adobe Air Stage3D applications use multiple rendering Direct3D9 threads and seems Wine can't handle the commands order exactly as in Windows (at least for these games and/or some environments), despite all the syncing between threads. So, I believe this is not a regression, the bug is just hidden per forced software rendering; and the trade off is between unplayability because of performance (see gameplay video attached https://bugs.winehq.org/attachment.cgi?id=56048) or flickering without StrictDrawOrdering on some systems What do you think? Best, Donnie On Вс, янв 8, 2017 at 5:57 , Sebastian Lackner <sebastian(a)fds-team.de> wrote: > On 08.01.2017 15:52, Donat Enikeev wrote: >>> It was probably never sent to patch list, so there was nothing to >>> discuss. >> >> Hm, so, do you think it is worth re-submitting for a formal review >> in current state and if so, who is eligible to do that on behalf of >> Michael Muller (michael(a)fds-team.de)? >> >> Best regards, >> Donnie >> > > Hi Donnie, > > the patch you are asking about is most likely responsible for the > following regression: > https://bugs.winehq.org/show_bug.cgi?id=41653#c11 > This means it is not suitable for the development branch yet > (especially during the feature freeze). > > Best regards, > Sebastian >

Jan. 8, 2017

Re: `setupapi` patch from staging

by Sebastian Lackner

On 08.01.2017 15:52, Donat Enikeev wrote: >>It was probably never sent to patch list, so there was nothing to discuss. > > Hm, so, do you think it is worth re-submitting for a formal review in current state and if so, who is eligible to do that on behalf of Michael Muller (michael(a)fds-team.de)? > > Best regards, > Donnie > Hi Donnie, the patch you are asking about is most likely responsible for the following regression: https://bugs.winehq.org/show_bug.cgi?id=41653#c11 This means it is not suitable for the development branch yet (especially during the feature freeze). Best regards, Sebastian

Jan. 8, 2017

Re: `setupapi` patch from staging

by Donat Enikeev

>It was probably never sent to patch list, so there was nothing to discuss. Hm, so, do you think it is worth re-submitting for a formal review in current state and if so, who is eligible to do that on behalf of Michael Muller (michael(a)fds-team.de)? Best regards, Donnie On Вс, янв 8, 2017 at 5:42 , Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 08.01.2017 17:26, Donat Enikeev wrote: >> >> I was unable to find @wine-devel discussion around this patch, I >> would >> be grateful if one could kindly remind why it was staged, probably >> it >> just requires refactoring around the change or additional tests? >> >> > > It was probably never sent to patch list, so there was nothing to > discuss.

Jan. 8, 2017

Re: `setupapi` patch from staging

by Nikolay Sivov

On 08.01.2017 17:26, Donat Enikeev wrote: > > I was unable to find @wine-devel discussion around this patch, I would > be grateful if one could kindly remind why it was staged, probably it > just requires refactoring around the change or additional tests? > > It was probably never sent to patch list, so there was nothing to discuss.

Jan. 8, 2017

`setupapi` patch from staging

by Donat Enikeev

Hi Guys, Number of recent well-known games are based on Starling game engine (Adobe Air+Stage3D for gpu rendering), such as: The Banner Saga 2, Samorost 3, The Inner World, Angry Birds. They are are falling into Software rendering mode on plain Wine and thus barely playable (bug #41635) Thanks to Béla Gyebrószki finding @ bug #41653, Wine makes these games consider d3d9 rendering with the following single patch from wine-staging https://github.com/wine-compholio/wine-staging/blob/master/patches/setupapi… This patch implements support of the case when a full driver path is passed to SetupDiGetClassDevs (trace successfully reaching AddDeviceToSet for a game below [1]). I was unable to find @wine-devel discussion around this patch, I would be grateful if one could kindly remind why it was staged, probably it just requires refactoring around the change or additional tests? I am asking this, because Adobe stopped Linux support for the Air years ago and we could never see such games ported, and therefore plain Wine's support of gpu acceleration for such games looks important. Thanks in advance Best regards, Donnie [1] 0009:trace:setupapi:SetupDiGetClassDevsExW {4d36e968-e325-11ce-bfc1-08002be10318} L"PCI\\VEN_0000&DEV_0000" (nil) 0x0000000a (nil) (null) (nil) 0009:warn:setupapi:SetupDiGetClassDevsExW unsupported flags 0000000a 0009:trace:setupapi:SetupDiCreateDeviceInfoListExW {4d36e968-e325-11ce-bfc1-08002be10318} (nil) (null) (nil) 0009:trace:setupapi:SETUPDI_EnumerateDevices 0x464ac90, {4d36e968-e325-11ce-bfc1-08002be10318}, L"PCI\\VEN_0000&DEV_0000", 0000000a 0009:trace:setupapi:SETUPDI_EnumerateMatchingDeviceInstances L"PCI" L"VEN_0000&DEV_0000" 0009:trace:setupapi:SETUPDI_AddDeviceToSet 0x464ac90, {4d36e968-e325-11ce-bfc1-08002be10318}, 0, L"PCI\\VEN_0000&DEV_0000\\13&12345&0", 0

Jan. 8, 2017

Wine slides for Linux user group?

by Austin English

Howdy, Does anyone have some recentish slides I could build on for a local Linux user group presentation about Wine? Thanks

Jan. 7, 2017

Re: ddraw/tests: A spelling fix in an ok() message.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27624 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

Jan. 7, 2017

Re: ddraw/tests: Spelling fixes in a few comments.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27623 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

Jan. 7, 2017

Re: dxgi/tests: Some spelling fixes in ok() messages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27612 Your paranoid android. === w7pro64 (32 bit device) === device.c:1445: Test failed: SetFullscreenState failed, hr 0x887a0004.

Jan. 7, 2017