January 2017 - Wine-Devel - list.winehq.org

Re: patches: Display multiple check marks for multiple signoffs.

by André Hentschel

Am 29.01.2017 um 21:56 schrieb Bruno Jesus: > On Sun, Jan 29, 2017 at 6:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: >>> The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list >>> ... >>> 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ >>> ... >>> 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ >>> ... >>> >>> I think something like that was what Bruno is looking for >> >> It is half-working then, because my patch 129061 is double checked >> because of Andrew's sign 129073. So it is missing some update after >> receiving new sign-offs, I don't know. > > Judging by the current contents of the list I infer that the other > signs are only added after the email is marked as Sign-off type. > Yeah, think so too

Jan. 29, 2017

Re: patches: Display multiple check marks for multiple signoffs.

by Bruno Jesus

On Sun, Jan 29, 2017 at 6:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: >> The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list >> ... >> 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ >> ... >> 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ >> ... >> >> I think something like that was what Bruno is looking for > > It is half-working then, because my patch 129061 is double checked > because of Andrew's sign 129073. So it is missing some update after > receiving new sign-offs, I don't know. Judging by the current contents of the list I infer that the other signs are only added after the email is marked as Sign-off type.

Jan. 29, 2017

Re: patches: Display multiple check marks for multiple signoffs.

by Bruno Jesus

On Sun, Jan 29, 2017 at 6:24 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > Hi, Hi, German friend. > > ... > > > The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list > ... > 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ > ... > 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ > ... > > I think something like that was what Bruno is looking for It is half-working then, because my patch 129061 is double checked because of Andrew's sign 129073. So it is missing some update after receiving new sign-offs, I don't know. Best wishes, Bruno

Jan. 29, 2017

Re: patches: Display multiple check marks for multiple signoffs.

by André Hentschel

Hi, > --- a/patches/update > +++ b/patches/update > @@ -229,7 +229,7 @@ foreach my $file (sort { $patches{$b}->{"order"} <=> $patches{$a}->{"order"} } k > } > if (defined($patch->{"signoff"})) > { > - printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">✓</td>"; > + printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">%s</td>", "✓" x @{$patch->{"signoff"}}; > } The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ... I think something like that was what Bruno is looking for

Jan. 29, 2017

Re: [v2 PATCH 3/3] windowscodecs: Add support for palette image formats to PNG encoder.

by Dmitry Timoshkov

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > On 27.01.2017 22:28, Vincent Povirk wrote: > >> + else > >> + { > >> + png_palette[i].red = 0; > >> + png_palette[i].green = 0; > >> + png_palette[i].blue = 0; > >> + } > > > > Why is it necessary to pad the palette in this way? Couldn't you just > > pass the appropriate number of colors? > > > > > > Clamping to 1 << This->format->bit_depth is necessary (see the comment > about newer libpng versions), but padding the palette probably isn't, > at least I'm not aware of any test for it. It still would be a good idea to test this, a standalone application should be fine. Although I'd guess this basically depends on libpng (old vs. new) behaviour, as far as I can see from my own tests WIC in Windows doesn't impose limitations to a PNG palette size. > It should be fine to replace > > colors = 1 << This->format->bit_depth; > > with > > colors = min(This->colors, 1 << This->format->bit_depth); > > and to remove the else branch. That should work, if newer libpng versions accept such palette sizes. -- Dmitry.

Jan. 29, 2017

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.

by guillaume.charifi＠sfr.fr

Yes, you're right, I forgot to commit the declaration of raw_resource in wined3d_private. And yes, it can be replaced by dst instead. <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;"> <div class="gl_quoted">On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi wrote: > Signed-off-by: Guillaume Charifi > --- > dlls/wined3d/arb_program_shader.c | 1 + > dlls/wined3d/glsl_shader.c | 1 + > dlls/wined3d/shader.c | 6 ++++++ > dlls/wined3d/shader_sm4.c | 10 ++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 5 files changed, 19 insertions(+) This patch doesn't even compile. Please test your patches before sending them to wine-patches. > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins, > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count, > + struct wined3d_sm4_data *priv) > +{ > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg); > +} You should just use "ins->declaration.dst".</div> </div>

Jan. 29, 2017

Re: [PATCH 1/7] regedit: Use a helper for LoadString() and add debug information

by Dmitry Timoshkov

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -static INT vmessagebox(HWND hwnd, INT buttons, INT titleId, INT resId, va_list ap) > +static void load_string(unsigned int msg_id, WCHAR *buf, unsigned int count) > { > static const WCHAR errorW[] = {'E','r','r','o','r',0}; > - static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',' ','e','r','r','o','r',' ','s','t','r','i','n','g','!',0}; > > + if (!buf) return; > + > + if (!LoadStringW(hInst, msg_id, buf, count)) > + { > + WINE_FIXME("LoadString failed with %u\n", GetLastError()); > + lstrcpyW(buf, errorW); > + } > +} Probably using a flavour of lstrcpy that checks the target buffer length would be more appropriate. Although simply returning an empty buffer and an error indicator to the caller could be slightly better. Under which conditions LoadString may fail here? -- Dmitry.

Jan. 29, 2017

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.

by Józef Kucia

On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/arb_program_shader.c | 1 + > dlls/wined3d/glsl_shader.c | 1 + > dlls/wined3d/shader.c | 6 ++++++ > dlls/wined3d/shader_sm4.c | 10 ++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 5 files changed, 19 insertions(+) This patch doesn't even compile. Please test your patches before sending them to wine-patches. > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins, > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count, > + struct wined3d_sm4_data *priv) > +{ > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg); > +} You should just use "ins->declaration.dst".

Jan. 29, 2017

Re: [PATCH] wined3d: Implement buffer texture range.

by Józef Kucia

Please add a test. On Sun, Jan 29, 2017 at 12:25 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > + GL_EXTCALL(glTexBufferRange(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object, > + desc->u.buffer.start_idx, desc->u.buffer.count)); This is wrong.

Jan. 29, 2017

RE : [PATCH] wined3d: Implement buffer texture range.

by Guillaume Charifi

Woops, I forgot the patch adding the required extension, I'll send it later.

Jan. 29, 2017