October 2017 - Wine-Devel - list.winehq.org

Re: [v3] oleaut32: Add ARM support to DispCallFunc().

by Martin Storsjö

On Tue, 31 Oct 2017, Alexandre Julliard wrote: > Donna Whisnant <dewhisna(a)dewtronics.com> writes: > >> Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls >> to succeed on ARM platforms. This change specifically targets only >> 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be >> compatible with big-endian (ARMEB) platforms, but testing for that >> platform should be completed before enabling. >> >> Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd >> container to compile and run it on an x86-64 Host.. When running on >> Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine >> to function. > > It breaks the Android build: > > arm-linux-androideabi-gcc -c -o typelib.o ../../../wine/dlls/oleaut32/typelib.c -I. -I../../../wine/dlls/oleaut32 \ > -I../../include -I../../../wine/include -D__WINESRC__ -D_OLEAUT32_ -D_REENTRANT -fPIC -Wall -pipe \ > -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ > -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ > -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret -D__ANDROID_API__=26 -marm > {standard input}: Assembler messages: > {standard input}:32: Error: selected processor does not support ARM mode `vldm r3!,{s0-s15}' > Makefile:516: recipe for target 'typelib.o' failed > make: *** [typelib.o] Error 1 FWIW, this is the same issue as was discussed before here: https://www.winehq.org/pipermail/wine-devel/2017-September/118872.html // Martin

Oct. 31, 2017

Re: [v3] oleaut32: Add ARM support to DispCallFunc().

by Alexandre Julliard

Donna Whisnant <dewhisna(a)dewtronics.com> writes: > Adds ARM ABI support to DispCallFunc() to allow IDispatch invoke calls > to succeed on ARM platforms. This change specifically targets only > 32-bit little-endian (ARMEL) platform CPUs. It's believed to likely be > compatible with big-endian (ARMEB) platforms, but testing for that > platform should be completed before enabling. > > Tested on Raspbian Stretch 2017-09-07 RPi image using a Qemu systemd > container to compile and run it on an x86-64 Host.. When running on > Raspberry Pi hardware, a 3G/1G split kernel needs to be used for Wine > to function. It breaks the Android build: arm-linux-androideabi-gcc -c -o typelib.o ../../../wine/dlls/oleaut32/typelib.c -I. -I../../../wine/dlls/oleaut32 \ -I../../include -I../../../wine/include -D__WINESRC__ -D_OLEAUT32_ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret -D__ANDROID_API__=26 -marm {standard input}: Assembler messages: {standard input}:32: Error: selected processor does not support ARM mode `vldm r3!,{s0-s15}' Makefile:516: recipe for target 'typelib.o' failed make: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2017

Re: [PATCH 1/4] dx8vb: Add stubs for D3DX8 interface

by Fabian Maurer

> > + > > +/*** d3dx8 - IUnknown methods ***/ > > + > > Comment seems a bit useless, you're not going to use this file for anything > else. What makes you think that? There are more interfaces that could be implemented. > > + if (IsEqualGUID(riid, &IID_IUnknown)) > > + *ppv = &This->ID3DX8_iface; > > + else if(IsEqualGUID(riid, &IID_ID3DX8)) > > + *ppv = &This->ID3DX8_iface; > > + else if(IsEqualGUID(riid, &IID_IPersistPropertyBag)) > > + FIXME("No interface for IID_IPersistPropertyBag\n"); > > + else if(IsEqualGUID(riid, &IID_IPersistStreamInit)) > > + FIXME("No interface for IID_IPersistStreamInit\n"); > > + else > > Where does this come from? The else part with > FIXME("No interface for %s\n", debugstr_guid(riid)); outputted this GUID, so I added a specific FIXME for that interface. It seemed reasonable to output a name instead of a GUID. Regards, Fabian Maurer

Oct. 31, 2017

Re: [PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs

by Fabian Maurer

> > > > - FIXME("(%p): stub!\n", ret); > > + HRESULT res = direct3d8_create(ret); > > > > - return E_NOTIMPL; > > + TRACE("(%p) -> (%x)\n", ret, res); > > + > > + return res; > > > > } > > That's an unusual way to arrange things. Why don't you return as "return > direct3d8_create();" ? I did this so I can trace the return value. Since it's a wrapper with nearly no own code I figured it makes sense. Is this unneeded? Because if so, I'll change that. Regards, Fabian Maurer

Oct. 31, 2017

Re: [PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs

by Nikolay Sivov

> > > static HRESULT WINAPI directx8_QueryInterface(IDirectX8 *iface, REFIID > riid, void **ppv) > @@ -237,9 +440,11 @@ static HRESULT WINAPI directx8_ > DirectPlayAddressCreate(IDirectX8 *iface, DirectP > > static HRESULT WINAPI directx8_Direct3DCreate(IDirectX8 *iface, > Direct3D8 **ret) > { > - FIXME("(%p): stub!\n", ret); > + HRESULT res = direct3d8_create(ret); > > - return E_NOTIMPL; > + TRACE("(%p) -> (%x)\n", ret, res); > + > + return res; > } > That's an unusual way to arrange things. Why don't you return as "return direct3d8_create();" ?

Oct. 31, 2017

Re: [PATCH 1/4] dx8vb: Add stubs for D3DX8 interface

by Nikolay Sivov

On Tue, Oct 31, 2017 at 2:31 AM, Fabian Maurer <dark.shadow4(a)web.de> wrote: > > main.c > > IDL_SRCS = dx8vb.idl > diff --git a/dlls/dx8vb/d3dx8.c b/dlls/dx8vb/d3dx8.c > new file mode 100644 > index 0000000000..2959849547 > --- /dev/null > +++ b/dlls/dx8vb/d3dx8.c > @@ -0,0 +1,861 @@ > + /* > + * Copyright 2017 Fabian Maurer > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +#define COBJMACROS > + > +#include "config.h" > + > +#include "dx8vb_private.h" > +#include "ocidl.h" > + > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(dx8vb); > + > +typedef struct > +{ > + ID3DX8 ID3DX8_iface; > + LONG ref; > +} d3dx8; > + > +static inline d3dx8 *impl_from_ID3DX8(ID3DX8 *iface) > +{ > + return CONTAINING_RECORD(iface, d3dx8, ID3DX8_iface); > +} > + > +/*** d3dx8 - IUnknown methods ***/ > + > Comment seems a bit useless, you're not going to use this file for anything else. > +static HRESULT WINAPI d3dx8_QueryInterface(ID3DX8 *iface, REFIID riid, > void **ppv) > +{ > + d3dx8 *This = impl_from_ID3DX8(iface); > + > + TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppv); > + > + *ppv = NULL; > + > + if (IsEqualGUID(riid, &IID_IUnknown)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_ID3DX8)) > + *ppv = &This->ID3DX8_iface; > + else if(IsEqualGUID(riid, &IID_IPersistPropertyBag)) > + FIXME("No interface for IID_IPersistPropertyBag\n"); > + else if(IsEqualGUID(riid, &IID_IPersistStreamInit)) > + FIXME("No interface for IID_IPersistStreamInit\n"); > + else > Where does this come from?

Oct. 31, 2017

Setting a source directory in winedbg

by Mihai Todor

Hi Everyone, I noticed that I can set the source directory via the `dir` command in winedbg, but, for some reason, it rejects absolute paths, like Z:\bla\blah, claiming that ":" is a syntax error. I tried to enclose the path in quotes / double quotes, but then the quote / double quote is rejected as a syntax error. I don't have sufficient knowledge of bison to grok the code in programs/winedbg/dbg.y, so is there a way to escape the colon symbol? As a workaround, I mapped my build directory under Wine, but that is really annoying. Thank you, Mihai Todor

Oct. 30, 2017

Re: Wineconference keynote 2017

by Stefan Dösinger

Cool :-) . I have my own recordings of video + sound and plan to put together proper videos of the talks, but it’ll take a while. Anybody who is willing to help please contact me! I might use your video + audio stream to patch up places where my recordings have issues. Cheers, Stefan > Am 28.10.2017 um 13:05 schrieb Marcus Meissner <meissner(a)suse.de>: > > Hi folks, > > I have uploaded Alexandres Wineconference 2017 Keynote to youtube: > > https://www.youtube.com/watch?v=AokFgDSLMWU&t=772s > > Ciao, Marcus > >

Oct. 30, 2017

Re: WineConf agenda

by Alex Henrie

2017-10-23 8:18 GMT+02:00 Alex Henrie <alexhenrie24(a)gmail.com>: > 2017-10-13 5:23 GMT-06:00 Jacek Caban <jacek(a)codeweavers.com>: >> It's getting close to WineConf and I think it's time to think about agenda. >> Does anyone have anything he'd like to talk about? Any ideas about >> conversations we should have? Feel free to add them to >> https://wiki.winehq.org/WineConf2017 > > It would be nice to talk about the fake DLL problem. In case you're > not familiar, numerous popular applications (Chrome, Steam, StarCraft, > Overwatch...) manually load system DLLs into memory, do some > verification checks, and then attempt to jump into the DLL's code. > This causes a crash because Wine's DLLs are fakes that don't contain > the actual function code. Wine Staging has a solution to the problem > involving making the fake DLLs more realistic and then catching and > redirecting attempts to execute memory-mapped code. I'm curious to > know what it would take to get the Wine Staging solution or another > reasonable solution into mainline Wine. There are at least two open bugs about the fake DLL problem: https://bugs.winehq.org/show_bug.cgi?id=39403 https://bugs.winehq.org/show_bug.cgi?id=42741 And at least two more that are related: https://bugs.winehq.org/show_bug.cgi?id=40479 https://bugs.winehq.org/show_bug.cgi?id=37585 -Alex

Oct. 29, 2017

Re: [v2] oleaut32: Add ARM support to DispCallFunc().

by Donna Whisnant

V3 has been posted. Other comments are inlined below... > > Hi, > > thanks, but it seems I missed minor things last time: > > > + args = heap_alloc(sizeof(VARIANT) * cActuals + sizeof(DWORD) * 4 ); > > Try to be consistent with the spaces for each function call. > Sorry. That one came from a cut-and-paste of the i386 code and I missed fixing it. > > + case VT_R4: /* these must be 4-byte aligned, and put in 's' regs or stack, as they are single-floats */ > > + if (scount < 16) > > + regs.sd.s[scount++] = V_R4(arg); > > + else > > + args[argspos++] = V_UI4(arg); > > + break; > ... > > + case VT_VARIANT: > > + /* 8-byte align 'r' and/or stack: */ > > + if (rcount < 3) > > + { > > + rcount += (rcount % 2); > > + } > > + else > > + { > > + rcount = 4; > > + argspos += (argspos % 2); > > + } > ... > > + case VT_BOOL: /* VT_BOOL is 16-bit but BOOL is 32-bit, needs to be extended */ > > + if (rcount < 4) > > + regs.r[rcount++] = V_BOOL(arg); > > + else > > + args[argspos++] = V_BOOL(arg); > > + break; > > + default: > > + if (rcount < 4) > > + regs.r[rcount++] = V_UI4(arg); > > + else > > + args[argspos++] = V_UI4(arg); > > + break; > > + } > > Maybe one of those is not really conistent wrt curly brackets > That was actually intentional, as I made the 'if' in the VT_VARIANT case consistent with itself. All of the others cited needed no curly braces on either half of the 'if'. However, that one had to have curly braces on the 'else', so I made it consistent on the other side too and used curly braces throughout the 'if'. My usage of curly braces with respect to 'if' statements was to use them on both halves or neither half... But since you want them removed, I have removed the extra curly braces on that one in the v3 post. > > + case VT_CY: > > + V_UI8(pvargResult) = call_method(func, argspos, args, (DWORD*)&regs ); > > + break; > > + default: > > + V_UI4(pvargResult) = call_method( func, argspos, args, (DWORD*)&regs ); > > + break; > > space issue again, maybe somewhere else too? > Oops, I missed that one space. Fixed. I didn't spot any others. The rest appear correct or are at least consistent throughout.

Oct. 28, 2017