October 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] dwrite: Free the mappings array, but not every element.

by Huw Davies

On 2 Oct 2017, at 10:26, Huw Davies <huw(a)codeweavers.com> wrote: > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/dwrite/analyzer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c > index 6808b468d6..183abed7f9 100644 > --- a/dlls/dwrite/analyzer.c > +++ b/dlls/dwrite/analyzer.c > @@ -2305,8 +2305,8 @@ static ULONG WINAPI fontfallbackbuilder_Release(IDWriteFontFallbackBuilder *ifac > IDWriteFontCollection_Release(mapping->collection); > heap_free(mapping->ranges); > heap_free(mapping->locale); > - heap_free(mapping); > } > + heap_free(fallbackbuilder->mappings); > > IDWriteFactory5_Release(fallbackbuilder->factory); > heap_free(fallbackbuilder); Ah, this is a dup of 137464. Huw.

Oct. 2, 2017

Re: [PATCH 2/2] winhttp: Send basic authorization credentials with the first request if they've been set.

by Huw Davies

On 2 Oct 2017, at 09:57, Marvin <testbot(a)winehq.org> wrote: > > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=33362 > > Your paranoid android. > > > === w2008s64 (64 bit winhttp) === > winhttp.c:1148: Test failed: request failed unexpectedly 400 This appears to be unrelated to my patch. Huw.

Oct. 2, 2017

Re: [PATCH 2/2] winhttp: Send basic authorization credentials with the first request if they've been set.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33362 Your paranoid android. === w2008s64 (64 bit winhttp) === winhttp.c:1148: Test failed: request failed unexpectedly 400

Oct. 2, 2017

Re: Update Japanese translation.

by Hugh McMaster

Hi Akihiro, On Sunday, 1 October 2017 11:23 PM, Akihiro Sagawa wrote: > #: regedit.rc:213 > -#, fuzzy > -#| msgid "" > -#| "Are you sure you want to delete the registry key '%1' and all of its " > -#| "subkeys?" > msgid "" > "Are you sure you want to delete this registry key and all of its subkeys?" > -msgstr "本当にレジストリキー '%1' とそのサブキーを削除しますか?" > +msgstr "本当にこのレジストリキー '%1' とそのサブキーすべてを削除しますか?" You left the '%1' in the updated string. -- Hugh McMaster

Oct. 2, 2017

Re: [PATCH] msvcrt: Don't crash if _vsnwprintf gets NULL as format string

by Fabian Maurer

On Sonntag, 1. Oktober 2017 23:22:19 CEST Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=33350 > > Your paranoid android. > > > === wxppro (32 bit printf) === > 09e8:printf: unhandled exception c0000005 at 77C431F7 > > === w2003std (32 bit printf) === > 05f0:printf: unhandled exception c0000005 at 77BD4190 Welp, XP seems to behave different, I'll need to rework that. Regards, Fabian Maurer

Oct. 1, 2017

Re: [PATCH] msvcrt: Don't crash if _vsnwprintf gets NULL as format string

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33350 Your paranoid android. === wxppro (32 bit printf) === 09e8:printf: unhandled exception c0000005 at 77C431F7 === w2003std (32 bit printf) === 05f0:printf: unhandled exception c0000005 at 77BD4190

Oct. 1, 2017