October 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] mshtml/tests: Skip postMessage test on IE7.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33746 Your paranoid android. === w7pro64 (32 bit htmldoc) === htmldoc.c:3118: Test failed: Incorrect error code: -2146697211 htmldoc.c:3123: Test failed: Page address: L"http://test.winehq.org/tests/winehq_snapshot/" htmldoc.c:5895: Test failed: expected OnChanged_1012 htmldoc.c:5896: Test failed: expected Exec_HTTPEQUIV htmldoc.c:5898: Test failed: expected Exec_SETTITLE htmldoc.c:5939: Test failed: expected FireNavigateComplete2

Oct. 24, 2017

Re: [PATCH 2/3] gdiplus: Add internal string format properties used by EMF+ records

by Vincent Povirk

I think the margins in default_drawstring_format should be 1/6. It's not currently used in GdipDrawString or GdipMeasureString, but that's something we may change in the future. Also, they're copied over to generic_default_format which would've had 1/6 margins previously.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Dmitry Timoshkov

Hans Leidekker <hans(a)codeweavers.com> wrote: > I'm looking for the Kerberos Security Support Provider (SSP). SSPs > are loaded through a different key and obtained with > InitSecurityInterface. https://technet.microsoft.com/en-us/library/dn169026(v=ws.10).aspx From https://technet.microsoft.com/en-us/library/dn169026(v=ws.10).aspx#BKMK_Ker… "The Kerberos SSP, Kerberos.dll, uses the Kerberos V5 authentication protocol (RFC 4120)." -- Dmitry.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Dmitry Timoshkov

Hans Leidekker <hans(a)codeweavers.com> wrote: > > > > On Tue, 2017-10-24 at 11:44 +0200, Alexandre Julliard wrote: > > > > > I liked the idea of putting this in kerberos.dll. Have you given up on > > > > > > > this? > > > > > > > > > > > > I liked it too, but it turns out that this dll doesn't implement the > > > > > > interface secur32 uses to load SSP modules (a SecurityFunctionTable > > > > > > returned by InitSecurityInterface). > > > > > > > > > > > > It's also clear now that native doesn't use the SecurityProviders > > > > > > registry key to load the Kerberos provider. > > > > > > > > > > Yes, but isn't that a matter of figuring out how secur32 is supposed to > > > > > load it instead? Or do you believe that it's now all inside secur32 on > > > > > Windows too? > > > > > > > > It looks like it. Searching the registry didn't turn up anything > > > > relevant. I looked for other dlls which export InitSecurityInterface > > > > (assuming it would use the same mechanism) but found none that > > > > implements Kerberos. > > > > > > secur32.dll in Windows 7 doesn't have any references or snippets of > > > the words resembling "Kerberos" in any combination of cases. > > > > > > On the other hand kerberos.dll has the references to sspicli.dll and > > > secur32.dll. > > > > > > So it looks like secur32.dll in Windows doesn't implement Kerberos SSP. > > > > If the presence of the following unicode text is more convincing > > > > +#define KERBEROS_COMMENT \ > > + {'M','i','c','r','o','s','o','f','t',' ','K','e','r','b','e','r','o','s',' ','V','1','.','0',0} > > +static CHAR kerberos_comment_A[] = KERBEROS_COMMENT; > > +static WCHAR kerberos_comment_W[] = KERBEROS_COMMENT; > > > > then this text does present in kerberos.dll in Windows 7. > > Well, this dll implements the Kerberos LSA security package. It's > listed under Control\LSA\Security Packages along with msv1_0 and > schannel, and it exports SpLsaModeInitialize. kerberos.dll implements both SSP/SA providers. If secure32.dll would implement anything kerberos related it would contain at least single ansi/unicode string "kerberos", but it does not. > I'm looking for the Kerberos Security Support Provider (SSP). SSPs > are loaded through a different key and obtained with > InitSecurityInterface. Then probably you are looking in the wrong direction. -- Dmitry.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Hans Leidekker

On Tue, 2017-10-24 at 21:10 +0800, Dmitry Timoshkov wrote: > mitry Timoshkov <dmitry(a)baikal.ru> wrote: > > > Hans Leidekker <hans(a)codeweavers.com> wrote: > > > > > On Tue, 2017-10-24 at 11:44 +0200, Alexandre Julliard wrote: > > > > I liked the idea of putting this in kerberos.dll. Have you given up on > > > > > > this? > > > > > > > > > > I liked it too, but it turns out that this dll doesn't implement the > > > > > interface secur32 uses to load SSP modules (a SecurityFunctionTable > > > > > returned by InitSecurityInterface). > > > > > > > > > > It's also clear now that native doesn't use the SecurityProviders > > > > > registry key to load the Kerberos provider. > > > > > > > > Yes, but isn't that a matter of figuring out how secur32 is supposed to > > > > load it instead? Or do you believe that it's now all inside secur32 on > > > > Windows too? > > > > > > It looks like it. Searching the registry didn't turn up anything > > > relevant. I looked for other dlls which export InitSecurityInterface > > > (assuming it would use the same mechanism) but found none that > > > implements Kerberos. > > > > secur32.dll in Windows 7 doesn't have any references or snippets of > > the words resembling "Kerberos" in any combination of cases. > > > > On the other hand kerberos.dll has the references to sspicli.dll and > > secur32.dll. > > > > So it looks like secur32.dll in Windows doesn't implement Kerberos SSP. > > If the presence of the following unicode text is more convincing > > +#define KERBEROS_COMMENT \ > + {'M','i','c','r','o','s','o','f','t',' ','K','e','r','b','e','r','o','s',' ','V','1','.','0',0} > +static CHAR kerberos_comment_A[] = KERBEROS_COMMENT; > +static WCHAR kerberos_comment_W[] = KERBEROS_COMMENT; > > then this text does present in kerberos.dll in Windows 7. Well, this dll implements the Kerberos LSA security package. It's listed under Control\LSA\Security Packages along with msv1_0 and schannel, and it exports SpLsaModeInitialize. I'm looking for the Kerberos Security Support Provider (SSP). SSPs are loaded through a different key and obtained with InitSecurityInterface.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Dmitry Timoshkov

mitry Timoshkov <dmitry(a)baikal.ru> wrote: > Hans Leidekker <hans(a)codeweavers.com> wrote: > > > On Tue, 2017-10-24 at 11:44 +0200, Alexandre Julliard wrote: > > > I liked the idea of putting this in kerberos.dll. Have you given up on > > > > > this? > > > > > > > > I liked it too, but it turns out that this dll doesn't implement the > > > > interface secur32 uses to load SSP modules (a SecurityFunctionTable > > > > returned by InitSecurityInterface). > > > > > > > > It's also clear now that native doesn't use the SecurityProviders > > > > registry key to load the Kerberos provider. > > > > > > Yes, but isn't that a matter of figuring out how secur32 is supposed to > > > load it instead? Or do you believe that it's now all inside secur32 on > > > Windows too? > > > > It looks like it. Searching the registry didn't turn up anything > > relevant. I looked for other dlls which export InitSecurityInterface > > (assuming it would use the same mechanism) but found none that > > implements Kerberos. > > secur32.dll in Windows 7 doesn't have any references or snippets of > the words resembling "Kerberos" in any combination of cases. > > On the other hand kerberos.dll has the references to sspicli.dll and > secur32.dll. > > So it looks like secur32.dll in Windows doesn't implement Kerberos SSP. If the presence of the following unicode text is more convincing +#define KERBEROS_COMMENT \ + {'M','i','c','r','o','s','o','f','t',' ','K','e','r','b','e','r','o','s',' ','V','1','.','0',0} +static CHAR kerberos_comment_A[] = KERBEROS_COMMENT; +static WCHAR kerberos_comment_W[] = KERBEROS_COMMENT; then this text does present in kerberos.dll in Windows 7. -- Dmitry.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Dmitry Timoshkov

Hans Leidekker <hans(a)codeweavers.com> wrote: > On Tue, 2017-10-24 at 11:44 +0200, Alexandre Julliard wrote: > > I liked the idea of putting this in kerberos.dll. Have you given up on > > > > this? > > > > > > I liked it too, but it turns out that this dll doesn't implement the > > > interface secur32 uses to load SSP modules (a SecurityFunctionTable > > > returned by InitSecurityInterface). > > > > > > It's also clear now that native doesn't use the SecurityProviders > > > registry key to load the Kerberos provider. > > > > Yes, but isn't that a matter of figuring out how secur32 is supposed to > > load it instead? Or do you believe that it's now all inside secur32 on > > Windows too? > > It looks like it. Searching the registry didn't turn up anything > relevant. I looked for other dlls which export InitSecurityInterface > (assuming it would use the same mechanism) but found none that > implements Kerberos. secur32.dll in Windows 7 doesn't have any references or snippets of the words resembling "Kerberos" in any combination of cases. On the other hand kerberos.dll has the references to sspicli.dll and secur32.dll. So it looks like secur32.dll in Windows doesn't implement Kerberos SSP. -- Dmitry.

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Hans Leidekker

On Tue, 2017-10-24 at 11:44 +0200, Alexandre Julliard wrote: > I liked the idea of putting this in kerberos.dll. Have you given up on > > > this? > > > > I liked it too, but it turns out that this dll doesn't implement the > > interface secur32 uses to load SSP modules (a SecurityFunctionTable > > returned by InitSecurityInterface). > > > > It's also clear now that native doesn't use the SecurityProviders > > registry key to load the Kerberos provider. > > Yes, but isn't that a matter of figuring out how secur32 is supposed to > load it instead? Or do you believe that it's now all inside secur32 on > Windows too? It looks like it. Searching the registry didn't turn up anything relevant. I looked for other dlls which export InitSecurityInterface (assuming it would use the same mechanism) but found none that implements Kerberos.

Oct. 24, 2017

Re: [PATCH] wmvcore/tests: Access IWMDRMReader(|2|3) interfaces on Windows.

by Jefferson Carpenter

;...( On Oct 24, 2017 4:41 AM, "Alexandre Julliard" <julliard(a)winehq.org> wrote: Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> writes: > I knew it was possible to get DRM interfaces because I have an > application that queries for an IWMDRMReader (I forget 1, 2, or 3) > over and over and over until S_OK is returned. To begin finding out > why the return value is sometimes S_OK and sometimes E_NOINTERFACE, I > compiled an exe that runs WMCreateReader and queries for the > IWMDRMReader2 interface, and then stepped through the assembly. Turns > out, the value at that memory location is checked inside of > QueryInterface. That's not an acceptable way of figuring things out. If you have an application that uses this, you can look at what the app is doing, and try to reproduce that behavior in a test case; but the Microsoft DLLs have to be treated as black boxes. You can call public APIs and see what they return, but you can't look inside the box. In particular, disassembling the code is strictly forbidden. I'm afraid this means I can no longer accept any patches of yours implementing this functionality. -- Alexandre Julliard julliard(a)winehq.org

Oct. 24, 2017

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > On Tue, 2017-10-24 at 10:27 +0200, Alexandre Julliard wrote: >> Hans Leidekker <hans(a)codeweavers.com> writes: >> >> > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> >> > --- >> > configure.ac | 18 +++ >> > dlls/secur32/Makefile.in | 2 +- >> > dlls/secur32/kerberos.c | 276 +++++++++++++++++++++++++++++++++++++++++--- >> > dlls/secur32/secur32.c | 1 + >> > dlls/secur32/secur32_priv.h | 1 + >> > 5 files changed, 282 insertions(+), 16 deletions(-) >> >> I liked the idea of putting this in kerberos.dll. Have you given up on >> this? > > I liked it too, but it turns out that this dll doesn't implement the > interface secur32 uses to load SSP modules (a SecurityFunctionTable > returned by InitSecurityInterface). > > It's also clear now that native doesn't use the SecurityProviders > registry key to load the Kerberos provider. Yes, but isn't that a matter of figuring out how secur32 is supposed to load it instead? Or do you believe that it's now all inside secur32 on Windows too? -- Alexandre Julliard julliard(a)winehq.org

Oct. 24, 2017