November 2017 - Wine-Devel - list.winehq.org

wdscore: Add stub DLL.

by Stefan Leichter

The wdscore.dll is used from the Windows 10 MediaCreationTool.exe Signed-off-by: Stefan Leichter <sle85276(a)gmx.de> --- configure.ac | 1 + dlls/wdscore/Makefile.in | 4 ++ dlls/wdscore/wdscore.spec | 161 ++++++++++++++++++++++++++++++++++++++++++++ dlls/wdscore/wdscore_main.c | 43 ++++++++++++ 4 files changed, 209 insertions(+) create mode 100644 dlls/wdscore/Makefile.in create mode 100644 dlls/wdscore/wdscore.spec create mode 100644 dlls/wdscore/wdscore_main.c

Nov. 30, 2017

Re: [PATCH 1/3] ntdll: NtReadFileScatter results are reported asynchronously

by Andrew Eikum

On Thu, Nov 30, 2017 at 01:16:35PM -0600, Andrew Eikum wrote: > On Thu, Nov 30, 2017 at 07:59:37PM +0100, Jacek Caban wrote: > > Hi Andrew, > > > > On 30.11.2017 18:23, Andrew Eikum wrote: > > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > > > index ca2afa0e89..12b1d0f6c5 100644 > > > --- a/dlls/ntdll/file.c > > > +++ b/dlls/ntdll/file.c > > > @@ -1105,7 +1105,7 @@ NTSTATUS WINAPI NtReadFileScatter( HANDLE file, HANDLE event, PIO_APC_ROUTINE ap > > > > > > if (send_completion) NTDLL_AddCompletion( file, cvalue, status, total ); > > > > > > - return status; > > > + return STATUS_PENDING; > > > > Are you sure it should always be a case? Your tests use overlaped file > > handle, I guess that's what makes differences. At least that's what I've > > seen with other similar APIs (eg. recent Windows versions always return > > STATUS_PENDING for ioctls if handle is overlapped). > > > > I thought it was weird that this behaved different from other ntdll > functions. I hadn't thought of the file handle type. I'll try with a > non-overlapped file and see what changes. > Actually, MSDN says the handle must be created with FILE_FLAG_OVERLAPPED, and a quick test confirms that. Andrew

Nov. 30, 2017

Re: [PATCH] gdiplus/tests: Check more return values (Coverity)

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

Nov. 30, 2017

Re: [PATCH v6 2/2] gdiplus: In GdipPrivateAddMemoryFont allow loading fonts with long names

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> +static WCHAR *create_testfontfile(const WCHAR *filename, int resource) +{ + static WCHAR pathW[MAX_PATH]; ... + return pathW; +} I guess this is fine, but I think it'd be simpler to have the caller pass in a buffer.

Nov. 30, 2017

[PATCH] msvcrt: Don't report error in fclose on already closed stream

by Piotr Caban

For bug #44091. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/file.c | 6 ++++++ dlls/msvcrt/tests/file.c | 3 +++ 2 files changed, 9 insertions(+)

Nov. 30, 2017

Re: [PATCH 04/29] dlls/appwiz.cpl/: move WineHQ URLs to https

by Jacek Caban

Hi Austin, On 30.11.2017 19:56, Austin English wrote: > diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c > index 5ec49cfe6a..0bbc90f3eb 100644 > --- a/dlls/appwiz.cpl/addons.c > +++ b/dlls/appwiz.cpl/addons.c > @@ -86,7 +86,7 @@ static const addon_info_t addons_info[] = { > "wine_gecko-" GECKO_VERSION "-" ARCH_STRING ".msi", > "gecko", > GECKO_SHA, > - "http://source.winehq.org/winegecko.php", > + "https://source.winehq.org/winegecko.php", > "MSHTML", "GeckoUrl", "GeckoCabDir", > MAKEINTRESOURCEW(ID_DWL_GECKO_DIALOG) > }, > @@ -95,7 +95,7 @@ static const addon_info_t addons_info[] = { > "wine-mono-" MONO_VERSION ".msi", > "mono", > MONO_SHA, > - "http://source.winehq.org/winemono.php", > + "https://source.winehq.org/winemono.php", While I'm not really opposed, I think this deserves more attention. Note that this change means that we will download Gecko and Mono using https instead of http. While it's usually fine, it's an extra complexity and involves additional dependences to achieve the task. For example, it means that if you don't have a working GnuTLS and WineGecko cached, Wine won't be able to setup your prefix correctly. Also note that we check checksums of downloaded files, so installing those packages is safe as far as attacks by modifying content is considered. All we gain from https in this case is a bit of privacy improvement. That said, I'm not sure we want that change unless we have a good reason. Thanks, Jacek

Nov. 30, 2017

Re: [PATCH 1/3] ntdll: NtReadFileScatter results are reported asynchronously

by Andrew Eikum

On Thu, Nov 30, 2017 at 07:59:37PM +0100, Jacek Caban wrote: > Hi Andrew, > > On 30.11.2017 18:23, Andrew Eikum wrote: > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > > index ca2afa0e89..12b1d0f6c5 100644 > > --- a/dlls/ntdll/file.c > > +++ b/dlls/ntdll/file.c > > @@ -1105,7 +1105,7 @@ NTSTATUS WINAPI NtReadFileScatter( HANDLE file, HANDLE event, PIO_APC_ROUTINE ap > > > > if (send_completion) NTDLL_AddCompletion( file, cvalue, status, total ); > > > > - return status; > > + return STATUS_PENDING; > > Are you sure it should always be a case? Your tests use overlaped file > handle, I guess that's what makes differences. At least that's what I've > seen with other similar APIs (eg. recent Windows versions always return > STATUS_PENDING for ioctls if handle is overlapped). > I thought it was weird that this behaved different from other ntdll functions. I hadn't thought of the file handle type. I'll try with a non-overlapped file and see what changes. Thanks, Andrew

Nov. 30, 2017

Re: [PATCH 1/3] ntdll: NtReadFileScatter results are reported asynchronously

by Jacek Caban

Hi Andrew, On 30.11.2017 18:23, Andrew Eikum wrote: > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index ca2afa0e89..12b1d0f6c5 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -1105,7 +1105,7 @@ NTSTATUS WINAPI NtReadFileScatter( HANDLE file, HANDLE event, PIO_APC_ROUTINE ap > > if (send_completion) NTDLL_AddCompletion( file, cvalue, status, total ); > > - return status; > + return STATUS_PENDING; Are you sure it should always be a case? Your tests use overlaped file handle, I guess that's what makes differences. At least that's what I've seen with other similar APIs (eg. recent Windows versions always return STATUS_PENDING for ioctls if handle is overlapped). Thanks, Jacek

Nov. 30, 2017

[PATCH 29/29] programs/winepath/: move WineHQ URLs to https

by Austin English

Signed-off-by: Austin English <austinenglish(a)gmail.com> --- programs/winepath/winepath.man.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/winepath/winepath.man.in b/programs/winepath/winepath.man.in index 5fc5012a0a..5548e40044 100644 --- a/programs/winepath/winepath.man.in +++ b/programs/winepath/winepath.man.in @@ -31,19 +31,19 @@ shows winepath help message and exit. shows version information and exit. .SH BUGS Bugs can be reported on the -.UR http://bugs.winehq.org +.UR https://bugs.winehq.org .B Wine bug tracker .UE . .SH AVAILABILITY .B winepath is part of the Wine distribution, which is available through WineHQ, the -.UR http://www.winehq.org/ +.UR https://www.winehq.org/ .B Wine development headquarters .UE . .SH "SEE ALSO" .BR wine (1), .br -.UR http://www.winehq.org/help +.UR https://www.winehq.org/help .B Wine documentation and support .UE . -- 2.13.6

Nov. 30, 2017

[PATCH 28/29] programs/winemine/: move WineHQ URLs to https

by Austin English

Signed-off-by: Austin English <austinenglish(a)gmail.com> --- programs/winemine/winemine.man.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/winemine/winemine.man.in b/programs/winemine/winemine.man.in index 27fe2102f1..6ce68b4f00 100644 --- a/programs/winemine/winemine.man.in +++ b/programs/winemine/winemine.man.in @@ -9,19 +9,19 @@ is the Wine Minesweeper game. The object of the game is to try to find all the h uncovering the tiles to see how many mines each tile is adjacent to, without uncovering a mine. .SH BUGS Bugs can be reported on the -.UR http://bugs.winehq.org +.UR https://bugs.winehq.org .B Wine bug tracker .UE . .SH AVAILABILITY .B winemine is part of the Wine distribution, which is available through WineHQ, the -.UR http://www.winehq.org/ +.UR https://www.winehq.org/ .B Wine development headquarters .UE . .SH "SEE ALSO" .BR wine (1), .br -.UR http://www.winehq.org/help +.UR https://www.winehq.org/help .B Wine documentation and support .UE . -- 2.13.6

Nov. 30, 2017