March 2017 - Wine-Devel - list.winehq.org

Re: COM tracing ...

by Michael Stefaniuc

Hello, On 03/30/2017 04:58 PM, Michael Meeks wrote: > Rather a peripheral question; apologies for that - but I'd imagine > there are experts here that may be able to help. > > I have a black-box problem - a Windows app dealing with confidential > data that I can't easily touch (and thus can't get to run under Wine) - > which does some small but critical automation of MS Office - using VBS / > COM scripting. > > I'd -really- love some input on how best to trace that series of COM > method calls on Windows itself ie. the (remote) service activation, and > the RPC beyond that - particularly the method names, parameters etc. of > the COM/OLE Office API. I've tried (so far): don't you have at least a tlb file for the culprit COM stuff? You can look at that with oleview; Wine implements one too should you be on Linux. > > http://www.rohitab.com/apimonitor > which, while closed, looks interesting; but traces a lot > in a hard-to-search way and doesn't appear to do the > trick. > > https://support.microsoft.com/en-us/help/926098/how-to-enable-com-and-com-d… > Sounds useful: using Event Tracing for Windows (ETW) but > has this rather unhelpful property: > "The binary file must be formatted by Microsoft > so that it can be analyzed. Please forward the > .etl files to your support contact. ..." ;-) > > Component models used to be all the rage in my youth ;-) surely someone > solved the "strace for COM calls" problem elegantly some-when ! Well Wine has that built in for the stuff it implements. For the rest we write tests that exercises the respective API. > Crazily - might it be possible to instrument, interpose and use Wine's > COM impl. on Windows [ which sounds a bit 'exciting' ;-], or ? You don't need Wine for that. You can write wrappers around the COM classes you need, easily if you have the info from the TLB. > Anyhow - help much appreciated & sorry for the noise ! bye michael

March 30, 2017

Re: [PATCH 2/2] regedit: Handle comment lines with leading spaces and tabs

by Alexandre Julliard

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/regproc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c > index 131149f..bce551b 100644 > --- a/programs/regedit/regproc.c > +++ b/programs/regedit/regproc.c > @@ -749,6 +749,7 @@ static char *get_lineA(FILE *fp) > next = line; > continue; > } > + while (*line == ' ' || *line == '\t') line++; > if (*line == ';' || *line == '#') > { > line = next; This is going to affect non-comment lines too, is that what you want? If so, the commit message is a bit misleading. -- Alexandre Julliard julliard(a)winehq.org

March 30, 2017

Re: d3d10: sync spec file to Windows 10

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > On Thu, Mar 30, 2017 at 7:25 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: >> On 29 March 2017 at 23:51, Austin English <austinenglish(a)gmail.com> wrote: >>> -- >> We may not necessarily care, but RevertToOldImplementation() is the >> first export instead of the last on my Windows 10. > > My reasoning was that for non-ordinals, it doesn't matter, and that > sorting was preferred. Usually if it's not sorted on Windows it's because the ordinal matters. -- Alexandre Julliard julliard(a)winehq.org

March 30, 2017

Re: [2/3] windowscodecs: Test for png codec seeking too far

by Viktor Semykin

Okay, I split the patch and put it in the tail of the series. It's up to you to accept it or not. On 30/03/17 03:57, Vincent Povirk wrote: > I think you should either split the patch, or leave it using HGLOBAL. > > On Wed, Mar 29, 2017 at 11:12 PM, Viktor Semykin <thesame.ml(a)gmail.com> wrote: >> No, there's no such a reason. This test would pass with HGLOBAL as well. >> What should I do in this situation? Would it better to leave it as it used >> to be? >> >> >> >> On 29/03/17 20:54, Vincent Povirk wrote: >>> Is there a reason to switch to SHCreateMemStream to do this test in >>> particular? If not, it would probably make more sense as a separate >>> cleanup project. >>> >>> On Mon, Mar 27, 2017 at 3:09 PM, Viktor Semykin <thesame.ml(a)gmail.com> >>> wrote: >>>> Signed-off-by: Viktor Semykin <thesame.ml(a)gmail.com> >>>> --- >>>> dlls/windowscodecs/tests/Makefile.in | 2 +- >>>> dlls/windowscodecs/tests/pngformat.c | 19 ++++++++++--------- >>>> 2 files changed, 11 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/dlls/windowscodecs/tests/Makefile.in >>>> b/dlls/windowscodecs/tests/Makefile.in >>>> index e11d184..e006e3d 100644 >>>> --- a/dlls/windowscodecs/tests/Makefile.in >>>> +++ b/dlls/windowscodecs/tests/Makefile.in >>>> @@ -1,5 +1,5 @@ >>>> TESTDLL = windowscodecs.dll >>>> -IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 >>>> +IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 shlwapi >>>> >>>> C_SRCS = \ >>>> bitmap.c \ >>>> diff --git a/dlls/windowscodecs/tests/pngformat.c >>>> b/dlls/windowscodecs/tests/pngformat.c >>>> index 34cb533..20b6e93 100644 >>>> --- a/dlls/windowscodecs/tests/pngformat.c >>>> +++ b/dlls/windowscodecs/tests/pngformat.c >>>> @@ -25,6 +25,7 @@ >>>> #include "windef.h" >>>> #include "wincodec.h" >>>> #include "wine/test.h" >>>> +#include "shlwapi.h" >>>> >>>> /* 1x1 pixel PNG image */ >>>> static const char png_no_color_profile[] = { >>>> @@ -277,21 +278,16 @@ static IWICImagingFactory *factory; >>>> >>>> static IWICBitmapDecoder *create_decoder(const void *image_data, UINT >>>> image_size) >>>> { >>>> - HGLOBAL hmem; >>>> - BYTE *data; >>>> HRESULT hr; >>>> IWICBitmapDecoder *decoder = NULL; >>>> IStream *stream; >>>> GUID format; >>>> LONG refcount; >>>> + ULARGE_INTEGER pos; >>>> + LARGE_INTEGER zero; >>>> >>>> - hmem = GlobalAlloc(0, image_size); >>>> - data = GlobalLock(hmem); >>>> - memcpy(data, image_data, image_size); >>>> - GlobalUnlock(hmem); >>>> - >>>> - hr = CreateStreamOnHGlobal(hmem, TRUE, &stream); >>>> - ok(hr == S_OK, "CreateStreamOnHGlobal error %#x\n", hr); >>>> + stream = SHCreateMemStream (image_data, image_size); >>>> + ok(stream != NULL, "SHCreateMemStream error\n"); >>>> >>>> hr = IWICImagingFactory_CreateDecoderFromStream(factory, stream, >>>> NULL, 0, &decoder); >>>> ok(hr == S_OK, "CreateDecoderFromStream error %#x\n", hr); >>>> @@ -302,6 +298,11 @@ static IWICBitmapDecoder *create_decoder(const void >>>> *image_data, UINT image_size >>>> ok(IsEqualGUID(&format, &GUID_ContainerFormatPng), >>>> "wrong container format %s\n", wine_dbgstr_guid(&format)); >>>> >>>> + zero.QuadPart = 0; >>>> + IStream_Seek (stream, zero, STREAM_SEEK_CUR, &pos); >>>> + todo_wine ok(pos.QuadPart < image_size, "seek beyond the end of >>>> stream: %lu >= %u\n", >>>> + pos.QuadPart, image_size); >>>> + >>>> refcount = IStream_Release(stream); >>>> ok(refcount > 0, "expected stream refcount > 0\n"); >>>> >>>> -- >>>> 2.12.1 >>>> >>>> >>>> >> -- >> best, Viktor. >> -- best, Viktor.

March 30, 2017

Re: d3d10: sync spec file to Windows 10

by Henri Verbeet

On 30 March 2017 at 18:06, Austin English <austinenglish(a)gmail.com> wrote: > On Thu, Mar 30, 2017 at 7:25 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: >> On 29 March 2017 at 23:51, Austin English <austinenglish(a)gmail.com> wrote: >>> -- >> We may not necessarily care, but RevertToOldImplementation() is the >> first export instead of the last on my Windows 10. > > My reasoning was that for non-ordinals, it doesn't matter, and that > sorting was preferred. > Good enough for me.

March 30, 2017

Re: d3d10: sync spec file to Windows 10

by Austin English

On Thu, Mar 30, 2017 at 7:25 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 29 March 2017 at 23:51, Austin English <austinenglish(a)gmail.com> wrote: >> -- > We may not necessarily care, but RevertToOldImplementation() is the > first export instead of the last on my Windows 10. My reasoning was that for non-ordinals, it doesn't matter, and that sorting was preferred. -- -Austin GPG: 14FB D7EA A041 937B

March 30, 2017

COM tracing ...

by Michael Meeks

Hi guys, Rather a peripheral question; apologies for that - but I'd imagine there are experts here that may be able to help. I have a black-box problem - a Windows app dealing with confidential data that I can't easily touch (and thus can't get to run under Wine) - which does some small but critical automation of MS Office - using VBS / COM scripting. I'd -really- love some input on how best to trace that series of COM method calls on Windows itself ie. the (remote) service activation, and the RPC beyond that - particularly the method names, parameters etc. of the COM/OLE Office API. I've tried (so far): http://www.rohitab.com/apimonitor which, while closed, looks interesting; but traces a lot in a hard-to-search way and doesn't appear to do the trick. https://support.microsoft.com/en-us/help/926098/how-to-enable-com-and-com-d… Sounds useful: using Event Tracing for Windows (ETW) but has this rather unhelpful property: "The binary file must be formatted by Microsoft so that it can be analyzed. Please forward the .etl files to your support contact. ..." ;-) Component models used to be all the rage in my youth ;-) surely someone solved the "strace for COM calls" problem elegantly some-when ! Crazily - might it be possible to instrument, interpose and use Wine's COM impl. on Windows [ which sounds a bit 'exciting' ;-], or ? Anyhow - help much appreciated & sorry for the noise ! Regards, Michael. -- michael.meeks(a)collabora.com <><, Pseudo Engineer, itinerant idiot

March 30, 2017

Re: [PATCH 3/3] shlwapi/tests: A test to query ISequentialStream from memory stream

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29831 Your paranoid android. === wxppro (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 09f0:istream: unhandled exception c0000005 at 00405AEC === w2003std (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 05f0:istream: unhandled exception c0000005 at 00405AEC

March 30, 2017

Re: [PATCH 2/3] shlwapi: Fix QueryInterface for file-based streams

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29830 Your paranoid android. === wxppro (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 09ec:istream: unhandled exception c0000005 at 00405AEC === w2003std (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 05f0:istream: unhandled exception c0000005 at 00405AEC

March 30, 2017

Re: [PATCH] wmvcore: Add WMReader stubs.

by Andrew Eikum

On Thu, Mar 30, 2017 at 08:25:03AM +0000, Alistair Leslie-Hughes wrote: > I have a basic patch for adding tests in the works, but I was waiting > for my IDL changes to be accepted first. > > So, If someone wants to review the IDL changes, Since Sebastian has been > busy with other stuff. > > https://source.winehq.org/patches/data/131403 > Okay :) I just noticed one thing: > + HRESULT GetAttributeCountEx( > + [in] WORD stream_num, > + [out] WORD attributes ); If attributes is an out-param, it should be a pointer, right? Andrew

March 30, 2017