March 2017 - Wine-Devel - list.winehq.org

Re: Darren Stevens II -- Outreachy Internship

by Austin English

On Tue, Mar 28, 2017 at 8:31 PM, Darren M. Stevens II <darren8(a)umbc.edu> wrote: > Hello, my name is Darren and I'm a computer science major at the University > of Maryland Baltimore County. I've never worked in open source software > before, but the idea of letting windows apps run for linux sounds appealing, > especially for games. > > Though it's my first time in open source, I have some experience in C. > Looking at the project list, the graphical user interface seems to be the > most interesting, but I'm also interested in the resource and dialog editor > since I'd like to get some UI experience. I've also worked in html, php, and > mysql before, so improving the AppDB website also interests me. If pressed, > I'd prefer to work with the gui and learn about what goes into making one. > > I look forward to potentially working with you all more during the summer. Hi Darren, For a start, you'll want to make sure you can download and build wine from source. Once you can do that, please send a small (but useful!) patch to Wine. Ideally it would be one related to the area of code you'd want to work in, to show us you can work with the code. I.e., if you wanted to work on a Winetest GUI, fixing a smaller problem in winetest would be a good idea. For the AppDB, what ideas do you have for it? -- -Austin GPG: 14FB D7EA A041 937B

March 30, 2017

Re: [2/3] windowscodecs: Test for png codec seeking too far

by Vincent Povirk

Is there a reason to switch to SHCreateMemStream to do this test in particular? If not, it would probably make more sense as a separate cleanup project. On Mon, Mar 27, 2017 at 3:09 PM, Viktor Semykin <thesame.ml(a)gmail.com> wrote: > Signed-off-by: Viktor Semykin <thesame.ml(a)gmail.com> > --- > dlls/windowscodecs/tests/Makefile.in | 2 +- > dlls/windowscodecs/tests/pngformat.c | 19 ++++++++++--------- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/tests/Makefile.in b/dlls/windowscodecs/tests/Makefile.in > index e11d184..e006e3d 100644 > --- a/dlls/windowscodecs/tests/Makefile.in > +++ b/dlls/windowscodecs/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = windowscodecs.dll > -IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 > +IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 shlwapi > > C_SRCS = \ > bitmap.c \ > diff --git a/dlls/windowscodecs/tests/pngformat.c b/dlls/windowscodecs/tests/pngformat.c > index 34cb533..20b6e93 100644 > --- a/dlls/windowscodecs/tests/pngformat.c > +++ b/dlls/windowscodecs/tests/pngformat.c > @@ -25,6 +25,7 @@ > #include "windef.h" > #include "wincodec.h" > #include "wine/test.h" > +#include "shlwapi.h" > > /* 1x1 pixel PNG image */ > static const char png_no_color_profile[] = { > @@ -277,21 +278,16 @@ static IWICImagingFactory *factory; > > static IWICBitmapDecoder *create_decoder(const void *image_data, UINT image_size) > { > - HGLOBAL hmem; > - BYTE *data; > HRESULT hr; > IWICBitmapDecoder *decoder = NULL; > IStream *stream; > GUID format; > LONG refcount; > + ULARGE_INTEGER pos; > + LARGE_INTEGER zero; > > - hmem = GlobalAlloc(0, image_size); > - data = GlobalLock(hmem); > - memcpy(data, image_data, image_size); > - GlobalUnlock(hmem); > - > - hr = CreateStreamOnHGlobal(hmem, TRUE, &stream); > - ok(hr == S_OK, "CreateStreamOnHGlobal error %#x\n", hr); > + stream = SHCreateMemStream (image_data, image_size); > + ok(stream != NULL, "SHCreateMemStream error\n"); > > hr = IWICImagingFactory_CreateDecoderFromStream(factory, stream, NULL, 0, &decoder); > ok(hr == S_OK, "CreateDecoderFromStream error %#x\n", hr); > @@ -302,6 +298,11 @@ static IWICBitmapDecoder *create_decoder(const void *image_data, UINT image_size > ok(IsEqualGUID(&format, &GUID_ContainerFormatPng), > "wrong container format %s\n", wine_dbgstr_guid(&format)); > > + zero.QuadPart = 0; > + IStream_Seek (stream, zero, STREAM_SEEK_CUR, &pos); > + todo_wine ok(pos.QuadPart < image_size, "seek beyond the end of stream: %lu >= %u\n", > + pos.QuadPart, image_size); > + > refcount = IStream_Release(stream); > ok(refcount > 0, "expected stream refcount > 0\n"); > > -- > 2.12.1 > > >

March 29, 2017

Re: Packaging related changes

by Michael Stefaniuc

On 03/29/2017 08:42 AM, Alexandre Julliard wrote: > Michael Müller <michael(a)fds-team.de> writes: > >> Nevertheless, we believe that these changes are very >> useful and will make things much easier in the long term. > > Indeed. Thanks for your work! Thanks Michael and Sebastian! Right in time for 2.0.1 ;) bye michael

March 29, 2017

wine-2.0.1-rc1 Available

by Michael Stefaniuc

Hello guys, I have pushed wine-2.0.1-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Nothing particularly special in this release. Slow start into 2.0.x due to lack of time on my side as well as to give the more risky patches some more time to burn in. Same old, same old: one week for feedback followed by another rc if needed with the final release 3-4 days later. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes - Deprecated tools/wineinstall ---------------------------------------------------------------- Bugs fixed in 2.0.1 (total 47): 14897 DirectDraw games (Jojo's Fashion Show 2: Las Cruces demo, The Chosen: Well of Souls) try to lock surface with invalid dwSize 14939 Black & White: DXTC to ARGB converter not implemented 17495 Open dialog crashes if the desktop folder is at a Unicode path that cannot be represented in the current locale 18477 Need For Speed Most Wanted crashes after accepting video settings changes 19888 Venom Codename: Outbreak - initial menu screen is black (no menu items) 25700 MessageBox does not display last word if string contains '&' (ampersand) 26603 iMesh 10 crashes at startup (needs wmvcore.dll.WMCreateReaderPriv) 27580 Wine Notepad command line parser eats the first 2 letters when the path starts with / (it should only do this for valid command line options) 30308 Property sheet fails to display Page Title 35993 Graphical Glitches in Agarest Generations of War 38354 Multiple games and applications need msvcr120.dll._except1 (Audacity 2.1.0, Tera Online) 38485 New Marvel Heroes 2015 Launcher crashes on unimplemented function dhcpcsvc.dll.DhcpRequestParams 39048 MIDI Clock Messages are Corrupted Between Wine and ALSA 39920 Nanocad 5.: file open/import dialog does not open 40392 ComicRack 0.9.x (.NET 4.5 app) hangs/crashes on startup when executing WMI query 40938 UE4 games (Ether One Redux, Into the Stars) crash while loading with "BackBuffer->GetResource() has 3 refs, expected 1" error 40952 improper escaping of quotes in command line 41448 Civilization II Unhandled page fault on read access 41579 Rush for Berlin Gold crashes after the intro videos 41623 Odallus The Dark Call crashes while starting if a force feedback enabled controller is plugged in 41648 AmiBroker 6.00 fails, when run, with raise_exception Unhandled exception 41725 Unimplemented function api-ms-win-crt-math-l1-1-0.dll._except1 (Starcraft 2 main menu, Firefox) 41830 Updating group box text causes garbage 41926 Zafehouse demo crashes with Call from 0x7b43c14c to unimplemented function ddraw.dll.GetSurfaceFromDC, aborting 42001 SC2 unimplemented function ucrtbase.dll._except1 42022 The Magic School Bus Explores The Solar System needs msvideo.dll16.DRAWDIBPROFILEDISPLAY 42023 The Magic School Bus Explores The Solar System crashes on launch; appears to be missing some files 42078 Dungeons & Dragons: Chronicles of Mystara needs d3dx11_43.dll.D3DX11CreateShaderResourceViewFromMemory 42093 Git for Windows 2.7.0 needs unimplemented function rstrtmgr.dll.RmShutdown 42094 winamp needs unimplemented function ntoskrnl.exe.IoStopTimer 42096 Steam -> RPGMaker 2003 needs unimplemented function KERNEL32.dll.BaseFlushAppcompatCache 42159 Sega Bug crashes immediately 42212 WOLF RPG Editor: Division by zero when winegstreamer is enabled 42218 mshtml/tests/dom crashes in xul while running test_doc_elem 42244 QQ 2013 needs ntoskrnl.exe.IoCreateFile 42245 QQ 2013 needs ntoskrnl.exe.KeClearEvent 42257 Warpath 21st Century does not have sound 42303 Magic: The Gathering Online 4.0 crashes when entering the battle 42306 One Note Free Retail installer crashes in xmllite 42315 Piriform Speccy 1.3 needs setupapi.dll.CM_Get_Child_Ex 42361 DX Library: PlaySoundFile() doesn't play MP3 files with specific extra headers 42365 Unimplemented function msvcr120.dll.fesetenv 42367 KiriKiri Z based games: main screen doesn't update. 42469 GetOpenFileName should expand environment variables in lpstrInitialDir 42483 Build for Ubuntu Precise fails because MPG123_IGNORE_INFOFRAME is undeclared 42557 NVIDIA GeForce GT 525M detected as GeForce GTX 470 42567 Acid Pro Trial 7.0e fails to install ---------------------------------------------------------------- Changes since 2.0: Adam Bolte (1): wined3d: Add GPU information for AMD FIJI. Akihiro Sagawa (3): d3d9/tests: Add LockRect tests with dynamic textures. d3d8/tests: Add LockRect tests with dynamic textures. wined3d: Upload textures if NO_DIRTY_UPDATE flag is set when locking dynamic textures. Alex Henrie (3): ddraw: Don't crash if writing out a new ddraw1 surface segfaults. comdlg32: Don't crash if an IShellFolder could not be created. user32: Include space for ampersands when determining MessageBox size. Alexandre Julliard (1): make_announce: Update version number parsing for the new versioning scheme. Alistair Leslie-Hughes (1): include: Add dhcpcsdk.h. Andrew Wesie (1): ntdll: Read entry point in LdrInitializeThunk. Andrey Gusev (2): setupapi: Add CM_Get_Child_Ex stub. d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub. Anton Romanov (1): user32: Add OCR_RDR* cursors. Austin English (6): ntoskrnl.exe: Add IoCreateFile stub. ntoskrnl.exe: Add stub KeClearEvent. kernel32: Add BaseFlushAppcompatCache stub. rstrtmgr: Add RmShutdown stub. dhcpsvc: Add DhcpRequestParams stub. readme: Remove wineinstall. Bruno Jesus (8): winmm: Fix the ordinal number for function PlaySound. dinput: DISFFC_RESET will not release the effects. notepad: Only skip valid command options. winemp3.acm: Ignore XING headers when parsing MP3 files. winemp3.acm: Fixes compilation for older mpg123 library versions. winealsa.drv: Fix handling of system real time MIDI messages. wined3d: Recognize Geforce GT 525M. wined3d: Recognize GeForce 940M. Can Taşan (3): wine.desktop: Add Turkish translation. kernel32: Add Unicode character for Turkish lira. documentation: Update Turkish translation. Christoph Brill (1): setupapi: Stub CM_Open_DevNode_Key and CM_Get_Child. Daniel Lehman (1): msvcrt: Implement nan. Dmitry Timoshkov (4): avifil32: AVIFileGetStream should set stream to NULL in case of an error. user32: BUTTON_CalcLabelRect should use the button font. user32: Fix groupbox rectangle calculation in the button's WM_SETTEXT handler. kernel32: Replace Peb->BeingDebugged check by CheckRemoteDebuggerPresent(). Fabian Maurer (1): msvcr120: Add fesetenv stub. François Gouget (3): readme: Note that Wine may also use Mac APIs. readme: Adjust a couple of section separators. readme: Update and rewrap the French translation. Gerald Pfeifer (1): winedump: Increase buffer size and potential string length inoutput_spec_symbol. Hans Leidekker (1): wbemprox: Only include matching rows in the table row count. Henri Verbeet (5): ddraw/tests: Rewrite GetDCTest(). ddraw: Implement GetSurfaceFromDC(). ddraw: Kill stray tabs. wined3d: Allow decompression blits on system memory resources in arbfp_blit_supported(). wined3d: Disallow upload conversion from compressed formats in surface_convert_format(). Jacek Caban (1): mshtml: Initialize nsAString in IHTMLDocument3::get_dir. Jacob Lifshay (1): kernel32: Fix improper escaping of quotes in command line. Jarkko Korpi (1): ntoskrnl: Add IoStopTimer stub. Jefferson Carpenter (1): wmvcore: Implement WMCreateReaderPriv. Julian Rüger (2): readme: Update German translation. readme: Fix typo in German translation. Józef Kucia (6): d3d11/tests: Add tests showing that views do not keep resource reference. d3d11: Do not keep reference to resources. ddraw: Relax "dwSize" validation in ddraw_surface*_Lock(). ddraw: Implement D3DOP_TEXTURELOAD. ddraw/tests: Add basic test for D3DOP_TEXTURELOAD. d3d9: Do not decrease swapchain surface refcount when it is already 0. Lauri Kenttä (2): readme: Update Finnish translation. readme: Update Swedish translation. Louis Lenders (2): xmllite/reader: Handle NULL node type argument in Read(). wmvcore: Add version resource. Masanori Kakura (1): winegstreamer: Avoid zero division in amt_from_gst_caps_video(). Matteo Bruni (1): d3d9: Fix DrawIndexedPrimitiveUP with non-zero min_vertex_idx. Michael Müller (2): msvideo.dll16: Implement DrawDibProfileDisplay. msvideo.dll16: Check if any 16 bit thunks have been allocated before accessing pointer. Michael Stefaniuc (1): tools: Get the ANNOUNCE bug list from the stable-notes git notes. Nikolay Sivov (5): comdlg32: Always use original Open File dialog template. comctl32/propsheet: Force wizard header if any of pages has title/subtitle. comctl32/propsheet: Only use header bitmap when asked for it. comdlg32: Expand initial directory path for file open dialog. readme: Update Russian translation. Piotr Caban (2): msvcrt: Add fesetenv implementation. msvcr120: Add _except1 implementation. Zebediah Figura (7): storage.dll16: Fix bad type in IStorage16_fnOpenStorage. winebuild: Use unsigned int in spec file variable parameters. compobj: Implement several IIDs. ole2: Implement several IIDs. avifile: Implement several IIDs. ole2disp: Implement several IIDs. typelib: Implement several IIDs. -- Michael Stefaniuc mstefani(a)winehq.org

March 29, 2017

Re: [v6 PATCH 00/21] x86: Enable User-Mode Instruction Prevention

by Stas Sergeev

29.03.2017 07:38, Ricardo Neri пишет: >> Probably you could also remove >> the sldt and str emulation for protected mode, because, >> as I understand from this thread, wine does not >> need those. > I see. I would lean on keeping the emulation because I already > implemented it :), for completeness, and because it is performed in a > single switch. The bulk of the emulation code deals with operands. But this is not for free. As Andy said, you will then need a syscall and a feature mask to be able to disable this emulation. And AFAIK you haven't implemented that yet, so there is something to consider. >>>> You know the wine's >>>> requirements now - they are very small. And >>>> dosemu doesn't need anything at all but smsw. >>>> And even smsw is very rare. >>> But emulation is still needed for SMSW, right? >> Likely so. >> If you want, I can enable the logging of this command >> and see if it is used by some of the DOS programs I have. > It would be great if you could do that, if you don't mind. OK, scheduled to the week-end. I'll let you know. >> But at least dosemu implements it, so probably it is needed. > Right. > >> Of course if it is used by one of 100 DOS progs, then there >> is an option to just add its support to dosemu2 and pretend >> the compatibility problems did not exist. :) > Do you mean relaying the GP fault to dosemu instead of trapping it and > emulating it in the kernel? Yes, that would be optimal if this does not severely break the current setups. If we can find out that smsw is not in the real use, we can probably do exactly that. But other instructions are not in real use in v86 for sure, so I wouldn't be adding the explicit test-cases to the kernel that will make you depend on some particular behaviour that no one may need. My objection was that we shouldn't write tests before we know exactly how we want this to work.

March 29, 2017

Re: Packaging related changes

by Michael Müller

Am 29.03.2017 um 01:48 schrieb Rosanne DiMesio: > I'm running into the CDN sync issue; http://dl.winehq.org/wine-builds/ doesn't show a directory for Ubuntu, but http://dl.winehq.org/wine-builds/ubuntu does exist. This shouldn't cause any problem for now except when manually clicking through the file listing. There are also a few other paths that will change with the next release, but I think it is sufficient when Jeremy updates the configuration afterwards. > We should also post a notice on the forum. I can take care of that. This is a good idea. > Fedora 22 is also EOL. You are right, I forgot to include it in the list. Regards, Michael

March 29, 2017

Re: [v2 1/2] d3dx9: Support relative addressing in preshader.

by Paul Gofman

Sorry, regarding my 1st question, I realized that of course first write make sense, as the size will be updated through output register. But still I would suggest to keep the currently implemented scheme to better much native approach (which is tolerant to missing constants definition). On 03/29/2017 09:23 PM, Paul Gofman wrote: > On 03/29/2017 09:17 PM, Matteo Bruni wrote: >> I haven't looked at the v3 patches yet, but in the meantime: >> >> 2017-03-29 2:09 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: >> >>> Oh, its a bug actually now, we should not mind absolute offset >>> here if >>> relative addressing is on, we know if it is out of bound or not when >>> we add >>> index register value only, which can be negative. Yes, it looks the >>> only >>> tables where we need to do this update table size are temporary >>> register >>> table (for which we don't have any size known in advance) and output >>> tables. >>> I would check that and if I am not missing something now would leave >>> just >>> update table size where required. >> Yeah and temporaries are supposed to be written before being read so >> in theory you can entirely skip the update_table_size() calls for >> source arguments. > But update_table_sizes is required to calculate memory allocation > size for table, what is the difference if temporary registers are > written first in this regard? In v3 I u sed correct offset for > updating table sizes when relative addressing is used in operand. I > didn't change table size update though to update temporary register > table size only, as doing so currently breaks one test. It is > test_effect_preshader_op(), which writes instructions to the effect > blob and unintentionally corrupts the data past end of the preshader > code being updated. This effectively results in destroying 'CTAB' for > the next preshader in blob, so that preshader is parsed ok but it does > not have input constant definition anymore, thus no table sizes set > from input registers definition. Still such an effect and preshader is > created ok by native implementation, and also by our current > implementation. So So I thought it is better to keep the current logic > of table size updates based on actual register access in preshader for > all tables, as according to the test native implementation does not > fail preshader creation if it access the constants outside defined > input range.

March 29, 2017

Re: [v2 1/2] d3dx9: Support relative addressing in preshader.

by Paul Gofman

On 03/29/2017 09:17 PM, Matteo Bruni wrote: > I haven't looked at the v3 patches yet, but in the meantime: > > 2017-03-29 2:09 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > >> Oh, its a bug actually now, we should not mind absolute offset here if >> relative addressing is on, we know if it is out of bound or not when we add >> index register value only, which can be negative. Yes, it looks the only >> tables where we need to do this update table size are temporary register >> table (for which we don't have any size known in advance) and output tables. >> I would check that and if I am not missing something now would leave just >> update table size where required. > Yeah and temporaries are supposed to be written before being read so > in theory you can entirely skip the update_table_size() calls for > source arguments. But update_table_sizes is required to calculate memory allocation size for table, what is the difference if temporary registers are written first in this regard? In v3 I u sed correct offset for updating table sizes when relative addressing is used in operand. I didn't change table size update though to update temporary register table size only, as doing so currently breaks one test. It is test_effect_preshader_op(), which writes instructions to the effect blob and unintentionally corrupts the data past end of the preshader code being updated. This effectively results in destroying 'CTAB' for the next preshader in blob, so that preshader is parsed ok but it does not have input constant definition anymore, thus no table sizes set from input registers definition. Still such an effect and preshader is created ok by native implementation, and also by our current implementation. So So I thought it is better to keep the current logic of table size updates based on actual register access in preshader for all tables, as according to the test native implementation does not fail preshader creation if it access the constants outside defined input range.

March 29, 2017

Re: [PATCH 10/10] xmllite/tests: Added tests for returned string pointers.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29805 Your paranoid android. === wxppro (32 bit reader) === reader.c:2517: Test failed: ns != value reader.c:2549: Test failed: xmlns_name != prefix reader.c:2555: Test failed: xmlns_name != prefix reader.c:2560: Test failed: p != prefix reader.c:2561: Test failed: empty != namespace reader.c:2566: Test failed: q != prefix reader.c:2567: Test failed: nsq != namespace reader.c:2570: Test failed: q == qname reader.c:2597: Test failed: ns+1 != p === w2003std (32 bit reader) === reader.c:2517: Test failed: ns != value reader.c:2549: Test failed: xmlns_name != prefix reader.c:2555: Test failed: xmlns_name != prefix reader.c:2560: Test failed: p != prefix reader.c:2561: Test failed: empty != namespace reader.c:2566: Test failed: q != prefix reader.c:2567: Test failed: nsq != namespace reader.c:2570: Test failed: q == qname reader.c:2597: Test failed: ns+1 != p

March 29, 2017

Re: [v2 1/2] d3dx9: Support relative addressing in preshader.

by Matteo Bruni

I haven't looked at the v3 patches yet, but in the meantime: 2017-03-29 2:09 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Oh, its a bug actually now, we should not mind absolute offset here if > relative addressing is on, we know if it is out of bound or not when we add > index register value only, which can be negative. Yes, it looks the only > tables where we need to do this update table size are temporary register > table (for which we don't have any size known in advance) and output tables. > I would check that and if I am not missing something now would leave just > update table size where required. Yeah and temporaries are supposed to be written before being read so in theory you can entirely skip the update_table_size() calls for source arguments. > Otherwise, if to leave the way it is done now, if relative addressing is > used update_table_size should be called on index register table/offset > instead of main register. > Regarding absolute offset check, if the absolute offset (without > relative addressing) is out of bound fxc does not allow to compile that. If > to test what happens to native implementation in this case I need to update > the blob manually. So do you suggest to check if the absolute offset to > input table is in bound and print a FIXME/fail preshader creation in this > case? Failing with a WARN is probably the best option. I don't think we necessarily need a Wine test for that, once you tested what happens with native. If you want you can add a test with a small effect manually hacked to contain an invalid argument. > Immediate const count is not necessarily the multiple of 4 (it is not the > case in the present tests). If we set PRES_REGTAB_IMMED count to 4 it breaks > new out of bounds index tests (due to incorrect size to wrap to). Hmm, I've never seen any effect with a number of immediates not multiple of 4. Can you point me to one?

March 29, 2017