March 2017 - Wine-Devel - list.winehq.org

Re: ntdll: Don't modify LockCount in RtlLeaveCriticalSection if section is not acquired.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29096 Your paranoid android. === wxppro (32 bit rtl) === rtl.c:2113: Test failed: expected LockCount == -2, got 0 rtl.c:2129: Test failed: expected LockCount == -1, got -2 rtl.c:2136: Test failed: expected LockCount == -1, got -3 ntdll:rtl has unreported failures

March 3, 2017

Re: [PATCH 2/2] ntdll: Fix NtFlushBuffersFile() for files with FILE_APPEND_DATA access.

by Józef Kucia

On Fri, Mar 3, 2017 at 6:05 PM, Paul Gofman <gofmanp(a)gmail.com> wrote: > I just verified that server_get_unix_fd() returns success if to request > FILE_APPEND_DATA for handles created with (read/)write access. I also > checked that requesting FILE_APPEND_DATA gets no error if using it with a > usb serial port. Is it anything bad to just use FILE_APPEND_DATA instead of > FILE_WRITE_DATA in server_get_unix_fd()? Does it work when you pass just FILE_WRITE_DATA to CreateFile()?

March 3, 2017

Re: [PATCH 2/2] ntdll: Fix NtFlushBuffersFile() for files with FILE_APPEND_DATA access.

by Paul Gofman

Sorry for introducing that in f7d40d45da7a1bc0accd58bca6d6da4e34861937. I just verified that server_get_unix_fd() returns success if to request FILE_APPEND_DATA for handles created with (read/)write access. I also checked that requesting FILE_APPEND_DATA gets no error if using it with a usb serial port. Is it anything bad to just use FILE_APPEND_DATA instead of FILE_WRITE_DATA in server_get_unix_fd()? If its not that I am missing something why it should not be done like that, I can add test for serial port. On 03/03/2017 06:21 PM, Józef Kucia wrote: > This fixes a regression introduced by commit > f7d40d45da7a1bc0accd58bca6d6da4e34861937. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/ntdll/file.c | 2 ++ > dlls/ntdll/tests/file.c | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 3f38c6f..e2cfe7f 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -3418,6 +3418,8 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock > int fd, needs_close; > > ret = server_get_unix_fd( hFile, FILE_WRITE_DATA, &fd, &needs_close, &type, NULL ); > + if (ret == STATUS_ACCESS_DENIED) > + ret = server_get_unix_fd( hFile, FILE_APPEND_DATA, &fd, &needs_close, &type, NULL ); > > if (!ret && type == FD_TYPE_SERIAL) > { > diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c > index 5e7e1ee..09bf688 100644 > --- a/dlls/ntdll/tests/file.c > +++ b/dlls/ntdll/tests/file.c > @@ -4441,7 +4441,6 @@ static void test_flush_buffers_file(void) > ok(hfile != INVALID_HANDLE_VALUE, "could not open temp file, error %d.\n", GetLastError()); > > status = pNtFlushBuffersFile(hfile, &io_status_block); > - todo_wine > ok(status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x.\n", status); > > CloseHandle(hfile);

March 3, 2017

Re: GSOC 2017 - Resource/Dialog Editor

by Joseph-Eugene Winzer

On 03/02/2017 10:45 PM, Austin English wrote: > On Thu, Mar 2, 2017 at 1:58 PM, Joe <ml999(a)openmailbox.org> wrote: >> Hi, >> >> First of all, congrats for getting picked for another GSoC! >> Wine made my transition to Linux way easier and with more and more >> applications being supported the year of the desktop can come :) >> >> My name is Joseph Winzer and I am a bachelor math/CS student looking forward >> to contribute to open source in this year's GSoC. >> The 'Resource/Dialog Editor' project caught my eye as I remember a few years >> back digging through executables out of curiousity. Last time I looked for a >> resource editor it was either bundled with other software (Visual Studio, >> PellesC) or as mentioned in the project description bundled up with adware >> like ResEdit. >> I want to change that by contributing to Wine with an open source standalone >> editor anyone can use free of charge. >> Equipped with my Petzold, MSDN and the help of the community I am sure I >> will be able to realize this project. >> >> >> Looking forward working with you guys :) > > Hi Joseph, > > Thanks for your interest. Could you describe your experience with > C/Wine a bit? Have you thought about how you would implement/design > the resource editor at all? Could you share your plans? > Thanks for your reply. So far, I experienced Wine exclusively from a user perspective, using it mostly for running games and apps I didn't find a substitute on Linux. I compiled Wine a few times when certain milestones were reached like improved D3D9 or bugfixes for certain apps. I did grep for stubs once in a while, browsed through the GDI implementation but wasn't confident enough to contribute. I read more code than I wrote myself and most of it has been C or C-style C++. WinAPI-wise, I remember writing small games like connect four or apps where I tried to use what I had recently learned. I also did some reverse engineering for writing trainers or just for the fun of it. That has been awhile, though. More recently I looked at quake, tuxpaint, util-linux, .. whatever caught my interest. Concerning the technical aspects of implementing the editor, I haven't given it much thought yet. MSDN et al provide enough documentation to tackle the task and problems can be dealt with once they come up (I assume in my naivete). Design-wise it depends on what the Wine community expects it to be but personally I imagined ResEdit trimmed to reading out and altering resources with dialog creation on top. From there it can be extended in whatever direction the community sees fit. The rough sketch would be as follows: * Establishing bare bones UI (sidebar for items, main window as viewer) * Read PE compatible file resources * Export resources * Modify resources (substitute images, edit items) * Refining UI for editing/viewing This covers the basic functionality of the resource viewer. The Dialog Editor provides rendering of dialog elements what would complement part of the resource viewer and exporting as .rc. My estimate is that the dialog editor will be the biggest part of the project with parsing resources, dialog rendering, layout, .. Overall the planning and focus of the project depends on what the community expects it to be and if there is an immediate use case it can cover in Wine or thought of as a general tool. Sorry for the wall of text but I hope I could describe to you my idea I have for it. Of course, in the official application the gaps for the implementation will be filled but getting feedback from the community first makes planning also easier for me.

March 3, 2017

Re: 1.8.7 maintenance release?

by Michael Stefaniuc

On 03/02/2017 07:50 PM, Nathan Schulte wrote: > I guess it's because wine supports multiple concurrent releases. No we don't do that. There won't be a 1.8.8. The main reasons why I cut a final 1.8.7 release after the 2.0 came out: - Current supported distribution versions won't upgrade from 1.8.x to 2.0. They will (hopefully) do the switch in their next version. - Ubuntu 16.10 LTS came out with Wine 1.6.2 even though 1.8.3 was out already. So I wouldn't wonder if they'll use 1.8.7 in their next LTS... I don't particularly care about Ubuntu but that's how most of our new users make their first contact with Wine. - It is very easy for me to do an old stable release after the new stable was cut. With the code freeze prior to a new stable release only small bug fixes and most importantly regression fixes go in. So there is a high density of good commits to cherry pick for the old stable. bye michael > > -- > Nate > > On Mar 2, 2017 12:48, <version2013(a)openmailbox.org > <mailto:version2013(a)openmailbox.org>> wrote: > > I still have much to learn. > Why have a 1.8.7 maintenance release after a 2.0 stable release? > > In advance, thank you for sharing your knowledge as to why.

March 3, 2017

Re: [PATCH 1/2] ws2_32/tests: Rework WSAStringToAddress tests

by Bruno Jesus

On Thu, Mar 2, 2017 at 10:29 PM, Marvin <testbot(a)winehq.org> wrote: > === w2008s64 (64 bit sock) === > ws2_32:sock returned an error (3221225477) despite having no failures > ws2_32:sock has no test summary line (early exit of the main process?) Just in case... Patch 2 passes and its the same test. https://testbot.winehq.org/JobDetails.pl?Key=29079

March 3, 2017

Re: [PATCH 1/2] ws2_32/tests: Rework WSAStringToAddress tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29078 Your paranoid android. === w2008s64 (64 bit sock) === ws2_32:sock returned an error (3221225477) despite having no failures ws2_32:sock has no test summary line (early exit of the main process?)

March 3, 2017

Re: GSOC 2017 - Resource/Dialog Editor

by Austin English

On Thu, Mar 2, 2017 at 1:58 PM, Joe <ml999(a)openmailbox.org> wrote: > Hi, > > First of all, congrats for getting picked for another GSoC! > Wine made my transition to Linux way easier and with more and more > applications being supported the year of the desktop can come :) > > My name is Joseph Winzer and I am a bachelor math/CS student looking forward > to contribute to open source in this year's GSoC. > The 'Resource/Dialog Editor' project caught my eye as I remember a few years > back digging through executables out of curiousity. Last time I looked for a > resource editor it was either bundled with other software (Visual Studio, > PellesC) or as mentioned in the project description bundled up with adware > like ResEdit. > I want to change that by contributing to Wine with an open source standalone > editor anyone can use free of charge. > Equipped with my Petzold, MSDN and the help of the community I am sure I > will be able to realize this project. > > > Looking forward working with you guys :) Hi Joseph, Thanks for your interest. Could you describe your experience with C/Wine a bit? Have you thought about how you would implement/design the resource editor at all? Could you share your plans? -- -Austin GPG: 14FB D7EA A041 937B

March 2, 2017

GSOC 2017 - Resource/Dialog Editor

by Joe

Hi, First of all, congrats for getting picked for another GSoC! Wine made my transition to Linux way easier and with more and more applications being supported the year of the desktop can come :) My name is Joseph Winzer and I am a bachelor math/CS student looking forward to contribute to open source in this year's GSoC. The 'Resource/Dialog Editor' project caught my eye as I remember a few years back digging through executables out of curiousity. Last time I looked for a resource editor it was either bundled with other software (Visual Studio, PellesC) or as mentioned in the project description bundled up with adware like ResEdit. I want to change that by contributing to Wine with an open source standalone editor anyone can use free of charge. Equipped with my Petzold, MSDN and the help of the community I am sure I will be able to realize this project. Looking forward working with you guys :)

March 2, 2017

Re: [PATCH v2 2/5] winebus.sys: Build device reports for linux event devices

by Aric Stewart

On 3/2/17 12:34 AM, Roderick Colenbrander wrote: > Hi Aric, > > I have had a quick look over this patch and have some initial > feedback, maybe more later if time permits. > > For the absolute and relative axes don't hard code the minimum and > maximum values for the report descriptors. These are not correct for > many devices e.g. Xbox controllers use 16-bit absolute axes, while > DS3/DS4 for example use 8-bit. In addition xbox controllers use signed > data, while DS3/DS4 use unsigned (0-255)Also many devices use signed > data. > > You should rely on the absinfo data returned by EVIOCGABS and base > your input ranges on that. > > Thanks, > Roderick > Hi Rodrick, Thanks for looking at these, your input is very valuable given all your experience. I am a bit swamped right at the moment so I will need a moment to circle back but any in depth review you give will not be ignored. I would love to get this part working. -aric > On Mon, Feb 27, 2017 at 9:32 AM, Aric Stewart <aric(a)codeweavers.com> wrote: >> >> v2: Updates from Sebastian Lackner >> >> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> >> --- >> dlls/winebus.sys/bus_udev.c | 438 +++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 436 insertions(+), 2 deletions(-) >> >> >> >> >>

March 2, 2017