April 2017 - Wine-Devel - list.winehq.org

Re: [3/3] [resend] wsdapi/tests: Add initial tests for WSDCreateDiscoveryPublisher

by Alexandre Julliard

Owen Rudge <orudge(a)codeweavers.com> writes: > +START_TEST(discovery) > +{ > + HMODULE dllHandle; > + > + CoInitialize(NULL); > + > + dllHandle = LoadLibraryA("wsdapi.dll"); > + > + if (dllHandle) > + { > + BOOL ret; > + > + ret = FreeLibrary(dllHandle); > + ok(ret, "FreeLibrary(1) returned %d\n", GetLastError()); > + } This test doesn't seem very useful. Also there shouldn't be any reason to load the library dynamically, you could simply link to it. -- Alexandre Julliard julliard(a)winehq.org

April 10, 2017

Wine Swag Sticker Poll

by Aric Stewart

Hello! So all the way back at wineconf I volunteered to be swag master for winehq. The idea is to have something that can be given away at trade shows, presentations, LUG visits and the like. Just something to help promote the visibility of the project. Jana here, CodeWeavers marketing director, has put together a sampling of designs to do as our first sticker and so now we are looking for some feedback on what people prefer. https://docs.google.com/forms/d/e/1FAIpQLSd5X_fXe9KSFAppRHz8kUo3XKeODyH5KeX… Rosanne? Could you direct me as to where this should be put up for the users as well? I am unfamiliar with how to communicate to our user base. The poll will run for as long as it feels like it needs to get some sort of winner. Comments and suggestions are always welcome! -aric

April 10, 2017

Re: [PATCH 1/13] msidb: Add stub tool for manipulating MSI databases.

by Erich E. Hoover

On Mon, Apr 10, 2017 at 1:53 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > ... > I can see how the extra functionality is useful for package builders but > at the same time it's not essential to build Wine. That doesn't mean we > can't maintain it in Wine, but I can also see it being part of a > separate SDK tools project. Have you considered that? Yes, I've actually been using this as a separate project for a few years. There are several of reasons that I think that this is worth including into Wine itself: 1) It allows us to match a documented tool for creating our own installers (gecko, mono), rather than having a custom interface (MSDN provides a lot of documentation on msidb) 2) The ability to easily extract and modify installers is very helpful for doing Wine MSI development 3) I've recently discovered that there are some bugs in Wine's ability to modify MSI databases I'm mostly interested in #2 and #3, but #1 is a nice side benefit. Discovering #3 is really the "final straw" for me and, while I have not had a chance to find the bug yet, I have found a reproducible test case. Since I rely upon this tool to create that test case, it's somewhat of a prerequisite for both solving the problem and demonstrating to you that it's fixed. Best, Erich

April 10, 2017

Re: [PATCH] regedit: Do not import DWORD values beginning with "0x" (v2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30089 Your paranoid android. === build (build) === Patch failed to apply

April 10, 2017

Re: [v2 1/2] d3dx9: Support relative addressing in preshader.

by Paul Gofman

On 04/09/2017 08:40 PM, Matteo Bruni wrote: > It looks to me as the CLIT section in the bytecode you attached > contains 16 as the constants count. Not sure why the print below > doesn't match that. > > Either way, it doesn't matter much. Even if immediate counts > non-multiple-of-4 can actually exist we could (and I argue, should) > bump that up to the next multiple, zeroing the extra components. > Oh, it must be due to the code for updating constant table size under discussion does not respect scalar op flag, and 18 constants here reveals that (as the constant used in the instruction causing actual size update is using just 1 constant for all 3 components, not 3). It is not good by itself, in particular, it can break index wrap logic. For the same index wrap logic we can't just bump to next multiple of 4, if the cases where the count is not the multiple actually exist (I am not sure anymore that they do). So I will fix that update for scalar op case at some point, do some more testing and either send the fix or change the constant components count to 4, with a fail on preshader creation if it is not the case.

April 10, 2017

Re: [PATCH] xmllite/writer: Fix IID argument handling in CreateXmlWriter()

by Nikolay Sivov

On 10.04.2017 11:06, Jacek Caban wrote: > Hi Nikolay, > > > On 4/10/17 6:37 AM, Nikolay Sivov wrote: >> + hr = CreateXmlWriter(&IID_IStream, (void **)&unk, NULL); >> + ok(hr == E_NOINTERFACE, "got %08x\n", hr); >> + >> + hr = CreateXmlWriter(&IID_IUnknown, (void **)&unk, NULL); >> + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); >> + hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&writer); >> + > > I think you meant IID_IXmlWriter here. Yes, this is wrong, thanks. > > Jacek > >

April 10, 2017

Re: [PATCH] xmllite/writer: Fix IID argument handling in CreateXmlWriter()

by Jacek Caban

Hi Nikolay, On 4/10/17 6:37 AM, Nikolay Sivov wrote: > + hr = CreateXmlWriter(&IID_IStream, (void **)&unk, NULL); > + ok(hr == E_NOINTERFACE, "got %08x\n", hr); > + > + hr = CreateXmlWriter(&IID_IUnknown, (void **)&unk, NULL); > + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&writer); > + I think you meant IID_IXmlWriter here. Jacek

April 10, 2017

Re: [PATCH 1/13] msidb: Add stub tool for manipulating MSI databases.

by Hans Leidekker

On Sun, 2017-04-09 at 13:12 -0600, Erich E. Hoover wrote: > The "Windows SDK Components for Windows Installer Developers" has a > command line tool called msidb that is incredibly useful for creating, > editing, and exporting MSI installer databases, think of it as > winemsibuilder on steroids. This patch series implements much of the > functionality of the msidb tool, maintains compatible CLI flags, and > the underlying MSI functionality necessary to support these features. > With this patch series all the existing winemsibuilder functionality > is available, plus the ability to drop streams, export the > _SummaryInformation table, export binary streams (Binary/Icon tables), > and some miscellaneous bug fixes. A big feature of the implementation > is that it allows you to edit existing installer databases, rather > than just creating new ones. I can see how the extra functionality is useful for package builders but at the same time it's not essential to build Wine. That doesn't mean we can't maintain it in Wine, but I can also see it being part of a separate SDK tools project. Have you considered that?

April 10, 2017

Re: [PATCH 2/2] odbccp32: Handle ODBC_CONFIG_DRIVER request in SQLConfigDriver/W

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30067 Your paranoid android. === build (build) === Make failed

April 10, 2017

Re: [PATCH 2/2 v2] ntdll: Zero debug registers after thread creation

by Matteo Bruni

2017-04-09 20:15 GMT+02:00 Christian Inci <chris.wine(a)broke-the-inter.net>: > Thanks. I guess that I should quit coding altogether. That's a bit of an overreaction... BTW, thank you for debugging and finding a fix for the bug!

April 9, 2017