April 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.

by Nikolay Sivov

On 05.04.2017 10:15, Stefan Dösinger wrote: > --- > dlls/comctl32/tests/msg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h > index 3fa0fae..b30b5d8 100644 > --- a/dlls/comctl32/tests/msg.h > +++ b/dlls/comctl32/tests/msg.h > @@ -369,7 +369,7 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > context, expected->message, actual->message); > } > > - if(todo && !failcount) /* succeeded yet marked todo */ > + if(todo && !failcount && !broken(TRUE)) /* succeeded yet marked todo */ > { > dump++; > todo_wine > This patch is marked is failed by testbot, but it looks like bot inability to deal with header file change in tests directory, as it still tries to run some tests. Anyway, could you make it look similar to user32/tests/msg.c? It's using: --- if( todo && !failcount) /* succeeded yet marked todo */ todo_wine { if (!strcmp(winetest_platform, "wine")) dump++; --- Platform is tested directly. It's not the only place where it's done like that, and it's more readable than broken(1), I think.

April 5, 2017

Re: [PATCH 2/4] ws2_32/tests: Added WSARecv tests using completion function.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29976 Your paranoid android. === w2008s64 (64 bit sock) === sock.c:6817: Test failed: got 0

April 5, 2017

Re: [PATCH 6/6] comctl32/tests: Test WINDOWPOS structure contents.

by Stefan Dösinger

Am 2017-04-05 um 09:42 schrieb Marvin: > pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} Smells like there's padding in the structure in 64 bit...

April 5, 2017

Re: [v3 PATCH 2/2] odbccp32: Implement SQLRemoveTranslator/W

by Huw Davies

On Wed, Apr 05, 2017 at 01:29:21AM +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 7b2f020bbe..4e00f2a29f 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1229,20 +1229,75 @@ BOOL WINAPI SQLRemoveDSNFromIni(LPCSTR lpszDSN) > return FALSE; > } > > -BOOL WINAPI SQLRemoveTranslatorW(LPCWSTR lpszTranslator, LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveTranslatorW(const WCHAR *translator, DWORD *usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %p\n", debugstr_w(lpszTranslator), lpdwUsageCount); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("%s %p\n", debugstr_w(translator), usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, translator, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + DWORD count; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + count = usagecount - 1; > + if (count) > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&count, sizeof(count)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + } > + > + RegCloseKey(hkeydriver); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + if(RegDeleteKeyW(hkey, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(translator)); > + > + if (RegOpenKeyW(hkey, odbctranslators, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(translator)); > + > + RegCloseKey(hkeydriver); > + } > + } > + > + RegCloseKey(hkey); > + } > + > + if (usage_count) > + *usage_count = 0; Should this really always be zero? Huw.

April 5, 2017

Re: [PATCH] winhttp/tests: Added multi Authenticate header test

by Hans Leidekker

On Tue, 2017-04-04 at 23:39 +0000, Alistair Leslie-Hughes wrote: > +static void test_multi_authentication(int port) > +{ > + static const WCHAR multiauthW[] = {'/','m','u','l','t','i','a','u','t','h',0}; > + static const WCHAR getW[] = {'G','E','T',0}; > + HINTERNET ses, con, req; > + DWORD supported, first, target = 8; > + BOOL ret; > + > + ses = WinHttpOpen(test_useragent, WINHTTP_ACCESS_TYPE_NO_PROXY, NULL, NULL, 0); > + ok(ses != NULL, "failed to open session %u\n", GetLastError()); > + > + con = WinHttpConnect(ses, localhostW, port, 0); > + ok(con != NULL, "failed to open a connection %u\n", GetLastError()); > + > + req = WinHttpOpenRequest(con, getW, multiauthW, NULL, NULL, NULL, 0); > + ok(req != NULL, "failed to open a request %u\n", GetLastError()); > + > + ret = WinHttpSendRequest(req, WINHTTP_NO_ADDITIONAL_HEADERS, 0, > + WINHTTP_NO_REQUEST_DATA,0, 0, 0 ); > + ok(ret, "expected success\n"); > + > + ret = WinHttpReceiveResponse(req, NULL); > + ok(ret, "expected success\n"); > + > + ret = WinHttpQueryAuthSchemes(req, &supported, &first, &target); > + todo_wine ok(ret, "expected success\n"); > + todo_wine ok(supported == (WINHTTP_AUTH_SCHEME_BASIC | WINHTTP_AUTH_SCHEME_NTLM), "got %x\n", supported); > + todo_wine ok(target == WINHTTP_AUTH_TARGET_SERVER, "got %x\n", target); You need to initialize 'supported'. Maybe test 'first' too?

April 5, 2017

Re: [PATCH 6/6] comctl32/tests: Test WINDOWPOS structure contents.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29956 Your paranoid android. === wvistau64 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w2008s64 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w7pro64 (64 bit pager) === pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w1064 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}

April 5, 2017

Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29951 Your paranoid android. === wxppro (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2003std (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === wvistau64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2008s64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7u (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7pro64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w8 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w864 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w1064 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === wvistau64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2008s64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7pro64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w864 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w1064 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?)

April 5, 2017

Re: shell32: Solve the problem about 'OK' button is always disable when call SHBrowseForFolder with flags including both BIF

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29950 Your paranoid android. === build (build) === Patch failed to apply

April 5, 2017

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS

by 许文龙

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS

April 5, 2017

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS

by 许文龙

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS

April 5, 2017