May 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 4/6] user32: Fix the calculation of system metrics icon sizes.

by Huw Davies

> On 2 May 2017, at 12:02, Marvin <testbot(a)winehq.org> wrote: > > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=30703 > > Your paranoid android. > > > === wxppro (32 bit sysparams) === > sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20 > sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20 Sorry about that. Probably best to hold this whole series while I get these sorted. Huw.

May 2, 2017

Re: [PATCH 6/6] user32: Change IsProcessDPIAware() to always return TRUE.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30704 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20 === wvistau64 (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w7u (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 6 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 6 === w8 (32 bit sysparams) === sysparams.c:2519: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2530: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0 === w1064 (32 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0 === wvistau64 (64 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w1064 (64 bit sysparams) === sysparams.c:2827: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2828: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 sysparams.c:2975: Test failed: got 96, dpi 96, real_dpi 0

May 2, 2017

Re: [PATCH 4/6] user32: Fix the calculation of system metrics icon sizes.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30703 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20 === wvistau64 (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w7u (32 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 6 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 6 === w8 (32 bit sysparams) === sysparams.c:2517: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 === w1064 (32 bit sysparams) === sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message sysparams.c:2523: Test failed: WM_DISPLAYCHANGE was sent with wParam 32 despite mode change failure sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16 === wvistau64 (64 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18 === w1064 (64 bit sysparams) === sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16 sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16

May 2, 2017

Re: [PATCH 2/5] ddraw: Validate that non-fill blits have a source surface in ddraw_surface7_Blt().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30698 Your paranoid android. === wxppro (32 bit ddraw4) === 0a24:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CE7A === wvistau64 (32 bit ddraw4) === 0970:ddraw4: unhandled exception c0000005 at 0049CE7A === w2008s64 (32 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 0049CE7F === w7u (32 bit ddraw4) === 0ca4:ddraw4: unhandled exception c0000005 at 0049CE7A === w7pro64 (32 bit ddraw4) === 00c0:ddraw4: unhandled exception c0000005 at 0049CE7F === wvistau64 (64 bit ddraw4) === 01b0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w2008s64 (64 bit ddraw4) === 08c4:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w7pro64 (64 bit ddraw4) === 07e0:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (64 bit ddraw4) === 0fc8:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w1064 (64 bit ddraw4) === 0f3c:ddraw4: unhandled exception c0000005 at 00000000004865E2 === w864 (32 bit ddraw1) === ddraw1.c:10272: Test failed: Got unexpected color 0x00ffffff.

May 2, 2017

Re: [PATCH 1/5] ddraw/tests: Port test_texturemapblend() to ddraw4.c as well.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30697 Your paranoid android. === wxppro (32 bit ddraw4) === 09f8:ddraw4: unhandled exception c0000005 at 0000FFFF === w2003std (32 bit ddraw4) === 05f0:ddraw4: unhandled exception c0000005 at 0049CB5A === wvistau64 (32 bit ddraw4) === 0744:ddraw4: unhandled exception c0000005 at 0049CB5A === w2008s64 (32 bit ddraw4) === 0bf4:ddraw4: unhandled exception c0000005 at 0049CB5F === w7u (32 bit ddraw4) === 0fbc:ddraw4: unhandled exception c0000005 at 0049CB5A === w7pro64 (32 bit ddraw4) === 0338:ddraw4: unhandled exception c0000005 at 0049CB5F === wvistau64 (64 bit ddraw4) === 072c:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w2008s64 (64 bit ddraw4) === 0b30:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w7pro64 (64 bit ddraw4) === 0854:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w864 (64 bit ddraw4) === 0fac:ddraw4: unhandled exception c0000005 at 00000000004863E2 === w1064 (64 bit ddraw4) === 0c84:ddraw4: unhandled exception c0000005 at 00000000004863E2

May 2, 2017

Re: Wine native fps overlay

by Nikolay Sivov

On 01.05.2017 17:10, CARLOS RODRIGUEZ wrote: > Hi > > Almost forget maybe can improve WINEDEBUG=+fps for only display fps > (actually gives priority to errors than fps information) You suppress the rest of traces, like -all,+fps. > > Thanks > > >

May 2, 2017

Re: [PATCH v3 1/2] mountmgr: Create devices and registry entries for serial ports.

by Bruno Jesus

On Wed, Apr 26, 2017 at 12:18 AM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=11811 > > This patch also autodetects USB serial ports, making them "just work". > > The user may override the port autodetection by creating entries in > HKLM\Software\Wine\Ports. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Although I don't feel qualified to sign this patch I can say that I tested it with real hardware and it works fine for both real and USB serial ports in Linux. Hyper Terminal recognizes all ports without any manual registry workaround.

May 2, 2017

Re: [v3 PATCH 1/4] mfplat: Implement MFTRegister

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static HRESULT register_category(CLSID *clsid, GUID *category) > +{ > + HKEY hcategory, htmp1, htmp2; > + WCHAR buffer[64]; > + DWORD ret; > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, categories_keyW, &hcategory)) > + return E_FAIL; > + > + GUIDToString(buffer, category); > + ret = RegCreateKeyW(hcategory, buffer, &htmp1); > + RegCloseKey(hcategory); > + if (ret) return E_FAIL; You should create the entire path if needed instead of failing. > @@ -650,6 +650,10 @@ HKLM,Software\Borland\Database Engine\Settings\SYSTEM\INIT,SHAREDMEMLOCATION,,90 > HKLM,Software\Clients\Mail,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,,2,"Native Mail Client" > HKLM,Software\Clients\Mail\Native Mail Client,"DLLPath",2,"%11%\winemapi.dll" > +HKLM,Software\Classes\MediaFoundation,,16 > +HKLM,Software\Classes\MediaFoundation\MediaSources,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms,,16 > +HKLM,Software\Classes\MediaFoundation\Transforms\Categories,,16 ...and then you no longer need this. -- Alexandre Julliard julliard(a)winehq.org

May 1, 2017

Re: regedit: Read registry lines through a single function

by Alexandre Julliard

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > +static WCHAR *get_line(struct reg_info *reg_info) > +{ > + WCHAR *line; > + > + if (!reg_info->is_unicode) > + { > + char *lineA = get_lineA(reg_info->file); > + line = GetWideString(lineA); > + } > + else > + { > + line = get_lineW(reg_info->file); > + } > + > + return line; > +} That's fairly ugly. If you want to use common code, you should probably pass a function pointer for getting lines. Also you'd have to do it in a way that doesn't require freeing the buffer. -- Alexandre Julliard julliard(a)winehq.org

May 1, 2017

Re: [PATCH] user32: Do not call SendMessage() to show a window that is already visible.

by Kimmo Myllyvirta

On 04/30/2017 07:38 AM, Dmitry Timoshkov wrote: > Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > >> diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c >> index c2b35ec..64fdfe0 100644 >> --- a/dlls/user32/winpos.c >> +++ b/dlls/user32/winpos.c >> @@ -1239,6 +1239,9 @@ BOOL WINAPI ShowWindow( HWND hwnd, INT cmd ) >> if ((cmd == SW_HIDE) && !(GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) >> return FALSE; >> >> + if ((cmd == SW_SHOW) && (GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE)) >> + return TRUE; >> + >> return SendMessageW( hwnd, WM_WINE_SHOWWINDOW, cmd, 0 ); >> } > Please have a look at the show_window() implementation and try to cover > all cases that trigger SWP_SHOWWINDOW flag passed to SetWindowPos() in > order to actually show a window. In fact it's only SW_HIDE that leads > to that, so perhaps just adding an 'else' to the SW_HIDE case is enough? > Yeah, it would be better to fix all the cases at once instead of one-by-one. Probably something similar to the attached diff. I'll take a look at it later, this is already fixed in staging it seems.

May 1, 2017