June 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 03/12] msacm32: Add more invalid parameter checks for acmFormatSuggest().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31450 Your paranoid android. === wvistau64 (64 bit msacm) === msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 === w2008s64 (64 bit msacm) === msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 === w7pro64 (64 bit msacm) === msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 === w864 (64 bit msacm) === msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 === w1064 (64 bit msacm) === msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:141: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200 msacm.c:186: Test failed: acmFormatSuggest(): rc = 0000000b, should be 00000200

June 6, 2017

Re: [PATCH 1/2] include/windocdec.idl: Add interface IWICImagingFactory2

by Vincent Povirk

> +cpp_quote ("typedef interface ID2D1Device ID2D1Device;") > +cpp_quote ("typedef interface ID2D1Image ID2D1Image;") That's odd, why is this in wincodec.idl?

June 6, 2017

Re: [PATCH 6/6] urlmon/tests: Added BindProtocol redirection handling tests.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/urlmon/tests/protocol.c | 155 > ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 152 insertions(+), 3 deletions(-) This is failing consistently here: ../../../tools/runtest -q -P wine -T ../../.. -M urlmon.dll -p urlmon_test.exe.so protocol && touch protocol.ok protocol.c:1483: Test failed: unexpected call SetPriority protocol.c:1483: Test failed: unexpected call SetPriority Makefile:249: recipe for target 'protocol.ok' failed make: *** [protocol.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

June 6, 2017

Re: [PATCH 2/4] ntdll: Provide more accurate virtual memory counters.

by Michael Müller

I also would like to point out that APCs can lead to a significant performance decrease when an application like a taskmanager or anticheat tool queries these values multiples times per second for all/multiple processes. The wineserver already has a list of committed memory allocated through NtAllocateVirtualMemory (see add_mapping_committed_range wineserver call). Maybe it is possible to satisfy the application using these values without interrupting running processes. I also wanted to take a look at the problem, but the download links are either broken or very unreliable. Regards, Michael

June 6, 2017

Re: configure: Set PKG_CONFIG_PATH to get the right settings for the target host.

by Sebastian Lackner

On 06.06.2017 17:52, Francois Gouget wrote: > On Tue, 6 Jun 2017, Michael Müller wrote: > >> Setting PKG_CONFIG_PATH doesn't seem like a good option for me. You >> would need to implement the path for every possible distribution and >> platform to not cause any regressions. > > You may be thinking of PKG_CONFIG_LIBDIR which overrides the > system defaults. PKG_CONFIG_PATH only prepends to the system defaults so > that if the .pc files are not found there they are still looked up in > all the standard places. > > >> On Arch Linux it is for example /usr/lib32/pkgconfig. On FreeBSD it is >> /usr/libdata/pkgconfig/. > > Maybe a few more paths will need to be added but their absence will not > make things worse. > > >> Not to speak of cross compilation cases in which users might have a >> special build of pkgconfig where overriding PKG_CONFIG_PATH doesn't >> make any sense. > > That's why PKG_CONFIG_PATH is only set if $cross_compiling is false in > the 32 bit case. The 64 bit case does not seem to have any qualms > forcing CC="$CC -m64" regardless of $cross_compiling so I'm aligning > myself with that until I know why it should be different. > The 32-bit case shouldn't cause any problems and looks fine to me, but the 64-bit case would break our cross compilation for macOS. Adding "-m64" doesn't matter, however setting PKG_CONFIG_PATH means that host pkgconfig information is used instead of the correct one. Of course it can be worked around with a cross compilation check, but I'm wondering if it wouldn't be better to omit this hack for 64-bit and only focus on the 32-bit case. Best regards, Sebastian

June 6, 2017

Re: configure: Set PKG_CONFIG_PATH to get the right settings for the target host.

by Francois Gouget

On Tue, 6 Jun 2017, Michael Müller wrote: > Setting PKG_CONFIG_PATH doesn't seem like a good option for me. You > would need to implement the path for every possible distribution and > platform to not cause any regressions. You may be thinking of PKG_CONFIG_LIBDIR which overrides the system defaults. PKG_CONFIG_PATH only prepends to the system defaults so that if the .pc files are not found there they are still looked up in all the standard places. > On Arch Linux it is for example /usr/lib32/pkgconfig. On FreeBSD it is > /usr/libdata/pkgconfig/. Maybe a few more paths will need to be added but their absence will not make things worse. > Not to speak of cross compilation cases in which users might have a > special build of pkgconfig where overriding PKG_CONFIG_PATH doesn't > make any sense. That's why PKG_CONFIG_PATH is only set if $cross_compiling is false in the 32 bit case. The 64 bit case does not seem to have any qualms forcing CC="$CC -m64" regardless of $cross_compiling so I'm aligning myself with that until I know why it should be different. -- Francois Gouget <fgouget(a)codeweavers.com>

June 6, 2017

Re: [PATCH 2/4] ntdll: Provide more accurate virtual memory counters.

by Matteo Bruni

2017-06-06 17:35 GMT+02:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: > On Mon, 5 Jun 2017 19:41:06 +0200, Matteo Bruni wrote: >> 2017-06-05 16:15 GMT+02:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: >> > On Sun, 4 Jun 2017 22:51:10 -0600, Alex Henrie wrote: >> >> Out of curiosity, is there a particular application that depends on >> >> this behavior? It could be argued that reporting the value from the >> >> native operating system is better because it tells what's really >> >> happening in the process. >> >> >> >> -Alex >> > >> > Good question. I'm trying to fix Sorcery Jokers (trial) issue, bug 43119. >> > The application repeatedly trys to allocate virtual memory as much as >> > possible, and measures available memory size by GlobalMemoryStatusEx(). >> > >> > This patch is better than nothing. The application stops memory >> > allocation about 384MB (0x17ffffff) free. After the allocation, it >> > succeeds to load libGL.so. However, it shows driver pointer missing >> > error when loading DRI driver, radeonsi_dri.so. I'm still in trouble >> > with this point. >> > >> > By the way, I have another idea about this issue. That is reserving >> > virtual memory area when loading wined3d.dll and release it just before >> > loading OpenGL libraries. Being hackish idea, I chose the forementioned >> > method in the beginning. >> >> As far as hacks go, does adding some arbitrary "reserved" amount to >> pvmi.VirtualSize make any difference? > > Thanks comments. Could you explain why adding "reserved" amount to > pvmi.VirtualSize helps the issue? > From my viewpoint, if we increase pvmi.VirtualSize, available virtual memory, > i.e. MEMORYSTATUSEX.ullAvailVirtual, will decline. And, VM allocation > limit doesn't change. As I understood your previous email, it sounded like the application allocates memory until the free memory amount gets to some particular value. By "faking" a lower free memory amount the application might stop allocating earlier and leave enough addressing space for native libraries. Does it make sense? Did I misunderstand something?

June 6, 2017

Re: [PATCH 2/4] ntdll: Provide more accurate virtual memory counters.

by Akihiro Sagawa

On Mon, 5 Jun 2017 19:41:06 +0200, Matteo Bruni wrote: > 2017-06-05 16:15 GMT+02:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: > > On Sun, 4 Jun 2017 22:51:10 -0600, Alex Henrie wrote: > >> Out of curiosity, is there a particular application that depends on > >> this behavior? It could be argued that reporting the value from the > >> native operating system is better because it tells what's really > >> happening in the process. > >> > >> -Alex > > > > Good question. I'm trying to fix Sorcery Jokers (trial) issue, bug 43119. > > The application repeatedly trys to allocate virtual memory as much as > > possible, and measures available memory size by GlobalMemoryStatusEx(). > > > > This patch is better than nothing. The application stops memory > > allocation about 384MB (0x17ffffff) free. After the allocation, it > > succeeds to load libGL.so. However, it shows driver pointer missing > > error when loading DRI driver, radeonsi_dri.so. I'm still in trouble > > with this point. > > > > By the way, I have another idea about this issue. That is reserving > > virtual memory area when loading wined3d.dll and release it just before > > loading OpenGL libraries. Being hackish idea, I chose the forementioned > > method in the beginning. > > As far as hacks go, does adding some arbitrary "reserved" amount to > pvmi.VirtualSize make any difference? Thanks comments. Could you explain why adding "reserved" amount to pvmi.VirtualSize helps the issue? >From my viewpoint, if we increase pvmi.VirtualSize, available virtual memory, i.e. MEMORYSTATUSEX.ullAvailVirtual, will decline. And, VM allocation limit doesn't change. Thanks in advance, Akihiro Sagawa

June 6, 2017

RE: [PATCH v2 1/2] msvcrt: Clean up registered C++ object in handler.

by Daniel Lehman

> > + __CxxUnregisterExceptionObject(frame, > > + rec->ExceptionCode == CXX_EXCEPTION && > > + data->exc_record->ExceptionCode == CXX_EXCEPTION && > > + rec->ExceptionInformation[1] == data->exc_record->ExceptionInformation[1]); > > + } > Do you need to call __CxxUnregisterExceptionObject with TRUE as second argument in any case except of rethrow? Yeah, just rethrow is handled specially. And extra specially for SEH > __FINALLY_CTX(cxx_catch_cleanup, &catch_cleanup_ctx); > > The above code is incorrect if exception object needs to be preserved not only in case of rethrow. > > What do you think about it? Sounds good Thanks, Piotr

June 6, 2017

Re: [PATCH 6/6] urlmon/tests: Added BindProtocol redirection handling tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31439 Your paranoid android. === w864 (32 bit protocol) === protocol.c:875: Test failed: unexpected call ReportProgress_CONNECTING === w864 (64 bit protocol) === protocol.c:875: Test failed: unexpected call ReportProgress_CONNECTING

June 6, 2017