June 2017 - Wine-Devel - list.winehq.org

Re: [PATCH v2] gdiplus: Scale widened dashes to the pen width.

by Vincent Povirk

I don't understand this part. On Tue, Jun 27, 2017 at 5:27 PM, Zebediah Figura <z.figura12(a)gmail.com> wrote: > @@ -2175,8 +2182,7 @@ static void widen_dashed_figure(GpPath *path, GpPen *pen, int start, int end, > if (dash_index % 2 == 0 && num_tmp_points != 0) > { > /* last dash overflows last segment */ > - tmp_points[num_tmp_points] = path->pathdata.Points[end]; > - widen_open_figure(tmp_points, pen, 0, num_tmp_points, > + widen_open_figure(tmp_points, pen, 0, num_tmp_points-1, > draw_start_cap ? pen->startcap : LineCapFlat, pen->customstart, > closed ? LineCapFlat : pen->endcap, pen->customend, last_point); > }

June 28, 2017

Re: [PATCH 3/3] gdiplus: Add partial support for GdipDrawImagePointsRect on metafile

by Vincent Povirk

Can we keep the code for generating an EmfplusImage structure separate from this? We'll want to reuse it for EmfPlusDrawImage and EmfPlusTextureBrushOptionalData.

June 28, 2017

WineConf RSVP

by Jacek Caban

Hi all, Jeremy has set up RSVP page for this year conference: https://www.winehq.org/wineconf/rsvp Please fill the form if you're planning to attend. The pool of rooms for participants is reserved until middle of October. However, some rooms will be released in the end of July unless we know that we need them. That said, an information about number of participants is important for organization reasons. Thanks, Piotr and Jacek

June 28, 2017

Re: [2/7] webservices: Add an index to the static dictionary.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > +static const ULONG dict_sorted[] = > +{ > + 81, 91, 129, 314, 185, 164, 346, 66, 235, 305, 14, 6, 114, 97, 96, 94, 11, 95, 110, 451, > + 443, 121, 213, 7, 71, 82, 431, 343, 74, 75, 73, 59, 447, 445, 467, 163, 472, 463, 453, 409, Why is it so large? Shouldn't it be the same size as the strings array? -- Alexandre Julliard julliard(a)winehq.org

June 28, 2017

Re: [v2 PATCH] dmime: Query the Sound buffer for supported interfaces

by Michael Stefaniuc

Hello Alistair, On 06/28/2017 08:46 AM, Alistair Leslie-Hughes wrote: > v2: Fix compile warning. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/dmime/audiopath.c | 18 +++++++----------- > dlls/dmime/tests/dmime.c | 23 +++++++++++++++++++++++ > 2 files changed, 30 insertions(+), 11 deletions(-) > > diff --git a/dlls/dmime/audiopath.c b/dlls/dmime/audiopath.c > index 04f0af03d0..211f2156f2 100644 > --- a/dlls/dmime/audiopath.c > +++ b/dlls/dmime/audiopath.c > @@ -137,17 +137,13 @@ static HRESULT WINAPI IDirectMusicAudioPathImpl_GetObjectInPath (IDirectMusicAud > case DMUS_PATH_BUFFER: > if (This->pDSBuffer) > { > - if (IsEqualIID (iidInterface, &IID_IDirectSoundBuffer8)) { > - IDirectSoundBuffer8_QueryInterface (This->pDSBuffer, &IID_IDirectSoundBuffer8, ppObject); > - TRACE("returning %p\n",*ppObject); > - return S_OK; > - } else if (IsEqualIID (iidInterface, &IID_IDirectSound3DBuffer)) { > - IDirectSoundBuffer8_QueryInterface (This->pDSBuffer, &IID_IDirectSound3DBuffer, ppObject); > - TRACE("returning %p\n",*ppObject); > - return S_OK; > - } else { > - FIXME("Bad iid\n"); > - } you need to add tests for all the interfaces supported by the DirectSoundBuffer object too: IID_IDirectSoundNotify, IID_IDirectSound3DBuffer, IID_IKsPropertySet. But if native supports the query for those too this can be simplified even further to a return IDirectSoundBuffer8_QueryInterface(This->pDSBuffer, iidInterface, ppObject); The extra tracing isn't really needed as IDirectSoundBuffer8_QueryInterface() already does that. And any serious dmusic tracing needs to include the dsound debug channels anyway. > + if(IDirectSoundBuffer8_QueryInterface (This->pDSBuffer, iidInterface, ppObject) == S_OK) { Just in case you insist on keeping the extra tracing: "if" is not a function so please have a space between it and the "(". And no space between the function name and "(". > + TRACE("returning %p\n",*ppObject); Please add a space after the "," thanks bye michael > + return S_OK; > + } > + > + WARN("Unsupported iid %s\n", debugstr_guid(iidInterface)); > + return E_NOINTERFACE; > } > break; > > diff --git a/dlls/dmime/tests/dmime.c b/dlls/dmime/tests/dmime.c > index a154eac50b..13c6afbfec 100644 > --- a/dlls/dmime/tests/dmime.c > +++ b/dlls/dmime/tests/dmime.c > @@ -23,6 +23,7 @@ > #include <wine/test.h> > #include <dmusici.h> > #include <audioclient.h> > +#include <guiddef.h> > > #define ARRAY_SIZE(a) (sizeof(a)/sizeof((a)[0])) > > @@ -45,8 +46,11 @@ static void test_COM_audiopath(void) > IDirectMusicAudioPath *dmap; > IUnknown *unk; > IDirectMusicPerformance8 *performance; > + IDirectSoundBuffer *dsound; > + IDirectSoundBuffer8 *dsound8; > ULONG refcount; > HRESULT hr; > + DWORD buffer = 0; > > hr = CoCreateInstance(&CLSID_DirectMusicPerformance, NULL, CLSCTX_INPROC_SERVER, > &IID_IDirectMusicPerformance8, (void**)&performance); > @@ -89,6 +93,25 @@ static void test_COM_audiopath(void) > ok(refcount == 5, "refcount == %u, expected 5\n", refcount); > refcount = IUnknown_Release(unk); > > + hr = IDirectMusicAudioPath_GetObjectInPath(dmap, DMUS_PCHANNEL_ALL, DMUS_PATH_BUFFER, buffer, &GUID_NULL, > + 0, &IID_IDirectSoundBuffer, (void**)&dsound); > + ok(hr == S_OK, "Failed: %08x\n", hr); > + IDirectSoundBuffer_Release(dsound); > + > + hr = IDirectMusicAudioPath_GetObjectInPath(dmap, DMUS_PCHANNEL_ALL, DMUS_PATH_BUFFER, buffer, &GUID_NULL, > + 0, &IID_IDirectSoundBuffer8, (void**)&dsound8); > + ok(hr == S_OK, "Failed: %08x\n", hr); > + IDirectSoundBuffer8_Release(dsound8); > + > + hr = IDirectMusicAudioPath_GetObjectInPath(dmap, DMUS_PCHANNEL_ALL, DMUS_PATH_BUFFER, buffer, &GUID_NULL, > + 0, &IID_IUnknown, (void**)&unk); > + ok(hr == S_OK, "Failed: %08x\n", hr); > + IUnknown_Release(unk); > + > + hr = IDirectMusicAudioPath_GetObjectInPath(dmap, DMUS_PCHANNEL_ALL, DMUS_PATH_BUFFER, buffer, &GUID_NULL, > + 0, &GUID_NULL, (void**)&dsound8); > + ok(hr == E_NOINTERFACE, "Failed: %08x\n", hr); > + > while (IDirectMusicAudioPath_Release(dmap) > 1); /* performance has a reference too */ > IDirectMusicPerformance8_CloseDown(performance); > IDirectMusicPerformance8_Release(performance); >

June 28, 2017

Rerun TestBot tasks that timeout?

by Francois Gouget

The hope would be that the timeout was due to an external factor and that the task won't time out on the second try. But it's also quite likely that that the timeout is caused by an issue with the test itself and then it would time out again, and again. So with the default 3 tries this would result in tripling the time it takes to get the results (so 6 minutes and 3 reverts). Furthermore timeouts are not that common (particularly spurious ones) so it may not be worth changing anything. If we do want to do something the patch would be simple. I believe something like the patch below would do the trick. We could also have a single retry in such a case but this would require to special-case the code. diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl index 1663c105..0cb0ea18 100755 --- a/testbot/bin/WineRunTask.pl +++ b/testbot/bin/WineRunTask.pl @@ -765,4 +765,5 @@ FatalTAError(undef, $TAError, $PossibleCrash) if (defined $TAError); # Wrap up # -WrapUpAndExit($NewStatus, $TaskFailures); +# Don't retry running a timed out test if it has failures anyway +WrapUpAndExit($NewStatus, $TaskFailures, ($TaskTimedOut and $TaskFailures == 1)); -- 2.11.0

June 28, 2017

Re: [v2 PATCH] oledb32: Support DBTYPE_DBTIMESTAMP to DBTYPE_WSTR in DataConvert

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31909 Your paranoid android. === wxppro (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w2003std (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === wvistau64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w2008s64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w7u (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w7pro64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w8 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w864 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w1064 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4

June 28, 2017

Re: [PATCH] oledb32: Support DBTYPE_DBTIMESTAMP to DBTYPE_WSTR in DataConvert

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31908 Your paranoid android. === wxppro (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w2003std (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === wvistau64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w2008s64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w7u (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w7pro64 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w8 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w864 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4 === w1064 (32 bit convert) === convert.c:1028: Test failed: got 4 convert.c:1037: Test failed: got 4 convert.c:1046: Test failed: got 4

June 28, 2017

Re: [PATCH] gdiplus: Scale widened dashes to the pen width.

by Vincent Povirk

Well, you need to decide that. You changed its meaning in one place but not everywhere. On Tue, Jun 27, 2017 at 3:58 PM, Zebediah Figura <zfigura(a)codeweavers.com> wrote: > On 06/27/2017 03:27 PM, Vincent Povirk wrote: >> >> If the dash_pos variable is relative to pen width, we need to fix the >> other references to it. It doesn't make sense to compare it directly >> with segment_length and segment_pos. >> >> Or we could scale the whole dash_pattern array by pen width at the start. >> > > If it is, I can fix that and resend. I hadn't bothered looking and just > assumed it was unitless for some reason.

June 27, 2017

Re: [PATCH] gdiplus: Scale widened dashes to the pen width.

by Zebediah Figura

On 06/27/2017 03:27 PM, Vincent Povirk wrote: > If the dash_pos variable is relative to pen width, we need to fix the > other references to it. It doesn't make sense to compare it directly > with segment_length and segment_pos. > > Or we could scale the whole dash_pattern array by pen width at the start. > If it is, I can fix that and resend. I hadn't bothered looking and just assumed it was unitless for some reason.

June 27, 2017