July 2017 - Wine-Devel - list.winehq.org

Re: [PATCHv2] msvcrt: Export -f suffixed float functions functions on arm64

by Piotr Caban

Hi Why do you need it? Is there native arm64 version of the dlls (I've seen some announcements but is it already available)? Or is it only for winelib applications? Thanks, Piotr

July 31, 2017

[PATCH] kernel32: Load library search in system32 directory.

by Carlos Palminha

Use %windows%\system32 directory to search for the DLL. Standard search path is not used. Signed-off-by: Carlos Palminha <palminha(a)synopsys.com> --- dlls/kernel32/module.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index badfe1d175..aff5097664 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -915,13 +915,19 @@ static HMODULE load_library( const UNICODE_STRING *libname, DWORD flags ) LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR | LOAD_LIBRARY_SEARCH_APPLICATION_DIR | LOAD_LIBRARY_SEARCH_USER_DIRS | - LOAD_LIBRARY_SEARCH_SYSTEM32 | LOAD_LIBRARY_SEARCH_DEFAULT_DIRS; if( flags & unsupported_flags) FIXME("unsupported flag(s) used (flags: 0x%08x)\n", flags); - load_path = MODULE_get_dll_load_path( flags & LOAD_WITH_ALTERED_SEARCH_PATH ? libname->Buffer : NULL ); + if (flags & LOAD_LIBRARY_SEARCH_SYSTEM32) { + WCHAR spath[] = {'%','w','i','n','d','o','w','s','%','\\','s','y','s','t','e','m','3','2',0}; + int slen = (strlenW(spath) + 1) * sizeof(WCHAR); + load_path = HeapAlloc(GetProcessHeap(), 0, slen); + memcpy (load_path, spath, slen); + } else { + load_path = MODULE_get_dll_load_path( flags & LOAD_WITH_ALTERED_SEARCH_PATH ? libname->Buffer : NULL ); + } if (flags & LOAD_LIBRARY_AS_DATAFILE) { -- 2.11.0

July 31, 2017

Re: [PATCH] wined3d: Don't enable GL_EXT_geometry_shader4 on OpenGL >3.1

by Henri Verbeet

On 31 July 2017 at 08:13, Zach Mertes <techiezach(a)gmail.com> wrote: > GL_EXT_geometry_shader4's features are intrinsically enabled on OpenGL > 3.1 and newer. > Enabling it past 3.1 causes an annoying GLSL warning. > Against what version of Wine is this written? While it's correct that we don't (ever) want to use EXT_geometry_shader4, Wine has never used that extension. We initially used ARB_geometry_shader4 and later dropped it in favour of the 3.2 core profile.

July 31, 2017

Re: shell32: Implement SHCreateItemInKnownFolder.

by Huw Davies

On Sun, Jul 30, 2017 at 05:37:02PM +0800, Jactry Zeng wrote: > diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c > index 1e19f7c72e..57fb849f16 100644 > --- a/dlls/shell32/shellitem.c > +++ b/dlls/shell32/shellitem.c > @@ -662,6 +662,66 @@ HRESULT WINAPI SHCreateItemFromIDList(PCIDLIST_ABSOLUTE pidl, REFIID riid, void > return ret; > } > > +HRESULT WINAPI SHCreateItemInKnownFolder(REFKNOWNFOLDERID rfid, DWORD flags, > + LPWSTR filename, REFIID riid, void **ppv) > +{ > + HRESULT hr; > + WCHAR *pathW = NULL; > + IShellFolder *desktop = NULL, *folder = NULL; > + LPITEMIDLIST pidl_folder = NULL, pidl = NULL; > + > + TRACE("%p, %x, %s, %s, %p\n", rfid, flags, wine_dbgstr_w(filename), > + debugstr_guid(riid), ppv); > + > + if(!rfid || !ppv) > + return E_INVALIDARG; > + > + if(flags) > + FIXME("flags 0x%08x not supported\n", flags); > + > + *ppv = NULL; > + hr = SHGetDesktopFolder(&desktop); > + if(hr != S_OK) return hr; > + > + hr = SHGetKnownFolderPath(rfid, 0, NULL, &pathW); > + if(hr != S_OK) return hr; > + > + hr = IShellFolder_ParseDisplayName(desktop, NULL, NULL, pathW, NULL, &pidl_folder, NULL); > + if(hr != S_OK) > + goto cleanup; You probably want to use SHGetKnownFolderIDList() instead of these last two calls. Huw.

July 31, 2017

Re: UIRibbon

by Fabian Maurer

> This sounds like a blocker to me, at this point at least. What are the > options for applications? Can you use raw xml too (this could be useful if > ribbon description is generated in runtime)? AFAIK, no. The xml must be compiled by UICC.exe, and the binary embedded as resource. You can't really generate stuff at runtime, but the application can hide controls. > Does it use DirectUI thing or something similarly undocumented and unstable? Sorry, I never heard about DirectUI, so I don't know. But I doubt it since there is no need for any dlls that look directui related. You can make ribbons work on wine by using "propsys.dll, uiribbon.dll, uiribbonres.dll, uxtheme.dll" from win7, and a hack for the built-in user32. It's undocumented sure, I didn't find any information about it after hours of googling. I don't know if I'd call it unstable though, it works well across windows versions. Luckily the UICC compiler works under wine (with msxml3 msxml6), so at least compiling is easily. If you want to see an example, I can provide one. I already began poking around in the binary format, but I'm not very experienced with binary analysis and the ribbon information is fairly complex, too. And reversing an unknown format is always a bunch of work, I guess. Regards, Fabian Maurer

July 30, 2017

Re: UIRibbon

by Nikolay Sivov

On Fri, 28 Jul 2017 at 23:53, Fabian Maurer <dark.shadow4(a)web.de> wrote: > Hi Wine-Devel, > > I'm currently working on a patchset to get UIRibbon to work, or at least to > not crash the program. > > I noticed that the ribbon xml files need to be compiled with a program > called > UICC.exe from the windows SDK, the resulting resources have some > proprietary > binary format. If we want to load and display a ribbon, we'll have to > understand it. This sounds like a blocker to me, at this point at least. What are the options for applications? Can you use raw xml too (this could be useful if ribbon description is generated in runtime)? > > Does anyone know about information on that, or is the only way to reverse > engineer it? Does it use DirectUI thing or something similarly undocumented and unstable? > > > Regards, > Fabian Maurer > > >

July 30, 2017

Re: [PATCH v4 2/3] uiribbon: Add interface definitions

by Alistair Leslie-Hughes

Hi Fabian, Besides the below issues, the patches look good. On 30/07/17 09:29, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > +[ > + object, > + uuid(D428903C-729A-491d-910D-682A08FF2522), Please make the uuid lowercase ... > +[ > + object, > + uuid(F4F0385D-6872-43a8-AD09-4C339CB3F5C5), > + local, > + pointer_default(unique) Please make the uuid lowercase Also, could you please get rid of the LPVOID in the third patch. Best Regards Alistair Leslie-Hughes

July 30, 2017

Re: [PATCH v3 2/3] uiribbon: Add interface definitions

by Alistair Leslie-Hughes

Hi Fabian, On 30/07/17 06:36, Fabian Maurer wrote: > Code taken and adapted from d3dxof. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/uiribbon/Makefile.in | 2 + > dlls/uiribbon/uiribbon_classes.idl | 21 +++++ These changes don't make any sense for this patch. Move them to the third patch in which the interfaces are registered. Besides this, everything looks ok. Best Regards Alistair

July 29, 2017

Re: [PATCH 1/3] uiribbon: Add DLL

by Fabian Maurer

Hi Alistair, thanks for the reply, I'll submit an updated patchset soon. Regards, Fabian Maurer

July 28, 2017

Re: [PATCH 1/3] uiribbon: Add DLL

by Alistair Leslie-Hughes

Hi Fabian, >Should I add all private functions like DllGetClassObject as stub, or already >implemented? Because the class factory logic is is a bunch of code, that's why >I separated it from the initial commit. Just have it return CLASS_E_CLASSNOTAVAILABLE is fine. >Just for clarification, I should add all the needed interfaces (including >IUIApplication) at once in the idl, Yes, have a single patch that adds the idl. Here is an example of what I would expect. In this case I wanted IMFTransform but it required a a few enum/struct's to make it compile. http://source.winehq.org/git/wine.git/?a=commit;h=2164a4da3f472c6613119fd6a… > but only add the IUnknown methods into IUIFramework_Vtbl? No, when you stub the interface all the functions should be added. Example. http://source.winehq.org/git/wine.git/?a=commitdiff;h=06f8c263c2bda30f1b08f… Best Regards Alistair Leslie-Hughes

July 28, 2017