July 2017 - Wine-Devel - list.winehq.org

wine-2.0.2-rc1 Available

by Michael Stefaniuc

Hello guys, I have pushed wine-2.0.2-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ This version features 88 commits: - Some patches deferred from 2.0.1 - The compilation fixes for the prediluvian gcc 2.95 (but untested if those are enough) - Some simple "crash fix" commits that have no bugzilla entries - The usual assortment of bug fixes And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes ---------------------------------------------------------------- Bugs fixed in 2.0.2 (total 61): 2624 In dialogs, an incorrect extra WM_ERASEBKGND is sent after WM_PAINT 10858 BlueByte Game Channel fails to install 14606 TreeView + right click doesn't work the way it does in native windows 20215 Extra mouse buttons do not work in Firefox 23302 Not standard background color in Wine configuration 25625 Implement PROPSHEET_InsertPage 30378 Xuzhou network client crashes at start 30764 regedit: a key created from right-click context menu is in incorrect position 33717 regedit: Sorting registry keys on refreshing 33987 Secret Files 3 demo shows only some parts of background in ConfigTool 35563 Custom game development library expects non-zero value for ProcessVmCounters info class member 'WorkingSetSize' 37404 A right click on a registry key does not select it 37976 Poedit 1.7.4 crashes on unimplemented function msvcr120.dll.??0_ReentrantBlockingLock(a)details@Concurrency@@QAE(a)XZ 39685 Multiple applications crash on startup, need unimplemented function msvcr120.dll.??0event(a)Concurrency@@QAE(a)XZ (Rollcage Redux v1.3.8, ARC client, Playstation Now) 39856 Regedit: Default registry key is not the same as on Windows 39895 MalwareBytes Anti-malware software needs msvcr100.dll.lldiv implementation 40629 Noto Nastaliq Urdu font crashes notepad during shaping 40798 ACDSee Pro 9 (64-bit) needs msvcr120.dll.??0event(a)Concurrency@@QEAA(a)XZ 40948 Multiple apps need api-ms-win-crt-locale-l1-1-0.dll.__initialize_lconv_for_unsigned_char 40956 unimplemented function msvcr110.dll._Lock_shared_ptr_spin_lock when starting Zoner Photo Studio 18 41408 Multiple applications crash on unimplemented function msvcp140.dll.??0task_continuation_context(a)Concurrency@@AAE(a)XZ 41472 kolotibablo needs ntoskrnl.exe.KeAcquireInStackQueuedSpinLock 41753 Steep (Ubisoft) needs iphlpapi.dll.GetUnicastIpAddressEntry 41928 Mortal Kombat X needs msvcr110.dll._get_dstbias 42017 Silence d3d11_immediate_context_OMSetBlendState spam at console 42129 Steam client - unimplemented function mfreadwrite.dll.MFCreateSourceReaderFromMediaSource 42138 bug when running reaktor 6: "Unhandled exception: unimplemented function concrt140.dll.??0_ReentrantBlockingLock(a)details@Concurrency@@QAE(a)XZ called in 32-bit code (0x7b43bf1c)." 42206 Gauntlet character screen background is corrupted. 42209 Native Instruments Native Access 1.0.25 (R37) crashes on unimplemented function concrt140.dll.??1_ReentrantBlockingLock(a)details@Concurrency@@QAE(a)XZ 42239 Kontact 5.6 needs api-ms-win-crt-time-l1-1-0.dll._Wcsftime 42240 Kontact 5.6 needs concrt140.dll.??0_ReentrantBlockingLock(a)details@Concurrency@@QEAA(a)XZ 42271 Final Fantasy X needs msvcr110.dll.__crtUnhandledException 42449 Multiple apps need function msvcr120.dll.fesetround (0 A.D., BeamNG.drive) 42463 ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting." 42465 winhttp set_cookies() violates RFC6265 string comparison rules 42487 Free Devanagari font Samanata crashes during GPOS processing 42490 Assertion failure when clicking boxes in altWinDirStat 42510 InternetOpenUrl does not send query parameters for HTTPS urls 42559 Adobe Reader DC: No longer installs (Unimplemented function msi.dll.MsiGetComponentPathExW) 42575 Multiple applications need msvcp140.dll.?_LogScheduleTask(a)_TaskEventLogger@details(a)Concurrency@@QAEX_N(a)Z 42576 Poedit crashes on start on unimplemented function msvcp140.dll.?_Reset(a)_ContextCallback@details(a)Concurrency@@AAEXXZ 42578 WSAStringToAddress fails to parse IP v6 addresses with port number 42626 unimplemented function msvcr110.dll.__crtUnhandledException 42651 ViStart: fails to install, needs ntoskrnl.exe.IoReportResourceForDetection 42655 Aliens vs. Predator (2010) needs d3dx11_42.dll.D3DX11FilterTexture 42657 ACDSee Pro 9 needs msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z 42658 Playstation Now needs msvcr120.dll.?Alloc(a)Concurrency@@YAPAXI(a)Z 42688 Native Acces crashes on unimplemented msvcp140.dll.?__ExceptionPtrCompare@@YA_NPBX0(a)Z 42703 Excel 2010 does not work: unimplemented function oleaut32.dll.GetAltMonthNames 42736 scanf doesn't work as expected when using format string contains non-ascii chars 42774 WinHttpQueryAuthSchemes fails to return the correct supported value for multiple WWW-Authenticate 42798 MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties 42834 Steuer-Spar-Erklärung 2017 crashes with critical error 42876 iTunes needs function msvcp140.dll._Lock_shared_ptr_spin_lock 42986 wine can't be compiled by gcc-2.95.4 (amstream/mediastream.c) 42991 wine can't be compiled by gcc-2.95.4 (dmusic/port.c) 42992 wine can't be compiled by gcc-2.95.4 (dwrite/opentype.c) 42993 wine can't be compiled by gcc-2.95.4 (gdiplus/metafile.c) 42994 wine can't be compiled by gcc-2.95.4 (mscoree/assembly.c) 42995 wine can't be compiled by gcc-2.95.4 (netprofm/list.c) 43127 Multiple 64-bit applications crash with stack overflow errors when Wine is compiled with GCC 7.x (set_context_reg in ntdll/signal_x86_64.c assumes Xmm registers are aligned) ---------------------------------------------------------------- Changes since 2.0.1: Alex Henrie (7): winecfg: Paint text on About tab with the right background color. ntdll: Implement ProcessVmCounters for Linux. user32: Translate WM_(NC)XBUTTONUP to WM_APPCOMMAND in DefWindowProc. comctl32: Return TRUE from LVM_REDRAWITEMS with bad indices. ddraw: Don't crash if writing out a new ddraw2 surface segfaults. ddraw: Don't crash if writing out a new ddraw4 surface segfaults. ddraw: Don't crash if writing out a new ddraw7 surface segfaults. Alistair Leslie-Hughes (3): winhttp/tests: Added multi Authenticate header test. include: Add mfreadwrite.idl. mfreadwrite: Add MFCreateSourceReaderFromMediaSource stub. Andrey Gusev (1): d3dx11: Add D3DX11FilterTexture stub. André Hentschel (4): include: Add the new version of the IP_ADAPTER_UNICAST_ADDRESS structure. iphlpapi: Add GetUnicastIpAddressEntry implementation. hidclass.sys: Fix compilation on systems that don't support nameless structs. winebus.sys: Fix compilation on systems that don't support nameless structs. Aric Stewart (1): usp10: Fix Contextual Shaping for Languages with RTL write order. Austin English (2): ntoskrnl.exe: Add KeAcquireInStackQueuedSpinLock stub. ntoskrnl.exe: Add IoReportResourceForDetection stub. Björn Bidar (1): wined3d: Add NVIDIA GTX 1080 Ti to the GPU list. Bruno Jesus (2): ws2_32/tests: Rework WSAStringToAddress tests. ws2_32: Fix WSAStringToAddress parsing for IPv6. Christopher Berner (1): wined3d: Add Nvidia TitanX (Pascal). Daniel Lehman (1): msvcrt: Add Concurrency::event stubs. Fabian Maurer (5): user32/tests: Add tests for windows when first shown with WS_VISIBLE or RedrawWindow. user32/tests: Add tests for windows when first shown with SetWindowPos. user32/tests: Add tests for windows when first shown if they have children. user32/tests: Add WM_NCPAINT tests for windows crossing screen or maximized. user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown. Gijs Vermeulen (1): msvcrt: Add stub for Concurrency::Alloc. Hans Leidekker (7): msi: Implement MsiGetComponentPathExA/W. winhttp: Parse cookie attributes. winhttp: Cookie attributes are case-insensitive. winhttp: Ignore unknown schemes in WinHttpQueryAuthSchemes. msi: Properly handle DWORD registry values in MsiGetPatchInfoEx. netprofm: Fix compilation on systems that don't support nameless unions. winhttp: Fix a memory leak in insert_header (Valgrind). Hugh McMaster (4): comctl32: Improve right-click handling in treeview controls. regedit: Call TrackPopupMenu() from WM_CONTEXTMENU. regedit: Select the targeted treeview item on right mouse click. regedit: Sort treeview children on refresh. Huw D. M. Davies (1): shell32: Avoid leaking icon handles. Jacek Caban (1): msvcrt: Added lldiv implementation. Jakub Bartmiński (1): regedit: Fall back to tree root on invalid path. Józef Kucia (11): d3d11: Try to avoid spurious blend state FIXMEs(). wined3d: Add ARB_texture_buffer_object extension. wined3d: Create dummy buffer textures. wined3d: Add initial support for shader buffer views. wined3d: Do not pass LOD to texelFetch() for buffer resources. wined3d: Implement buffer samplers. amstream: Fix compilation on systems that don't support nameless unions. dmusic: Fix compilation on systems that don't support nameless structs or unions. mscoree: Fix compilation on systems that don't support nameless unions. gdiplus: Fix compilation on systems that don't support nameless unions. dxgi: Fix HMODULE leak in register_d3d10core_layers(). Michael Müller (2): cabinet: Set index of folder in FDICopy callback. wininet: Handle query parameters for HTTPS urls in InternetOpenUrlW. Michael Stefaniuc (1): dmloader: Avoid a crash on a NULL string pointer. Nikolay Sivov (8): oleaut32: Implement GetAltMonthNames(). dwrite: Make CreateFontFaceFromHdc() properly fail on unsupported font format. regedit: Sort each of top level branches separately. usp10: Ignore device tables with invalid delta format. dwrite: Fix compilation failure regarding nameless unions. schedsvc: Fix xml buffer leak (Valgrind). dwrite: Fix file object leak. shell32: Fix string leak. Peter Hater (1): comctl32/propsheet: Added PSM_INSERTPAGE implementation. Piotr Caban (16): msvcp110: Add _Lock_shared_ptr_spin_lock implementation. msvcp140: Add task_continuation_context constructor implementation. msvcp140: Add _ContextCallback implementation. msvcp140: Add _TaskEventLogger class implementation. msvcr: Add _Wcsftime implementation. msvcr100: Add reader_writer_lock class stub. msvcr100: Add _ReentrantBlockingLock class implementation. msvcrt: Add __ExceptionPtrCopyException implementation. msvcrt: Add __ExceptionPtrCompare implementation. msvcr: Add __crtUnhandledException implementation. msvcr120: Add fesetround implementation. msvcrt: Fix handling of unsigned chars in scanf format. msvcrt: Fix wide characters handling in wscanf functions. msvcr: Add _get_dstbias implementation. ucrtbase: Add __initialize_lconv_for_unsigned_char implementation. msvcr110: Add _Lock_shared_ptr_spin_lock implementation. Sebastian Lackner (3): rasapi32: Set *lpcDevices in RasEnumDevicesA. ntdll: Do not cast unaligned pointer to M128A in set_context_reg. mmdevapi: Use InitOnce to initialize audio drivers. Thierry Vermeylen (1): wnaspi32: Do not crash on SC_GETSET_TIMEOUTS. Viktor Semykin (2): windowscodecs/tests: Test for png codec seeking too far. windowscodecs: Fixed loading png from streams. -- Michael Stefaniuc mstefani(a)winehq.org

July 3, 2017

Re: Definition (or not) of IDXGIResource methods

by Ben "Root" Anderson

On Mon, Jul 3, 2017 at 1:52 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > I expect ultimately you'll need some way to get at the underlying > OpenGL object. One way to go about that may to for example extend the > IWineDXGIDevice interface in include/wine/winedxgi.idl with a method > to retrieve the underlying OpenGL object of a resource. Thanks for the tip. It'll likely make a good temporary hack until I put together the (sizable) proper solution. The added functions may even wind up being a part of said solution. > There are some details to take care of there though. For one, while > wined3d is implemented on top OpenGL, that's an implementation detail > and may not be true forever. A D3D surface/texture could be backed by > an OpenGL texture, an OpenGL renderbuffer, both, or something else > entirely, so you'll probably want some kind of interface to negotiate > the kind of representation you're requesting. Even if for simplicity > we assume we have a D3D texture backed by an OpenGL texture, that > doesn't guarantee that at any given time that OpenGL texture is > current/coherent. (See also, wined3d_texture_load_location(), > wined3d_texture_validate_location(), > wined3d_texture_invalidate_location(), etc.) So you may need a way to > flush/synchronise that OpenGL texture as well. And while > IWineDXGIDevice may be a good way to prove the concept, that's an > internal interface that doesn't make any guarantees about interface > stability, so for something that you'd want to use to interface with > external software, it would be best to create a separate interface > that does make those kinds of guarantees. Yeah, I definitely want to avoid interfaces that aren't agnostic to the underlying implementation, at which point it makes more sense to instead implement the relevant Windows APIs. My current plan is to make and submit a patch to wine-staging that implements VK_KHX_external_memory_win32 and the Direct3D/DXGI functionality needed to interact with that extension from Direct3D; this implementation would very probably lean on GL_EXT_memory_object and related extensions. Then, I'd use those interfaces to import the textures into a Vulkan instance, which is then passed to the compositor. > Finally, does this need to work with arbitrary resources, or do you > only need this for e.g. swapchain buffers? It needs to work not with swapchain buffers, but a pair of ID3D11Texture2D objects that are created by the application for the express purpose of being passed to the API I'm wrapping. One or both of these textures may or may not also be presented by the application in its own window through the usual D3D process, but I do not know and am not supposed to know whether they are, and shouldn't care. (Some apps actually render and present a completely separate scene in their window.) I need to ultimately pass the textures to the native Linux version of the compositor in a form it can digest (specifically, either a GL texture or render buffer name, or a VkImage and associated instance structs), which then (among other things) presents it in the HMD using its own (Vulkan) swapchains.

July 3, 2017

Re: [PATCH 2/2] make_unicode: Update to Unicode to version 10 I added "Bottom_And_Left", but i have no idea, if my change is correct

by Aric Stewart

Please do not change existing values. You can add new ones to the end. -aric On 7/2/17 5:23 PM, Detlef Riekenberg wrote: > -- > Bye bye ... Detlef > > Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de> > --- > tools/make_unicode | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tools/make_unicode b/tools/make_unicode > index f9c2917..5bbc5b8 100755 > --- a/tools/make_unicode > +++ b/tools/make_unicode > @@ -23,7 +23,7 @@ use strict; > > # base URLs for www.unicode.org files > my $MAPPINGS = "http://www.unicode.org/Public/MAPPINGS"; > -my $UNIDATA = "http://www.unicode.org/Public/9.0.0/ucd"; > +my $UNIDATA = "http://www.unicode.org/Public/10.0.0/ucd"; > my $REPORTS = "http://www.unicode.org/reports"; > my $RFCS = "http://www.rfc-editor.org/rfc"; > my $VERTICALPATH = "http://www.unicode.org/Public/vertical/revision-17"; > @@ -190,9 +190,10 @@ my %matra_types = > "Top_And_Left" => 0x09, > "Top_And_Left_And_Right" => 0x0a, > "Bottom_And_Right" => 0x0b, > - "Top_And_Bottom_And_Right" => 0x0c, > - "Overstruck" => 0x0d, > - "Invisible" => 0x0e > + "Bottom_And_Left" => 0x0c, > + "Top_And_Bottom_And_Right" => 0x0d, > + "Overstruck" => 0x0e, > + "Invisible" => 0x0f > ); > > my %nameprep_flags = >

July 3, 2017

Re: [4/7] ntdll: Allow map_view() to allocate fixed memory between reserved area and non-reserved area.

by Alexandre Julliard

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -551,11 +551,12 @@ void wine_mmap_remove_reserved_area( void *addr, size_t size, int unmap ) > * Check if the specified range is included in a reserved area. > * Returns 1 if range is fully included, 0 if range is not included > * at all, and -1 if it is only partially included. > + * When returning -1, set the boundary address if the pointer is supplied. > * > * Note: the reserved areas functions are not reentrant, caller is > * responsible for proper locking. > */ > -int wine_mmap_is_in_reserved_area( void *addr, size_t size ) > +int wine_mmap_is_in_reserved_area( void *addr, size_t size, void **boundary ) libwine is supposed to be backwards compatible, you can't change its interface. -- Alexandre Julliard julliard(a)winehq.org

July 3, 2017

Re: [PATCH 1/4] msi: Add a basic internal UI implementation.

by Hans Leidekker

On Mon, 2017-07-03 at 08:22 -0500, Zebediah Figura wrote: > > === w7u (32 bit msi) === > > The task timed out > > > > I'm not entirely sure what's up with this. I noticed that the testbot > consistently timed out on xp/2003/vista(/2008?) with my patches starting > with 358ed0d8. They only take a few seconds to run on my Windows 7 > machine—which to be sure does have much better hardware than a VM would, > but I can't be sure what part of my patches in particular is slowing > down or hanging the machine. > > Can anyone perhaps try running the package tests on their own machine > and see if they get any distinct slowness? Thanks. The sequence that causes the hang is closehandle_sequence. Changing externalui_message_callback to not touch the record handle if the message is INSTALLMESSAGE_TERMINATE makes the hang go away.

July 3, 2017

Re: [PATCH] make_unicode: Update vertical spec to revision 17

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -26,7 +26,8 @@ my $MAPPINGS = "http://www.unicode.org/Public/MAPPINGS"; > my $UNIDATA = "http://www.unicode.org/Public/9.0.0/ucd"; > my $REPORTS = "http://www.unicode.org/reports"; > my $RFCS = "http://www.rfc-editor.org/rfc"; > -my $VERTICALDATA = "http://www.unicode.org/Public/vertical/revision-15"; > +my $VERTICALPATH = "http://www.unicode.org/Public/vertical/revision-17"; > +my $VERTICALFILE = "VerticalOrientation-17.txt"; This doesn't seem to make any difference in the generated file, should it? -- Alexandre Julliard julliard(a)winehq.org

July 3, 2017

Re: [PATCH 1/4] msi: Add a basic internal UI implementation.

by Zebediah Figura

On 07/03/2017 12:50 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=31999 > > Your paranoid android. > > > === w7u (32 bit msi) === > The task timed out > I'm not entirely sure what's up with this. I noticed that the testbot consistently timed out on xp/2003/vista(/2008?) with my patches starting with 358ed0d8. They only take a few seconds to run on my Windows 7 machine—which to be sure does have much better hardware than a VM would, but I can't be sure what part of my patches in particular is slowing down or hanging the machine. Can anyone perhaps try running the package tests on their own machine and see if they get any distinct slowness? Thanks.

July 3, 2017

Re: [PATCH 05/10 v4] gdiplus: Support SetTextRenderingHint in metafiles

by Piotr Caban

On 07/02/17 10:34, Nikolay Sivov wrote: > This is not specific to text rendering hint parameter anymore, local > variable should be just "record". Thanks, I'll send a fixed version. Piotr

July 3, 2017

Re: [PATCH 03/10 v4] gdiplus: Add functions for managing metafile objects id

by Piotr Caban

On 06/30/17 22:24, Vincent Povirk wrote: > This seems like overkill to me? I just realized that maybe you were only referring to the comment. If you prefer I can change it to something like: TODO: object id should not be released here or I can even remove the function for releasing the IDs for now. > I don't see the need for per-object refcounting. Every drawing > operation that uses an object is just going to end with a series of > releases, and after it returns all refcounts should be 0. Currently there's no per-object refcounting. There's only kind of a timestamp that stores when object id was last used. Thanks to it the function frees object that was not used for the longest time first. This will be needed for reusing of object IDs. Also thanks to it we don't need to free the IDs on all error paths. Thanks, Piotr

July 3, 2017

Re: [PATCH 1/4] msi: Add a basic internal UI implementation.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31999 Your paranoid android. === w7u (32 bit msi) === The task timed out

July 3, 2017