July 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4 v2] mshtml: Expose IElementTraversal interface to scripts

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32475 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

July 25, 2017

Re: [PATCH] gdiplus: Avoid division by zero in SOFTWARE_GdipDrawThinPath

by Vincent Povirk

In my testing, native does not appear to draw the pixel. But I also wasn't able to crash builtin with my test case.

July 25, 2017

Re: [PATCH 3/4 v2] mshtml: Expose IElementTraversal interface to scripts

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

July 25, 2017

Re: [PATCH 4/4] mshtml: Add IElementTraversal::get_firstElementChild implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32474 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

July 25, 2017

Re: [PATCH 3/4] mshtml: Expose IElementTraversal interface to scripts

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32473 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

July 25, 2017

Re: [PATCH] gdiplus: Avoid division by zero in SOFTWARE_GdipDrawThinPath

by Fabian Maurer

Or maybe we should draw this single pixel? Regards, Fabian Maurer

July 25, 2017

Re: [PATCH 1/5] po: Fix a typo in the Norwegian translation

by Kim Malmo

Thank you kindly! How did you find it? I read through the patch 3 times and missed it. Kim --- Den 24. juli 2017 14:47, skrev Hugh McMaster: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > po/nb_NO.po | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/po/nb_NO.po b/po/nb_NO.po > index 2fa8d89863..0ad494b4f2 100644 > --- a/po/nb_NO.po > +++ b/po/nb_NO.po > @@ -12512,7 +12512,7 @@ msgstr "regedit: Registerverdien \"%1\" vil bli eksportert som binære data.\n" > > #: regedit.rc:427 > msgid "regedit: Invalid system key [%1]\n" > -msgstr "reg: Ugyldig systemnøkkel [%1]\n" > +msgstr "regedit: Ugyldig systemnøkkel [%1]\n" > > #: regedit.rc:428 > msgid ""

July 25, 2017

Re: [PATCH] kernel32: Add support for detecting volume information with libudev.

by Alexandre Julliard

Zebediah Figura <z.figura12(a)gmail.com> writes: > Using GetVolumeInformation may fail due to lack of permissions; e.g. > when the drive was mounted as root. This patch uses libudev, if it > is available, to retrieve the volume label, serial number, and type. > > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/kernel32/Makefile.in | 3 +- > dlls/kernel32/volume.c | 88 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+), 1 deletion(-) libudev should be loaded dynamically, and that sort of thing should ideally be done in mountmgr. -- Alexandre Julliard julliard(a)winehq.org

July 25, 2017

Re: [1/2] gdi32/tests: Add test for SetPixel erase with R2_XORPEN

by Tim Worthington

Huw Davies wrote: > Hi Tim, > > Thank you for your contribution to Wine. > > There were a number of issues with this series, which by the time I'd > reviewed them meant I'd essentially re-written the patches; so I just > sent them in: > > https://source.winehq.org/patches/data/136093 > https://source.winehq.org/patches/data/136094 > > This seemed more efficient than explaining the problems and suggesting > alternative approaches. If you're interested, please free feel to > look at my patches and ask if there's anything you're curious about. > > Huw. Thanks Huw. Yours are much better. regards tim

July 25, 2017

Re: [PATCH] user32: In CURSORICON_FindBestCursor scale cursor correctly

by Fabian Maurer

Was too slow, not needed anymore after d0e8170c90ef63363f8389be2619c9332ae2c371. Regards, Fabian Maurer

July 24, 2017