August 2017 - Wine-Devel - list.winehq.org

Re: ntdll: Support receiving server reply data to memory with write watch.

by Jacek Caban

On 03.08.2017 09:48, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> @@ -256,6 +256,7 @@ static void read_reply_data( void *buffer, size_t size ) >> if (!ret) break; >> if (errno == EINTR) continue; >> if (errno == EPIPE) break; >> + if (errno == EFAULT && virtual_uninterrupted_write_memory( buffer, NULL, size ) >= size) continue; >> server_protocol_perror("read"); > You can't enter a critical section in the middle of a server call. Oh, right, we could need to do another server call there. Unless I'm missing something, it should work fine for platforms that have optimized CS implementation (Linux and Mac) as they don't do server calls. We could limit effect of the patch to those platform, but that would be ugly. Could we just use pthread mutexes for server_enter_uninterrupted_section/server_leave_uninterrupted_section instead of critical sections? Thanks, Jacek

Aug. 3, 2017

Re: [PATCH v3] ole32: Store proxy/stub CLSIDs per process, not per apartment.

by Huw Davies

On Wed, Aug 02, 2017 at 11:00:04AM -0500, Zebediah Figura wrote: > +static void COM_RevokeAllPSClsids(void) > +{ How about calling it revoke_registered_psclsids() ? Otherwise, this looks good. Huw.

Aug. 3, 2017

Re: ntdll: Support receiving server reply data to memory with write watch.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -256,6 +256,7 @@ static void read_reply_data( void *buffer, size_t size ) > if (!ret) break; > if (errno == EINTR) continue; > if (errno == EPIPE) break; > + if (errno == EFAULT && virtual_uninterrupted_write_memory( buffer, NULL, size ) >= size) continue; > server_protocol_perror("read"); You can't enter a critical section in the middle of a server call. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2017

Re: [PATCH 2/2] winebrowser: Open the default browser if called without an argument.

by Alexandre Julliard

Vincent Povirk <madewokherd(a)gmail.com> writes: >> I'd suggest to simply open the default start page in that case. That's >> what iexplore does when there are no arguments. > > That's the intent. We don't know what the default start page is for > the user's default browser, but it should open it when started with no > arguments. I don't mean the default page for the Unix browser, the behavior is apparently not guaranteed in that case. I mean get the default page configured on the Windows side, and open that. This way we don't need to worry about what the Unix browser will do with no arguments. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2017

Re: [PATCH 2/2] winebrowser: Open the default browser if called without an argument.

by Vincent Povirk

> I'd suggest to simply open the default start page in that case. That's > what iexplore does when there are no arguments. That's the intent. We don't know what the default start page is for the user's default browser, but it should open it when started with no arguments.

Aug. 2, 2017

Re: [PATCH 2/2] winebrowser: Open the default browser if called without an argument.

by Alexandre Julliard

Zebediah Figura <zfigura(a)codeweavers.com> writes: > xdg-open can't handle this, so work around with the following command > (suggested by Vincent Povirk): > gtk-launch `xdg-mime query default x-scheme-handler/http` > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > programs/winebrowser/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments. -- Alexandre Julliard julliard(a)winehq.org

Aug. 2, 2017

Re: [4/6] wsdapi: Implement "Hello" message creation support. [try 2]

by Owen Rudge

On 02/08/2017 19:36, Vincent Povirk wrote: > You're still using rand/srand in this one. Sorry, I removed them from the network code but missed the initial delay required by some of the messages. Now corrected as well. Cheers, -- Owen Rudge http://www.owenrudge.net/

Aug. 2, 2017

Re: [2/6] wsdapi: Add code to create SOAP envelope from header and body elements. [try 2]

by Owen Rudge

On 02/08/2017 19:17, Vincent Povirk wrote: > I think this should be parent->FirstAttribute = curAttrib->Next. Thanks. > You still don't seem to be adding the new text node to newElement. Ah, I had corrected the memory allocation parenting, but not the actual nodes. This is now fixed in my new revision. Thanks, -- Owen Rudge http://www.owenrudge.net/

Aug. 2, 2017

Re: [4/6] wsdapi: Implement "Hello" message creation support. [try 2]

by Vincent Povirk

You're still using rand/srand in this one.

Aug. 2, 2017

Re: [2/6] wsdapi: Add code to create SOAP envelope from header and body elements. [try 2]

by Vincent Povirk

+static void remove_attribute(WSDXML_ELEMENT *parent, WSDXML_ATTRIBUTE *attribute) +{ + WSDXML_ATTRIBUTE *curAttrib; + + /* Find the last attribute and add this as the next one */ + curAttrib = parent->FirstAttribute; + + if (curAttrib == attribute) + { + parent->FirstAttribute = NULL; + } I think this should be parent->FirstAttribute = curAttrib->Next. + } + else if (curNode->Type == TextType) + { + textNode = WSDAllocateLinkedMemory(newElement, sizeof(WSDXML_TEXT)); + if (textNode == NULL) goto cleanup; + + textNode->Node.Next = NULL; + textNode->Node.Parent = newElement; + textNode->Node.Type = TextType; + textNode->Text = duplicate_string(textNode, ((WSDXML_TEXT *)curNode)->Text); + if (textNode->Text == NULL) goto cleanup; + } You still don't seem to be adding the new text node to newElement.

Aug. 2, 2017