August 2017 - Wine-Devel - list.winehq.org

Re: [PATCH v2 2/3] include: Add initial IDL for cmnquery.h

by Alexandre Julliard

Zebediah Figura <zfigura(a)codeweavers.com> writes: > +[ > + object, > + uuid(1a3114b8-a62e-11d0-a6c5-00a0c906af45), > + local > +] > +interface IPersistQuery : IPersist > +{ > + HRESULT Clear(); > + > + HRESULT ReadInt([in] LPCWSTR section, [in] LPCWSTR name, [out] INT *value); > + > + HRESULT ReadString([in] LPCWSTR section, [in] LPCWSTR name, [out, size_is(buflen)] LPWSTR buffer, [in] INT buflen); > + > + HRESULT ReadStruct([in] LPCWSTR section, [in] LPCWSTR name, [out, size_is(buflen)] LPVOID buffer, [in] DWORD buflen); > + > + HRESULT WriteInt([in] LPCWSTR section, [in] LPCWSTR name, [in] INT value); > + > + HRESULT WriteString([in] LPCWSTR section, [in] LPCWSTR name, [in] LPCWSTR value); > + > + HRESULT WriteStruct([in] LPCWSTR section, [in] LPCWSTR name, [in] LPVOID value, [in] DWORD size); > +}; This doesn't match the PSDK, the order matters. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2017

Re: [PATCH v2 2/3] include: Add initial IDL for cmnquery.h

by Alistair Leslie-Hughes

Hi Zebediah, On 01/08/17 05:24, Zebediah Figura wrote: > v2: fix a typo in MSDN > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > +cpp_quote("DEFINE_GUID(CLSID_CommonQuery, 0x83BC5EC0, 0x6F2A, 0x11D0, 0xA1,0xC4, 0x00,0xAA,0x00,0xC1,0x6E,0x65);") > Please make the GUID lowercase. Best Regards Alistair

Aug. 1, 2017

Re: [PATCH v2 2/3] include: Add initial IDL for cmnquery.h

by Alistair Leslie-Hughes

Hi Zebediah, On 01/08/17 05:24, Zebediah Figura wrote: > v2: fix a typo in MSDN > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > +cpp_quote("DEFINE_GUID(CLSID_CommonQuery, 0x83BC5EC0, 0x6F2A, 0x11D0, 0xA1,0xC4, 0x00,0xAA,0x00,0xC1,0x6E,0x65);") > Please make the GUID lowercase. Best Regards Alistair

Aug. 1, 2017

Re: [PATCH] kernel32: Load library search in system32 directory.

by Alexandre Julliard

Carlos Palminha <CARLOS.PALMINHA(a)synopsys.com> writes: > On 31-07-2017 19:56, Alexandre Julliard wrote: >> Carlos Palminha <CARLOS.PALMINHA(a)synopsys.com> writes: >> >>> I think today its working for some of those unsupported flags because it's a side effect of calling MODULE_get_dll_load_path with NULL. >>> Probably using only system32 path it might break some of the application that are working based on a side effect. Nevertheless i run the existing tests for module and its ok. >>> >>> I will look at it and add the other SEARCH flags. If i check the other flags then there is no need to fallback to MODULE_get_dll_load_path(NULL), do you agree? >> >> My guess is that you'd want to integrate the flags handling into >> MODULE_get_dll_load_path instead of bypassing it. >> > > i thought on that but it seems wine_kernel_init and SearchPathW are also using it. > Do you think its acceptable for these functions to call dll_load_path with the SEARCH flags? That should be fine. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2017

Re: [PATCH] kernel32: Load library search in system32 directory.

by Carlos Palminha

On 31-07-2017 19:56, Alexandre Julliard wrote: > Carlos Palminha <CARLOS.PALMINHA(a)synopsys.com> writes: > >> I think today its working for some of those unsupported flags because it's a side effect of calling MODULE_get_dll_load_path with NULL. >> Probably using only system32 path it might break some of the application that are working based on a side effect. Nevertheless i run the existing tests for module and its ok. >> >> I will look at it and add the other SEARCH flags. If i check the other flags then there is no need to fallback to MODULE_get_dll_load_path(NULL), do you agree? > > My guess is that you'd want to integrate the flags handling into > MODULE_get_dll_load_path instead of bypassing it. > i thought on that but it seems wine_kernel_init and SearchPathW are also using it. Do you think its acceptable for these functions to call dll_load_path with the SEARCH flags? Regards, C.Palminha

Aug. 1, 2017

Re: [PATCH 3/3] ucrtbase/tests: Add tests for math function errors.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32534 Your paranoid android. === wvistau64 (64 bit misc) === misc.c:691: Test failed: log2(-1.#INF00) got exception type 1 misc.c:691: Test failed: log2(-1.000000) got exception type 1 misc.c:691: Test failed: log2(0.000000) got exception type 2 misc.c:721: Test failed: _scalb(1.000000, -1000000000) got exception type -1 === w1064 (64 bit misc) === misc.c:691: Test failed: log2(-1.#INF00) got exception type 1 misc.c:691: Test failed: log2(-1.000000) got exception type 1 misc.c:691: Test failed: log2(0.000000) got exception type 2 misc.c:721: Test failed: _scalb(1.000000, -1000000000) got exception type -1

Aug. 1, 2017

Re: [PATCH] opengl32: Update OpenGL Registry files URLs.

by Austin English

On Mon, Jul 31, 2017 at 5:14 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > The OpenGL Registry has been moved. See > https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/README.txt. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/opengl32/make_opengl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/opengl32/make_opengl b/dlls/opengl32/make_opengl > index 45e3f720ea..ef4156686a 100755 > --- a/dlls/opengl32/make_opengl > +++ b/dlls/opengl32/make_opengl > @@ -8,8 +8,8 @@ use XML::Simple; > # > # - It needs files from the OpenGL extension registry: > # > -# https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/gl.xml > -# https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/wgl.xml > +# https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml > +# https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/wgl.xml > # > # If they are not found in the current directory the script will > # attempt to download them from there. > @@ -404,8 +404,8 @@ if ($version eq "1.0") { > # > # Fetch the registry files > # > --f "gl.xml" || system "wget --no-check-certificate https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/gl.xml" || die "cannot download gl.xml"; > --f "wgl.xml" || system "wget --no-check-certificate https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/wgl.xml" || die "cannot download wgl.xml"; > +-f "gl.xml" || system "wget --no-check-certificate https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml" || die "cannot download gl.xml"; > +-f "wgl.xml" || system "wget --no-check-certificate https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/wgl.xml" || die "cannot download wgl.xml"; > > > # > -- > 2.13.0 Do we really want to keep the --no-check-certificate now the file is on github.com? I feel like github's cert is pretty widely trusted, and likely to stay working. Especially since all of *winehq.org is finally on HTTPS.. -- -Austin GPG: 14FB D7EA A041 937B

Aug. 1, 2017