September 2017 - Wine-Devel

Re: [PATCH] midimap: Add warning for user in case midi won't work

by Matteo Bruni

2017-09-23 22:52 GMT+02:00 Fabian Maurer <dark.shadow4(a)web.de>: > When no midi port or only the midi-through port > is found, we can inform the user that midi > won't work as expected. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/midimap/midimap.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/dlls/midimap/midimap.c b/dlls/midimap/midimap.c > index 64b4dc8546..c80834515b 100644 > --- a/dlls/midimap/midimap.c > +++ b/dlls/midimap/midimap.c > @@ -553,6 +553,7 @@ static LRESULT MIDIMAP_drvOpen(void) > { > MIDIOUTCAPSW moc; > unsigned dev, i; > + WCHAR throughportW[] = {'M','i','d','i',' ','T','h','r','o','u','g','h',0}; > > if (midiOutPorts) > return 0; > @@ -578,6 +579,13 @@ static LRESULT MIDIMAP_drvOpen(void) > } > } > > + if(numMidiOutPorts == 0) > + MESSAGE("Midi sound output won't work - No midi port found.\n"); > + else if(numMidiOutPorts == 1 && midiOutPorts[0].loaded == -1) > + MESSAGE("Midi sound output won't work - No working midi port found.\n"); > + else if(numMidiOutPorts == 1 && strncmpW(midiOutPorts[0].name, throughportW, strlenW(throughportW)) == 0) > + MESSAGE("Midi sound output probably won't work - Only 'midi through' port found. Make sure your setup is correct.\n"); > + > return 1; > } Since you have to resend anyway... The string comparison doesn't look correct to me, I think that breaks if the midi port name has a prefix matching the throughportW string. I guess it's not going to be a problem in practice but it seems better to do it right anyway. There should be a space between 'if' and the '(', like elsewhere in the function and source file.

Sept. 28, 2017

Re: mshtml: Inherit document mode from parent document.

by Gijs Vermeulen

Hi, 2017-09-28 19:50 GMT+02:00 Jacek Caban <jacek(a)codeweavers.com>: > > + TRACE("parnet mode %u\n", parent_mode); > > There seems to be a typo here. Sincerely, Gijs

Sept. 28, 2017

Re: mshtml: Inherit document mode from parent document.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33325 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

Sept. 28, 2017

Re: [PATCH] midimap: Add warning for user in case midi won't work

by Alexandre Julliard

Fabian Maurer <dark.shadow4(a)web.de> writes: > When no midi port or only the midi-through port > is found, we can inform the user that midi > won't work as expected. This should probably use the winediag debug channel. -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2017

Re: [PATCH v3 2/3] hlink/tests: Add tests for navigating from a string reference.

by Zebediah Figura

On 09/22/2017 07:19 AM, Jacek Caban wrote: > Hi Zebediah, > > This test leaves iexplore instance running on Wine. > > Jacek > > Thanks; I think I forgot to rerun the tests after changing something. On Windows, IHlinkTarget::Navigate() is evidently supposed to check the HTTP status code before actually opening the browser. I don't know what the proper method of doing this in Wine is. Would it be acceptable just to disable those tests for now?

Sept. 28, 2017

Re: [PATCH 2/9] sapi: Implement SpDataKey::SetKey().

by Huw Davies

On Thu, Sep 28, 2017 at 02:45:09AM -0500, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=33314 > > Your paranoid android. > > > === build (build) === > Recreation of tests/Makefile failed Looks like testbot needs to be taught about make_makefiles. Here's a run with the diff of the entire series (including configure.ac changes this time). https://testbot.winehq.org/JobDetails.pl?Key=33317 Huw.

Sept. 28, 2017

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1

by Michael Stefaniuc

On 09/28/2017 10:07 AM, Dmitry Timoshkov wrote: > Michael Stefaniuc <mstefani(a)winehq.org> wrote: > >>> Did you test that after this patch font and glyph metrics still stay the same? >> To find the relevant changes I have verified that the numbers increased >> by the factor of 2048 divided by the old Em size (11 or 13 or 15). Of >> course as 11, 13, 15 aren't factors of 2048 there are rounding errors. >> >> But it doesn't matter as: >> a) Those are bitmap only fonts. >> b) Only the *.fon files are installed but not the corresponding *.ttf files. > > That's true, but it's sometimes useful to be able to load and test .ttf > files as well, although it looks like after some Windows update intermediate > Wine bitmap-only .ttf fonts is no longer possible to load under Windows, and > since freetype 2.8.1 Linux started to behave same way. Seems the Em increase fixed that on Windows too: <nsivov> puk, with fixed em field ttfs open now on windows too >> c) The generated *.fon files are bit by bit identical (sha1sum) before >> and after this commit. > > Great, that's the key point. Right, that's why I have included that info in my patch submission ;) https://www.winehq.org/pipermail/wine-patches/2017-September/165357.html "With this two patches applied I always get the exact same fon files for all possible combinations: - freetype 2.6.5 and unpatched Wine - freetype 2.6.5 and this two patches applied - freetype 2.8.1 and this two patches applied" bye michael

Sept. 28, 2017

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1

by Dmitry Timoshkov

Michael Stefaniuc <mstefani(a)winehq.org> wrote: > > Did you test that after this patch font and glyph metrics still stay the same? > To find the relevant changes I have verified that the numbers increased > by the factor of 2048 divided by the old Em size (11 or 13 or 15). Of > course as 11, 13, 15 aren't factors of 2048 there are rounding errors. > > But it doesn't matter as: > a) Those are bitmap only fonts. > b) Only the *.fon files are installed but not the corresponding *.ttf files. That's true, but it's sometimes useful to be able to load and test .ttf files as well, although it looks like after some Windows update intermediate Wine bitmap-only .ttf fonts is no longer possible to load under Windows, and since freetype 2.8.1 Linux started to behave same way. > c) The generated *.fon files are bit by bit identical (sha1sum) before > and after this commit. Great, that's the key point. -- Dmitry.

Sept. 28, 2017

Re: [PATCH 9/9] sapi: Add a partial implementation of SpObjectTokenCategory::EnumTokens().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33316 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Sept. 28, 2017

Re: [PATCH 6/9] sapi: Add a partial implementation of SpObjectTokenEnum::Next().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33315 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Sept. 28, 2017