September 2017 - Wine-Devel

Re: [PATCH 2/9] sapi: Implement SpDataKey::SetKey().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33314 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

Sept. 28, 2017

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1

by Michael Stefaniuc

On 09/28/2017 06:53 AM, Dmitry Timoshkov wrote: > Michael Stefaniuc <mstefani(a)winehq.org> wrote: > >> -UnderlinePosition: -100 >> -UnderlineWidth: 50 >> -Ascent: 11 >> -Descent: 2 >> +UnderlinePosition: -15753.8 >> +UnderlineWidth: 7876.92 >> +Ascent: 1733 >> +Descent: 315 >> +InvalidEm: 0 >> LayerCount: 2 >> Layer: 0 0 "Back" 1 >> Layer: 1 0 "Fore" 0 >> @@ -21,7 +22,7 @@ OS2_UseTypoMetrics: 0 >> PfmFamily: 49 >> TTFWeight: 400 >> TTFWidth: 5 >> -LineGap: 1 >> +LineGap: 158 >> VLineGap: 0 >> Panose: 2 0 6 9 0 0 0 0 0 0 >> OS2TypoAscent: 0 >> @@ -56,770 +57,770 @@ BeginChars: 65536 498 >> >> StartChar: space >> Encoding: 32 32 0 >> -Width: 8 >> +Width: 1260 >> Flags: W >> LayerCount: 2 >> EndChar >> >> StartChar: exclam >> Encoding: 33 33 1 >> -Width: 8 >> +Width: 1260 >> Flags: W >> LayerCount: 2 >> EndChar > > Did you test that after this patch font and glyph metrics still stay the same? To find the relevant changes I have verified that the numbers increased by the factor of 2048 divided by the old Em size (11 or 13 or 15). Of course as 11, 13, 15 aren't factors of 2048 there are rounding errors. But it doesn't matter as: a) Those are bitmap only fonts. b) Only the *.fon files are installed but not the corresponding *.ttf files. c) The generated *.fon files are bit by bit identical (sha1sum) before and after this commit. bye michael

Sept. 28, 2017

Re: WineTest does not run the vcomp tests

by Francois Gouget

On Wed, 27 Sep 2017, Vincent Povirk wrote: > Could we try to run the .exe without specifying a test, and if it > fails due to a missing dll (can we determine that?), skip the test? Your idea is to not check for missing dlls and instead just run the executable as a way to check that all the required dlls are present? The problem is that if a dll is missing the executable remains stuck while Windows displays a dialog saying the dll is missing. Also, killing the process does not dismiss the windows dialog. Maybe we could take a page out of the shlexec test and wait for the executable for 5 seconds and do a FindWindowA("#32770", "Windows") to click on the OK ourselves. But I believe on Windows 8+ we had problems due to Windows popping up a window offering to install the missing dll but we could not intercept that one. That said the dlls would be installed on machines that run WineTest regularly anyway. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Dieu dit: "M-x Lumière". Et la lumière fut.

Sept. 28, 2017

RE: user.exe16: Support Windows 1.x and 2.x Menus

by Martin Payne

Hi Alexandre, > Mainly I find it interesting that Windows 2 apps still work, it probably hasn't been tested in 20 years. Apart from the menu issue, are other things looking OK? A few applications crash at startup with a null pointer dereference. I'd need to read up some more on Wine debugging to understand why. Icon and cursor resources don't load, but like with the menus it's just because the format is slightly different. It shouldn't be difficult to add support for that as most of the required code is already in Wine. Other than that, it's surprising how ~30 year old applications can still work on a modern OS! Regards, Martin

Sept. 28, 2017

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1

by Dmitry Timoshkov

Michael Stefaniuc <mstefani(a)winehq.org> wrote: > -UnderlinePosition: -100 > -UnderlineWidth: 50 > -Ascent: 11 > -Descent: 2 > +UnderlinePosition: -15753.8 > +UnderlineWidth: 7876.92 > +Ascent: 1733 > +Descent: 315 > +InvalidEm: 0 > LayerCount: 2 > Layer: 0 0 "Back" 1 > Layer: 1 0 "Fore" 0 > @@ -21,7 +22,7 @@ OS2_UseTypoMetrics: 0 > PfmFamily: 49 > TTFWeight: 400 > TTFWidth: 5 > -LineGap: 1 > +LineGap: 158 > VLineGap: 0 > Panose: 2 0 6 9 0 0 0 0 0 0 > OS2TypoAscent: 0 > @@ -56,770 +57,770 @@ BeginChars: 65536 498 > > StartChar: space > Encoding: 32 32 0 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar > > StartChar: exclam > Encoding: 33 33 1 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar Did you test that after this patch font and glyph metrics still stay the same? -- Dmitry.

Sept. 28, 2017

Re: WineTest does not run the vcomp tests

by Vincent Povirk

Could we try to run the .exe without specifying a test, and if it fails due to a missing dll (can we determine that?), skip the test?

Sept. 27, 2017

Re: [v7 1/5] server: Named pipe query SD from pipe object

by Jacek Caban

Hi Jonathan, Your tests still don't really show intended behaviour. Your calls that set security descriptor use new SD that has the same tested values as before the call, then what's the point in setting it? Anyway, I cleaned it up and changed a bit to see how it's really supposed to work. See the attachment. It looks like client and served should indeed share security descriptor, but pipe object should not, so that part is wrong. Thanks, Jacek

Sept. 27, 2017

Re: Please change WINE logo

by Aric Stewart

That is the design for our sticker swag. It was not intended to be a logo replacement but I am very happy that it is very well received! I was thinking of bringing up a logo redesign at wineconf this year as part of continued swag discussions, so this sort of kicks that forward. I personally have no investment in this, however design wise I think we need to think of the website logo in relation to how it would connect to the wine icon. So we would need something that would have a variant that can scale down to those sizes. -aric On 9/26/17 7:58 AM, Farhad Mohammadi Majd wrote: > On Tue, 2017-09-26 at 07:06 -0500, Rosanne DiMesio wrote: >> On Tue, 26 Sep 2017 12:16:10 +0330 >> Farhad Mohammadi Majd <farhadbenyamin(a)yahoo.com> wrote: >> >>> and it does not have any concept when it is without any text, >>> >> >> You might like this one better: https://www.winehq.org/pipermail/wine >> -devel/attachments/20170726/7bcef3ba/attachment-0001.png. >> > YES! this one is really good! I am agree with that, thank you. > >

Sept. 27, 2017

WineTest does not run the vcomp tests

by Francois Gouget

So WineTest is not running the vcomp tests. What happens is this: * It parses the vcomp_test.exe filename and concludes that this tests the vcomp dll. * It does a LoadLibraryExA("vcomp.dll", NULL, LOAD_LIBRARY_AS_DATAFILE) which fails (as expected) and concludes that the dll is missing: vcomp=dll is missing * Since the dll is missing WineTest skips the vcomp tests. According to Dan Kegel this is a manifest / activation context issue and he sent a patch for it [1]. However the patch was for the TestBot [2], not WineTest, and as far as I can tell it's not working. Furthermore WineTest already has activation context code that seems equivalent to Dan Kegel's patch. Does anyone know how to fix WineTest? [1] https://bugs.winehq.org/show_bug.cgi?id=31609 https://www.winehq.org/pipermail/wine-patches/2012-September/117631.html [2] Paradoxically the TestBot has no problem running the vcomp tests now that they dynamically load the vcomp dll. That's because the TestBot makes no assumption based on the executable filename since one can upload test binaries that don't follow any naming scheme. So now the test dynamically loads vcomp.dll the TestBot cannot check for it. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

Sept. 27, 2017

Re: [PATCH 6/6] shell32: Implement FolderItem::Name() property getter

by Nikolay Sivov

On 09/27/2017 11:25 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=33296 > > Your paranoid android. > > > === wxppro (32 bit shelldispatch) === > shelldispatch.c:635: Test failed: file_defs[1]: unexpected name L"01-empty". Skip this one please, I'll take a look later. This could be about shell set up to hide extension, or XP being special.

Sept. 27, 2017