September 2017 - Wine-Devel

Re: [PATCH 6/6] shell32: Implement FolderItem::Name() property getter

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33296 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:635: Test failed: file_defs[1]: unexpected name L"01-empty".

Sept. 27, 2017

Re: user.exe16: Support Windows 1.x and 2.x Menus

by Alexandre Julliard

"Martin Payne" <development(a)martinpayne.me.uk> writes: > Hi Alexandre, > >> Where did you find an app that needs this? > > The applications which come with Windows 2, or Petzold's first edition > menu examples will demonstrate this. For example the Windows 2 > Terminal application warns "version must be 0 for Win16" and the menus > fail to load without the patch applied. I can provide the source and / > or binary for a trivial Windows 2 application I've written which > demonstrates this behaviour if you would like it. If so, please let me > know how you would like me to send it. Mainly I find it interesting that Windows 2 apps still work, it probably hasn't been tested in 20 years. Apart from the menu issue, are other things looking OK? -- Alexandre Julliard julliard(a)winehq.org

Sept. 27, 2017

RE: user.exe16: Support Windows 1.x and 2.x Menus

by Martin Payne

Hi Alexandre, > Where did you find an app that needs this? The applications which come with Windows 2, or Petzold's first edition menu examples will demonstrate this. For example the Windows 2 Terminal application warns "version must be 0 for Win16" and the menus fail to load without the patch applied. I can provide the source and / or binary for a trivial Windows 2 application I've written which demonstrates this behaviour if you would like it. If so, please let me know how you would like me to send it. Regards, Martin

Sept. 27, 2017

Re: user.exe16: Support Windows 1.x and 2.x Menus

by Alexandre Julliard

Martin Payne <development(a)martinpayne.me.uk> writes: > Added support for Windows 1.x / 2.x menu resources to > LoadMenuIndirect16. The format of these are slightly different from > Windows 3.x menus which causes them to fail to load. Where did you find an app that needs this? -- Alexandre Julliard julliard(a)winehq.org

Sept. 26, 2017

Re: Please change WINE logo

by Farhad Mohammadi Majd

On Tue, 2017-09-26 at 07:06 -0500, Rosanne DiMesio wrote: > On Tue, 26 Sep 2017 12:16:10 +0330 > Farhad Mohammadi Majd <farhadbenyamin(a)yahoo.com> wrote: > > > and it does not have any concept when it is without any text, > > > > You might like this one better: https://www.winehq.org/pipermail/wine > -devel/attachments/20170726/7bcef3ba/attachment-0001.png. > YES! this one is really good! I am agree with that, thank you.

Sept. 26, 2017

Re: Please change WINE logo

by Rosanne DiMesio

On Tue, 26 Sep 2017 12:16:10 +0330 Farhad Mohammadi Majd <farhadbenyamin(a)yahoo.com> wrote: > and it does not have any concept when it is without any text, > You might like this one better: https://www.winehq.org/pipermail/wine-devel/attachments/20170726/7bcef3ba/a…. -- Rosanne DiMesio dimesio(a)earthlink.net

Sept. 26, 2017

Re: [PATCH] ole32: CreateDataCache should return a COleCache object by default.

by Alistair Leslie-Hughes

Hi Huw, Thanks of the review. >> + hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, riid, ppvObj); >> IUnknown_Release(&newCache->IUnknown_inner); >But now if you call QI(IID_IUnknown) on this interface you'll get >back something different, which is wrong. You'll need to do >some more restructing to make this correct. >Btw, is there a bug that depends on this? https://bugs.winehq.org/show_bug.cgi?id=7369 >A better test would be to call QI(IID_IOleCache) on the returned >IUnknown* and show that it's the same. You could also >QI(IID_IUnknown) to test for my comment above. I'll have another go at it. Alistair.

Sept. 26, 2017

Re: [PATCH] ole32: CreateDataCache should return a COleCache object by default.

by Huw Davies

On Tue, Sep 26, 2017 at 01:00:08AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ole32/datacache.c | 5 ++++- > dlls/ole32/tests/ole2.c | 10 ++++++++-- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index a95d0fb..c563118 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -2760,7 +2760,10 @@ HRESULT WINAPI CreateDataCache( > if (newCache == 0) > return E_OUTOFMEMORY; > > - hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, riid, ppvObj); > + if ( !pUnkOuter && IsEqualIID(&IID_IUnknown, riid) ) > + hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, &IID_IOleCache2, ppvObj); > + else > + hr = IUnknown_QueryInterface(&newCache->IUnknown_inner, riid, ppvObj); > IUnknown_Release(&newCache->IUnknown_inner); But now if you call QI(IID_IUnknown) on this interface you'll get back something different, which is wrong. You'll need to do some more restructing to make this correct. Btw, is there a bug that depends on this? > diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c > index b30f63b..39b161c 100644 > --- a/dlls/ole32/tests/ole2.c > +++ b/dlls/ole32/tests/ole2.c > @@ -1575,6 +1575,7 @@ static void test_data_cache(void) > char szSystemDir[MAX_PATH]; > WCHAR wszPath[MAX_PATH]; > static const WCHAR wszShell32[] = {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + DWORD connection; > > static const struct expected_method methods_cacheinitnew[] = > { > @@ -1651,14 +1652,19 @@ static void test_data_cache(void) > ok(hr == S_OK, "got 0x%08x\n", hr); > hr = IUnknown_QueryInterface(unk, &IID_IOleCache2, (void**)&pOleCache); > ok(hr == S_OK, "got 0x%08x\n", hr); > -todo_wine { > ok(unk == (IUnknown*)olecache, "got %p, expected %p\n", olecache, unk); > ok(unk == (IUnknown*)pOleCache, "got %p, expected %p\n", pOleCache, unk); > -} > + > IOleCache2_Release(pOleCache); > IOleCache_Release(olecache); > IUnknown_Release(unk); > > + hr = CreateDataCache(NULL, &CLSID_NULL, &IID_IUnknown, (void**)&olecache); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + hr = IOleCache_Cache(olecache, &fmtetc, ADVF_PRIMEFIRST | ADVFCACHE_NOHANDLER, &connection); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + IOleCache_Release(olecache); > + A better test would be to call QI(IID_IOleCache) on the returned IUnknown* and show that it's the same. You could also QI(IID_IUnknown) to test for my comment above. Huw.

Sept. 26, 2017

Re: [PATCH 1/2] gdi32: Remove runtime check for FT_Set_Charmap()

by Huw Davies

On Mon, Sep 25, 2017 at 05:38:53PM +0300, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/gdi32/freetype.c | 79 ++++++++++++++++++++++++--------------------------- > 1 file changed, 37 insertions(+), 42 deletions(-) I've resent this series removing pFT_Select_Charmap since it's now not used. Thanks, Huw.

Sept. 26, 2017

Re: Please change WINE logo

by Farhad Mohammadi Majd

On Mon, 2017-09-25 at 09:42 -0500, Jeremy Newman wrote: > This is the scalable shaded version of our logo: > http://dl.winehq.org/wine/logos/wine_logo.svg > > The current logo. Your suggested logo would never work, as it uses a > copyrighted image. > > When it comes to logo design you need to design a logo that works in > black and white, flat color, and shaded color. A 3D rendered wine > glass > would not work in all those cases. > > FYI: Calling the current logo ugly is not the best way to start a > dialog > about changing it. > > -N > I'm not a graphic designer, I just see current WINE logo is really ugly and it does not have any concept when it is without any text, so I suggested to find a better logo. At least can you change its white colour to become more transparent, like the real glass? Below cases are good examples for new logo: * http://cliparts101.com/files/413/AA872DB27C136B9104E22F297CC317F0/Gla ss_Of_Red_Wine.png * http://cdn.mysitemyway.com/etc-mysitemyway/icons/legacy-previews/icon s/simple-red-square-icons-food-beverage/129042-simple-red-square-icon- food-beverage-drink-glass2.png * http://www.sysads.co.uk/wp-content/uploads/2014/04/wine-hq-01.png * http://images.easyfreeclipart.com/355/viewing-gallery-for-wine-glass- clip-art-png-355132.png * http://clipart-library.com/clipart/1182402.htm

Sept. 26, 2017