September 2017 - Wine-Devel

Re: Fabian Maurer : evr/tests: Add tests.

by Fabian Maurer

> > Wasn't this rejected? > > That was the intent, not sure how I screwed this up. Lucky you ;-) I created a slightly tweaked version of the tests that don't fail on wine, but are marked todo. I'll submit the changes after the evr interfaces are implemented, if that's ok? Do I need to resend the other 2 patches of my evr patchset for that? Regards, Fabian Maurer

Sept. 22, 2017

Re: vbscript: Improve parsing of separators in loops and switches.

by Jacek Caban

Hi Dmitry, Thanks for the patch, it generally looks good. I have a few comments bellow. On 20.09.2017 05:48, Dmitry Kislyuk wrote: > > +StSeps > + : StSep > + | StSep StSeps Since you're changing all uses of StSep, I think it would make more sense to change StSep itself to accept multiple separator. > x = 0 > -Do While x < 2 : x = x + 1 > +Do While x < 2 : > +x = x + 1 > Loop > Call ok(x = 2, "x not equal to 2") Please don't change existing tests like that. We want previous version tested as well. Add new ones instead. > @@ -511,7 +533,8 @@ Call collectionObj.reset() > y = 0 > x = 10 > z = 0 > -for each x in collectionObj : z = z + 2 > +for each x in collectionObj : > + :z = z + 2 Same here. Thanks, Jacek

Sept. 22, 2017

Re: [PATCH v3 2/3] hlink/tests: Add tests for navigating from a string reference.

by Jacek Caban

Hi Zebediah, This test leaves iexplore instance running on Wine. Jacek

Sept. 22, 2017

Re: [PATCH 1/7] include: Convert dxgitype.h to IDL.

by Henri Verbeet

On 22 September 2017 at 12:30, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > You forgot to update the Makefile.in to reflect the name change. > (same goes for rest of the patchset) > include/Makefile.in is updated by tools/make_makefiles, and we generally omit auto-generated changes when sending patches. It doesn't hurt to include, but is superfluous.

Sept. 22, 2017

Re: [PATCH 1/7] include: Convert dxgitype.h to IDL.

by Alistair Leslie-Hughes

Hi Henri, On 22/09/17 06:29, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > include/dxgi.idl | 2 +- > include/{dxgitype.h => dxgitype.idl} | 83 ++++++++++++++++++++---------------- You forgot to update the Makefile.in to reflect the name change. (same goes for rest of the patchset) Best Regards Alistair.

Sept. 22, 2017

Re: Fabian Maurer : evr/tests: Add tests.

by Alexandre Julliard

Fabian Maurer <dark.shadow4(a)web.de> writes: > On Donnerstag, 21. September 2017 22:01:00 CEST Alexandre Julliard wrote: >> Module: wine >> Branch: master >> Commit: 98923665105334ca6aaf39a756b62da606ecc861 >> URL: >> http://source.winehq.org/git/wine.git/?a=commit;h=98923665105334ca6aaf39a75 >> 6b62da606ecc861 >> >> Author: Fabian Maurer <dark.shadow4(a)web.de> >> Date: Wed Sep 20 14:03:36 2017 +0200 >> >> evr/tests: Add tests. >> >> Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> >> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> > > Wasn't this rejected? That was the intent, not sure how I screwed this up. Lucky you ;-) -- Alexandre Julliard julliard(a)winehq.org

Sept. 22, 2017

Re: [PATCH] msvcrt: Implement clearerr_s

by Nikolay Sivov

Docs say it should invoke invalid parameter handler and set error number.

Sept. 22, 2017

Re: Fabian Maurer : evr/tests: Add tests.

by Fabian Maurer

On Donnerstag, 21. September 2017 22:01:00 CEST Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 98923665105334ca6aaf39a756b62da606ecc861 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=98923665105334ca6aaf39a75 > 6b62da606ecc861 > > Author: Fabian Maurer <dark.shadow4(a)web.de> > Date: Wed Sep 20 14:03:36 2017 +0200 > > evr/tests: Add tests. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Wasn't this rejected? Regards, Fabian Maurer

Sept. 22, 2017

Re: [PATCH v2 3/3] wined3d: Advertise AUTOGENMIPMAP only for renderable and filterable formats.

by Henri Verbeet

On 21 September 2017 at 01:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + || (format->flags[gl_type] & (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING)) > + != (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING))) As an aside, that could also be written as "~format->flags[gl_type] & (WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FILTERING)"

Sept. 21, 2017

Re: [PATCH] wine/test.h: Increment correct counter for tests in todo blocks

by Nikolay Sivov

On 21.09.2017 19:40, Fabian Maurer wrote: >> If it succeeds inside a todo then it's counted as failure. If it fails >> as expected it's not counted. > >> This is correct. If test passes but is marked as todo it is a failure. > > I see, to detect if some test now works while it used to fail, I guess? Makes > sense, but goes directly against the comments: Right. > >> static LONG todo_successes; /* number of successful tests inside todo block >> static LONG todo_failures; /* number of failures inside todo block */ > > According to this, it's the other way round. Or at least it's > misunderstandable. But if it's working as intended, please ignore my patch. > But could we maybe rename these variables and change these comments so it's > easier to understand? todo_successes means todo block works, meaning current wine result matches expected result negated by todo_wine. The fact that it matches means todo block works as intended. > > > Regards, > Fabian Maurer >

Sept. 21, 2017