October 2018 - Wine-Devel - list.winehq.org

Re: [PATCH v2 1/5] mfplat: Add MFCreateFile stub

by Sven Baars

On 30-10-18 02:12, Zebediah Figura wrote: > On 10/29/18 5:26 PM, Sven Baars wrote: >> +HRESULT WINAPI MFCreateFile(MF_FILE_ACCESSMODE accessmode, >> MF_FILE_OPENMODE openmode, MF_FILE_FLAGS flags, >> + LPCWSTR url, IMFByteStream **bytestream) >> +{ >> + mfbytestream *object; >> + >> + FIXME("(%d, %d, %d, %s, %p): stub\n", accessmode, openmode, >> flags, debugstr_w(url), bytestream); >> + >> + object = heap_alloc( sizeof(*object) ); >> + if(!object) >> + return E_OUTOFMEMORY; >> + >> + object->ref = 1; >> + object->IMFByteStream_iface.lpVtbl = &mfbytesteam_vtbl; >> + MFCreateAttributes(&object->attributes, 0); >> *bytestream = &object->IMFByteStream_iface; >> return S_OK; >> } > > I think it probably wouldn't be too difficult to implement this > directly on top of MFCreateMFByteStreamOnStream, using > SHCreateStreamOnFile(). Obviously the latter doesn't do anything yet, > but the implementation seems pretty clear. Hi Zebediah, I am now working on implementing this, but unfortunately SHCreateStreamOnFileEx is insufficient for the flags that can be passed to MFCreateFile. I instead parse the flags so they can be passed to CreateFileW as is also done in SHCreateStreamOnFileEx. However, SHCreateStreamOnFileEx calls IStream_Create from the same file, but this function is not exposed. Is there any way to get access to the IStream interface defined in shlwapi/istream.c or does the same interface have to be implemented in/copied to mfplat? Or should I just stop at the point where the file is created for the moment since MFCreateMFByteStreamOnStream doesn't do anything yet anyway? Best, Sven

Oct. 31, 2018

Re: [PATCH vkd3d 4/5] tests: Introduce check_sub_resource_uvec4().

by Henri Verbeet

On Wed, 31 Oct 2018 at 18:49, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +#define check_sub_resource_uvec4(a, b, c, d, e) check_sub_resource_uvec4_(__LINE__, a, b, c, d, e) > +static void check_sub_resource_uvec4_(unsigned int line, ID3D12Resource *texture, > + unsigned int sub_resource_idx, ID3D12CommandQueue *queue, ID3D12GraphicsCommandList *command_list, > + const struct uvec4 *expected_value) > +{ > + struct resource_readback rb; > + struct uvec4 value = {}; > + unsigned int x = 0, y; > + bool all_match = true; > + > + get_texture_readback_with_command_list(texture, 0, &rb, queue, command_list); You don't seem to be using the sub-resource index here.

Oct. 31, 2018

Re: [PATCH vkd3d 2/5] vkd3d-shader: Use vkd3d_dxbc_compiler_emit_swizzle_ext() in vkd3d_dxbc_compiler_emit_input().

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Oct. 31, 2018

Re: [PATCH vkd3d 1/5] vkd3d-shader: Check more accurately if swizzle is required.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Oct. 31, 2018

Re: [PATCH vkd3d 3/5] vkd3d-shader: Try harder to avoid using private variables for inputs.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Oct. 31, 2018

[PATCH] user32/tests: Add scrollbar subclassing tests.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/tests/scroll.c | 74 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+)

Oct. 31, 2018

[PATCH] qwave: add new stub dll

by Louis Lenders

fix for https://bugs.winehq.org/show_bug.cgi?id=46066 this dll seems to be present on winversions >= winVista (on testbots) Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> --- configure | 2 ++ configure.ac | 1 + dlls/qwave/Makefile.in | 4 ++++ dlls/qwave/main.c | 41 +++++++++++++++++++++++++++++++++++++++++ dlls/qwave/qwave.spec | 14 ++++++++++++++ 5 files changed, 62 insertions(+) create mode 100644 dlls/qwave/Makefile.in create mode 100644 dlls/qwave/main.c create mode 100644 dlls/qwave/qwave.spec diff --git a/configure b/configure index 9d4a7a8b78..780c5c475d 100755 --- a/configure +++ b/configure @@ -1486,6 +1486,7 @@ enable_qmgr enable_qmgrprxy enable_quartz enable_query +enable_qwave enable_rasapi32 enable_rasdlg enable_regapi @@ -19758,6 +19759,7 @@ wine_fn_config_makefile dlls/qmgrprxy enable_qmgrprxy wine_fn_config_makefile dlls/quartz enable_quartz wine_fn_config_makefile dlls/quartz/tests enable_tests wine_fn_config_makefile dlls/query enable_query +wine_fn_config_makefile dlls/qwave enable_qwave wine_fn_config_makefile dlls/rasapi16.dll16 enable_win16 wine_fn_config_makefile dlls/rasapi32 enable_rasapi32 wine_fn_config_makefile dlls/rasapi32/tests enable_tests diff --git a/configure.ac b/configure.ac index b64d99e9d1..82a3c46a24 100644 --- a/configure.ac +++ b/configure.ac @@ -3611,6 +3611,7 @@ WINE_CONFIG_MAKEFILE(dlls/qmgrprxy) WINE_CONFIG_MAKEFILE(dlls/quartz) WINE_CONFIG_MAKEFILE(dlls/quartz/tests) WINE_CONFIG_MAKEFILE(dlls/query) +WINE_CONFIG_MAKEFILE(dlls/qwave) WINE_CONFIG_MAKEFILE(dlls/rasapi16.dll16,enable_win16) WINE_CONFIG_MAKEFILE(dlls/rasapi32) WINE_CONFIG_MAKEFILE(dlls/rasapi32/tests) diff --git a/dlls/qwave/Makefile.in b/dlls/qwave/Makefile.in new file mode 100644 index 0000000000..9de8224697 --- /dev/null +++ b/dlls/qwave/Makefile.in @@ -0,0 +1,4 @@ +MODULE = qwave.dll + +C_SRCS = \ + main.c diff --git a/dlls/qwave/main.c b/dlls/qwave/main.c new file mode 100644 index 0000000000..ce1cfbd670 --- /dev/null +++ b/dlls/qwave/main.c @@ -0,0 +1,41 @@ +/* + * Copyright 2018 Louis Lenders + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "config.h" +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(qwave); + +BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD reason, LPVOID lpv) +{ + TRACE("(%p, %d, %p)\n", hInstDLL, reason, lpv); + + switch (reason) + { + case DLL_WINE_PREATTACH: + return FALSE; /* prefer native version */ + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls(hInstDLL); + break; + } + return TRUE; +} diff --git a/dlls/qwave/qwave.spec b/dlls/qwave/qwave.spec new file mode 100644 index 0000000000..27b07f55d6 --- /dev/null +++ b/dlls/qwave/qwave.spec @@ -0,0 +1,14 @@ +@ stub QDLHPathDiagnostics +@ stub QDLHStartDiagnosingPath +@ stub QOSAddSocketToFlow +@ stub QOSCancel +@ stub QOSCloseHandle +@ stub QOSCreateHandle +@ stub QOSEnumerateFlows +@ stub QOSNotifyFlow +@ stub QOSQueryFlow +@ stub QOSRemoveSocketFromFlow +@ stub QOSSetFlow +@ stub QOSStartTrackingClient +@ stub QOSStopTrackingClient +@ stub ServiceMain -- 2.17.1

Oct. 31, 2018

[PATCH 3/3] server: Use file mode flags in async_handoff to decide if request is blocking.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/tests/pipe.c | 20 +++++++------------- server/async.c | 4 ++-- server/fd.c | 8 ++++---- server/file.h | 2 +- 4 files changed, 14 insertions(+), 20 deletions(-)

Oct. 31, 2018

[PATCH 2/3] server: Introduce is_fd_synchronous helper.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- server/fd.c | 10 ++++++++-- server/file.c | 7 +------ server/file.h | 1 + 3 files changed, 10 insertions(+), 8 deletions(-)

Oct. 31, 2018

[PATCH 1/3 v3] ntdll/tests: Add more I/O blocking and completion tests.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/tests/pipe.c | 319 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 318 insertions(+), 1 deletion(-)

Oct. 31, 2018