February 2018 - Wine-Devel - list.winehq.org

[PATCH 6/6] mshtml: Merge propbag.c into pluginhost.c

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/Makefile.in | 1 - dlls/mshtml/pluginhost.c | 321 ++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/pluginhost.h | 2 - dlls/mshtml/propbag.c | 357 ----------------------------------------------- 4 files changed, 321 insertions(+), 360 deletions(-) delete mode 100644 dlls/mshtml/propbag.c

Feb. 28, 2018

[PATCH 5/6] mshtml: Merge ipwindow.c into pluginhost.c.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/Makefile.in | 1 - dlls/mshtml/ipwindow.c | 347 ----------------------------------------------- dlls/mshtml/pluginhost.c | 311 ++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/pluginhost.h | 3 - 4 files changed, 311 insertions(+), 351 deletions(-) delete mode 100644 dlls/mshtml/ipwindow.c

Feb. 28, 2018

[PATCH 3/6] mshtml: Implement IOleDocumentView and IViewObjectEx interfaces in HTMLDocumentObj object instead of HTMLDocument.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/htmldoc.c | 21 ++-- dlls/mshtml/mshtml_private.h | 7 +- dlls/mshtml/oleobj.c | 16 +-- dlls/mshtml/view.c | 245 ++++++++++++++++++++----------------------- 4 files changed, 136 insertions(+), 153 deletions(-)

Feb. 28, 2018

[PATCH 4/6] mshtml: Merge htmlscreen.c into imnavigator.c

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/Makefile.in | 1 - dlls/mshtml/htmlscreen.c | 263 ---------------------------------------------- dlls/mshtml/omnavigator.c | 233 +++++++++++++++++++++++++++++++++++++++- 3 files changed, 232 insertions(+), 265 deletions(-) delete mode 100644 dlls/mshtml/htmlscreen.c

Feb. 28, 2018

[PATCH 2/6] mshtml: Implement IHTMLTextContainer interface directly in HTMLBodyElement object.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/htmlbody.c | 113 +++++++++++++++++++++---------------------------- 1 file changed, 49 insertions(+), 64 deletions(-)

Feb. 28, 2018

Re: [PATCH 4/4] comctl32: Add listbox WM_MEASUREITEM tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=36281 Your paranoid android. === wxppro (32 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 === w2003std (32 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 === wvistau64 (32 bit listbox) === listbox.c:938: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 === w7u (32 bit listbox) === listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9B2 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9B2 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 listbox.c:248: Test failed: mi->itemHeight = 18 === w8 (32 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 === w864 (32 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 listbox.c:260: Test failed: mi->itemData = 00000000, expected 004DC9A6 === wvistau64 (64 bit listbox) === listbox.c:938: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 === w2008s64 (64 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 00000000004BEAAA listbox.c:260: Test failed: mi->itemData = 00000000, expected 00000000004BEAAA The previous 2 run(s) terminated abnormally === w864 (64 bit listbox) === listbox.c:260: Test failed: mi->itemData = 00000000, expected 00000000004BEAAA listbox.c:260: Test failed: mi->itemData = 00000000, expected 00000000004BEAAA

Feb. 28, 2018

[PATCH 1/6] mshtml: Merge htmltextcont.c into htmlbody.c.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/mshtml/Makefile.in | 1 - dlls/mshtml/htmlbody.c | 165 ++++++++++++++++++++++++++++++++++++ dlls/mshtml/htmltextcont.c | 194 ------------------------------------------- dlls/mshtml/mshtml_private.h | 7 -- 4 files changed, 165 insertions(+), 202 deletions(-) delete mode 100644 dlls/mshtml/htmltextcont.c

Feb. 28, 2018

Re: [PATCH 2/4] user32: Add listbox WM_MEASUREITEM tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=36280 Your paranoid android. === wvistau64 (32 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 listbox.c:739: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY, *) filled with 7 entries, expected > 7 listbox.c:974: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 === w2008s64 (32 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B94 listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B94 === w7u (32 bit listbox) === listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 listbox.c:258: Test failed: mi->itemHeight = 18 === w7pro64 (32 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 === w1064 (32 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 listbox.c:270: Test failed: mi->itemData = 00000000, expected 00530B88 === wvistau64 (64 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 000000000050A9CC listbox.c:739: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY, *) filled with 7 entries, expected > 7 listbox.c:974: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:270: Test failed: mi->itemData = 00000000, expected 000000000050A9CC === w864 (64 bit listbox) === listbox.c:270: Test failed: mi->itemData = 00000000, expected 2E2E2F2E2E2F2E2E listbox.c:270: Test failed: mi->itemData = 00000000, expected 2E2E2F2E2E2F2E2E

Feb. 28, 2018

Re: [PATCH 2/2] gdiplus/tests: Add some invalid arguments tests for GdipLoadImageFromStream()

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

Feb. 28, 2018

Re: [PATCH 4/8] wined3d: Fix draw calls when first render target is NULL.

by Henri Verbeet

On 28 February 2018 at 12:12, Józef Kucia <jkucia(a)codeweavers.com> wrote: > In Direct3D 10+, the render target at index 0 can be set to NULL. > Yes, but draw_primitive() at least seems to account for that. What is the issue there specifically? > @@ -4792,12 +4820,7 @@ void draw_primitive(struct wined3d_device *device, const struct wined3d_state *s > if (!parameters->indirect && !parameters->u.direct.index_count) > return; > > - if (!(rtv = fb->render_targets[0])) > - rtv = fb->depth_stencil; > - if (rtv) > - context = context_acquire(device, wined3d_texture_from_resource(rtv->resource), rtv->sub_resource_idx); > - else > - context = context_acquire(device, NULL, 0); > + context = context_acquire_for_draw_call(device, fb); I.e., here.

Feb. 28, 2018