June 2018 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] msvcrt/tests: Use the available ARRAY_SIZE() macro

by Piotr Caban

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>

June 21, 2018

Re: [PATCH 1/2] msvcrt: Rename a macro to ARRAY_SIZE()

by Piotr Caban

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>

June 21, 2018

Re: [PATCH v8 5/9] ntdll: Return BIOS info from NtQuerySystemInformation on Linux

by Alex Henrie

On Wed, Jun 20, 2018 at 11:59 PM Marvin <testbot(a)winehq.org> wrote: > > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://testbot.winehq.org/JobDetails.pl?Key=39269 > > Your paranoid android. > > > === wxppro (32 bit info) === > The task timed out This is an intermittent failure which could not have been caused by this patch's minor changes to the tests: https://testbot.winehq.org/JobDetails.pl?Key=39279 -Alex

June 21, 2018

Re: [PATCH 1/2] iphlpapi: Use a standalone buffer in IcmpSendEcho().

by Huw Davies

On Thu, Jun 21, 2018 at 05:51:13PM +0800, Zhiyi Zhang wrote: > > > On Thu 6 21 17:35, Huw Davies wrote: > > On Fri, Jun 15, 2018 at 12:23:23PM +0800, Zhiyi Zhang wrote: > >> Fix https://bugs.winehq.org/show_bug.cgi?id=43252 > >> > >> The old implementation uses user provided buffer to receive > >> packet data, which is alway not enough, causing data corruptions > >> or incorrectly timeout. > >> > >> Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> > >> --- > >> dlls/iphlpapi/icmp.c | 38 +++++++++++++++++++++++++++------- > >> dlls/iphlpapi/tests/iphlpapi.c | 21 +++++++++++++++---- > >> 2 files changed, 47 insertions(+), 12 deletions(-) > >> > >> diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c > >> index ebc2f2b65c..7c91443598 100644 > >> --- a/dlls/iphlpapi/icmp.c > >> +++ b/dlls/iphlpapi/icmp.c > >> @@ -113,6 +113,9 @@ typedef struct { > >> #define IP_OPTS_DEFAULT 1 > >> #define IP_OPTS_CUSTOM 2 > >> > >> +#define MAXIPLEN 60 > >> +#define MAXICMPLEN 76 > > > > Out of interest, how did you get to 76? > > > > That was copied from https://github.com/iputils/iputils/blob/master/ping.c#L76 I guess it's for errors: 8 for the icmp header, 60 for the original ip header, then 8 for the original icmp header. We probably don't need all of that, but it doesn't hurt. Huw.

June 21, 2018

Re: [PATCH 1/2] iphlpapi: Use a standalone buffer in IcmpSendEcho().

by Zhiyi Zhang

On Thu 6 21 17:35, Huw Davies wrote: > On Fri, Jun 15, 2018 at 12:23:23PM +0800, Zhiyi Zhang wrote: >> Fix https://bugs.winehq.org/show_bug.cgi?id=43252 >> >> The old implementation uses user provided buffer to receive >> packet data, which is alway not enough, causing data corruptions >> or incorrectly timeout. >> >> Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> >> --- >> dlls/iphlpapi/icmp.c | 38 +++++++++++++++++++++++++++------- >> dlls/iphlpapi/tests/iphlpapi.c | 21 +++++++++++++++---- >> 2 files changed, 47 insertions(+), 12 deletions(-) >> >> diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c >> index ebc2f2b65c..7c91443598 100644 >> --- a/dlls/iphlpapi/icmp.c >> +++ b/dlls/iphlpapi/icmp.c >> @@ -113,6 +113,9 @@ typedef struct { >> #define IP_OPTS_DEFAULT 1 >> #define IP_OPTS_CUSTOM 2 >> >> +#define MAXIPLEN 60 >> +#define MAXICMPLEN 76 > > Out of interest, how did you get to 76? > That was copied from https://github.com/iputils/iputils/blob/master/ping.c#L76 >> + >> /* The sequence number is unique process wide, so that all threads >> * have a distinct sequence number. >> */ >> @@ -270,13 +273,14 @@ DWORD WINAPI IcmpSendEcho( >> icmp_t* icp=(icmp_t*)IcmpHandle; >> unsigned char* reqbuf; >> int reqsize; >> + unsigned char* repbuf; >> + int repsize; >> >> struct icmp_echo_reply* ier; >> struct ip* ip_header; >> struct icmp* icmp_header; >> char* endbuf; >> int ip_header_len; >> - int maxlen; >> struct pollfd fdr; >> DWORD send_time,recv_time; >> struct sockaddr_in addr; >> @@ -312,6 +316,16 @@ DWORD WINAPI IcmpSendEcho( >> return 0; >> } >> >> + /* max ip header + max icmp header and error data + reply size(max 65535 on Windows) */ >> + /* FIXME: request size of 65535 is not supported yet because max buffer size of raw socket on linux is 32767 */ >> + repsize=MAXIPLEN+MAXICMPLEN+(ReplySize&0xFFFF); >> + repbuf=HeapAlloc(GetProcessHeap(), 0, repsize); >> + if (reqbuf==NULL) { > > This should be repbuf. > >> + HeapFree(GetProcessHeap(), 0, reqbuf); >> + SetLastError(ERROR_OUTOFMEMORY); >> + return 0; >> + } >> + >> icmp_header=(struct icmp*)reqbuf; >> icmp_header->icmp_type=ICMP_ECHO; >> icmp_header->icmp_code=0; >> @@ -367,9 +381,7 @@ DWORD WINAPI IcmpSendEcho( >> fdr.events = POLLIN; >> addrlen=sizeof(addr); >> ier=ReplyBuffer; >> - ip_header=(struct ip *) ((char *) ReplyBuffer+sizeof(ICMP_ECHO_REPLY)); >> endbuf=(char *) ReplyBuffer+ReplySize; >> - maxlen=ReplySize-sizeof(ICMP_ECHO_REPLY); >> >> /* Send the packet */ >> TRACE("Sending %d bytes (RequestSize=%d) to %s\n", reqsize, RequestSize, inet_ntoa(addr.sin_addr)); >> @@ -407,10 +419,11 @@ DWORD WINAPI IcmpSendEcho( >> } >> >> /* Get the reply */ >> + ip_header=(struct ip*)repbuf; >> ip_header_len=0; /* because gcc was complaining */ >> while (poll(&fdr,1,Timeout)>0) { >> recv_time = GetTickCount(); >> - res=recvfrom(icp->sid, (char*)ip_header, maxlen, 0, (struct sockaddr*)&addr,&addrlen); >> + res=recvfrom(icp->sid, (char*)repbuf, repsize, 0, (struct sockaddr*)&addr, &addrlen); >> TRACE("received %d bytes from %s\n",res, inet_ntoa(addr.sin_addr)); >> ier->Status=IP_REQ_TIMED_OUT; >> >> @@ -508,6 +521,12 @@ DWORD WINAPI IcmpSendEcho( >> else Timeout = 0; >> continue; >> } else { >> + /* Check free space, should be large enough for an ICMP_ECHO_REPLY and remainning icmp data */ >> + if (endbuf-(char *)ier < sizeof(struct icmp_echo_reply)+(res-ip_header_len-ICMP_MINLEN)) { >> + res=ier-(ICMP_ECHO_REPLY *)ReplyBuffer; >> + SetLastError(IP_GENERAL_FAILURE); >> + goto done; >> + } >> /* This is a reply to our packet */ >> memcpy(&ier->Address,&ip_header->ip_src,sizeof(IPAddr)); >> /* Status is already set */ >> @@ -515,7 +534,7 @@ DWORD WINAPI IcmpSendEcho( >> ier->DataSize=res-ip_header_len-ICMP_MINLEN; >> ier->Reserved=0; >> ier->Data=endbuf-ier->DataSize; >> - memmove(ier->Data,((char*)ip_header)+ip_header_len+ICMP_MINLEN,ier->DataSize); >> + memcpy(ier->Data, ((char *)ip_header)+ip_header_len+ICMP_MINLEN, ier->DataSize); >> ier->Options.Ttl=ip_header->ip_ttl; >> ier->Options.Tos=ip_header->ip_tos; >> ier->Options.Flags=ip_header->ip_off >> 13; >> @@ -523,7 +542,7 @@ DWORD WINAPI IcmpSendEcho( >> if (ier->Options.OptionsSize!=0) { >> ier->Options.OptionsData=(unsigned char *) ier->Data-ier->Options.OptionsSize; >> /* FIXME: We are supposed to rearrange the option's 'source route' data */ >> - memmove(ier->Options.OptionsData,((char*)ip_header)+ip_header_len,ier->Options.OptionsSize); >> + memcpy(ier->Options.OptionsData, ((char *)ip_header)+ip_header_len, ier->Options.OptionsSize); >> endbuf=(char*)ier->Options.OptionsData; >> } else { >> ier->Options.OptionsData=NULL; >> @@ -531,9 +550,8 @@ DWORD WINAPI IcmpSendEcho( >> } >> >> /* Prepare for the next packet */ >> + endbuf-=ier->DataSize; >> ier++; >> - ip_header=(struct ip*)(((char*)ip_header)+sizeof(ICMP_ECHO_REPLY)); >> - maxlen=endbuf-(char*)ip_header; >> >> /* Check out whether there is more but don't wait this time */ >> Timeout=0; >> @@ -542,6 +560,10 @@ DWORD WINAPI IcmpSendEcho( >> res=ier-(ICMP_ECHO_REPLY*)ReplyBuffer; >> if (res==0) >> SetLastError(IP_REQ_TIMED_OUT); >> + else >> + SetLastError(NO_ERROR); > > This hunk looks like a separate change so should be a separate patch. > Note, in general setting last error to NO_ERROR looks wrong, though it may > be needed in this case. > > Huw. >

June 21, 2018

[PATCH 2/2] vulkan-1/tests: Add tests.

by Józef Kucia

Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- configure | 1 + configure.ac | 1 + dlls/vulkan-1/Makefile.in | 1 + dlls/vulkan-1/tests/Makefile.in | 5 +++ dlls/vulkan-1/tests/vulkan.c | 92 +++++++++++++++++++++++++++++++++++++++++ 5 files changed, 100 insertions(+) create mode 100644 dlls/vulkan-1/tests/Makefile.in create mode 100644 dlls/vulkan-1/tests/vulkan.c diff --git a/configure b/configure index bcb660d56982..ddd6db152cc9 100755 --- a/configure +++ b/configure @@ -19222,6 +19222,7 @@ wine_fn_config_makefile dlls/vnetbios.vxd enable_win16 wine_fn_config_makefile dlls/vssapi enable_vssapi wine_fn_config_makefile dlls/vtdapi.vxd enable_win16 wine_fn_config_makefile dlls/vulkan-1 enable_vulkan_1 +wine_fn_config_makefile dlls/vulkan-1/tests enable_tests wine_fn_config_makefile dlls/vwin32.vxd enable_win16 wine_fn_config_makefile dlls/w32skrnl enable_win16 wine_fn_config_makefile dlls/w32sys.dll16 enable_win16 diff --git a/configure.ac b/configure.ac index 469fa8d72977..68f7f146ca1f 100644 --- a/configure.ac +++ b/configure.ac @@ -3721,6 +3721,7 @@ WINE_CONFIG_MAKEFILE(dlls/vnetbios.vxd,enable_win16) WINE_CONFIG_MAKEFILE(dlls/vssapi) WINE_CONFIG_MAKEFILE(dlls/vtdapi.vxd,enable_win16) WINE_CONFIG_MAKEFILE(dlls/vulkan-1) +WINE_CONFIG_MAKEFILE(dlls/vulkan-1/tests) WINE_CONFIG_MAKEFILE(dlls/vwin32.vxd,enable_win16) WINE_CONFIG_MAKEFILE(dlls/w32skrnl,enable_win16) WINE_CONFIG_MAKEFILE(dlls/w32sys.dll16,enable_win16) diff --git a/dlls/vulkan-1/Makefile.in b/dlls/vulkan-1/Makefile.in index 4bb8cec41287..2abc54df0e41 100644 --- a/dlls/vulkan-1/Makefile.in +++ b/dlls/vulkan-1/Makefile.in @@ -1,5 +1,6 @@ MODULE = vulkan-1.dll IMPORTS = winevulkan +IMPORTLIB = vulkan-1 C_SRCS = \ vulkan.c diff --git a/dlls/vulkan-1/tests/Makefile.in b/dlls/vulkan-1/tests/Makefile.in new file mode 100644 index 000000000000..c9f9f0727c80 --- /dev/null +++ b/dlls/vulkan-1/tests/Makefile.in @@ -0,0 +1,5 @@ +TESTDLL = vulkan-1.dll +IMPORTS = vulkan-1 + +C_SRCS = \ + vulkan.c diff --git a/dlls/vulkan-1/tests/vulkan.c b/dlls/vulkan-1/tests/vulkan.c new file mode 100644 index 000000000000..67da880fe470 --- /dev/null +++ b/dlls/vulkan-1/tests/vulkan.c @@ -0,0 +1,92 @@ +/* + * Copyright 2018 Józef Kucia for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "windows.h" +#include "wine/heap.h" +#include "wine/vulkan.h" +#include "wine/test.h" + +static VkResult create_instance(uint32_t extension_count, + const char * const *enabled_extensions, VkInstance *vk_instance) +{ + VkInstanceCreateInfo create_info; + + create_info.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO; + create_info.pNext = NULL; + create_info.flags = 0; + create_info.pApplicationInfo = NULL; + create_info.enabledLayerCount = 0; + create_info.ppEnabledLayerNames = NULL; + create_info.enabledExtensionCount = extension_count; + create_info.ppEnabledExtensionNames = enabled_extensions; + + return vkCreateInstance(&create_info, NULL, vk_instance); +} + +static void test_enumerate_physical_devices(void) +{ + VkPhysicalDevice *vk_physical_devices; + VkPhysicalDeviceProperties properties; + VkInstance vk_instance; + unsigned int i; + uint32_t count; + VkResult vr; + + if ((vr = create_instance(0, NULL, &vk_instance)) < 0) + { + skip("Failed to create Vulkan instance, vr %d.\n", vr); + return; + } + ok(vr == VK_SUCCESS, "Got unexpected VkResult %d.\n", vr); + + vr = vkEnumeratePhysicalDevices(vk_instance, &count, NULL); + ok(vr == VK_SUCCESS, "Got unexpected VkResult %d.\n", vr); + if (!count) + { + skip("No physical devices.\n"); + vkDestroyInstance(vk_instance, NULL); + return; + } + + trace("Got %u physical device(s).\n", count); + vk_physical_devices = heap_calloc(count, sizeof(*vk_physical_devices)); + ok(!!vk_physical_devices, "Failed to allocate memory.\n"); + vr = vkEnumeratePhysicalDevices(vk_instance, &count, vk_physical_devices); + ok(vr == VK_SUCCESS, "Got unexpected VkResult %d.\n", vr); + + for (i = 0; i < count; ++i) + { + vkGetPhysicalDeviceProperties(vk_physical_devices[i], &properties); + + trace("Device '%s', %#x:%#x, driver version %u.%u.%u (%#x), api version %u.%u.%u.\n", + properties.deviceName, properties.vendorID, properties.deviceID, + VK_VERSION_MAJOR(properties.driverVersion), VK_VERSION_MINOR(properties.driverVersion), + VK_VERSION_PATCH(properties.driverVersion), properties.driverVersion, + VK_VERSION_MAJOR(properties.apiVersion), VK_VERSION_MINOR(properties.apiVersion), + VK_VERSION_PATCH(properties.apiVersion)); + } + + heap_free(vk_physical_devices); + + vkDestroyInstance(vk_instance, NULL); +} + +START_TEST(vulkan) +{ + test_enumerate_physical_devices(); +} -- 2.16.4

June 21, 2018

[PATCH 1/2] wrc: Accept hyphens in identificators.

by Józef Kucia

It is a bit more permissive than it should be, hyphens should be allowed in resource names, but not in filenames. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- I need it to add tests for vulkan-1. I would like to add some tests for structure conversion bugs. --- tools/wrc/parser.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/wrc/parser.l b/tools/wrc/parser.l index 32a231b5a2ea..0f46670288ce 100644 --- a/tools/wrc/parser.l +++ b/tools/wrc/parser.l @@ -402,7 +402,7 @@ static unsigned long xstrtoul(const char *nptr, char **endptr, int base) 0[oO][0-7]+[lL]? { parser_lval.num = xstrtoul(yytext+2, 0, 8); return (yytext[yyleng-1] == 'L' || yytext[yyleng-1] == 'l') ? tLNUMBER : tNUMBER; } -[A-Za-z_0-9./\\]+ { +[A-Za-z_0-9./\\][A-Za-z_0-9./\\\-]* { struct keyword *tok = iskeyword(yytext); if(tok) -- 2.16.4

June 21, 2018

Re: [PATCH 1/2] iphlpapi: Use a standalone buffer in IcmpSendEcho().

by Huw Davies

On Fri, Jun 15, 2018 at 12:23:23PM +0800, Zhiyi Zhang wrote: > Fix https://bugs.winehq.org/show_bug.cgi?id=43252 > > The old implementation uses user provided buffer to receive > packet data, which is alway not enough, causing data corruptions > or incorrectly timeout. > > Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> > --- > dlls/iphlpapi/icmp.c | 38 +++++++++++++++++++++++++++------- > dlls/iphlpapi/tests/iphlpapi.c | 21 +++++++++++++++---- > 2 files changed, 47 insertions(+), 12 deletions(-) > > diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c > index ebc2f2b65c..7c91443598 100644 > --- a/dlls/iphlpapi/icmp.c > +++ b/dlls/iphlpapi/icmp.c > @@ -113,6 +113,9 @@ typedef struct { > #define IP_OPTS_DEFAULT 1 > #define IP_OPTS_CUSTOM 2 > > +#define MAXIPLEN 60 > +#define MAXICMPLEN 76 Out of interest, how did you get to 76? > + > /* The sequence number is unique process wide, so that all threads > * have a distinct sequence number. > */ > @@ -270,13 +273,14 @@ DWORD WINAPI IcmpSendEcho( > icmp_t* icp=(icmp_t*)IcmpHandle; > unsigned char* reqbuf; > int reqsize; > + unsigned char* repbuf; > + int repsize; > > struct icmp_echo_reply* ier; > struct ip* ip_header; > struct icmp* icmp_header; > char* endbuf; > int ip_header_len; > - int maxlen; > struct pollfd fdr; > DWORD send_time,recv_time; > struct sockaddr_in addr; > @@ -312,6 +316,16 @@ DWORD WINAPI IcmpSendEcho( > return 0; > } > > + /* max ip header + max icmp header and error data + reply size(max 65535 on Windows) */ > + /* FIXME: request size of 65535 is not supported yet because max buffer size of raw socket on linux is 32767 */ > + repsize=MAXIPLEN+MAXICMPLEN+(ReplySize&0xFFFF); > + repbuf=HeapAlloc(GetProcessHeap(), 0, repsize); > + if (reqbuf==NULL) { This should be repbuf. > + HeapFree(GetProcessHeap(), 0, reqbuf); > + SetLastError(ERROR_OUTOFMEMORY); > + return 0; > + } > + > icmp_header=(struct icmp*)reqbuf; > icmp_header->icmp_type=ICMP_ECHO; > icmp_header->icmp_code=0; > @@ -367,9 +381,7 @@ DWORD WINAPI IcmpSendEcho( > fdr.events = POLLIN; > addrlen=sizeof(addr); > ier=ReplyBuffer; > - ip_header=(struct ip *) ((char *) ReplyBuffer+sizeof(ICMP_ECHO_REPLY)); > endbuf=(char *) ReplyBuffer+ReplySize; > - maxlen=ReplySize-sizeof(ICMP_ECHO_REPLY); > > /* Send the packet */ > TRACE("Sending %d bytes (RequestSize=%d) to %s\n", reqsize, RequestSize, inet_ntoa(addr.sin_addr)); > @@ -407,10 +419,11 @@ DWORD WINAPI IcmpSendEcho( > } > > /* Get the reply */ > + ip_header=(struct ip*)repbuf; > ip_header_len=0; /* because gcc was complaining */ > while (poll(&fdr,1,Timeout)>0) { > recv_time = GetTickCount(); > - res=recvfrom(icp->sid, (char*)ip_header, maxlen, 0, (struct sockaddr*)&addr,&addrlen); > + res=recvfrom(icp->sid, (char*)repbuf, repsize, 0, (struct sockaddr*)&addr, &addrlen); > TRACE("received %d bytes from %s\n",res, inet_ntoa(addr.sin_addr)); > ier->Status=IP_REQ_TIMED_OUT; > > @@ -508,6 +521,12 @@ DWORD WINAPI IcmpSendEcho( > else Timeout = 0; > continue; > } else { > + /* Check free space, should be large enough for an ICMP_ECHO_REPLY and remainning icmp data */ > + if (endbuf-(char *)ier < sizeof(struct icmp_echo_reply)+(res-ip_header_len-ICMP_MINLEN)) { > + res=ier-(ICMP_ECHO_REPLY *)ReplyBuffer; > + SetLastError(IP_GENERAL_FAILURE); > + goto done; > + } > /* This is a reply to our packet */ > memcpy(&ier->Address,&ip_header->ip_src,sizeof(IPAddr)); > /* Status is already set */ > @@ -515,7 +534,7 @@ DWORD WINAPI IcmpSendEcho( > ier->DataSize=res-ip_header_len-ICMP_MINLEN; > ier->Reserved=0; > ier->Data=endbuf-ier->DataSize; > - memmove(ier->Data,((char*)ip_header)+ip_header_len+ICMP_MINLEN,ier->DataSize); > + memcpy(ier->Data, ((char *)ip_header)+ip_header_len+ICMP_MINLEN, ier->DataSize); > ier->Options.Ttl=ip_header->ip_ttl; > ier->Options.Tos=ip_header->ip_tos; > ier->Options.Flags=ip_header->ip_off >> 13; > @@ -523,7 +542,7 @@ DWORD WINAPI IcmpSendEcho( > if (ier->Options.OptionsSize!=0) { > ier->Options.OptionsData=(unsigned char *) ier->Data-ier->Options.OptionsSize; > /* FIXME: We are supposed to rearrange the option's 'source route' data */ > - memmove(ier->Options.OptionsData,((char*)ip_header)+ip_header_len,ier->Options.OptionsSize); > + memcpy(ier->Options.OptionsData, ((char *)ip_header)+ip_header_len, ier->Options.OptionsSize); > endbuf=(char*)ier->Options.OptionsData; > } else { > ier->Options.OptionsData=NULL; > @@ -531,9 +550,8 @@ DWORD WINAPI IcmpSendEcho( > } > > /* Prepare for the next packet */ > + endbuf-=ier->DataSize; > ier++; > - ip_header=(struct ip*)(((char*)ip_header)+sizeof(ICMP_ECHO_REPLY)); > - maxlen=endbuf-(char*)ip_header; > > /* Check out whether there is more but don't wait this time */ > Timeout=0; > @@ -542,6 +560,10 @@ DWORD WINAPI IcmpSendEcho( > res=ier-(ICMP_ECHO_REPLY*)ReplyBuffer; > if (res==0) > SetLastError(IP_REQ_TIMED_OUT); > + else > + SetLastError(NO_ERROR); This hunk looks like a separate change so should be a separate patch. Note, in general setting last error to NO_ERROR looks wrong, though it may be needed in this case. Huw.

June 21, 2018

[PATCH] kernel32: Implement K32EnumDeviceDrivers and K32GetDeviceDriverBaseNameA (pt. 2)

by Anthony Lauzon

I noticed my submission yesterday was a little undercooked and since I have spent some more time on it, I thought I'd try to submit a (hopefully) proper patch to the list. This is a rough implementation of K32EnumDeviceDrivers and K32GetDeviceDriverBaseNameA.

June 21, 2018

Re: [PATCH v2] user32: Always release menu item in EnableMenuItem

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

June 21, 2018