July 2018 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] d3dcompiler_43/tests: Load d3dcompiler_43.dll dynamically.

by Matteo Bruni

With the subject prefix changed to "d3dcompiler/tests:" this is Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>

July 31, 2018

[PATCH] d3dx9: Return a mesh in D3DXCreateTeapot().

by Matteo Bruni

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=36884 Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- dlls/d3dx9_36/mesh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index 62acd211148..acbb2477670 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -5166,9 +5166,9 @@ HRESULT WINAPI D3DXCreateCylinder(struct IDirect3DDevice9 *device, float radius1 HRESULT WINAPI D3DXCreateTeapot(struct IDirect3DDevice9 *device, struct ID3DXMesh **mesh, struct ID3DXBuffer **adjacency) { - FIXME("(%p, %p, %p): stub\n", device, mesh, adjacency); + FIXME("device %p, mesh %p, adjacency %p semi-stub.\n", device, mesh, adjacency); - return E_NOTIMPL; + return D3DXCreateSphere(device, 1.0f, 4, 4, mesh, adjacency); } HRESULT WINAPI D3DXCreateTextA(struct IDirect3DDevice9 *device, HDC hdc, const char *text, float deviation, -- 2.16.4

July 31, 2018

Re: [PATCH] wmp: Make it possible to query IUnknown from IWMPControls.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=40338 Your paranoid android. === w2003std (32 bit oleobj) === The task timed out

July 31, 2018

[PATCH] wmp: Make it possible to query IUnknown from IWMPControls.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/wmp/player.c | 4 +++- dlls/wmp/tests/oleobj.c | 10 ++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/dlls/wmp/player.c b/dlls/wmp/player.c index 97fd66b79c..56b408f5b1 100644 --- a/dlls/wmp/player.c +++ b/dlls/wmp/player.c @@ -1365,7 +1365,9 @@ static const IWMPNetworkVtbl WMPNetworkVtbl = { static HRESULT WINAPI WMPControls_QueryInterface(IWMPControls *iface, REFIID riid, void **ppv) { - if(IsEqualGUID(riid, &IID_IDispatch)) { + if(IsEqualGUID(riid, &IID_IUnknown)) { + *ppv = iface; + }else if(IsEqualGUID(riid, &IID_IDispatch)) { *ppv = iface; }else if(IsEqualGUID(riid, &IID_IWMPControls)) { *ppv = iface; diff --git a/dlls/wmp/tests/oleobj.c b/dlls/wmp/tests/oleobj.c index 6dfaa1c9e1..472b985244 100644 --- a/dlls/wmp/tests/oleobj.c +++ b/dlls/wmp/tests/oleobj.c @@ -889,7 +889,6 @@ static void test_ConnectionPoint(IOleObject *unk) IConnectionPoint_Release(point); } - static void test_wmp_ifaces(IOleObject *oleobj) { IWMPSettings *settings, *settings_qi; @@ -899,6 +898,7 @@ static void test_wmp_ifaces(IOleObject *oleobj) IWMPControls *controls; VARIANT_BOOL vbool; IWMPNetwork *network; + IUnknown *unk; HRESULT hres; BSTR filename; BSTR url; @@ -913,9 +913,15 @@ static void test_wmp_ifaces(IOleObject *oleobj) player = NULL; hres = IWMPControls_QueryInterface(controls, &IID_IWMPPlayer, (void**)&player); - ok(hres != S_OK, "Getting IWMPPlayer from IWMPControls SUCCEEDED\n"); + ok(hres == E_NOINTERFACE, "Getting IWMPPlayer from IWMPControls SUCCEEDED\n"); ok(player == NULL, "player != NULL\n"); + unk = NULL; + hres = IWMPControls_QueryInterface(controls, &IID_IUnknown, (void **)&unk); + ok(hres == S_OK, "Failed to get IUnknown, hr %#x.\n", hres); + ok(unk != NULL, "Unexpected interface pointer.\n"); + IUnknown_Release(unk); + IWMPControls_Release(controls); /* IWPNetwork */ -- 2.18.0

July 31, 2018

[PATCH] kernel32: Set environment variable %PUBLIC% on the process start-up.

by Dmitry Timoshkov

This patch fixes an installer that has "[%PUBLIC]\Documents" entry for some of the targets being copied from a cabinet file. Under Windows %PUBLIC% environment variable is set to C:\Users\Public. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/kernel32/process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 4e6ba1118e..280f406627 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -520,6 +520,7 @@ static void set_additional_environment(void) static const WCHAR computernameW[] = {'C','O','M','P','U','T','E','R','N','A','M','E',0}; static const WCHAR allusersW[] = {'A','L','L','U','S','E','R','S','P','R','O','F','I','L','E',0}; static const WCHAR programdataW[] = {'P','r','o','g','r','a','m','D','a','t','a',0}; + static const WCHAR publicW[] = {'P','U','B','L','I','C',0}; OBJECT_ATTRIBUTES attr; UNICODE_STRING nameW; WCHAR *profile_dir = NULL, *all_users_dir = NULL, *program_data_dir = NULL; @@ -560,6 +561,7 @@ static void set_additional_environment(void) if (p > value && p[-1] != '\\') *p++ = '\\'; strcpyW( p, all_users_dir ); SetEnvironmentVariableW( allusersW, value ); + SetEnvironmentVariableW( publicW, value ); HeapFree( GetProcessHeap(), 0, value ); } -- 2.17.1

July 31, 2018

Re: [PATCH v2 1/2] winevulkan: Expose driver vkGetInstanceProcAddr via winevulkan exports.

by Józef Kucia

Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>

July 31, 2018

Re: [PATCH v2 2/2] winevulkan: Mark ICD and thunking functions as private.

by Józef Kucia

Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>

July 31, 2018

Re: [PATCH 13/13] msvcp90: Add implementation of _Concurrent_vector_Internal_push_back.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=40335 Your paranoid android. === debian9 (build) === error: patch failed: dlls/msvcp90/misc.c:2224 error: patch failed: dlls/msvcp90/misc.c:2041 error: patch failed: dlls/msvcp90/misc.c:1616 error: patch failed: dlls/msvcp90/misc.c:2029 Task: Patch failed to apply

July 31, 2018

Re: [PATCH 12/13] msvcp90: Add implementation of _Concurrent_vector_Internal_compact.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=40334 Your paranoid android. === debian9 (build) === error: patch failed: dlls/msvcp90/misc.c:2224 error: patch failed: dlls/msvcp90/misc.c:2041 error: patch failed: dlls/msvcp90/misc.c:1616 Task: Patch failed to apply

July 31, 2018

Re: [PATCH 11/13] msvcp90: Add implementation of _Concurrent_vector_Internal_swap.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=40333 Your paranoid android. === debian9 (build) === error: patch failed: dlls/msvcp90/misc.c:2224 error: patch failed: dlls/msvcp90/misc.c:2041 Task: Patch failed to apply

July 31, 2018