September 2018 - Wine-Devel

Re: [PATCH v3 4/6] shell32/autocomplete: Re-arrange some fields for better packing

by Alexandre Julliard

Gabriel Ivăncescu <gabrielopcode(a)gmail.com> writes: > On Thu, Sep 27, 2018 at 1:55 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> >> Why is packing relevant at all? How many of these structures are you >> expecting to allocate? >> >> -- >> Alexandre Julliard >> julliard(a)winehq.org > > It's not that it's really relevant (patch was really minor), but the > original used two BOOLs and then I had to add a UCHAR (next patch, > this was split from), each of which would have 3 bytes of padding (and > more on x86_64 later, when I'll have to add more fields), which just > seems a bit wasteful for the cache and a bit inelegant to me. I mean > it's a trivial change anyway, it's not like it makes the code itself > worse off, IMO. :-) It's a gratuitous change, and in many cases would generate worse code because of the need to manipulate bits. Losing a couple of padding bytes here and there is not a problem that needs fixing. -- Alexandre Julliard julliard(a)winehq.org

Sept. 27, 2018

[PATCH 2/2] mscms: update spec (win7)

by Louis Lenders

Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> --- dlls/mscms/mscms.spec | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/dlls/mscms/mscms.spec b/dlls/mscms/mscms.spec index 421a8fcf77..7208341afd 100644 --- a/dlls/mscms/mscms.spec +++ b/dlls/mscms/mscms.spec @@ -3,6 +3,20 @@ @ stdcall CheckBitmapBits(ptr ptr ptr long long long ptr ptr long) @ stdcall CheckColors(ptr ptr long long ptr) @ stdcall CloseColorProfile(ptr) +@ stub CloseDisplay +@ stub ColorCplGetDefaultProfileScope +@ stub ColorCplGetDefaultRenderingIntentScope +@ stub ColorCplGetProfileProperties +@ stub ColorCplHasSystemWideAssociationListChanged +@ stub ColorCplInitialize +@ stub ColorCplLoadAssociationList +@ stub ColorCplMergeAssociationLists +@ stub ColorCplOverwritePerUserAssociationList +@ stub ColorCplReleaseProfileProperties +@ stub ColorCplResetSystemWideAssociationListChangedWarning +@ stub ColorCplSaveAssociationList +@ stub ColorCplSetUsePerUserProfiles +@ stub ColorCplUninitialize @ stdcall ConvertColorNameToIndex(ptr ptr ptr long) @ stdcall ConvertIndexToColorName(ptr ptr ptr long) @ stdcall CreateColorTransformA(ptr ptr ptr long) @@ -11,9 +25,17 @@ @ stdcall CreateMultiProfileTransform(ptr long ptr long long long) @ stdcall CreateProfileFromLogColorSpaceA(ptr ptr) @ stdcall CreateProfileFromLogColorSpaceW(ptr ptr) +@ stub DccwCreateDisplayProfileAssociationList +@ stub DccwGetDisplayProfileAssociationList +@ stub DccwGetGamutSize +@ stub DccwReleaseDisplayProfileAssociationList +@ stub DccwSetDisplayProfileAssociationList @ stdcall DeleteColorTransform(ptr) +@ stub DeviceRenameEvent @ stdcall DisassociateColorProfileFromDeviceA(str str str) @ stdcall DisassociateColorProfileFromDeviceW(wstr wstr wstr) +@ stub DllCanUnloadNow +@ stub DllGetClassObject @ stdcall EnumColorProfilesA(str ptr ptr ptr ptr) @ stdcall EnumColorProfilesW(wstr ptr ptr ptr ptr) @ stdcall GenerateCopyFilePaths(wstr wstr ptr long ptr ptr ptr ptr long) @@ -38,11 +60,14 @@ @ stub InternalGetPS2ColorRenderingDictionary @ stub InternalGetPS2ColorSpaceArray @ stub InternalGetPS2PreviewCRD +@ stub InternalRefreshCalibration @ stub InternalSetDeviceConfig +@ stub InternalWcsAssociateColorProfileWithDevice @ stdcall IsColorProfileTagPresent(ptr long ptr) @ stdcall IsColorProfileValid(ptr ptr) @ stdcall OpenColorProfileA(ptr long long long) @ stdcall OpenColorProfileW(ptr long long long) +@ stub OpenDisplay @ stdcall RegisterCMMA(str long str) @ stdcall RegisterCMMW(wstr long wstr) @ stdcall SelectCMM(long) @@ -59,4 +84,22 @@ @ stdcall UninstallColorProfileW(wstr wstr long) @ stdcall UnregisterCMMA(str long) @ stdcall UnregisterCMMW(wstr long) +@ stub WcsAssociateColorProfileWithDevice +@ stub WcsCheckColors +@ stub WcsCreateIccProfile +@ stub WcsDisassociateColorProfileFromDevice +@ stub WcsEnumColorProfiles +@ stub WcsEnumColorProfilesSize +@ stub WcsGetCalibrationManagementState +@ stub WcsGetDefaultColorProfile +@ stub WcsGetDefaultColorProfileSize +@ stub WcsGetDefaultRenderingIntent @ stdcall WcsGetUsePerUserProfiles(wstr long ptr) +@ stub WcsGpCanInstallOrUninstallProfiles +@ stub WcsOpenColorProfileA +@ stub WcsOpenColorProfileW +@ stub WcsSetCalibrationManagementState +@ stub WcsSetDefaultColorProfile +@ stub WcsSetDefaultRenderingIntent +@ stub WcsSetUsePerUserProfiles +@ stub WcsTranslateColors -- 2.17.1

Sept. 27, 2018

[PATCH 1/2] mscms: add stub for WcsGetUsePerUserProfiles

by Louis Lenders

fix for https://bugs.winehq.org/show_bug.cgi?id=45861 Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> --- dlls/mscms/mscms.spec | 1 + dlls/mscms/profile.c | 10 ++++++++++ include/icm.h | 1 + 3 files changed, 12 insertions(+) diff --git a/dlls/mscms/mscms.spec b/dlls/mscms/mscms.spec index dd404f10a7..421a8fcf77 100644 --- a/dlls/mscms/mscms.spec +++ b/dlls/mscms/mscms.spec @@ -59,3 +59,4 @@ @ stdcall UninstallColorProfileW(wstr wstr long) @ stdcall UnregisterCMMA(str long) @ stdcall UnregisterCMMW(wstr long) +@ stdcall WcsGetUsePerUserProfiles(wstr long ptr) diff --git a/dlls/mscms/profile.c b/dlls/mscms/profile.c index cb4908cb27..53016ef5ce 100644 --- a/dlls/mscms/profile.c +++ b/dlls/mscms/profile.c @@ -1525,3 +1525,13 @@ BOOL WINAPI CloseColorProfile( HPROFILE profile ) #endif /* HAVE_LCMS2 */ return ret; } + +/****************************************************************************** + * WcsGetUsePerUserProfiles [MSCMS.@] + */ +BOOL WINAPI WcsGetUsePerUserProfiles( const WCHAR* name, DWORD class, BOOL* use_per_user_profile ) +{ + FIXME( "%s %s %p\n", debugstr_w(name), dbgstr_tag(class), use_per_user_profile ); + SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); + return FALSE; +} diff --git a/include/icm.h b/include/icm.h index 34b0b63d80..8a666fad5c 100644 --- a/include/icm.h +++ b/include/icm.h @@ -403,6 +403,7 @@ BOOL WINAPI UninstallColorProfileW(PCWSTR,PCWSTR,BOOL); BOOL WINAPI UnregisterCMMA(PCSTR,DWORD); BOOL WINAPI UnregisterCMMW(PCWSTR,DWORD); #define UnregisterCMM WINELIB_NAME_AW(UnregisterCMM) +BOOL WINAPI WcsGetUsePerUserProfiles(const WCHAR*,DWORD,BOOL*); #define PROFILE_FILENAME 1 #define PROFILE_MEMBUFFER 2 -- 2.17.1

Sept. 27, 2018

Re: [PATCH v3 4/6] shell32/autocomplete: Re-arrange some fields for better packing

by Gabriel Ivăncescu

On Thu, Sep 27, 2018 at 1:55 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > Why is packing relevant at all? How many of these structures are you > expecting to allocate? > > -- > Alexandre Julliard > julliard(a)winehq.org It's not that it's really relevant (patch was really minor), but the original used two BOOLs and then I had to add a UCHAR (next patch, this was split from), each of which would have 3 bytes of padding (and more on x86_64 later, when I'll have to add more fields), which just seems a bit wasteful for the cache and a bit inelegant to me. I mean it's a trivial change anyway, it's not like it makes the code itself worse off, IMO. :-)

Sept. 27, 2018

Re: [PATCH v3 4/6] shell32/autocomplete: Re-arrange some fields for better packing

by Alexandre Julliard

Gabriel Ivăncescu <gabrielopcode(a)gmail.com> writes: > Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> > --- > > v3: Use bitfield for future expansion. > > dlls/shell32/autocomplete.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Why is packing relevant at all? How many of these structures are you expecting to allocate? -- Alexandre Julliard julliard(a)winehq.org

Sept. 27, 2018

Re: [PATCH v3 6/6] shell32/autocomplete: Hide the auto-suggest listbox when ESC is pressed

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 27, 2018

Re: [PATCH v3 5/6] shell32/autocomplete: Fix handling of Return key when an auto-suggestion item is selected

by Huw Davies

This isn't particularly pretty, but I don't see another way. Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 27, 2018

Re: [PATCH v3 4/6] shell32/autocomplete: Re-arrange some fields for better packing

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 27, 2018

Re: [PATCH v3 3/6] shell32/autocomplete: Implement PageDown and PageUp for the auto-suggest listbox

by Huw Davies

Thanks for making this a helper function. Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 27, 2018

Re: [PATCH v3 2/6] shell32/autocomplete: Don't auto-append unless the caret is at the end

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 27, 2018