September 2018 - Wine-Devel

Re: [PATCH 1/2] msvcrt: Use isnan instead of isnanf

by Piotr Caban

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>

Sept. 26, 2018

[PATCH] server: copy_context(): Copy only valid information from source context.

by Joachim Priesner

A thread's context may be incomplete. For example, the i386 RtlCaptureContext() function does not save floating-point registers, setting the context's flags accordingly. Signed-off-by: Joachim Priesner <joachim.priesner(a)web.de> --- I'd like some feedback on whether this patch goes in the right direction. In particular, it breaks the functionality introduced in 03d31ea8 ("Only update the modified parts of the context on thread suspend") because the flags field is now used both to state what part of the context is valid and what part has changed. I found the issue when a program that manually raised an exception using RaiseException() was run under winedbg. The copy_context() invocation copied the zeroed-out floating point status from the suspended thread's context and set the SERVER_CTX_FLOATING_POINT flag. When winedbg wrote back the context after handling the exception, it overwrote the floating-point registers with zeroes. --- server/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/thread.c b/server/thread.c index 2cf5054738..dfd2f61104 100644 --- a/server/thread.c +++ b/server/thread.c @@ -1129,6 +1129,7 @@ void kill_thread( struct thread *thread, int violent_death ) static void copy_context( context_t *to, const context_t *from, unsigned int flags ) { assert( to->cpu == from->cpu ); + flags &= from->flags; to->flags |= flags; if (flags & SERVER_CTX_CONTROL) to->ctl = from->ctl; if (flags & SERVER_CTX_INTEGER) to->integer = from->integer; @@ -1754,7 +1755,6 @@ DECL_HANDLER(set_suspend_context) else if ((current->suspend_context = mem_alloc( sizeof(context_t) ))) { memcpy( current->suspend_context, get_req_data(), sizeof(context_t) ); - current->suspend_context->flags = 0; /* to keep track of what is modified */ current->context = current->suspend_context; if (current->debug_break) break_thread( current ); } -- 2.19.0

Sept. 26, 2018

Re: [v2 PATCH 1/4] d2d1: Add ID2D1Effect stub.

by Henri Verbeet

On 26 September 2018 at 04:04, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +void d2d_effect_init(struct d2d_effect *effect) > +{ > + effect->ID2D1Effect_iface.lpVtbl = &d2d_effect_vtbl; > + effect->refcount = 1; > +} > + > -- That's a whitespace error, but I think Alexandre's scripts will fix that up automatically.

Sept. 26, 2018

Re: [PATCH 3/4] d2d1: Implement SetTarget() for bitmap targets.

by Henri Verbeet

On 26 September 2018 at 21:18, Henri Verbeet <hverbeet(a)gmail.com> wrote: > I don't think you need a separate view field if you have a bitmap. I > think the rendertarget view should be stored in the d2d_bitmap > structure. I.e., the same way the shader resource view is part of that > structure. > Actually, related to that, I imagine SetTarget() should check that the bitmap has D2D1_BITMAP_OPTIONS_TARGET.

Sept. 26, 2018