September 2018 - Wine-Devel

[PATCH 1/4] d3d10core/tests: Add test for staging buffers.

by Józef Kucia

Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- dlls/d3d10core/tests/d3d10core.c | 64 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index 11eede764bc5..c41a4eb6603c 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -17223,6 +17223,69 @@ static void test_depth_clip(void) release_test_context(&test_context); } +static void test_staging_buffers(void) +{ + struct d3d10core_test_context test_context; + ID3D10Buffer *dst_buffer, *src_buffer; + D3D10_SUBRESOURCE_DATA resource_data; + D3D10_BUFFER_DESC buffer_desc; + struct resource_readback rb; + float data[16], value; + ID3D10Device *device; + unsigned int i; + HRESULT hr; + + if (!init_test_context(&test_context)) + return; + device = test_context.device; + + buffer_desc.ByteWidth = sizeof(data); + buffer_desc.Usage = D3D10_USAGE_STAGING; + buffer_desc.BindFlags = 0; + buffer_desc.CPUAccessFlags = D3D10_CPU_ACCESS_WRITE; + buffer_desc.MiscFlags = 0; + + for (i = 0; i < ARRAY_SIZE(data); ++i) + data[i] = i; + resource_data.pSysMem = data; + resource_data.SysMemPitch = 0; + resource_data.SysMemSlicePitch = 0; + + hr = ID3D10Device_CreateBuffer(device, &buffer_desc, &resource_data, &src_buffer); + ok(hr == S_OK, "Failed to create buffer, hr %#x.\n", hr); + + buffer_desc.Usage = D3D10_USAGE_DEFAULT; + buffer_desc.BindFlags = D3D10_BIND_CONSTANT_BUFFER; + buffer_desc.CPUAccessFlags = 0; + hr = ID3D10Device_CreateBuffer(device, &buffer_desc, NULL, &dst_buffer); + ok(hr == S_OK, "Failed to create buffer, hr %#x.\n", hr); + + ID3D10Device_CopyResource(device, (ID3D10Resource *)dst_buffer, (ID3D10Resource *)src_buffer); + get_buffer_readback(dst_buffer, &rb); + for (i = 0; i < ARRAY_SIZE(data); ++i) + { + value = get_readback_float(&rb, i, 0); + ok(value == data[i], "Got unexpected value %.8e at %u.\n", value, i); + } + release_resource_readback(&rb); + + for (i = 0; i < ARRAY_SIZE(data); ++i) + data[i] = 2 * i; + ID3D10Device_UpdateSubresource(device, (ID3D10Resource *)src_buffer, 0, NULL, data, 0, 0); + ID3D10Device_CopyResource(device, (ID3D10Resource *)dst_buffer, (ID3D10Resource *)src_buffer); + get_buffer_readback(dst_buffer, &rb); + for (i = 0; i < ARRAY_SIZE(data); ++i) + { + value = get_readback_float(&rb, i, 0); + ok(value == i, "Got unexpected value %.8e at %u.\n", value, i); + } + release_resource_readback(&rb); + + ID3D10Buffer_Release(dst_buffer); + ID3D10Buffer_Release(src_buffer); + release_test_context(&test_context); +} + START_TEST(d3d10core) { unsigned int argc, i; @@ -17331,6 +17394,7 @@ START_TEST(d3d10core) queue_test(test_multiple_viewports); queue_test(test_multisample_resolve); queue_test(test_depth_clip); + queue_test(test_staging_buffers); run_queued_tests(); -- 2.16.4

Sept. 26, 2018

Re: [PATCH v2 6/8] shell32/autocomplete: Re-arrange some fields for better packing

by Huw Davies

On Tue, Sep 25, 2018 at 02:55:32PM +0300, Gabriel Ivăncescu wrote: > Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> > --- > > Minor patch split from the next patch in the series from where it helps > more. options field only really helps slightly with x86_64 to reduce > padding bytes. > > dlls/shell32/autocomplete.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c > index 05648c7..b3a6808 100644 > --- a/dlls/shell32/autocomplete.c > +++ b/dlls/shell32/autocomplete.c > @@ -67,8 +67,9 @@ typedef struct > IAutoComplete2 IAutoComplete2_iface; > IAutoCompleteDropDown IAutoCompleteDropDown_iface; > LONG ref; > - BOOL initialized; > - BOOL enabled; > + BOOLEAN initialized; > + BOOLEAN enabled; > + AUTOCOMPLETEOPTIONS options; > HWND hwndEdit; > HWND hwndListBox; > WNDPROC wpOrigEditProc; > @@ -76,7 +77,6 @@ typedef struct > WCHAR *txtbackup; > WCHAR *quickComplete; > IEnumString *enumstr; > - AUTOCOMPLETEOPTIONS options; > } IAutoCompleteImpl; I doubt all of this micro-optimization is really worth it (but please let's not get into a debate about it). If you're going to do this stuff then using a bitfield for initialized and enabled is probably what you want to do. Huw.

Sept. 26, 2018

Re: [PATCH v2 3/8] shell32/autocomplete: Use the same font for the AutoComplete listbox as the edit control

by Huw Davies

On Wed, Sep 26, 2018 at 02:42:20PM +0300, Gabriel Ivăncescu wrote: > On Wed, Sep 26, 2018 at 2:37 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > > > Is there any reason you can't use SendMessage here? > > > > I don't remember. I think I wanted to get it despite an application > subclassing the edit control, but it's more likely I just forgot to > rebase this after the previous patch where I had replaced the > SendMessage and i missed it. In either case if you think SendMessage > is better, then I'll adjust it. Yes, please use SendMessage. Huw.

Sept. 26, 2018

Re: [PATCH v2 3/8] shell32/autocomplete: Use the same font for the AutoComplete listbox as the edit control

by Gabriel Ivăncescu

On Wed, Sep 26, 2018 at 2:37 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > Is there any reason you can't use SendMessage here? > I don't remember. I think I wanted to get it despite an application subclassing the edit control, but it's more likely I just forgot to rebase this after the previous patch where I had replaced the SendMessage and i missed it. In either case if you think SendMessage is better, then I'll adjust it.

Sept. 26, 2018

Re: [PATCH v2 3/8] shell32/autocomplete: Use the same font for the AutoComplete listbox as the edit control

by Huw Davies

On Tue, Sep 25, 2018 at 02:55:29PM +0300, Gabriel Ivăncescu wrote: > Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> > --- > > This looks much nicer and less out of place. > > dlls/shell32/autocomplete.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c > index fe5bba2..a681655 100644 > --- a/dlls/shell32/autocomplete.c > +++ b/dlls/shell32/autocomplete.c > @@ -384,6 +384,10 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, > ret = CallWindowProcW(This->wpOrigEditProc, hwnd, uMsg, wParam, lParam); > autocomplete_text(This, hwnd, autoappend_flag_yes); > return ret; > + case WM_SETFONT: > + if (This->hwndListBox) > + SendMessageW(This->hwndListBox, WM_SETFONT, wParam, lParam); > + break; > case WM_DESTROY: > { > WNDPROC proc = This->wpOrigEditProc; > @@ -434,9 +438,16 @@ static void create_listbox(IAutoCompleteImpl *This) > 0, 0, 0, 0, GetParent(This->hwndEdit), NULL, shell32_hInstance, NULL); > > if (This->hwndListBox) { > + HFONT edit_font; > + > This->wpOrigLBoxProc = (WNDPROC) SetWindowLongPtrW( This->hwndListBox, GWLP_WNDPROC, (LONG_PTR) ACLBoxSubclassProc); > SetWindowLongPtrW( This->hwndListBox, GWLP_USERDATA, (LONG_PTR)This); > SetParent(This->hwndListBox, HWND_DESKTOP); > + > + /* Use the same font as the edit control, as it gets destroyed before it anyway */ > + edit_font = (HFONT)CallWindowProcW(This->wpOrigEditProc, This->hwndEdit, WM_GETFONT, 0, 0); Is there any reason you can't use SendMessage here? > + if (edit_font) > + SendMessageW(This->hwndListBox, WM_SETFONT, (WPARAM)edit_font, FALSE); > }

Sept. 26, 2018

Re: [PATCH v2 2/8] shell32/autocomplete: Use 0 instead of CW_USEDEFAULT

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 26, 2018

Re: [PATCH v2 1/8] shell32/autocomplete: Remove flicker while redrawing the AutoComplete listbox

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 26, 2018

Re: [PATCH 2/2] msi: Allow recursive changes to the target folder path.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=42525 Your paranoid android. === w7u (32 bit Windows report) === msi: msi: Timeout

Sept. 26, 2018

Re: [PATCH 1/2] msi/tests: Drop workarounds for Windows 2000.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=42524 Your paranoid android. === wvistau64_he (32 bit Windows report) === msi: action: Timeout === w7u (32 bit Windows report) === msi: action: Timeout === w2003std (32 bit Windows report) === msi: install.c:2820: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:2495: Test failed: File not installed install.c:2496: Test failed: Directory not created install.c:2497: Test failed: File not installed install.c:2498: Test failed: Directory not created install.c:2499: Test failed: File not installed install.c:2500: Test failed: Directory not created install.c:2501: Test failed: File not installed install.c:2502: Test failed: Directory not created install.c:2503: Test failed: File not installed install.c:2504: Test failed: File not installed install.c:2505: Test failed: Directory not created install.c:2831: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:2495: Test failed: File not installed install.c:2496: Test failed: Directory not created install.c:2497: Test failed: File not installed install.c:2498: Test failed: Directory not created install.c:2499: Test failed: File not installed install.c:2500: Test failed: Directory not created install.c:2501: Test failed: File not installed install.c:2502: Test failed: Directory not created install.c:2503: Test failed: File not installed install.c:2504: Test failed: File not installed install.c:2505: Test failed: Directory not created install.c:2842: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:2495: Test failed: File not installed install.c:2496: Test failed: Directory not created install.c:2497: Test failed: File not installed install.c:2498: Test failed: Directory not created install.c:2499: Test failed: File not installed install.c:2500: Test failed: Directory not created install.c:2501: Test failed: File not installed install.c:2502: Test failed: Directory not created install.c:2503: Test failed: File not installed install.c:2504: Test failed: File not installed install.c:2505: Test failed: Directory not created install.c:2853: Test failed: Expected ERROR_SUCCESS, got 1603 install.c:2495: Test failed: File not installed install.c:2496: Test failed: Directory not created install.c:2497: Test failed: File not installed install.c:2498: Test failed: Directory not created install.c:2499: Test failed: File not installed install.c:2500: Test failed: Directory not created install.c:2501: Test failed: File not installed install.c:2502: Test failed: Directory not created install.c:2503: Test failed: File not installed install.c:2504: Test failed: File not installed install.c:2505: Test failed: Directory not created === w7u (32 bit Windows report) === msi: install: Timeout === w7u (task log) === Task errors: The task timed out === w7u (32 bit Windows report) === msi: msi: Timeout === w2003std (32 bit Windows report) === msi: 06ac:package: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit Windows report) === msi: 0870:package: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit Windows report) === msi: 0874:package: unhandled exception c0000005 at 0000000000000000

Sept. 26, 2018

[PATCH v5 4/4] msftedit: Add tests for interfaces.

by Jactry Zeng

Superseded patch 151802. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> --- configure | 1 + configure.ac | 1 + dlls/msftedit/tests/Makefile.in | 5 + dlls/msftedit/tests/richole.c | 197 ++++++++++++++++++++++++++++++++ 4 files changed, 204 insertions(+) create mode 100644 dlls/msftedit/tests/Makefile.in create mode 100644 dlls/msftedit/tests/richole.c diff --git a/configure b/configure index 657ff9ae83..dbdf5d0499 100755 --- a/configure +++ b/configure @@ -19595,6 +19595,7 @@ wine_fn_config_makefile dlls/msdmo enable_msdmo wine_fn_config_makefile dlls/msdmo/tests enable_tests wine_fn_config_makefile dlls/msdrm enable_msdrm wine_fn_config_makefile dlls/msftedit enable_msftedit +wine_fn_config_makefile dlls/msftedit/tests enable_tests wine_fn_config_makefile dlls/msg711.acm enable_msg711_acm wine_fn_config_makefile dlls/msgsm32.acm enable_msgsm32_acm wine_fn_config_makefile dlls/mshtml.tlb enable_mshtml_tlb diff --git a/configure.ac b/configure.ac index 6936a71b6f..0566cfd30c 100644 --- a/configure.ac +++ b/configure.ac @@ -3451,6 +3451,7 @@ WINE_CONFIG_MAKEFILE(dlls/msdmo) WINE_CONFIG_MAKEFILE(dlls/msdmo/tests) WINE_CONFIG_MAKEFILE(dlls/msdrm) WINE_CONFIG_MAKEFILE(dlls/msftedit) +WINE_CONFIG_MAKEFILE(dlls/msftedit/tests) WINE_CONFIG_MAKEFILE(dlls/msg711.acm) WINE_CONFIG_MAKEFILE(dlls/msgsm32.acm) WINE_CONFIG_MAKEFILE(dlls/mshtml.tlb) diff --git a/dlls/msftedit/tests/Makefile.in b/dlls/msftedit/tests/Makefile.in new file mode 100644 index 0000000000..99cc46a007 --- /dev/null +++ b/dlls/msftedit/tests/Makefile.in @@ -0,0 +1,5 @@ +TESTDLL = msftedit.dll +IMPORTS = ole32 oleaut32 user32 + +C_SRCS = \ + richole.c diff --git a/dlls/msftedit/tests/richole.c b/dlls/msftedit/tests/richole.c new file mode 100644 index 0000000000..1d336f1099 --- /dev/null +++ b/dlls/msftedit/tests/richole.c @@ -0,0 +1,197 @@ +/* + * Tests for IRichEditOle and friends. + * + * Copyright 2008 Google (Dan Hipschman) + * Copyright 2018 Jactry Zeng for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define COBJMACROS + +#include <stdarg.h> + +#include <windef.h> +#include <winbase.h> +#include <initguid.h> +#include <ole2.h> +#include <richedit.h> +#include <richole.h> +#include <tom.h> +#include <wine/test.h> + +static HMODULE msftedit_hmodule; + +#define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__) +static void _expect_ref(IUnknown* obj, ULONG ref, int line) +{ + ULONG rc; + IUnknown_AddRef(obj); + rc = IUnknown_Release(obj); + ok_(__FILE__,line)(rc == ref, "expected refcount %d, got %d.\n", ref, rc); +} + +static HWND new_window(LPCWSTR classname, DWORD dwstyle, HWND parent) +{ + HWND hwnd = CreateWindowW(classname, NULL, + dwstyle | WS_POPUP | WS_HSCROLL | WS_VSCROLL | WS_VISIBLE, + 0, 0, 200, 60, parent, NULL, msftedit_hmodule, NULL); + ok(hwnd != NULL, "class: %s, error: %d.\n", wine_dbgstr_w(classname), (int) GetLastError()); + return hwnd; +} + +static void test_Interfaces(void) +{ + IRichEditOle *reole = NULL, *reole1 = NULL; + ITextDocument *txtdoc = NULL; + ITextDocument2Old *txtdoc2old = NULL; + ITextDocument2 *txtdoc2 = NULL; + ITextSelection *txtsel = NULL, *txtsel2; + IUnknown *punk; + HRESULT hres; + LRESULT res; + HWND hwnd; + ULONG refcount; + + hwnd = new_window(MSFTEDIT_CLASS, ES_MULTILINE, NULL); + if (!hwnd) + { + skip("Couldn't create window.\n"); + return; + } + + res = SendMessageA(hwnd, EM_GETOLEINTERFACE, 0, (LPARAM)&reole); + ok(res, "SendMessage\n"); + ok(reole != NULL, "EM_GETOLEINTERFACE\n"); + EXPECT_REF(reole, 2); + + res = SendMessageA(hwnd, EM_GETOLEINTERFACE, 0, (LPARAM)&reole1); + ok(res == 1, "SendMessage\n"); + ok(reole1 == reole, "Should not return a new IRichEditOle interface.\n"); + EXPECT_REF(reole, 3); + + hres = IRichEditOle_QueryInterface(reole, &IID_ITextDocument, (void **)&txtdoc); + ok(hres == S_OK, "IRichEditOle_QueryInterface failed: 0x%08x.\n", hres); + ok(txtdoc != NULL, "IRichEditOle_QueryInterface\n"); + + hres = ITextDocument_GetSelection(txtdoc, NULL); + ok(hres == E_INVALIDARG, "ITextDocument_GetSelection: 0x%08x.\n", hres); + + EXPECT_REF(txtdoc, 4); + + hres = ITextDocument_GetSelection(txtdoc, &txtsel); + ok(hres == S_OK, "ITextDocument_GetSelection failed 0x%08x.\n", hres); + + EXPECT_REF(txtdoc, 4); + EXPECT_REF(txtsel, 2); + + hres = ITextDocument_GetSelection(txtdoc, &txtsel2); + ok(hres == S_OK, "ITextDocument_GetSelection failed: 0x%08x.\n", hres); + ok(txtsel2 == txtsel, "got %p, %p\n", txtsel, txtsel2); + + EXPECT_REF(txtdoc, 4); + EXPECT_REF(txtsel, 3); + + ITextSelection_Release(txtsel2); + + punk = NULL; + hres = ITextSelection_QueryInterface(txtsel, &IID_ITextSelection, (void **)&punk); + ok(hres == S_OK, "ITextSelection_QueryInterface failed: 0x%08x.\n", hres); + ok(punk != NULL, "ITextSelection_QueryInterface\n"); + IUnknown_Release(punk); + + punk = NULL; + hres = ITextSelection_QueryInterface(txtsel, &IID_ITextRange, (void **)&punk); + ok(hres == S_OK, "ITextSelection_QueryInterface failed: 0x%08x.\n", hres); + ok(punk != NULL, "ITextSelection_QueryInterface\n"); + IUnknown_Release(punk); + + punk = NULL; + hres = ITextSelection_QueryInterface(txtsel, &IID_IDispatch, (void **)&punk); + ok(hres == S_OK, "ITextSelection_QueryInterface failed: 0x%08x.\n", hres); + ok(punk != NULL, "ITextSelection_QueryInterface\n"); + IUnknown_Release(punk); + + punk = NULL; + hres = IRichEditOle_QueryInterface(reole, &IID_IOleClientSite, (void **)&punk); + ok(hres == E_NOINTERFACE, "IRichEditOle_QueryInterface: 0x%08x.\n", hres); + + punk = NULL; + hres = IRichEditOle_QueryInterface(reole, &IID_IOleWindow, (void **)&punk); + ok(hres == E_NOINTERFACE, "IRichEditOle_QueryInterface: 0x%08x.\n", hres); + + punk = NULL; + hres = IRichEditOle_QueryInterface(reole, &IID_IOleInPlaceSite, (void **)&punk); + ok(hres == E_NOINTERFACE, "IRichEditOle_QueryInterface: 0x%08x.\n", hres); + + /* ITextDocument2 is implemented on msftedit after win8 for superseding ITextDocument2Old */ + hres = IRichEditOle_QueryInterface(reole, &IID_ITextDocument2, (void **)&txtdoc2); + ok(hres == S_OK || + hres == E_NOINTERFACE /* before win8 */, "IRichEditOle_QueryInterface: 0x%08x.\n", hres); + if (hres != E_NOINTERFACE) + { + ok(txtdoc2 != NULL, "IRichEditOle_QueryInterface\n"); + ok((ITextDocument *)txtdoc2 == txtdoc, "Interface pointer isn't equal.\n"); + EXPECT_REF(txtdoc2, 5); + EXPECT_REF(reole, 5); + + hres = ITextDocument2_QueryInterface(txtdoc2, &IID_ITextDocument2Old, (void **)&txtdoc2old); + ok(hres == S_OK, "ITextDocument2_QueryInterface failed: 0x%08x.\n", hres); + EXPECT_REF(txtdoc2, 5); + EXPECT_REF(reole, 5); + EXPECT_REF(txtdoc2old, 1); + ITextDocument2Old_Release(txtdoc2old); + ITextDocument2_Release(txtdoc2); + + hres = IRichEditOle_QueryInterface(reole, &IID_ITextDocument2Old, (void **)&txtdoc2old); + ok(hres == S_OK, "IRichEditOle_QueryInterface failed: 0x%08x.\n", hres); + ok(txtdoc2old != NULL, "IRichEditOle_QueryInterface\n"); + ok((ITextDocument *)txtdoc2old != txtdoc, "Interface pointer is equal.\n"); + EXPECT_REF(txtdoc2old, 1); + EXPECT_REF(reole, 4); + ITextDocument2Old_Release(txtdoc2old); + } + else + { + hres = IRichEditOle_QueryInterface(reole, &IID_ITextDocument2Old, (void **)&txtdoc2old); + ok(hres == S_OK, "IRichEditOle_QueryInterface failed: 0x%08x.\n", hres); + ok(txtdoc2old != NULL, "IRichEditOle_QueryInterface\n"); + ok((ITextDocument *)txtdoc2old == txtdoc, "Interface pointer is equal.\n"); + EXPECT_REF(txtdoc2old, 5); + EXPECT_REF(reole, 5); + ITextDocument2Old_Release(txtdoc2old); + } + + ITextDocument_Release(txtdoc); + IRichEditOle_Release(reole); + refcount = IRichEditOle_Release(reole); + ok(refcount == 1, "Got wrong ref count: %d.\n", refcount); + DestroyWindow(hwnd); + + /* Methods should return CO_E_RELEASED if the backing document has + been released. One test should suffice. */ + hres = ITextSelection_CanEdit(txtsel, NULL); + ok(hres == CO_E_RELEASED, "ITextSelection after ITextDocument destroyed\n"); + + ITextSelection_Release(txtsel); +} + +START_TEST(richole) +{ + msftedit_hmodule = LoadLibraryA("msftedit.dll"); + ok(msftedit_hmodule != NULL, "error: %d\n", (int) GetLastError()); + + test_Interfaces(); +} -- 2.19.0

Sept. 26, 2018