September 2018 - Wine-Devel

Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters

by Huw Davies

On Fri, Sep 21, 2018 at 02:39:12PM +0300, Gabriel Ivăncescu wrote: > On Fri, Sep 21, 2018 at 2:32 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > > > How many exceptions (to iscntrlW()) do you actually need? > > > > Huw. > > Well Backspace for sure, maybe Tab (if it's inserted in an edit > control, don't know if that's possible), same doubt about newlines > ('\n' and '\r') or "vertical tab" (are those valid in certain edit > controls?). > > I mean if anything '\b' has to be an exception, at the very least. The > rest can be ignored I guess, if you want to simplify this to just one > check for '\b' instead. Should I just check for backspace? Doesn't sound like it would be too hard to test (just send some WM_CHARs to the edit). Huw.

Sept. 21, 2018

Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters

by Gabriel Ivăncescu

On Fri, Sep 21, 2018 at 2:32 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > How many exceptions (to iscntrlW()) do you actually need? > > Huw. Well Backspace for sure, maybe Tab (if it's inserted in an edit control, don't know if that's possible), same doubt about newlines ('\n' and '\r') or "vertical tab" (are those valid in certain edit controls?). I mean if anything '\b' has to be an exception, at the very least. The rest can be ignored I guess, if you want to simplify this to just one check for '\b' instead. Should I just check for backspace?

Sept. 21, 2018

Re: [PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

by Huw Davies

On Fri, Sep 21, 2018 at 02:07:11PM +0300, Gabriel Ivăncescu wrote: > On Fri, Sep 21, 2018 at 1:55 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > > > Do you have an application that depends on this? If not, we should > > leave it as it is. > > > > Huw. > > Not that I'm aware of, but I thought matching Windows is a good idea > here. I should probably still send it directly to the control though > since it reduces needless overhead (especially due to GetPropW), but > then the code can be simplified a bit if I don't have to special-case > the WM_GETTEXT. The other hijack case needs to remain else I can't add > WM_SETTEXT to the messages handled later since it would result in a > recursive loop. > > That said, It's a single extra call (get_edit_proc here), I don't > think it's so bad to keep it like this since it's still better > (behavior & overhead). Well firstly, I very much doubt the overhead is going to be relevant for a user input driven auto-complete. We don't necessarily want to copy Windows' implementation exactly--- indeed if it's possible we try to avoid that. As long as apps don't notice the difference it's fine. Just make the changes that you need to add WM_SETTEXT. Huw.

Sept. 21, 2018

Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters

by Huw Davies

On Fri, Sep 21, 2018 at 02:05:33PM +0300, Gabriel Ivăncescu wrote: > On Fri, Sep 21, 2018 at 1:45 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > > > Yes, I think iscntrlW() would be better. > > > > Huw. > > Something like this? > > iscntrlW(wParam) && !(wParam >= '\b' && wParam <= '\r') > > Or do you have other exceptions in mind? How many exceptions (to iscntrlW()) do you actually need? Huw.

Sept. 21, 2018

Re: [PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

by Gabriel Ivăncescu

On Fri, Sep 21, 2018 at 1:55 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > Do you have an application that depends on this? If not, we should > leave it as it is. > > Huw. Not that I'm aware of, but I thought matching Windows is a good idea here. I should probably still send it directly to the control though since it reduces needless overhead (especially due to GetPropW), but then the code can be simplified a bit if I don't have to special-case the WM_GETTEXT. The other hijack case needs to remain else I can't add WM_SETTEXT to the messages handled later since it would result in a recursive loop. That said, It's a single extra call (get_edit_proc here), I don't think it's so bad to keep it like this since it's still better (behavior & overhead).

Sept. 21, 2018

Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters

by Gabriel Ivăncescu

On Fri, Sep 21, 2018 at 1:45 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > Yes, I think iscntrlW() would be better. > > Huw. Something like this? iscntrlW(wParam) && !(wParam >= '\b' && wParam <= '\r') Or do you have other exceptions in mind?

Sept. 21, 2018

Re: [PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

by Huw Davies

On Thu, Sep 20, 2018 at 02:55:38PM +0300, Gabriel Ivăncescu wrote: > Send the messages directly to the edit control's window procedure to match > Windows behavior and reduce needless overhead. However, it appears that > Windows allows hijacking WM_GETTEXT and WM_GETTEXTLENGTH for autocompletion, > so handle that case separately. Do you have an application that depends on this? If not, we should leave it as it is. Huw.

Sept. 21, 2018

Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters

by Huw Davies

On Thu, Sep 20, 2018 at 06:54:28PM +0300, Gabriel Ivăncescu wrote: > On Thu, Sep 20, 2018 at 3:51 PM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > Maybe filter with iscntrlW() with exceptions? > > > Do you think it's a better approach with iscntrlW? (and keep the range > between \b and \r then as the exceptions?). Unfortunately it would > still look like a semi-hack due to the exceptions which are needed, at > least for backspace and maybe tab. Not sure if it's better honestly. Yes, I think iscntrlW() would be better. Huw.

Sept. 21, 2018

Re: [PATCH v2 3/8] shell32/autocomplete: Forward to the edit control outside of the switch to simplify the code

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 21, 2018

Re: [PATCH v2 2/8] shell32/autocomplete: Handle more messages for autocompletion

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 21, 2018