September 2018 - Wine-Devel

Re: [PATCH v3 2/3] comdlg32: Check invalid options in IFileDialog::SetOptions.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

Sept. 18, 2018

Re: [PATCH v3 1/3] comdlg32/tests: Fix crashes.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

Sept. 18, 2018

Re: [v2 PATCH 1/3] d2d1: Update to ID2D1BitmapBrush1.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 18, 2018

Re: [PATCH 3/3] include: Add ID2D1Effect definition.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 18, 2018

Re: [PATCH 2/3] d2d1: Implement newer CreateBitmapBrush() variant.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 18, 2018

Re: [PATCH] wininet/tests: Don't check certificate when secure flag is not set

by Jacek Caban

Hi André, On 09/18/2018 02:09 PM, André Hentschel wrote: > On 17.09.2018 16:55, Jacek Caban wrote: >> Hi André, >> >> On 09/15/2018 02:47 PM, André Hentschel wrote: >>> Signed-off-by: André Hentschel <nerv(a)dawncrow.de> >>> --- >>> dlls/wininet/tests/http.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c >>> index ace8512399..8bc06b9166 100644 >>> --- a/dlls/wininet/tests/http.c >>> +++ b/dlls/wininet/tests/http.c >>> @@ -6025,7 +6025,8 @@ static void test_secure_connection(void) >>> ok(ret, "InternetQueryOption failed: %d\n", GetLastError()); >>> ok(flags & SECURITY_FLAG_SECURE, "expected secure flag to be >>> set\n"); >>> - test_cert_struct(req, &test_winehq_org_cert); >>> + if (flags & SECURITY_FLAG_SECURE) >>> + test_cert_struct(req, &test_winehq_org_cert); >> >> What do you want to achieve with this patch? Note that we test the flag >> just before test_cert_struct call, so tests will fail with your patch >> anyway. >> >> Jacek >> > > Hi Jacek, > > I should have mentioned that it's supposed to fix the crash in newer > win10 versions: > https://test.winehq.org/data/8a985174ebc1b041d9a4f1abbdc184fe692d25bf/index… > Still, there will be failures, so it's not much better. Ideally we'd find why it fails. Those are not testbot machines, so it's hard to experiment with them... I can see a value in avoiding the crash. This way we'd see how other https-related tests behave and maybe have more information that would help us find the actual problem. For that, however, I'd suggest to return early from test_cert_struct when InternetQueryOptionA fails. Thanks, Jacek

Sept. 18, 2018

Re: [PATCH v7 4/7] shell32/autocomplete: Avoid another buffer overflow and handle arbitrary sizes for the auto-append string

by Huw Davies

On Mon, Sep 17, 2018 at 10:23:12PM +0300, Gabriel Ivăncescu wrote: > The previous code caps the auto-append text at 255 characters, which can be > easily exploited. It's also less efficient as it scans the string multiple > times. Thia and the other patches in the series look ok. Please resend after [1] and [2] have been committed with a fixed up version of [3]. Huw.

Sept. 18, 2018

Re: [PATCH v7 3/7] shell32/autocomplete: Don't auto-append on control characters, except for ^V (paste)

by Huw Davies

On Mon, Sep 17, 2018 at 10:23:11PM +0300, Gabriel Ivăncescu wrote: > We must not auto-append on control characters, most notably Backspace, but > also ^X (cut) and so on. An exception is ^V, which auto-appends on Windows, > so this is needed to match Windows behavior (also needed when receiving > the ^V message directly). > > Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> > --- > dlls/shell32/autocomplete.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c > index 183b37b..429b4fb 100644 > --- a/dlls/shell32/autocomplete.c > +++ b/dlls/shell32/autocomplete.c > @@ -343,7 +343,8 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, > case WM_CHAR: > case WM_UNICHAR: > ret = CallWindowProcW(This->wpOrigEditProc, hwnd, uMsg, wParam, lParam); > - autocomplete_text(This, hwnd, (This->options & ACO_AUTOAPPEND) > + autocomplete_text(This, hwnd, (This->options & ACO_AUTOAPPEND) && > + (wParam >= ' ' || wParam == 0x16 /* ^V (paste) */) > ? autoappend_flag_yes : autoappend_flag_no); Let's leave the ^V out of this.

Sept. 18, 2018

Re: [PATCH v7 2/7] shell32/autocomplete: Redesign the window proc to trigger on key presses instead of key release

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 18, 2018

Re: [PATCH v7 1/7] shell32/autocomplete: Move the autocomplete processing and WM_KEYUP to separate functions

by Huw Davies

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

Sept. 18, 2018