September 2018 - Wine-Devel

Re: [PATCH] urlmon/uri: Implement IsEqual for external implementations.

by Jacek Caban

Hi Nikolay, On 09/17/2018 06:00 AM, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/opcservices/tests/opcservices.c | 3 +-- > dlls/urlmon/uri.c | 18 ++++++++++++++++-- > 2 files changed, 17 insertions(+), 4 deletions(-) It would be interesting to have some urlmon tests for that. While what you do seems reasonable, a test in opcservices is not convincing. For all I know, native opcservices may call urlmon in a different way (or not at all). Please add a custom IUri implementation inside urlmon tests pass that to IsEqual. Jacek

Sept. 17, 2018

Re: [PATCH] wininet/tests: Don't check certificate when secure flag is not set

by Jacek Caban

Hi André, On 09/15/2018 02:47 PM, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/wininet/tests/http.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index ace8512399..8bc06b9166 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -6025,7 +6025,8 @@ static void test_secure_connection(void) > ok(ret, "InternetQueryOption failed: %d\n", GetLastError()); > ok(flags & SECURITY_FLAG_SECURE, "expected secure flag to be set\n"); > > - test_cert_struct(req, &test_winehq_org_cert); > + if (flags & SECURITY_FLAG_SECURE) > + test_cert_struct(req, &test_winehq_org_cert); What do you want to achieve with this patch? Note that we test the flag just before test_cert_struct call, so tests will fail with your patch anyway. Jacek

Sept. 17, 2018

Re: [PATCH] windowscodecs: IWICMetadataQueryReader::GetMetadataByName() should accept NULL for returned value.

by Vincent Povirk

Due to health problems I'm not able to do a proper review, but this looks good to me.

Sept. 17, 2018

Re: [PATCH] mshtml: Make HTMLStyle_init_dispex_info() static.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

Sept. 17, 2018

Re: [PATCH 2/2] d3d11: Add D3D11On12CreateDevice() stub.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 17, 2018

Re: [v2 PATCH 1/4] d2d1: Implement GetSurface() for bitmaps.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 17, 2018

Re: [PATCH 2/4] include: Add ID2D1BitmapBrush1 definition.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 17, 2018

Re: [PATCH v6 2/6] shell32/autocomplete: Redesign the window proc to trigger on key presses instead of key release

by Gabriel Ivăncescu

On Mon, Sep 17, 2018 at 1:10 PM, Huw Davies <huw(a)codeweavers.com> wrote: > > The condition on flag setting is a hack. For paste you'll likely want > a WM_PASTE handler. If pasting didn't work before, then leave it for a > later patch, if it did work before this patch you'll have to add such > a handler before this one. > > Huw. Well it has to be done this way, because this doesn't handle WM_PASTE (which can also happen with e.g. right-click on edit control and choose Paste), but a straight CTRL+V message, which can be sent by applications like AutoHotkey. This hack is needed to match Windows behavior. Also the wParam >= ' ' is *very* needed to avoid control characters, *especially* backspace, otherwise you wouldn't be able to delete the last character with a backspace as it would immediately be auto-appended, it doesn't happen in Windows. Same thing with e.g. CTRL+X (Cut) sent via message directly, bypassing WM_CUT. (remember one of my previous band-aids had a hardcoded check for VK_BACK and VK_DELETE, I think handling all control characters is much more elegant and matches Windows, except for CTRL+V). I'm not sure I can get rid of this hack at all and still guarantee correct behavior. I can, of course, add it as an extra patch following it, and only handle ACO_AUTOAPPEND in this patch. Is that ok? I'll still need the hack though in the next patch in such case, unless you have some better method.

Sept. 17, 2018

Re: [PATCH 1/2] include: Add d3d11on12 header.

by Henri Verbeet

On 17 September 2018 at 14:50, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +typedef HRESULT (__stdcall *PFN_D3D11ON12_CREATE_DEVICE)(IUnknown *device, UINT FLAGS, "flags"?

Sept. 17, 2018

Re: [PATCH 3/4] d2d1: Update to ID2D1BitmapBrush1.

by Henri Verbeet

On 16 September 2018 at 20:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + switch (mode) > + { > + case D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR: > + case D2D1_BITMAP_INTERPOLATION_MODE_LINEAR: > + break; > + default: > + WARN("Unknown interpolation mode %#x.\n", mode); > + return; > + } We indent case labels in d2d1. > @@ -1242,7 +1300,7 @@ static void d2d_brush_bind_bitmap(struct d2d_brush *brush, ID3D10Device *device, > { > D3D10_SAMPLER_DESC sampler_desc; > > - if (brush->u.bitmap.interpolation_mode == D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR) > + if (brush->u.bitmap.interpolation_mode == D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR) > sampler_desc.Filter = D3D10_FILTER_MIN_MAG_MIP_POINT; > else > sampler_desc.Filter = D3D10_FILTER_MIN_MAG_MIP_LINEAR; I think it would be helpful to print a FIXME for unimplemented interpolation modes. Either here, or in SetInterpolationMode1(). > + ID2D1BitmapBrush1_SetInterpolationMode1(brush1, D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC); > + interpolation_mode = ID2D1BitmapBrush1_GetInterpolationMode(brush1); > + ok(interpolation_mode == D2D1_BITMAP_INTERPOLATION_MODE_LINEAR, > + "Unexpected interpolation mode %#x.\n", interpolation_mode); > + > + interpolation_mode1 = ID2D1BitmapBrush1_GetInterpolationMode1(brush1); > + ok(interpolation_mode1 == D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC, > + "Unexpected interpolation mode %#x.\n", interpolation_mode1); > + > + ID2D1BitmapBrush1_SetInterpolationMode1(brush1, 100); > + interpolation_mode1 = ID2D1BitmapBrush1_GetInterpolationMode1(brush1); > + ok(interpolation_mode1 == D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC, > + "Unexpected interpolation mode %#x.\n", interpolation_mode1); > + I think the choice of interpolation modes and ordering of these is a little unfortunate. It's not clear from the test whether "SetInterpolationMode1(..., 100);" is ignored as you'd expect, or clamped to D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC.

Sept. 17, 2018