September 2018 - Wine-Devel

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoRegisterDeviceInterface

by Zebediah Figura

On 14/09/18 13:59, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 216 ++++++++++++++++++++++++++++++++++++ > dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- > include/ddk/wdm.h | 1 + > 3 files changed, 218 insertions(+), 1 deletion(-) > > > > > Can this go directly through setupapi instead?

Sept. 14, 2018

[PATCH 2/2] hidclass.sys: use IoRegisterDeviceInterface

by Aric Stewart

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- dlls/hidclass.sys/device.c | 60 ++++++++++++++++------------------------------ dlls/hidclass.sys/hid.h | 2 +- dlls/hidclass.sys/pnp.c | 4 +--- 3 files changed, 22 insertions(+), 44 deletions(-)

Sept. 14, 2018

[PATCH 1/2] ntoskrnl.exe: Implement IoRegisterDeviceInterface

by Aric Stewart

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- dlls/ntoskrnl.exe/ntoskrnl.c | 216 ++++++++++++++++++++++++++++++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- include/ddk/wdm.h | 1 + 3 files changed, 218 insertions(+), 1 deletion(-)

Sept. 14, 2018

Re: [PATCH 1/2] d2d1: Implement GetSurface() for bitmaps.

by Nikolay Sivov

On 09/14/2018 07:02 PM, Henri Verbeet wrote: > On 14 September 2018 at 20:13, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: >> On 09/14/2018 06:15 PM, Henri Verbeet wrote: >>> This seems a little more complicated than it really needs to be. In >>> d2d_bitmap_GetSurface(), can't you just do something like the >>> following? >>> >>> ID3D10ShaderResourceView_GetResource(bitmap->view, &resource); >>> ID3D10Resource_QueryInterface(resource, &IID_IDXGISurface, &surface); >> Yes, that would be an alternative to separate surface pointer in bitmap >> structure. The problem is that this method is not supposed to always work. >> According to tests it only works for bitmaps created from DXGI target/device >> context. I can use some flag instead to indicate that if you think it's >> better. > Sure, you can just flag it on bitmap creation. It's perhaps > unfortunate that D2D1_BITMAP_OPTIONS doesn't have a flag for that. Yes, I don't think you can tell from options if it will work. > > I'm not necessarily opposed to storing the surface in struct > d2d_bitmap though, but in that case I think you should retrieve it > from the SRV in d2d_bitmap_init() as well, instead of doing that in > its callers. Right, I'll keep this field then, thanks for the suggestion.

Sept. 14, 2018

Re: [PATCH 1/2] d2d1: Implement GetSurface() for bitmaps.

by Henri Verbeet

On 14 September 2018 at 20:13, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 09/14/2018 06:15 PM, Henri Verbeet wrote: >> This seems a little more complicated than it really needs to be. In >> d2d_bitmap_GetSurface(), can't you just do something like the >> following? >> >> ID3D10ShaderResourceView_GetResource(bitmap->view, &resource); >> ID3D10Resource_QueryInterface(resource, &IID_IDXGISurface, &surface); > > Yes, that would be an alternative to separate surface pointer in bitmap > structure. The problem is that this method is not supposed to always work. > According to tests it only works for bitmaps created from DXGI target/device > context. I can use some flag instead to indicate that if you think it's > better. Sure, you can just flag it on bitmap creation. It's perhaps unfortunate that D2D1_BITMAP_OPTIONS doesn't have a flag for that. I'm not necessarily opposed to storing the surface in struct d2d_bitmap though, but in that case I think you should retrieve it from the SRV in d2d_bitmap_init() as well, instead of doing that in its callers.

Sept. 14, 2018

Re: [PATCH 1/2] d2d1: Implement GetSurface() for bitmaps.

by Nikolay Sivov

On 09/14/2018 06:15 PM, Henri Verbeet wrote: > On 14 September 2018 at 10:20, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: >> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> >> --- >> dlls/d2d1/bitmap.c | 69 ++++++++++++++++++++++++---------------- >> dlls/d2d1/d2d1_private.h | 12 +++++-- >> dlls/d2d1/device.c | 9 ++---- >> dlls/d2d1/tests/d2d1.c | 63 ++++++++++++++++++++---------------- >> 4 files changed, 90 insertions(+), 63 deletions(-) >> > This seems a little more complicated than it really needs to be. In > d2d_bitmap_GetSurface(), can't you just do something like the > following? > > ID3D10ShaderResourceView_GetResource(bitmap->view, &resource); > ID3D10Resource_QueryInterface(resource, &IID_IDXGISurface, &surface); Yes, that would be an alternative to separate surface pointer in bitmap structure. The problem is that this method is not supposed to always work. According to tests it only works for bitmaps created from DXGI target/device context. I can use some flag instead to indicate that if you think it's better.

Sept. 14, 2018

Re: [PATCH vkd3d] vkd3d: Do not hardcode aspect mask in d3d12_command_list_ClearUnorderedAccessViewUint().

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 14, 2018

[PATCH vkd3d] build: Fix the "missing widl" message.

by Henri Verbeet

I.e., print the name of the target instead of the prerequisite. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 3ee2f13..1fdc916 100644 --- a/Makefile.am +++ b/Makefile.am @@ -157,7 +157,7 @@ if HAVE_WIDL $(AM_V_at)$(SED) -e '/#include <rpc.h>/d' -e '/#include <rpcndr.h>/d' <$@.tmp >$@ $(AM_V_at)$(RM) $@.tmp else - @echo "widl is required to generate $<" + @echo "widl is required to generate $@" endif EXTRA_DIST += $(vkd3d_demos_shaders) -- 2.11.0

Sept. 14, 2018

Re: [PATCH 2/3] wined3d: Set WINED3DFMT_FLAG_COMPRESSED based on format block info.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 14, 2018

Re: [PATCH 1/3] wined3d: Use >= for shader model checks in feature_level_from_caps().

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Sept. 14, 2018