January 2019 - Wine-Devel - list.winehq.org

Re: [PATCH v8] mscoree: Allow loading of registration free .NET COM objects

by Vincent Povirk

> Sure, I don't mind. If you don't mind the question, how would you write it? + if (lstrlenW(ptr_name) + 1 > classname_size) + if (lstrlenW(filename) + lstrlenW(path) + ARRAY_SIZE(str_dll) + 1 > filename_size) Calculate required buffer size, compare to actual buffer size.

Jan. 31, 2019

Release 4.1

by Alexandre Julliard

Folks, Since I'm leaving for FOSDEM tomorrow, and since it's not quite two weeks since 4.0 was released, I'm planning to delay release 4.1 until Monday. See some of you in Brussels! -- Alexandre Julliard julliard(a)winehq.org

Jan. 31, 2019

Re: [PATCH] mshtml: Print the debug string and not the pointer to it

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

Jan. 31, 2019

[PATCH] shell32: Avoid FALSE : TRUE conditional expressions

by Michael Stefaniuc

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/shell32/autocomplete.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c index 90036e73fb..36b0c5d7bc 100644 --- a/dlls/shell32/autocomplete.c +++ b/dlls/shell32/autocomplete.c @@ -508,14 +508,14 @@ static BOOL display_matching_strs(IAutoCompleteImpl *ac, WCHAR *text, UINT len, /* Return FALSE if we need to hide the listbox */ WCHAR **str = ac->enum_strs; UINT start, end; - if (!str) return (ac->options & ACO_AUTOSUGGEST) ? FALSE : TRUE; + if (!str) return !(ac->options & ACO_AUTOSUGGEST); /* Windows seems to disable autoappend if ACO_NOPREFIXFILTERING is set */ if (!(ac->options & ACO_NOPREFIXFILTERING) && len) { start = find_matching_enum_str(ac, 0, text, len, pfx_filter, -1); if (start == ~0) - return (ac->options & ACO_AUTOSUGGEST) ? FALSE : TRUE; + return !(ac->options & ACO_AUTOSUGGEST); if (flag == autoappend_flag_yes) autoappend_str(ac, text, len, filter_str_prefix(str[start], pfx_filter), hwnd); -- 2.20.1

Jan. 31, 2019

[PATCH] mshtml: Print the debug string and not the pointer to it

by Michael Stefaniuc

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/mshtml/htmlevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index cab39d6f9d..9fa258c7c5 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -2121,7 +2121,7 @@ static HRESULT WINAPI DOMCustomEvent_initCustomEvent(IDOMCustomEvent *iface, BST DOMCustomEvent *This = impl_from_IDOMCustomEvent(iface); HRESULT hres; - TRACE("(%p)->(%s %x %x %p)\n", This, debugstr_w(type), can_bubble, cancelable, debugstr_variant(detail)); + TRACE("(%p)->(%s %x %x %s)\n", This, debugstr_w(type), can_bubble, cancelable, debugstr_variant(detail)); hres = IDOMEvent_initEvent(&This->event.IDOMEvent_iface, type, can_bubble, cancelable); if(FAILED(hres)) -- 2.20.1

Jan. 31, 2019

Re: [PATCH v8] mscoree: Allow loading of registration free .NET COM objects

by Fabian Maurer

Sure, I don't mind. If you don't mind the question, how would you write it? Regards, Fabian Maurer

Jan. 31, 2019

Re: [PATCH v8] mscoree: Allow loading of registration free .NET COM objects

by Vincent Povirk

I see my mistake, you used >= for the size check when I expected (and assumed) >. The size checks look correct to me now. The style is a little strange, though, with the code calculating the minimum size that would overrun the buffer, rather than required buffer size. I'd prefer it be changed for readability, if you don't mind.

Jan. 31, 2019

Re: [PATCH 3/4] gdiplus/tests: Add some tests for GdipInitializePalette.

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

Jan. 31, 2019

Re: [PATCH 2/4] gdiplus: Implement GdipInitializePalette.

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

Jan. 31, 2019

Re: [PATCH 1/4] windowscodecs: Implement IWICPalette::InitializeFromBitmap.

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>

Jan. 31, 2019