March 2019 - Wine-Devel - list.winehq.org

Wine staging 4.5 release

by Alistair Leslie-Hughes

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 4.5 (759 patches are applied to wine vanilla) NOTE: All FAudio patches has been reverted due to the lack of official package support. This will allow games that require XAudio2 support to still function. Upstreamed (Either directly from staging or fixed with a similar patch). * winex11: Forward all clipping requests to the right thread (including fullscreen clipping). * advapi32: Add RegLoadAppKeyA/RegLoadAppKeyW stubs * uianimation.idl: Add more interfaces * imagehlp: Implement ImageLoad and cleanup ImageUnload. * imagehlp/tests: Add tests for ImageLoad, ImageUnload, GetImageUnusedHeaderBytes. * msi: Always return MSIDBSTATE_ERROR when MsiGetDatabaseState is called from a custom action. * urlmon: Use unescaped Urls for FTP actions. * urlmon/tests: Add FTP encoded url test. * d3dx9_36/tests: Add initial tests for dummy skininfo interface. * imagehlp: Catch invalid memory access in CheckSumMappedFile and add tests. * imagehlp: Fix checksum calculation for odd sizes. * wintrust/tests: Add tests for WinVerifyTrust. * wintrust/tests: Add some additional tests. * kernel32: Allow empty profile section and key name strings. Added: * [46470] opencl: Add support for OpenCL 1.2. Updated: * wined3d-Indexed_Vertex_Blending * wined3d-SWVP-shaders * dinput-remap-joystick * ddraw-version-check * ddraw-Rendering_Targets Where can you help * Run Steam/Battle.net/UPlay. * Try you favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

March 31, 2019

[PATCH 2/2] po: Update French translation.

by Isira Seneviratne

March 30, 2019

[PATCH 1/2] po: Update Sinhala translation.

by Isira Seneviratne

March 30, 2019

[PATCH] uninstaller: Re-exec as 64-bit in wow64.

by Vincent Povirk

Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> --- programs/uninstaller/main.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/programs/uninstaller/main.c b/programs/uninstaller/main.c index 142d3d16f7..fa9a23c2d7 100644 --- a/programs/uninstaller/main.c +++ b/programs/uninstaller/main.c @@ -165,6 +165,31 @@ int wmain(int argc, WCHAR *argv[]) static const WCHAR listW[] = { '-','-','l','i','s','t',0 }; static const WCHAR removeW[] = { '-','-','r','e','m','o','v','e',0 }; int i = 1; + BOOL is_wow64; + + if (IsWow64Process( GetCurrentProcess(), &is_wow64 ) && is_wow64) + { + STARTUPINFOW si; + PROCESS_INFORMATION pi; + WCHAR filename[MAX_PATH]; + void *redir; + DWORD exit_code; + + memset( &si, 0, sizeof(si) ); + si.cb = sizeof(si); + GetModuleFileNameW( 0, filename, MAX_PATH ); + + Wow64DisableWow64FsRedirection( &redir ); + if (CreateProcessW( filename, GetCommandLineW(), NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi )) + { + WINE_TRACE( "restarting %s\n", wine_dbgstr_w(filename) ); + WaitForSingleObject( pi.hProcess, INFINITE ); + GetExitCodeProcess( pi.hProcess, &exit_code ); + ExitProcess( exit_code ); + } + else WINE_ERR( "failed to restart 64-bit %s, err %d\n", wine_dbgstr_w(filename), GetLastError() ); + Wow64RevertWow64FsRedirection( redir ); + } while( i<argc ) { -- 2.17.1

March 30, 2019

Re: TestBot job 50182 results: [PATCH 1/2] kernel32: Partially implement VirtualAllocExNuma

by Fabian Maurer

This is unrelated since I didn't touch the tests, or code that the tests used. PS: Still don't know why the PATCH is marked as OK on https:// source.winehq.org/patches/, when the testbot says it failed. Regards, Fabian Maurer > VM Status Failures Command > debian9 failed 2 > debian9 failed 2 > > You can also see the results at: > https://testbot.winehq.org/JobDetails.pl?Key=50182 > > > === debian9 (32 bit report) === > > kernel32: > Unhandled exception: page fault on write access to 0x00000000 in 32-bit code > (0x7ebcc85d). > > Report errors: > kernel32:virtual prints too much data (90431 bytes) > > === debian9 (32 bit Chinese:China report) === > > kernel32: > Unhandled exception: page fault on write access to 0x00000000 in 32-bit code > (0x7ebd785d). > > Report errors: > kernel32:virtual prints too much data (90431 bytes) > > === debian9 (32 bit WoW report) === > > kernel32: > Unhandled exception: page fault on write access to 0x00000000 in 32-bit code > (0x7ebcc85d). > > Report errors: > kernel32:virtual prints too much data (90502 bytes) > > === debian9 (64 bit WoW report) === > > kernel32: > Unhandled exception: page fault on write access to 0x00000000 in 64-bit code > (0x00007f9902d9e8a1). > > Report errors: > kernel32:virtual prints too much data (87157 bytes)

March 30, 2019

[PATCH 2/2] kernel32: Stub FindFirstStreamW/FindNextStreamW

by Fabian Maurer

Follow up to https://bugs.winehq.org/show_bug.cgi?id=46927 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/kernel32/file.c | 25 +++++++++++++++++++++++++ dlls/kernel32/kernel32.spec | 4 ++-- include/winbase.h | 6 ++++++ 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/file.c b/dlls/kernel32/file.c index 3214d724cb..3d18e48096 100644 --- a/dlls/kernel32/file.c +++ b/dlls/kernel32/file.c @@ -2349,6 +2349,31 @@ BOOL WINAPI FindNextFileA( HANDLE handle, WIN32_FIND_DATAA *data ) } +/************************************************************************** + * FindFirstStreamW (KERNEL32.@) + */ +HANDLE WINAPI FindFirstStreamW(LPCWSTR lpFileName, STREAM_INFO_LEVELS infoLevel, + LPVOID lpFindStreamData, DWORD dwFlags) +{ + FIXME("(%s, %d, %p, %x): stub!\n", debugstr_w(lpFileName), infoLevel, lpFindStreamData, dwFlags); + + SetLastError(ERROR_HANDLE_EOF); + return INVALID_HANDLE_VALUE; +} + + +/************************************************************************** + * FindNextStreamW (KERNEL32.@) + */ +BOOL WINAPI FindNextStreamW(HANDLE hFindStream, LPVOID lpFindStreamData) +{ + FIXME("(%p, %p): stub!\n", hFindStream, lpFindStreamData); + + SetLastError(ERROR_HANDLE_EOF); + return FALSE; +} + + /************************************************************************** * GetFileAttributesW (KERNEL32.@) */ diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 1cf7b58a02..ff0be6cf47 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -488,7 +488,7 @@ # @ stub FindFirstFileTransactedW @ stdcall FindFirstFileW(wstr ptr) # @ stub FindFirstStreamTransactedW -# @ stub FindFirstStreamW +@ stub FindFirstStreamW(str long ptr long) @ stdcall FindFirstVolumeA(ptr long) @ stdcall FindFirstVolumeMountPointA(str ptr long) @ stdcall FindFirstVolumeMountPointW(wstr ptr long) @@ -497,7 +497,7 @@ @ stdcall FindNextFileA(long ptr) # @ stub FindNextFileNameW @ stdcall FindNextFileW(long ptr) -# @ stub FindNextStreamW +@ stdcall FindNextStreamW(long ptr) @ stdcall FindNextVolumeA(long ptr long) @ stub FindNextVolumeMountPointA @ stub FindNextVolumeMountPointW diff --git a/include/winbase.h b/include/winbase.h index 20c73af319..e5377d43f5 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -1717,6 +1717,12 @@ typedef struct _UMS_SCHEDULER_STARTUP_INFO typedef enum _RTL_UMS_SCHEDULER_REASON UMS_SCHEDULER_REASON; typedef enum _RTL_UMS_THREAD_INFO_CLASS UMS_THREAD_INFO_CLASS, *PUMS_THREAD_INFO_CLASS; +typedef enum _STREAM_INFO_LEVELS +{ + FindStreamInfoStandard, + FindStreamInfoMaxInfoLevel +} STREAM_INFO_LEVELS; + WINBASEAPI BOOL WINAPI ActivateActCtx(HANDLE,ULONG_PTR *); WINADVAPI BOOL WINAPI AddAccessAllowedAce(PACL,DWORD,DWORD,PSID); WINADVAPI BOOL WINAPI AddAccessAllowedAceEx(PACL,DWORD,DWORD,DWORD,PSID); -- 2.21.0

March 30, 2019

[PATCH 1/2] kernel32: Partially implement VirtualAllocExNuma

by Fabian Maurer

Ignoring the preferred node should be good enough Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46927 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/kernel32/kernel32.spec | 2 +- dlls/kernel32/virtual.c | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index c8d52cec58..1cf7b58a02 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -1559,7 +1559,7 @@ @ stdcall VerifyVersionInfoW(long long int64) @ stdcall VirtualAlloc(ptr long long long) @ stdcall VirtualAllocEx(long ptr long long long) -# @ stub VirtualAllocExNuma +@ stdcall VirtualAllocExNuma(long ptr long long long long) @ stub VirtualBufferExceptionHandler @ stdcall VirtualFree(ptr long long) @ stdcall VirtualFreeEx(long ptr long long) diff --git a/dlls/kernel32/virtual.c b/dlls/kernel32/virtual.c index 42da7f0d8c..e859dd4dcb 100644 --- a/dlls/kernel32/virtual.c +++ b/dlls/kernel32/virtual.c @@ -46,6 +46,7 @@ WINE_DECLARE_DEBUG_CHANNEL(seh); WINE_DECLARE_DEBUG_CHANNEL(file); +WINE_DECLARE_DEBUG_CHANNEL(virtual); /*********************************************************************** @@ -100,6 +101,32 @@ LPVOID WINAPI DECLSPEC_HOTPATCH VirtualAllocEx( HANDLE hProcess, LPVOID addr, SI return ret; } +/*********************************************************************** + * VirtualAllocExNuma (KERNEL32.@) + * + * Seems to be just as VirtualAllocEx, but with a preferred NUMA node. + * + * PARAMS + * hProcess [I] Handle to process to do mem operation. + * addr [I] Address of region to reserve or commit. + * size [I] Size of region. + * type [I] Type of allocation. + * protect [I] Type of access protection. + * numa_node[I] Preferred NUMA node. + * + * + * RETURNS + * Success: Base address of allocated region of pages. + * Failure: NULL. + */ +LPVOID WINAPI DECLSPEC_HOTPATCH VirtualAllocExNuma(HANDLE hProcess, LPVOID addr, SIZE_T size, + DWORD type, DWORD protect, DWORD numa_node) +{ + FIXME_(virtual)("Ignoring preferred numa_node\n"); + + return VirtualAllocEx(hProcess, addr, size, type, protect); +} + /*********************************************************************** * VirtualFree (KERNEL32.@) -- 2.21.0

March 30, 2019

[PATCH v2] ntdll: Avoid matching the config directory for /windows/ in lookup_unix_name().

by Zebediah Figura

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46863 Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/ntdll/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index b46c2a6736..717873551b 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -2638,7 +2638,7 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer char *p; unix_name[pos + ret] = 0; for (p = unix_name + pos ; *p; p++) if (*p == '\\') *p = '/'; - if (!redirect || (!strstr( unix_name, "/windows/") && strncmp( unix_name, "windows/", 8 ))) + if (!redirect || strncmp( unix_name + pos, "/windows/", 9 )) { if (!stat( unix_name, &st )) { -- 2.17.1

March 30, 2019

Re: [PATCH] d3dx9: Implement D3DXComputeTangent

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=50160 Your paranoid android. === build (build log) === ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11084:155: error: expected ‘)’ before ‘;’ token ../../../../wine/include/wine/test.h:122:83: error: too few arguments to function ‘winetest_ok’ ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11089:1: error: expected ‘;’ before ‘}’ token Makefile:422: recipe for target 'mesh.o' failed Makefile:7631: recipe for target 'dlls/d3dx9_36/tests' failed Task: The exe32 Wine crossbuild failed === debian9 (build log) === ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11084:155: error: expected ‘)’ before ‘;’ token ../../../../wine/include/wine/test.h:122:83: error: too few arguments to function ‘winetest_ok’ ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11089:1: error: expected ‘;’ before ‘}’ token Makefile:422: recipe for target 'mesh.o' failed Makefile:8681: recipe for target 'dlls/d3dx9_36/tests' failed Task: The win32 build failed === debian9 (build log) === ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11084:155: error: expected ‘)’ before ‘;’ token ../../../../wine/include/wine/test.h:122:83: error: too few arguments to function ‘winetest_ok’ ../../../../wine/dlls/d3dx9_36/tests/mesh.c:11089:1: error: expected ‘;’ before ‘}’ token Makefile:422: recipe for target 'mesh.o' failed Makefile:8408: recipe for target 'dlls/d3dx9_36/tests' failed Task: The wow64 build failed

March 30, 2019

Re: [PATCH] d3dx9: Implement D3DXComputeTangent

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=50159 Your paranoid android. === w8 (32 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK === w8adm (32 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK === w864 (32 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK === w1064 (32 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK === w864 (64 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK === w1064 (64 bit report) === d3dx9_36: mesh.c:11084: Test failed: D3DXComputeTangentFrameEx returned 0x8876086c, expected D3D_OK

March 30, 2019