May 2019 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] kernel32: Add sxs tests

by Fabian Maurer

Hello Alexandre, > These should be reported as errors, not just skipped. Right, I'll fix that. > Please use the appropriate constant instead of 14001. Also, why does it > fail? Will do. It fails because windows XP doesn't support manifests outside of PE files. I could add a comment next to the check for broken(). > > + FreeLibrary(info->module); > > + FreeLibrary(info->module); /* Make sure it's freed in any case */ > > Why do you need this? On current wine, one dll gets loaded twice while the other isn't loaded at all. For the tests not to fail, I need to free the module twice, to make 100% sure it's unloaded before trying to delete it. At least that was the most sensible approach that came to my mind. Regards, Fabian Maurer

May 31, 2019

[PATCH 3/3] msscript: Return S_OK in IScriptControl::put_SitehWnd().

by Jactry Zeng

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> --- dlls/msscript.ocx/msscript.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c index d9ffd98cb7..74ffc47bbf 100644 --- a/dlls/msscript.ocx/msscript.c +++ b/dlls/msscript.ocx/msscript.c @@ -794,8 +794,10 @@ static HRESULT WINAPI ScriptControl_put_State(IScriptControl *iface, ScriptContr static HRESULT WINAPI ScriptControl_put_SitehWnd(IScriptControl *iface, LONG hwnd) { ScriptControl *This = impl_from_IScriptControl(iface); + FIXME("(%p)->(%x)\n", This, hwnd); - return E_NOTIMPL; + + return S_OK; } static HRESULT WINAPI ScriptControl_get_SitehWnd(IScriptControl *iface, LONG *p) -- 2.20.1

May 31, 2019

[PATCH 2/3] msscript: Partially implement IScriptControl::AddCode().

by Jactry Zeng

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> --- dlls/msscript.ocx/msscript.c | 21 +++++- dlls/msscript.ocx/tests/msscript.c | 105 +++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+), 1 deletion(-) diff --git a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c index 39e71b8b0c..d9ffd98cb7 100644 --- a/dlls/msscript.ocx/msscript.c +++ b/dlls/msscript.ocx/msscript.c @@ -972,8 +972,27 @@ static HRESULT WINAPI ScriptControl_Reset(IScriptControl *iface) static HRESULT WINAPI ScriptControl_AddCode(IScriptControl *iface, BSTR code) { ScriptControl *This = impl_from_IScriptControl(iface); + EXCEPINFO excepinfo; + HRESULT hr; + FIXME("(%p)->(%s)\n", This, debugstr_w(code)); - return E_NOTIMPL; + + if (!This->host || This->state != Initialized) + return E_FAIL; + + if (This->host->script_state != SCRIPTSTATE_STARTED) + { + hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED); + if (FAILED(hr)) + return hr; + This->host->script_state = SCRIPTSTATE_STARTED; + } + + hr = IActiveScriptParse_ParseScriptText(This->host->parse, code, NULL, NULL, NULL, + 0, 1, SCRIPTTEXT_ISVISIBLE, NULL, &excepinfo); + /* FIXME: more error hanlding */ + + return hr; } static HRESULT WINAPI ScriptControl_Eval(IScriptControl *iface, BSTR expression, VARIANT *res) diff --git a/dlls/msscript.ocx/tests/msscript.c b/dlls/msscript.ocx/tests/msscript.c index 8ed4af2e6f..0bdca22f43 100644 --- a/dlls/msscript.ocx/tests/msscript.c +++ b/dlls/msscript.ocx/tests/msscript.c @@ -1572,6 +1572,110 @@ static void test_IScriptControl_Eval(void) skip("Could not register TestScript engine.\n"); } +static void test_IScriptControl_AddCode(void) +{ + BSTR code_str, language; + IScriptControl *sc; + VARIANT var; + HRESULT hr; + + hr = CoCreateInstance(&CLSID_ScriptControl, NULL, CLSCTX_INPROC_SERVER | CLSCTX_INPROC_HANDLER, + &IID_IScriptControl, (void **)&sc); + ok(hr == S_OK, "Failed to create IScriptControl interface: 0x%08x.\n", hr); + + code_str = a2bstr("1 + 1"); + hr = IScriptControl_AddCode(sc, code_str); + ok(hr == E_FAIL, "IScriptControl_AddCode returned: 0x%08x.\n", hr); + SysFreeString(code_str); + + hr = IScriptControl_AddCode(sc, NULL); + ok(hr == E_FAIL, "IScriptControl_AddCode returned: 0x%08x.\n", hr); + + language = a2bstr("jscript"); + hr = IScriptControl_put_Language(sc, language); + ok(hr == S_OK, "IScriptControl_put_Language failed: 0x%08x.\n", hr); + SysFreeString(language); + + code_str = a2bstr("1 + 1"); + hr = IScriptControl_AddCode(sc, code_str); + ok(hr == S_OK, "IScriptControl_AddCode failed: 0x%08x.\n", hr); + SysFreeString(code_str); + todo_wine CHECK_ERROR(sc, 0); + + code_str = a2bstr("invalid syntax"); + hr = IScriptControl_AddCode(sc, code_str); + todo_wine ok(hr == 0x800a03ec, "IScriptControl_AddCode returned: 0x%08x.\n", hr); + SysFreeString(code_str); + todo_wine CHECK_ERROR(sc, 1004); + + IScriptControl_Release(sc); + + /* custom script engine */ + if (register_script_engine()) + { + hr = CoCreateInstance(&CLSID_ScriptControl, NULL, CLSCTX_INPROC_SERVER | CLSCTX_INPROC_HANDLER, + &IID_IScriptControl, (void **)&sc); + ok(hr == S_OK, "Failed to create IScriptControl interface: 0x%08x.\n", hr); + + SET_EXPECT(CreateInstance); + SET_EXPECT(SetInterfaceSafetyOptions); + SET_EXPECT(SetScriptSite); + SET_EXPECT(QI_IActiveScriptParse); + SET_EXPECT(InitNew); + + language = a2bstr("testscript"); + hr = IScriptControl_put_Language(sc, language); + ok(hr == S_OK, "IScriptControl_put_Language failed: 0x%08x.\n", hr); + SysFreeString(language); + + CHECK_CALLED(CreateInstance); + CHECK_CALLED(SetInterfaceSafetyOptions); + CHECK_CALLED(SetScriptSite); + CHECK_CALLED(QI_IActiveScriptParse); + CHECK_CALLED(InitNew); + + SET_EXPECT(SetScriptState_STARTED); + SET_EXPECT(ParseScriptText); + code_str = a2bstr("1 + 1"); + hr = IScriptControl_AddCode(sc, code_str); + ok(hr == S_OK, "IScriptControl_AddCode failed: 0x%08x.\n", hr); + SysFreeString(code_str); + CHECK_CALLED(SetScriptState_STARTED); + CHECK_CALLED(ParseScriptText); + + SET_EXPECT(ParseScriptText); + code_str = a2bstr("0x100"); + hr = IScriptControl_AddCode(sc, code_str); + ok(hr == S_OK, "IScriptControl_AddCode failed: 0x%08x.\n", hr); + SysFreeString(code_str); + CHECK_CALLED(ParseScriptText); + + /* Call Eval() after AddCode() for checking if it will call SetScriptState() again. */ + SET_EXPECT(ParseScriptText); + code_str = a2bstr("var2 = 10 + var1"); + V_VT(&var) = VT_NULL; + V_I4(&var) = 0xdeadbeef; + hr = IScriptControl_Eval(sc, code_str, &var); + ok(hr == S_OK, "IScriptControl_Eval failed: 0x%08x.\n", hr); + ok((V_VT(&var) == VT_EMPTY) && (V_I4(&var) == 0xdeadbeef), "V_VT(var) = %d, V_I4(var) = %d.\n", + V_VT(&var), V_I4(&var)); + SysFreeString(code_str); + CHECK_CALLED(ParseScriptText); + + IActiveScriptSite_Release(site); + + init_registry(FALSE); + + SET_EXPECT(Close); + + IScriptControl_Release(sc); + + CHECK_CALLED(Close); + } + else + skip("Could not register TestScript engine.\n"); +} + START_TEST(msscript) { IUnknown *unk; @@ -1602,6 +1706,7 @@ START_TEST(msscript) test_UseSafeSubset(); test_State(); test_IScriptControl_Eval(); + test_IScriptControl_AddCode(); CoUninitialize(); } -- 2.20.1

May 31, 2019

[PATCH 1/3] msscript: Cache state of IActiveScript in ScriptHost struct.

by Jactry Zeng

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> --- dlls/msscript.ocx/msscript.c | 18 ++++-- dlls/msscript.ocx/tests/msscript.c | 91 +++++++++++++++++++++++++++++- 2 files changed, 102 insertions(+), 7 deletions(-) diff --git a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c index 9044c4988b..39e71b8b0c 100644 --- a/dlls/msscript.ocx/msscript.c +++ b/dlls/msscript.ocx/msscript.c @@ -71,6 +71,7 @@ typedef struct ScriptHost { IActiveScript *script; IActiveScriptParse *parse; + SCRIPTSTATE script_state; CLSID clsid; struct list named_items; @@ -568,6 +569,7 @@ static HRESULT init_script_host(const CLSID *clsid, ScriptHost **ret) WARN("InitNew failed, %#x\n", hr); goto failed; } + host->script_state = SCRIPTSTATE_INITIALIZED; *ret = host; return S_OK; @@ -953,6 +955,7 @@ static HRESULT WINAPI ScriptControl_AddObject(IScriptControl *iface, BSTR name, static HRESULT WINAPI ScriptControl_Reset(IScriptControl *iface) { ScriptControl *This = impl_from_IScriptControl(iface); + HRESULT hr; TRACE("(%p)\n", This); @@ -960,7 +963,10 @@ static HRESULT WINAPI ScriptControl_Reset(IScriptControl *iface) return E_FAIL; clear_named_items(This->host); - return IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_INITIALIZED); + hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_INITIALIZED); + if (SUCCEEDED(hr)) + This->host->script_state = SCRIPTSTATE_INITIALIZED; + return hr; } static HRESULT WINAPI ScriptControl_AddCode(IScriptControl *iface, BSTR code) @@ -985,9 +991,13 @@ static HRESULT WINAPI ScriptControl_Eval(IScriptControl *iface, BSTR expression, if (!This->host || This->state != Initialized) return E_FAIL; - hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED); - if (FAILED(hr)) - return hr; + if (This->host->script_state != SCRIPTSTATE_STARTED) + { + hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED); + if (FAILED(hr)) + return hr; + This->host->script_state = SCRIPTSTATE_STARTED; + } hr = IActiveScriptParse_ParseScriptText(This->host->parse, expression, NULL, NULL, NULL, 0, 1, SCRIPTTEXT_ISEXPRESSION, res, &excepinfo); diff --git a/dlls/msscript.ocx/tests/msscript.c b/dlls/msscript.ocx/tests/msscript.c index 2d500d8308..8ed4af2e6f 100644 --- a/dlls/msscript.ocx/tests/msscript.c +++ b/dlls/msscript.ocx/tests/msscript.c @@ -95,6 +95,8 @@ DEFINE_EXPECT(Close); DEFINE_EXPECT(SetScriptSite); DEFINE_EXPECT(QI_IActiveScriptParse); DEFINE_EXPECT(SetScriptState_INITIALIZED); +DEFINE_EXPECT(SetScriptState_STARTED); +DEFINE_EXPECT(ParseScriptText); DEFINE_EXPECT(AddNamedItem); #define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__) @@ -147,8 +149,8 @@ static HRESULT WINAPI ActiveScriptParse_ParseScriptText(IActiveScriptParse *ifac LPCOLESTR pstrDelimiter, CTXARG_T dwSourceContextCookie, ULONG ulStartingLine, DWORD dwFlags, VARIANT *pvarResult, EXCEPINFO *pexcepinfo) { - ok(0, "unexpected call\n"); - return E_NOTIMPL; + CHECK_EXPECT(ParseScriptText); + return S_OK; } static const IActiveScriptParseVtbl ActiveScriptParseVtbl = { @@ -304,6 +306,10 @@ static HRESULT WINAPI ActiveScript_SetScriptState(IActiveScript *iface, SCRIPTST CHECK_EXPECT(SetScriptState_INITIALIZED); return S_OK; } + else if (ss == SCRIPTSTATE_STARTED) { + CHECK_EXPECT(SetScriptState_STARTED); + return S_OK; + } else ok(0, "unexpected call, state %u\n", ss); @@ -1381,7 +1387,7 @@ static void _check_error(IScriptControl *sc, LONG exp_num, int line) { error_num = 0xdeadbeef; hr = IScriptError_get_Number(script_err, &error_num); - ok_(__FILE__,line)(hr == S_OK, "IScriptError_get_Number failed: 0x%08x.", hr); + ok_(__FILE__,line)(hr == S_OK, "IScriptError_get_Number failed: 0x%08x.\n", hr); ok_(__FILE__,line)(error_num == exp_num, "got wrong error number: %d, expected %d.\n", error_num, exp_num); IScriptError_Release(script_err); @@ -1485,6 +1491,85 @@ static void test_IScriptControl_Eval(void) SysFreeString(script_str); IScriptControl_Release(sc); + + /* custom script engine */ + if (register_script_engine()) + { + hr = CoCreateInstance(&CLSID_ScriptControl, NULL, CLSCTX_INPROC_SERVER | CLSCTX_INPROC_HANDLER, + &IID_IScriptControl, (void **)&sc); + ok(hr == S_OK, "Failed to create IScriptControl interface: 0x%08x.\n", hr); + + SET_EXPECT(CreateInstance); + SET_EXPECT(SetInterfaceSafetyOptions); + SET_EXPECT(SetScriptSite); + SET_EXPECT(QI_IActiveScriptParse); + SET_EXPECT(InitNew); + + language= a2bstr("testscript"); + hr = IScriptControl_put_Language(sc, language); + ok(hr == S_OK, "IScriptControl_put_Language failed: 0x%08x.\n", hr); + SysFreeString(language); + + CHECK_CALLED(CreateInstance); + CHECK_CALLED(SetInterfaceSafetyOptions); + CHECK_CALLED(SetScriptSite); + CHECK_CALLED(QI_IActiveScriptParse); + CHECK_CALLED(InitNew); + + SET_EXPECT(SetScriptState_STARTED); + SET_EXPECT(ParseScriptText); + script_str = a2bstr("var1 = 1 + 1"); + V_VT(&var) = VT_NULL; + V_I4(&var) = 0xdeadbeef; + hr = IScriptControl_Eval(sc, script_str, &var); + ok(hr == S_OK, "IScriptControl_Eval failed: 0x%08x.\n", hr); + ok((V_VT(&var) == VT_EMPTY) && (V_I4(&var) == 0xdeadbeef), "V_VT(var) = %d, V_I4(var) = %d.\n", + V_VT(&var), V_I4(&var)); + SysFreeString(script_str); + CHECK_CALLED(SetScriptState_STARTED); + CHECK_CALLED(ParseScriptText); + + SET_EXPECT(ParseScriptText); + script_str = a2bstr("var2 = 10 + var1"); + V_VT(&var) = VT_NULL; + V_I4(&var) = 0xdeadbeef; + hr = IScriptControl_Eval(sc, script_str, &var); + ok(hr == S_OK, "IScriptControl_Eval failed: 0x%08x.\n", hr); + ok((V_VT(&var) == VT_EMPTY) && (V_I4(&var) == 0xdeadbeef), "V_VT(var) = %d, V_I4(var) = %d.\n", + V_VT(&var), V_I4(&var)); + SysFreeString(script_str); + CHECK_CALLED(ParseScriptText); + + SET_EXPECT(SetScriptState_INITIALIZED); + hr = IScriptControl_Reset(sc); + ok(hr == S_OK, "IScriptControl_Reset failed: 0x%08x.\n", hr); + CHECK_CALLED(SetScriptState_INITIALIZED); + + SET_EXPECT(SetScriptState_STARTED); + SET_EXPECT(ParseScriptText); + script_str = a2bstr("var2 = 10 + var1"); + V_VT(&var) = VT_NULL; + V_I4(&var) = 0xdeadbeef; + hr = IScriptControl_Eval(sc, script_str, &var); + ok(hr == S_OK, "IScriptControl_Eval failed: 0x%08x.\n", hr); + ok((V_VT(&var) == VT_EMPTY) && (V_I4(&var) == 0xdeadbeef), "V_VT(var) = %d, V_I4(var) = %d.\n", + V_VT(&var), V_I4(&var)); + SysFreeString(script_str); + CHECK_CALLED(SetScriptState_STARTED); + CHECK_CALLED(ParseScriptText); + + IActiveScriptSite_Release(site); + + init_registry(FALSE); + + SET_EXPECT(Close); + + IScriptControl_Release(sc); + + CHECK_CALLED(Close); + } + else + skip("Could not register TestScript engine.\n"); } START_TEST(msscript) -- 2.20.1

May 31, 2019

Re: [PATCH 2/2] comctl32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> >> My question was whether it's drawn with transparency in that case, since >> >> it's not really specified in which cases a DDB is considered to have an >> >> alpha channel. >> > >> > In order to draw it with a transparency it's necessary to create a 32-bpp >> > DIB section, copy source bitmap bits, and use GdiAlphaBlend() with a DIB >> > section. Basically my patch does all of this. >> >> Yes of course. My question was whether on Windows it's drawn transparent >> even for the DDB case. I guess the answer is yes since you have an app >> that does this, but a small test case wouldn't hurt. > > I just added the code to my test app to draw a bitmap with BitBlt() > loaded with LoadBitmap() (instead of assigning it to the Static control), > and the result is drawn without transparency under Windows. But if you assign it to the Static control it's transparent, right? And it's really a DDB, right? Just want to make sure that we need special handling there, and that it's not the app getting a DDB when it should be getting a DIB or something like that. -- Alexandre Julliard julliard(a)winehq.org

May 31, 2019

Re: [PATCH 2/2] comctl32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Alexandre Julliard <julliard(a)winehq.org> wrote: > > > >> My question was whether it's drawn with transparency in that case, since > > >> it's not really specified in which cases a DDB is considered to have an > > >> alpha channel. > > > > > > In order to draw it with a transparency it's necessary to create a 32-bpp > > > DIB section, copy source bitmap bits, and use GdiAlphaBlend() with a DIB > > > section. Basically my patch does all of this. > > > > Yes of course. My question was whether on Windows it's drawn transparent > > even for the DDB case. I guess the answer is yes since you have an app > > that does this, but a small test case wouldn't hurt. > > I just added the code to my test app to draw a bitmap with BitBlt() > loaded with LoadBitmap() (instead of assigning it to the Static control), > and the result is drawn without transparency under Windows. On the other hand using GdiAlphaBlend() instead of BitBlt() gives a very nicely looking image. So it's not necessary to create a copy of the source bitmap in the first place, but it's still necessary to verify that the bitmap has an alpha channel in order to use correct API for drawing. -- Dmitry.

May 31, 2019

Re: [PATCH v6 2/7] ntdll/tests: Add broken results NtAllocateVirtualMemory tests on w1064v1809

by Huw Davies

On Fri, May 31, 2019 at 11:11:46AM +0200, Rémi Bernon wrote: > On Thu, 2019-05-30 at 13:21 +0100, Huw Davies wrote: > > On Wed, May 29, 2019 at 03:13:08PM +0200, Rémi Bernon wrote: > > > if (status == STATUS_SUCCESS) ok(VirtualFree(addr2, 0, > > > MEM_RELEASE), "VirtualFree failed\n"); > > > > > > /* AT_ROUND_TO_PAGE flag is not supported for > > > NtAllocateVirtualMemory */ > > > @@ -66,7 +69,9 @@ static void test_AllocateVirtualMemory(void) > > > status = pNtAllocateVirtualMemory(GetCurrentProcess(), &addr2, > > > 0, &size, MEM_RESERVE | > > > MEM_COMMIT | > > > AT_ROUND_TO_PAGE, PAGE_EXECUTE_READWRITE); > > > todo_wine > > > - ok(status == STATUS_INVALID_PARAMETER_5, > > > "NtAllocateVirtualMemory returned %08x\n", status); > > > + ok(status == STATUS_INVALID_PARAMETER_5 || > > > + broken(status == STATUS_INVALID_PARAMETER) /* w1064v1809 > > > */, > > > + "NtAllocateVirtualMemory returned %08x\n", status); > > > > And again. > > > > Huw. > > Here Wine returns STATUS_INVALID_PARAMETER, like w1064v1809, but not > like previous Windows version, therefore the todo_wine. Should we > detect the emulated windows version to be sure the returned status is > consistent with it, or can the todo_wine be dropped? So they've 'fixed' Windows to behave like Wine - cool! ;-) Yes, in that case just accept STATUS_INVALID_PARAMETER as well and remove the todo_wine. Huw.

May 31, 2019

Re: [PATCH 2/2] comctl32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > >> My question was whether it's drawn with transparency in that case, since > >> it's not really specified in which cases a DDB is considered to have an > >> alpha channel. > > > > In order to draw it with a transparency it's necessary to create a 32-bpp > > DIB section, copy source bitmap bits, and use GdiAlphaBlend() with a DIB > > section. Basically my patch does all of this. > > Yes of course. My question was whether on Windows it's drawn transparent > even for the DDB case. I guess the answer is yes since you have an app > that does this, but a small test case wouldn't hurt. I just added the code to my test app to draw a bitmap with BitBlt() loaded with LoadBitmap() (instead of assigning it to the Static control), and the result is drawn without transparency under Windows. -- Dmitry.

May 31, 2019

Re: [PATCH 2/2] comctl32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> My question was whether it's drawn with transparency in that case, since >> it's not really specified in which cases a DDB is considered to have an >> alpha channel. > > In order to draw it with a transparency it's necessary to create a 32-bpp > DIB section, copy source bitmap bits, and use GdiAlphaBlend() with a DIB > section. Basically my patch does all of this. Yes of course. My question was whether on Windows it's drawn transparent even for the DDB case. I guess the answer is yes since you have an app that does this, but a small test case wouldn't hurt. -- Alexandre Julliard julliard(a)winehq.org

May 31, 2019

Re: [PATCH 2/2] comctl32: Paint 32-bpp bitmaps with an alpha channel using GdiAlphaBlend.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > >> It's not clear that an alpha channel is even meaningful with a DDB, did > >> you test that case? > > > > The app loads the bitmap using LoadBitmap(), i.e. it gets loaded without > > creating a DIB section, then the app assigns it to "Static" control. > > Calling BitBlt() with that bitmap as a source and a 32-bpp DIB section > > as a destination works just fine under Windows and Wine, and the result > > preserves alpha. Is that what you mean with testing a DDB? > > I don't particularly care about BitBlt() behavior, but I still think > GetDIBits() is preferable, particularly since it works even if the > bitmap is already selected in a DC. I see, thanks for the explanation. > My question was whether it's drawn with transparency in that case, since > it's not really specified in which cases a DDB is considered to have an > alpha channel. In order to draw it with a transparency it's necessary to create a 32-bpp DIB section, copy source bitmap bits, and use GdiAlphaBlend() with a DIB section. Basically my patch does all of this. -- Dmitry.

May 31, 2019