July 2019 - Wine-Devel - list.winehq.org

[PATCH 1/2] services: Report a PID of 0 for drivers.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- programs/services/rpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 41501024dac..8a77d97dd9f 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -831,7 +831,9 @@ static void fill_status_process(SERVICE_STATUS_PROCESS *status, struct service_e { struct process_entry *process = service->process; memcpy(status, &service->status, sizeof(service->status)); - status->dwProcessId = process ? process->process_id : 0; + status->dwProcessId = 0; + if (process && !(service->status.dwServiceType & SERVICE_DRIVER)) + status->dwProcessId = process->process_id; status->dwServiceFlags = 0; } -- 2.20.1

July 3, 2019

Re: [PATCH 2/8] winebus.sys: Create a stub mouse device.

by Alexandre Julliard

Zebediah Figura <zfigura(a)codeweavers.com> writes: > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > dlls/winebus.sys/main.c | 77 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) This breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M advapi32.dll -p advapi32_test.exe service && touch service.ok service.c:1727: Test failed: Expected a process id for this running service (winehid) make: *** [Makefile:417: service.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

July 3, 2019

Re: [PATCH 1/3 v2] kernel32/tests: Add more debugger tests.

by Jacek Caban

On 7/3/19 11:17 PM, Alexandre Julliard wrote: > Jacek Caban<jacek(a)codeweavers.com> writes: > >> Signed-off-by: Jacek Caban<jacek(a)codeweavers.com> >> --- >> v2: Better timeout handling >> >> dlls/kernel32/tests/debugger.c | 270 ++++++++++++++++++++++++++++++--- >> 1 file changed, 248 insertions(+), 22 deletions(-) > It doesn't work here: > > ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe debugger && touch debugger.ok > debugger.c:653: Tests skipped: "none" debugger test needs user interaction > debugger.c:975: Test failed: dwDebugEventCode = -1 > debugger.c:976: Test failed: ExceptionCode = 0 > debugger.c:1013: Test failed: dwDebugEventCode = 1 This looks like the timeout needs adjustment. In this case timeout should be considered a failure, so we may just use a use a high value. I will send a new version. Thanks, Jacek

July 3, 2019

Re: [PATCH 1/3 v2] kernel32/tests: Add more debugger tests.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > v2: Better timeout handling > > dlls/kernel32/tests/debugger.c | 270 ++++++++++++++++++++++++++++++--- > 1 file changed, 248 insertions(+), 22 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe debugger && touch debugger.ok debugger.c:653: Tests skipped: "none" debugger test needs user interaction debugger.c:975: Test failed: dwDebugEventCode = -1 debugger.c:976: Test failed: ExceptionCode = 0 debugger.c:1013: Test failed: dwDebugEventCode = 1 debugger.c:1018: Test failed: didn't get any child events (flag: 1). debugger.cdebugger.c:149: Test failed: wrong size for 'C:\users\julliard\Temp\wtf1ab.tmp': read=0 debugger.c:963: Test failed: unexpected event pid debugger.c:975: Test failed: dwDebugEventCode = -1 debugger.c:976: Test failed: ExceptionCode = 0 debugger.c:1013: Test failed: dwDebugEventCode = 1 debugger.c:149: Test failed: wrong size for 'C:\users\julliard\Temp\wtf2a2.tmp': read=0 debugger.c:963: Test failed: unexpected event pid debugger.c:975: Test failed: dwDebugEventCode = -1 debugger.c:976: Test failed: ExceptionCode = 0 debugger.c:1013: Test failed: dwDebugEventCode = 1 debugger.c:149debugger.c: Test failed: :wrong size for 'C:\users\julliard\Temp\wtf394.tmp': read=0 debugger.c:286: Test failed: unexpected event pid make: *** [Makefile:347: debugger.ok] Error 16 -- Alexandre Julliard julliard(a)winehq.org

July 3, 2019

Re: [PATCH 1/2 v2] ntdll: Move null terminating result to pf_vsnprintf callers.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54428 Your paranoid android. === debian9 (32 bit report) === ntdll: om.c:2118: Test failed: got 99

July 3, 2019

[PATCH 2/2] ntdll: Implement _snprintf_s and _vsnprintf_s.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/ntdll.spec | 2 ++ dlls/ntdll/printf.c | 45 +++++++++++++++++++++++++++++++++ dlls/ntdll/tests/string.c | 53 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+)

July 3, 2019

[PATCH 1/2 v2] ntdll: Move null terminating result to pf_vsnprintf callers.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- v2: Merged first two patches. dlls/ntdll/printf.c | 48 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 38 insertions(+), 10 deletions(-)

July 3, 2019

Re: [PATCH 1/3] ntdll: Store the actual used value in error cases.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54425 Your paranoid android. === debian9 (32 bit report) === ntdll: string.c:1329: Test failed: _snprintf returned 10, expected 11. === debian9 (32 bit Chinese:China report) === ntdll: string.c:1329: Test failed: _snprintf returned 10, expected 11. === debian9 (32 bit WoW report) === ntdll: string.c:1329: Test failed: _snprintf returned 10, expected 11. === debian9 (64 bit WoW report) === ntdll: string.c:1329: Test failed: _snprintf returned 10, expected 11.

July 3, 2019

[PATCH 3/3] ntdll: Implement _snprintf_s and _vsnprintf_s.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/ntdll.spec | 2 ++ dlls/ntdll/printf.c | 45 +++++++++++++++++++++++++++++++++ dlls/ntdll/tests/string.c | 53 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+)

July 3, 2019

[PATCH 2/3] ntdll: Move null terminating result to pf_vsnprintf callers.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/printf.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)

July 3, 2019