July 2019 - Wine-Devel - list.winehq.org

[PATCH 2/3] server: Fix debug event order in generate_startup_debug_events.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/kernel32/tests/debugger.c | 2 -- server/debugger.c | 20 +++++++++++++------- 2 files changed, 13 insertions(+), 9 deletions(-)

July 3, 2019

[PATCH 1/3 v2] kernel32/tests: Add more debugger tests.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- v2: Better timeout handling dlls/kernel32/tests/debugger.c | 270 ++++++++++++++++++++++++++++++--- 1 file changed, 248 insertions(+), 22 deletions(-)

July 3, 2019

Re: [PATCH 1/2] wineserver: Implement thread priorities on Unix with sched_setscheduler / setpriority

by Dmitry Timoshkov

Rémi Bernon <rbernon(a)codeweavers.com> wrote: > > > diff --git a/configure b/configure > > > index 3b6d744c391..e89be467e2e 100755 > > > --- a/configure > > > +++ b/configure > > > > There is no need to include a diff for auto-generated file. > > Alright but the file is committed and only regenerated with > autoreconf -fi, right? I believe I had to do it manually. Somebody else (read: Julliard) will do that for you. > > > + if (thread->process->priority == PROCESS_PRIOCLASS_REALTIME) > > > + { > > > +#ifdef HAVE_SCHED_SETSCHEDULER > > > + struct sched_param param; > > > + if (sched_getparam( thread->unix_tid, &param ) != 0) > > > + goto error; > > > > This 'goto' is useless. > > The error handling code path currently returns 0 in order not to > introduce any behavior change, but it should perhaps return an error > code instead. This goto was there to indicate the error codepath is > used in opposition to the other return 0 statements which are the > "success" codepath. Maybe a return 0 with a comment would make it more > clear, as for the last return 0 as well. You are free to change 'return 0;' to a proper error handling in a patch that actually intruduces it, until that it's purely confusing and looks like a bad coding style. -- Dmitry.

July 3, 2019

Re: [PATCH 1/2] wineserver: Implement thread priorities on Unix with sched_setscheduler / setpriority

by Rémi Bernon

On Wed, 2019-07-03 at 18:03 +0800, Dmitry Timoshkov wrote: > Rémi Bernon <rbernon(a)codeweavers.com> wrote: > > > diff --git a/configure b/configure > > index 3b6d744c391..e89be467e2e 100755 > > --- a/configure > > +++ b/configure > > There is no need to include a diff for auto-generated file. Alright but the file is committed and only regenerated with autoreconf -fi, right? I believe I had to do it manually. > > + if (thread->process->priority == PROCESS_PRIOCLASS_REALTIME) > > + { > > +#ifdef HAVE_SCHED_SETSCHEDULER > > + struct sched_param param; > > + if (sched_getparam( thread->unix_tid, &param ) != 0) > > + goto error; > > This 'goto' is useless. The error handling code path currently returns 0 in order not to introduce any behavior change, but it should perhaps return an error code instead. This goto was there to indicate the error codepath is used in opposition to the other return 0 statements which are the "success" codepath. Maybe a return 0 with a comment would make it more clear, as for the last return 0 as well. -- Rémi Bernon <rbernon(a)codeweavers.com>

July 3, 2019

Re: [PATCH 5/5] wined3d: Also try to create a depth/stencil buffer for WINED3D_NO3D devices in swapchain_init().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54404 Your paranoid android. === debian9 (build log) === Task errors: The task timed out

July 3, 2019

Re: [PATCH 4/5] wined3d: Pass a wined3d_context_gl structure to set_glsl_compute_shader_program().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54403 Your paranoid android. === debian9 (build log) === Task errors: The task timed out

July 3, 2019

Re: [PATCH 3/5] wined3d: Pass a wined3d_context_gl structure to find_glsl_compute_shader().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54402 Your paranoid android. === debian9 (build log) === Task errors: The task timed out

July 3, 2019

Re: [PATCH 2/5] wined3d: Pass a wined3d_context_gl structure to shader_glsl_compile_compute_shader().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54401 Your paranoid android. === debian9 (build log) === Task errors: The task timed out

July 3, 2019

Re: [PATCH 1/5] wined3d: Pass a wined3d_context_gl structure to shader_glsl_find_ffp_fragment_shader().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54400 Your paranoid android. === debian9 (build log) === Task errors: The task timed out

July 3, 2019

[PATCH 5/5] wined3d: Also try to create a depth/stencil buffer for WINED3D_NO3D devices in swapchain_init().

by Henri Verbeet

If requested. It will fail as it should, but the client library should never request it. I.e., the additional check is redundant. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/wined3d/swapchain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 9be6658c83d..69580adbffb 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -938,7 +938,7 @@ static HRESULT swapchain_init(struct wined3d_swapchain *swapchain, struct wined3 } /* Swapchains share the depth/stencil buffer, so only create a single depthstencil surface. */ - if (desc->enable_auto_depth_stencil && !(device->wined3d->flags & WINED3D_NO3D)) + if (desc->enable_auto_depth_stencil) { TRACE("Creating depth/stencil buffer.\n"); if (!device->auto_depth_stencil_view) -- 2.11.0

July 3, 2019