July 2019 - Wine-Devel - list.winehq.org

[PATCH 6/8] user32: Introduce and use an array_reserve() helper.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/user32/rawinput.c | 51 ++++++++++++++++++++++++++---------------- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/dlls/user32/rawinput.c b/dlls/user32/rawinput.c index 56ea2497d16..294926400fd 100644 --- a/dlls/user32/rawinput.c +++ b/dlls/user32/rawinput.c @@ -58,6 +58,33 @@ static CRITICAL_SECTION_DEBUG hid_devices_cs_debug = }; static CRITICAL_SECTION hid_devices_cs = { &hid_devices_cs_debug, -1, 0, 0, 0, 0 }; +static BOOL array_reserve(void **elements, unsigned int *capacity, unsigned int count, unsigned int size) +{ + unsigned int new_capacity, max_capacity; + void *new_elements; + + if (count <= *capacity) + return TRUE; + + max_capacity = ~(SIZE_T)0 / size; + if (count > max_capacity) + return FALSE; + + new_capacity = max(4, *capacity); + while (new_capacity < count && new_capacity <= max_capacity / 2) + new_capacity *= 2; + if (new_capacity < count) + new_capacity = max_capacity; + + if (!(new_elements = heap_realloc(*elements, new_capacity * size))) + return FALSE; + + *elements = new_elements; + *capacity = new_capacity; + + return TRUE; +} + static void find_hid_devices(void) { static ULONGLONG last_check; @@ -125,26 +152,12 @@ static void find_hid_devices(void) continue; } - if (didx >= hid_devices_max) + if (!array_reserve((void **)&hid_devices, &hid_devices_max, didx + 1, sizeof(*hid_devices))) { - if (hid_devices) - { - hid_devices_max *= 2; - hid_devices = heap_realloc(hid_devices, - hid_devices_max * sizeof(hid_devices[0])); - } - else - { - hid_devices_max = 8; - hid_devices = heap_alloc(hid_devices_max * sizeof(hid_devices[0])); - } - if (!hid_devices) - { - ERR("Failed to allocate memory.\n"); - CloseHandle(file); - heap_free(path); - goto done; - } + ERR("Failed to allocate memory.\n"); + CloseHandle(file); + heap_free(path); + goto done; } TRACE("Found HID device %s.\n", debugstr_w(path)); -- 2.20.1

July 2, 2019

[PATCH 5/8] hidclass.sys: Create a mouse device interface for HID mouse devices.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- An alternative approach is not to go through the HID stack, but rather to create a winemouse.sys directly. In the event that an application ever needs to use the mouse device, this may be easier than implementing translation to and from HID reports. On the other hand, given that evdev and hidraw can already expose mice, implementing mouhid.sys may be worthwhile anyway. dlls/hidclass.sys/device.c | 9 +++++++++ dlls/hidclass.sys/hid.h | 3 +++ dlls/hidclass.sys/pnp.c | 5 +++++ 3 files changed, 17 insertions(+) diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c index e96177225ba..60506ec9ce7 100644 --- a/dlls/hidclass.sys/device.c +++ b/dlls/hidclass.sys/device.c @@ -33,6 +33,7 @@ #include "initguid.h" #include "devguid.h" +#include "ntddmou.h" WINE_DEFAULT_DEBUG_CHANNEL(hid); WINE_DECLARE_DEBUG_CHANNEL(hid_report); @@ -122,6 +123,14 @@ NTSTATUS HID_LinkDevice(DEVICE_OBJECT *device) return status; } + /* FIXME: This should probably be done in mouhid.sys. */ + if (ext->preparseData->caps.UsagePage == HID_USAGE_PAGE_GENERIC + && ext->preparseData->caps.Usage == HID_USAGE_GENERIC_MOUSE) + { + if (!IoRegisterDeviceInterface(device, &GUID_DEVINTERFACE_MOUSE, NULL, &ext->mouse_link_name)) + ext->is_mouse = TRUE; + } + return STATUS_SUCCESS; error: diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index 0f82323dfb5..86d7bdf98f1 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -55,6 +55,9 @@ typedef struct _BASE_DEVICE_EXTENSION { KSPIN_LOCK irp_queue_lock; LIST_ENTRY irp_queue; + BOOL is_mouse; + UNICODE_STRING mouse_link_name; + /* Minidriver Specific stuff will end up here */ } BASE_DEVICE_EXTENSION; diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c index 8265efd9b4e..b5c99870148 100644 --- a/dlls/hidclass.sys/pnp.c +++ b/dlls/hidclass.sys/pnp.c @@ -215,6 +215,9 @@ NTSTATUS PNP_RemoveDevice(minidriver *minidriver, DEVICE_OBJECT *device, IRP *ir return rc; } + if (ext->is_mouse) + IoSetDeviceInterfaceState(&ext->mouse_link_name, FALSE); + if (irp) rc = minidriver->PNPDispatch(device, irp); HID_DeleteDevice(device); @@ -294,6 +297,8 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) rc = minidriver->PNPDispatch(device, irp); IoSetDeviceInterfaceState(&ext->link_name, TRUE); + if (ext->is_mouse) + IoSetDeviceInterfaceState(&ext->mouse_link_name, TRUE); return rc; } case IRP_MN_REMOVE_DEVICE: -- 2.20.1

July 2, 2019

[PATCH 4/8] include: Add ntddmou.h.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- include/ntddmou.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 include/ntddmou.h diff --git a/include/ntddmou.h b/include/ntddmou.h new file mode 100644 index 00000000000..828a3e30e58 --- /dev/null +++ b/include/ntddmou.h @@ -0,0 +1,24 @@ +/* + * Copyright 2019 Zebediah Figura for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef _NTDDMOU_ +#define _NTDDMOU_ + +DEFINE_GUID(GUID_DEVINTERFACE_MOUSE, 0x378de44c, 0x56ef, 0x11d1, 0xbc, 0x8c, 0x00, 0xa0, 0xc9, 0x14, 0x05, 0xdd); + +#endif -- 2.20.1

July 2, 2019

[PATCH 3/8] winehid.inf: Add WINEMOUSE to the list of winehid device IDs.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- loader/winehid.inf.in | 1 + 1 file changed, 1 insertion(+) diff --git a/loader/winehid.inf.in b/loader/winehid.inf.in index bd42bceeaac..566448e4a51 100644 --- a/loader/winehid.inf.in +++ b/loader/winehid.inf.in @@ -11,6 +11,7 @@ Wine hidraw device=device_section,HIDRAW Wine IOHID device=device_section,IOHID Wine libevent device=device_section,LNXEV Wine SDL HID device=device_section,SDLJOY +Wine mouse device=device_section,WINEMOUSE [device_section.Services] AddService = winehid,0x2,svc_section -- 2.20.1

July 2, 2019

[PATCH 2/8] winebus.sys: Create a stub mouse device.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/winebus.sys/main.c | 77 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c index 3616ebe8152..89ea65bba67 100644 --- a/dlls/winebus.sys/main.c +++ b/dlls/winebus.sys/main.c @@ -33,13 +33,16 @@ #include "setupapi.h" #include "cfgmgr32.h" #include "winioctl.h" +#include "hidusage.h" #include "ddk/wdm.h" #include "ddk/hidport.h" +#include "ddk/hidtypes.h" #include "wine/debug.h" #include "wine/unicode.h" #include "wine/list.h" #include "bus.h" +#include "controller.h" WINE_DEFAULT_DEBUG_CHANNEL(plugplay); WINE_DECLARE_DEBUG_CHANNEL(hid_report); @@ -66,6 +69,8 @@ static const WORD PID_XBOX_CONTROLLERS[] = { static DRIVER_OBJECT *driver_obj; +static DEVICE_OBJECT *mouse_obj; + HANDLE driver_key; struct pnp_device @@ -767,6 +772,76 @@ static void WINAPI driver_unload(DRIVER_OBJECT *driver) NtClose(driver_key); } +static NTSTATUS mouse_get_reportdescriptor(DEVICE_OBJECT *device, BYTE *buffer, DWORD length, DWORD *ret_length) +{ + TRACE("buffer %p, length %u.\n", buffer, length); + + *ret_length = sizeof(REPORT_HEADER) + sizeof(REPORT_TAIL); + if (length < sizeof(REPORT_HEADER) + sizeof(REPORT_TAIL)) + return STATUS_BUFFER_TOO_SMALL; + + memcpy(buffer, REPORT_HEADER, sizeof(REPORT_HEADER)); + memcpy(buffer + sizeof(REPORT_HEADER), REPORT_TAIL, sizeof(REPORT_TAIL)); + buffer[IDX_HEADER_PAGE] = HID_USAGE_PAGE_GENERIC; + buffer[IDX_HEADER_USAGE] = HID_USAGE_GENERIC_MOUSE; + + return STATUS_SUCCESS; +} + +static NTSTATUS mouse_get_string(DEVICE_OBJECT *device, DWORD index, WCHAR *buffer, DWORD length) +{ + static const WCHAR nameW[] = {'W','i','n','e',' ','H','I','D',' ','m','o','u','s','e',0}; + if (index != HID_STRING_ID_IPRODUCT) + return STATUS_NOT_IMPLEMENTED; + if (length < ARRAY_SIZE(nameW)) + return STATUS_BUFFER_TOO_SMALL; + strcpyW(buffer, nameW); + return STATUS_SUCCESS; +} + +static NTSTATUS mouse_begin_report_processing(DEVICE_OBJECT *device) +{ + return STATUS_SUCCESS; +} + +static NTSTATUS mouse_set_output_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *ret_length) +{ + FIXME("id %u, stub!\n", id); + return STATUS_NOT_IMPLEMENTED; +} + +static NTSTATUS mouse_get_feature_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *ret_length) +{ + FIXME("id %u, stub!\n", id); + return STATUS_NOT_IMPLEMENTED; +} + +static NTSTATUS mouse_set_feature_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *ret_length) +{ + FIXME("id %u, stub!\n", id); + return STATUS_NOT_IMPLEMENTED; +} + +static const platform_vtbl mouse_vtbl = +{ + .get_reportdescriptor = mouse_get_reportdescriptor, + .get_string = mouse_get_string, + .begin_report_processing = mouse_begin_report_processing, + .set_output_report = mouse_set_output_report, + .get_feature_report = mouse_get_feature_report, + .set_feature_report = mouse_set_feature_report, +}; + +static void mouse_device_create(void) +{ + static const GUID wine_mouse_class = {0xdfe2580e,0x52fd,0x453d,{0xa2,0xc1,0x33,0x81,0xf2,0x32,0x68,0x4c}}; + static const WCHAR busidW[] = {'W','I','N','E','M','O','U','S','E',0}; + + mouse_obj = bus_create_hid_device(busidW, 0, 0, -1, 0, 0, busidW, FALSE, + &wine_mouse_class, &mouse_vtbl, 0); + IoInvalidateDeviceRelations(mouse_obj, BusRelations); +} + NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path ) { static const WCHAR SDL_enabledW[] = {'E','n','a','b','l','e',' ','S','D','L',0}; @@ -788,6 +863,8 @@ NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path ) driver->MajorFunction[IRP_MJ_INTERNAL_DEVICE_CONTROL] = hid_internal_dispatch; driver->DriverUnload = driver_unload; + mouse_device_create(); + if (check_bus_option(&SDL_enabled, 1)) { if (sdl_driver_init() == STATUS_SUCCESS) -- 2.20.1

July 2, 2019

[PATCH 1/8] user32/tests: Test opening raw input devices.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/user32/tests/input.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index 4a9be550bdc..998fcdd1943 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1599,6 +1599,7 @@ static void test_GetRawInputDeviceList(void) char nameA[128]; UINT sz, len; RID_DEVICE_INFO info; + HANDLE file; /* get required buffer size */ name[0] = '\0'; @@ -1638,6 +1639,11 @@ static void test_GetRawInputDeviceList(void) ok(ret == sizeof(info), "GetRawInputDeviceInfo gave wrong return: %d\n", err); ok(sz == sizeof(info), "GetRawInputDeviceInfo set wrong size\n"); ok(info.dwType == devices[i].dwType, "GetRawInputDeviceInfo set wrong type: 0x%x\n", info.dwType); + + file = CreateFileW(name, 0, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL); + todo_wine_if(info.dwType != RIM_TYPEHID) + ok(file != INVALID_HANDLE_VALUE, "Failed to open %s, error %u\n", wine_dbgstr_w(name), GetLastError()); + CloseHandle(file); } /* check if variable changes from larger to smaller value */ -- 2.20.1

July 2, 2019

[PATCH] ntoskrnl.exe: Use the registered interface class in IoSetDeviceInterfaceState().

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/ntoskrnl.exe/pnp.c | 77 +---------------------------------------- 1 file changed, 1 insertion(+), 76 deletions(-) diff --git a/dlls/ntoskrnl.exe/pnp.c b/dlls/ntoskrnl.exe/pnp.c index 4ec8aaaed27..30865a05dcb 100644 --- a/dlls/ntoskrnl.exe/pnp.c +++ b/dlls/ntoskrnl.exe/pnp.c @@ -71,77 +71,6 @@ static int interface_rb_compare( const void *key, const struct wine_rb_entry *en static struct wine_rb_tree device_interfaces = { interface_rb_compare }; -static inline BOOL is_valid_hex(WCHAR c) -{ - if (!(((c >= '0') && (c <= '9')) || - ((c >= 'a') && (c <= 'f')) || - ((c >= 'A') && (c <= 'F')))) - return FALSE; - return TRUE; -} - -static const BYTE guid_conv_table[256] = -{ - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x00 */ - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x10 */ - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x20 */ - 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0, 0, 0, 0, 0, /* 0x30 */ - 0, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x40 */ - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0x50 */ - 0, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf /* 0x60 */ -}; - -static BOOL guid_from_string(const WCHAR *s, GUID *id) -{ - int i; - - if (!s || s[0] != '{') - { - memset( id, 0, sizeof (CLSID) ); - return FALSE; - } - - id->Data1 = 0; - for (i = 1; i < 9; i++) - { - if (!is_valid_hex(s[i])) return FALSE; - id->Data1 = (id->Data1 << 4) | guid_conv_table[s[i]]; - } - if (s[9] != '-') return FALSE; - - id->Data2 = 0; - for (i = 10; i < 14; i++) - { - if (!is_valid_hex(s[i])) return FALSE; - id->Data2 = (id->Data2 << 4) | guid_conv_table[s[i]]; - } - if (s[14] != '-') return FALSE; - - id->Data3 = 0; - for (i = 15; i < 19; i++) - { - if (!is_valid_hex(s[i])) return FALSE; - id->Data3 = (id->Data3 << 4) | guid_conv_table[s[i]]; - } - if (s[19] != '-') return FALSE; - - for (i = 20; i < 37; i += 2) - { - if (i == 24) - { - if (s[i] != '-') return FALSE; - i++; - } - if (!is_valid_hex(s[i]) || !is_valid_hex(s[i+1])) return FALSE; - id->Data4[(i-20)/2] = guid_conv_table[s[i]] << 4 | guid_conv_table[s[i+1]]; - } - - if (s[37] == '}') - return TRUE; - - return FALSE; -} - static NTSTATUS WINAPI internal_complete( DEVICE_OBJECT *device, IRP *irp, void *context ) { HANDLE event = context; @@ -594,7 +523,6 @@ NTSTATUS WINAPI IoSetDeviceInterfaceState( UNICODE_STRING *name, BOOLEAN enable UNICODE_STRING string; DWORD data = enable; NTSTATUS ret; - GUID class; ULONG len; TRACE("device %s, enable %u.\n", debugstr_us(name), enable); @@ -615,9 +543,6 @@ NTSTATUS WINAPI IoSetDeviceInterfaceState( UNICODE_STRING *name, BOOLEAN enable if (*p == '\\') refstr = p; if (!refstr) refstr = p; - if (!guid_from_string( refstr - 38, &class )) - return STATUS_INVALID_PARAMETER; - len = lstrlenW(DeviceClassesW) + 38 + 1 + namelen + 2 + 1; if (!(path = heap_alloc( len * sizeof(WCHAR) ))) @@ -676,7 +601,7 @@ NTSTATUS WINAPI IoSetDeviceInterfaceState( UNICODE_STRING *name, BOOLEAN enable { broadcast->dbcc_size = len; broadcast->dbcc_devicetype = DBT_DEVTYP_DEVICEINTERFACE; - broadcast->dbcc_classguid = class; + broadcast->dbcc_classguid = iface->interface_class; lstrcpynW( broadcast->dbcc_name, name->Buffer, namelen + 1 ); BroadcastSystemMessageW( BSF_FORCEIFHUNG | BSF_QUERY, NULL, WM_DEVICECHANGE, enable ? DBT_DEVICEARRIVAL : DBT_DEVICEREMOVECOMPLETE, (LPARAM)broadcast ); -- 2.20.1

July 2, 2019

Re: Ubuntu 19.10 will be 64 bit only

by Jens Reyer

On 29.06.19 10:31, Sveinar Søpler wrote: > ----- On Jun 22, 2019, at 1:12 PM, dimesio dimesio(a)earthlink.net wrote: >> On Sat, 22 Jun 2019 14:34:47 +0430 >> Henri Verbeet <hverbeet(a)gmail.com> wrote: >>> Provided the Ubuntu kernels will continue to support 32-bit >>> executables, and provided there's interest in the Ubuntu community to >>> continue running Wine, I imagine it should be possible for a bunch of >>> people in the Ubuntu community to get together and provide 32-bit >>> builds of the required packages as a PPA or something. Although hardly >>> ideal, I don't think there's a reason such an approach wouldn't work. >> >> I can't use PPAs to satisfy build dependencies on the OBS. Packages have to >> either be in the Ubuntu standard, update, or universe repositories, or on the >> OBS itself. The latter is what we're doing for FAudio. That works fine, other >> than the whining from Ubuntu users about the tremendous difficulty of copying >> and pasting the command to add another repository. So if Ubuntu users do decide >> to go the PPA route, they should also plan on building their own Wine packages. >> > Since most Launchpad PPA´s provide the needed orig.tar.xz files, along with .dsc > and -debian.tar.xz, it is not impossible to re-build those packages on the OBS > for use as a dependency. It is not there the work lies i guess. tldr: No, unfortunately I'm quite sure you are wrong here. But fortunately that doesn't matter now because Ubuntu changed its plans for 19.10/20.04. Doing this for the *complete* i386 dependency chain of Wine is lot of work, even if you manage to automate it for the initial setup and subsequent permanent updates. Even though most packages are based on Debian and thus already work for i386, there will be some packages that need specific fixes and adjustments. This is most probably not a job winehq can do. But it might work, if you've got a community which has knowledge about Debian packaging - people discussed doing this in this discourse thread [1]. The work should be based directly on the Ubuntu archive then, not some random PPAs. [1] https://discourse.ubuntu.com/t/would-a-community-supported-i386-repo-be-via… > Dunno if *buntu maintaners plan on creating any wine-release on Launchpad at all, > but if they do, it is not really impossible to maintain OBS as a kind of "backup" > of Launchpad to use for -devel and -staging. Winehq/Rosanne is on OBS only. Debian/me is only working in the official archive. I'm not aware of any other maintainers for Ubuntu packages, of course that hopefully changes for the time after 20.04. > Will be interesting to see how this is solved on Launchpad, cos dependencies is > a hornets nest on top of a anthill, and once main repo´s start dropping deps it´s > a huge undertaking to unwind. As I understand the old plans there is no solution on launchpad: i386 would've been gone, and not possible to build on launchpad. But (and I assume you missed that): Ubuntu has changed its plans and will do the work for Wine's dependency chain until 20.04. AIUI all we have to do is to nag them, if some packages are missing. Then, for the time after 20.04, they (Ubuntu) announced to contact us (Wine) to work out a permanent solution. Greets jre

July 2, 2019

Re: [PATCH 2/2] winmm: Build with msvcrt.

by Jacek Caban

On 7/2/19 8:08 PM, Marvin wrote: > === debian9 (32 bit Chinese:China report) === > > winmm: > wave.c:751: Test failed: WHDR_INQUEUE WHDR_PREPARED expected, got= WHDR_DONE WHDR_PREPARED > wave.c:756: Test failed: waveOutWrite(WAVE_MAPPER): WAVE_STILLPLAYING expected, got MMSYSERR_NOERROR(The specified command was carried out.) > wave.c:793: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED > wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19404 bytes, should be 17640 > wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19404 samples (19404 bytes), should be 17640 (17640 bytes) > wave.c:526: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 880 ms, (19404 bytes), should be 800 (17640 bytes) > wave.c:539: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed > wave.c:550: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed > wave.c:561: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed > wave.c:804: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) That's an existing failure: http://test.winehq.org/data/95be042be3f116db38eb4a255c2667a6b46fcc1e/linux_… Jacek

July 2, 2019

Re: [PATCH] d2d1: Remove unused function.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

July 2, 2019