July 2019 - Wine-Devel - list.winehq.org

Re: [PATCH] d3drm: Fix reference leak in d3drm_viewport2_Clear().

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

July 2, 2019

Re: [PATCH 2/2] winmm: Build with msvcrt.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54364 Your paranoid android. === debian9 (32 bit Chinese:China report) === winmm: wave.c:751: Test failed: WHDR_INQUEUE WHDR_PREPARED expected, got= WHDR_DONE WHDR_PREPARED wave.c:756: Test failed: waveOutWrite(WAVE_MAPPER): WAVE_STILLPLAYING expected, got MMSYSERR_NOERROR(The specified command was carried out.) wave.c:793: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19404 bytes, should be 17640 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 19404 samples (19404 bytes), should be 17640 (17640 bytes) wave.c:526: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 880 ms, (19404 bytes), should be 800 (17640 bytes) wave.c:539: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:550: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:561: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed wave.c:804: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) === debian9 (build log) === Task: WineTest did not produce the wow32 report

July 2, 2019

Re: [PATCH 1/2] winmm: Use condition variable to sleep in timer thread.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54363 Your paranoid android. === debian9 (build log) === Task: WineTest did not produce the wow32 report

July 2, 2019

[PATCH 2/2] winmm: Build with msvcrt.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winmm/Makefile.in | 2 + dlls/winmm/driver.c | 6 +-- dlls/winmm/joystick.c | 8 ---- dlls/winmm/lolvldrv.c | 2 - dlls/winmm/mci.c | 105 ++++++++++++++++++++--------------------- 5 files changed, 54 insertions(+), 69 deletions(-)

July 2, 2019

[PATCH 1/2] winmm: Use condition variable to sleep in timer thread.

by Jacek Caban

We have fast condition variable implementation now, so performance should not be a problem. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/winmm/time.c | 81 ++++++++--------------------------------------- 1 file changed, 14 insertions(+), 67 deletions(-)

July 2, 2019

Re: [PATCH] shlwapi: Remove unused function.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54362 Your paranoid android. === debian9 (build log) === Task: WineTest did not produce the wow32 report

July 2, 2019

Re: [PATCH] d2d1: Remove unused function.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=54361 Your paranoid android. === debian9 (build log) === Task: WineTest did not produce the wow32 report

July 2, 2019

[PATCH] shlwapi: Remove unused function.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/shlwapi/path.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/dlls/shlwapi/path.c b/dlls/shlwapi/path.c index a8d1c97172..e7b56a7ade 100644 --- a/dlls/shlwapi/path.c +++ b/dlls/shlwapi/path.c @@ -54,21 +54,6 @@ static fnpIsNetDrive pIsNetDrive; HRESULT WINAPI SHGetWebFolderFilePathW(LPCWSTR,LPWSTR,DWORD); -static inline WCHAR* heap_strdupAtoW(LPCSTR str) -{ - WCHAR *ret = NULL; - - if (str) - { - DWORD len = MultiByteToWideChar(CP_ACP, 0, str, -1, NULL, 0); - ret = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); - if (ret) - MultiByteToWideChar(CP_ACP, 0, str, -1, ret, len); - } - - return ret; -} - /************************************************************************* * PathBuildRootA [SHLWAPI.@] * -- 2.20.1

July 2, 2019

[PATCH] d2d1: Remove unused function.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/d2d1/device.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c index 9e4acb6ea2..98f06a281a 100644 --- a/dlls/d2d1/device.c +++ b/dlls/d2d1/device.c @@ -207,11 +207,6 @@ static inline struct d2d_device_context *impl_from_ID2D1DeviceContext(ID2D1Devic return CONTAINING_RECORD(iface, struct d2d_device_context, ID2D1DeviceContext_iface); } -static inline struct d2d_device_context *impl_from_ID2D1RenderTarget(ID2D1RenderTarget *iface) -{ - return CONTAINING_RECORD(iface, struct d2d_device_context, ID2D1DeviceContext_iface); -} - static HRESULT STDMETHODCALLTYPE d2d_device_context_inner_QueryInterface(IUnknown *iface, REFIID iid, void **out) { struct d2d_device_context *context = impl_from_IUnknown(iface); -- 2.20.1

July 2, 2019

[PATCH 2/2] winedbg: Set auto attach event after processing the first exception.

by Jacek Caban

On Windows, the process is broken by ordering and actual debug break execution in a new thread. We need to process this even before continuing exception handling in debuggee to avoid race. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/winedbg/debugger.h | 4 ++-- programs/winedbg/tgt_active.c | 14 +++++--------- programs/winedbg/winedbg.c | 10 ++++++++-- 3 files changed, 15 insertions(+), 13 deletions(-)

July 2, 2019