March 2020 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] qasf: Partially implement IFileSourceFilter_Load() for WM ASF reader.

by Nikolay Sivov

On 3/31/20 7:03 PM, Jactry Zeng wrote: > + if (filter->filename) > + { > + CoTaskMemFree(filter->filename); > + FreeMediaType(&filter->type); > + } > + It should match the way 'filename' was allocated. Also, does it make sense to check for null pointer at all?

March 31, 2020

Re: [PATCH 1/4] qasf: Implement WM ASF reader stub.

by Nikolay Sivov

On 3/31/20 7:01 PM, Jactry Zeng wrote: > + if (!(object = calloc(sizeof(*object), 1))) > + return E_OUTOFMEMORY; Hi, arguments are swapped here.

March 31, 2020

Re: RFC How to get rid of "always new" TestBot false positives?

by Francois Gouget

On Tue, 31 Mar 2020, Zebediah Figura wrote: [...] > We wouldn't do this for test.winehq.org, presumably (and as I understand, the > two systems are different enough that it's not difficult). Yes. test.winehq.org is a completely different codebase. -- Francois Gouget <fgouget(a)codeweavers.com>

March 31, 2020

Re: [PATCH 4/4] qasf: Implement IFileSourceFilter_GetCurFile() for WM ASF reader.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=68583 Your paranoid android. === debiant (32 bit report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit French report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Japanese:Japan report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Chinese:China report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (64 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005)

March 31, 2020

Re: [PATCH 3/4] qasf: Partially implement IFileSourceFilter_Load() for WM ASF reader.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=68582 Your paranoid android. === debiant (32 bit report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit French report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Japanese:Japan report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Chinese:China report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (64 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005)

March 31, 2020

Re: [PATCH 2/4] qasf: Implement IFileSourceFilter stub for WM ASF reader.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=68581 Your paranoid android. === debiant (32 bit report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit French report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Japanese:Japan report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Chinese:China report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (64 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005)

March 31, 2020

Re: [PATCH 1/4] qasf: Implement WM ASF reader stub.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=68580 Your paranoid android. === debiant (32 bit report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit French report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Japanese:Japan report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit Chinese:China report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (32 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005) === debiant (64 bit WoW report) === qasf: wmasf.c:35: Test failed: Got hr 0x80040154. Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x0040c28e). Report validation errors: qasf:wmasf crashed (c0000005)

March 31, 2020

[PATCH 13/13] dbghelp: Don't use system headers for ELF declarations.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- configure.ac | 10 ---------- dlls/dbghelp/elf_module.c | 6 +----- dlls/dbghelp/image_private.h | 17 ----------------- 3 files changed, 1 insertion(+), 32 deletions(-)

March 31, 2020

[PATCH 12/13] dbghelp: Use local ELF constants definitaions.

by Jacek Caban

Based on glibc. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/elf_module.c | 61 +++++++++++++++++++++++++++++---------- 1 file changed, 46 insertions(+), 15 deletions(-)

March 31, 2020

[PATCH 11/13] dbghelp: Don't use ELF32_ST_BIND and ELF32_ST_TYPE macros.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dbghelp/elf_module.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)

March 31, 2020