May 2020 - Wine-Devel - list.winehq.org

[PATCH] msasn1: Add stub for ASN1_Decode function

by Vijay Kiran Kamuju

ASN1decoding_t and ASN1encoding_t are implemented as linked lists. Current implementation does not properly emulate the linked list, as we need to identify where the next link pointers are stored. This patch adds a stub for ASN1_Decode function so that second crash related to the bug #38020 can be avoided and close the bug. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38020 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>

May 31, 2020

[PATCH] api-ms-win-downlevel-kernel32-l2-1-0: new dll

by Austin English

Signed-off-by: Austin English <austinenglish(a)gmail.com> --- configure.ac | 1 + .../Makefile.in | 1 + .../api-ms-win-downlevel-kernel32-l2-1-0.spec | 122 ++++++++++++++++++ tools/make_specfiles | 1 + 4 files changed, 125 insertions(+) create mode 100644 dlls/api-ms-win-downlevel-kernel32-l2-1-0/Makefile.in create mode 100644 dlls/api-ms-win-downlevel-kernel32-l2-1-0/api-ms-win-downlevel-kernel32-l2-1-0.spec diff --git a/configure.ac b/configure.ac index c0f60fe694..dda8ec95b1 100644 --- a/configure.ac +++ b/configure.ac @@ -2985,6 +2985,7 @@ WINE_CONFIG_MAKEFILE(dlls/api-ms-win-devices-config-l1-1-1) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-devices-query-l1-1-1) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-advapi32-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-advapi32-l2-1-0) +WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-kernel32-l2-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-normaliz-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-ole32-l1-1-0) WINE_CONFIG_MAKEFILE(dlls/api-ms-win-downlevel-shell32-l1-1-0) diff --git a/dlls/api-ms-win-downlevel-kernel32-l2-1-0/Makefile.in b/dlls/api-ms-win-downlevel-kernel32-l2-1-0/Makefile.in new file mode 100644 index 0000000000..fb89e55d58 --- /dev/null +++ b/dlls/api-ms-win-downlevel-kernel32-l2-1-0/Makefile.in @@ -0,0 +1 @@ +MODULE = api-ms-win-downlevel-kernel32-l2-1-0.dll diff --git a/dlls/api-ms-win-downlevel-kernel32-l2-1-0/api-ms-win-downlevel-kernel32-l2-1-0.spec b/dlls/api-ms-win-downlevel-kernel32-l2-1-0/api-ms-win-downlevel-kernel32-l2-1-0.spec new file mode 100644 index 0000000000..d4ed0f4a1a --- /dev/null +++ b/dlls/api-ms-win-downlevel-kernel32-l2-1-0/api-ms-win-downlevel-kernel32-l2-1-0.spec @@ -0,0 +1,122 @@ +@ stdcall AddAtomA(str) kernel32.AddAtomA +@ stdcall AddAtomW(wstr) kernel32.AddAtomW +@ stdcall BackupRead(ptr ptr long ptr long long ptr) kernel32.BackupRead +@ stdcall BackupWrite(ptr ptr long ptr long long ptr) kernel32.BackupWrite +@ stdcall BindIoCompletionCallback(long ptr long) kernel32.BindIoCompletionCallback +@ stdcall ConvertFiberToThread() kernel32.ConvertFiberToThread +@ stdcall ConvertThreadToFiber(ptr) kernel32.ConvertThreadToFiber +@ stdcall CopyFileA(str str long) kernel32.CopyFileA +@ stdcall CopyFileW(wstr wstr long) kernel32.CopyFileW +@ stdcall CreateFiber(long ptr ptr) kernel32.CreateFiber +@ stdcall CreateFileMappingA(long ptr long long long str) kernel32.CreateFileMappingA +@ stub CreateFileTransactedW +@ stdcall CreateMailslotA(str long long ptr) kernel32.CreateMailslotA +@ stdcall CreateNamedPipeA(str long long long long long long ptr) kernel32.CreateNamedPipeA +@ stdcall CreateSemaphoreW(ptr long long wstr) kernel32.CreateSemaphoreW +@ stdcall DeleteAtom(long) kernel32.DeleteAtom +@ stdcall DeleteFiber(ptr) kernel32.DeleteFiber +@ stdcall DnsHostnameToComputerNameW(wstr ptr ptr) kernel32.DnsHostnameToComputerNameW +@ stdcall DosDateTimeToFileTime(long long ptr) kernel32.DosDateTimeToFileTime +@ stdcall FatalAppExitA(long str) kernel32.FatalAppExitA +@ stdcall FatalAppExitW(long wstr) kernel32.FatalAppExitW +@ stdcall FileTimeToDosDateTime(ptr ptr ptr) kernel32.FileTimeToDosDateTime +@ stdcall FindAtomA(str) kernel32.FindAtomA +@ stdcall FindAtomW(wstr) kernel32.FindAtomW +@ stdcall FindResourceA(long str str) kernel32.FindResourceA +@ stdcall FindResourceExA(long str str long) kernel32.FindResourceExA +@ stdcall FindResourceW(long wstr wstr) kernel32.FindResourceW +@ stdcall GetActiveProcessorCount(long) kernel32.GetActiveProcessorCount +@ stdcall GetAtomNameA(long ptr long) kernel32.GetAtomNameA +@ stdcall GetAtomNameW(long ptr long) kernel32.GetAtomNameW +@ stdcall GetComputerNameA(ptr ptr) kernel32.GetComputerNameA +@ stdcall GetComputerNameW(ptr ptr) kernel32.GetComputerNameW +@ stdcall GetConsoleWindow() kernel32.GetConsoleWindow +@ stub GetDurationFormatEx +@ stdcall GetFirmwareEnvironmentVariableW(wstr wstr ptr long) kernel32.GetFirmwareEnvironmentVariableW +@ stub GetMaximumProcessorGroupCount +@ stdcall GetNamedPipeClientProcessId(long ptr) kernel32.GetNamedPipeClientProcessId +@ stdcall GetNamedPipeServerProcessId(long ptr) kernel32.GetNamedPipeServerProcessId +@ stdcall GetPrivateProfileIntA(str str long str) kernel32.GetPrivateProfileIntA +@ stdcall GetPrivateProfileIntW(wstr wstr long wstr) kernel32.GetPrivateProfileIntW +@ stdcall GetPrivateProfileSectionW(wstr ptr long wstr) kernel32.GetPrivateProfileSectionW +@ stdcall GetPrivateProfileStringA(str str str ptr long str) kernel32.GetPrivateProfileStringA +@ stdcall GetPrivateProfileStringW(wstr wstr wstr ptr long wstr) kernel32.GetPrivateProfileStringW +@ stdcall GetProcessAffinityMask(long ptr ptr) kernel32.GetProcessAffinityMask +@ stdcall GetProcessIoCounters(long ptr) kernel32.GetProcessIoCounters +@ stdcall GetProfileIntA(str str long) kernel32.GetProfileIntA +@ stdcall GetProfileIntW(wstr wstr long) kernel32.GetProfileIntW +@ stdcall GetProfileSectionA(str ptr long) kernel32.GetProfileSectionA +@ stdcall GetProfileSectionW(wstr ptr long) kernel32.GetProfileSectionW +@ stdcall GetProfileStringA(str str str ptr long) kernel32.GetProfileStringA +@ stdcall GetProfileStringW(wstr wstr wstr ptr long) kernel32.GetProfileStringW +@ stdcall GetShortPathNameA(str ptr long) kernel32.GetShortPathNameA +@ stdcall GetStartupInfoA(ptr) kernel32.GetStartupInfoA +@ stdcall GetStringTypeExA(long long str long ptr) kernel32.GetStringTypeExA +@ stdcall GetSystemPowerStatus(ptr) kernel32.GetSystemPowerStatus +@ stdcall GetSystemWow64DirectoryA(ptr long) kernel32.GetSystemWow64DirectoryA +@ stdcall GetSystemWow64DirectoryW(ptr long) kernel32.GetSystemWow64DirectoryW +@ stdcall GetTapeParameters(ptr long ptr ptr) kernel32.GetTapeParameters +@ stdcall GetTempPathA(long ptr) kernel32.GetTempPathA +@ stdcall GetThreadSelectorEntry(long long ptr) kernel32.GetThreadSelectorEntry +@ stdcall GlobalAddAtomA(str) kernel32.GlobalAddAtomA +@ stdcall GlobalAddAtomW(wstr) kernel32.GlobalAddAtomW +@ stdcall GlobalAlloc(long long) kernel32.GlobalAlloc +@ stdcall GlobalDeleteAtom(long) kernel32.GlobalDeleteAtom +@ stdcall GlobalFindAtomA(str) kernel32.GlobalFindAtomA +@ stdcall GlobalFindAtomW(wstr) kernel32.GlobalFindAtomW +@ stdcall GlobalFlags(long) kernel32.GlobalFlags +@ stdcall GlobalFree(long) kernel32.GlobalFree +@ stdcall GlobalGetAtomNameA(long ptr long) kernel32.GlobalGetAtomNameA +@ stdcall GlobalGetAtomNameW(long ptr long) kernel32.GlobalGetAtomNameW +@ stdcall GlobalHandle(ptr) kernel32.GlobalHandle +@ stdcall GlobalLock(long) kernel32.GlobalLock +@ stdcall GlobalMemoryStatus(ptr) kernel32.GlobalMemoryStatus +@ stdcall GlobalReAlloc(long long long) kernel32.GlobalReAlloc +@ stdcall GlobalSize(long) kernel32.GlobalSize +@ stdcall GlobalUnlock(long) kernel32.GlobalUnlock +@ stdcall InitAtomTable(long) kernel32.InitAtomTable +@ stdcall LoadLibraryA(str) kernel32.LoadLibraryA +@ stdcall LoadLibraryW(wstr) kernel32.LoadLibraryW +@ stdcall LocalAlloc(long long) kernel32.LocalAlloc +@ stdcall LocalFlags(long) kernel32.LocalFlags +@ stdcall LocalFree(long) kernel32.LocalFree +@ stdcall LocalLock(long) kernel32.LocalLock +@ stdcall LocalReAlloc(long long long) kernel32.LocalReAlloc +@ stdcall LocalSize(long) kernel32.LocalSize +@ stdcall LocalUnlock(long) kernel32.LocalUnlock +@ stdcall MoveFileA(str str) kernel32.MoveFileA +@ stdcall MoveFileExA(str str long) kernel32.MoveFileExA +@ stdcall MoveFileW(wstr wstr) kernel32.MoveFileW +@ stdcall MulDiv(long long long) kernel32.MulDiv +@ stdcall OpenFile(str ptr long) kernel32.OpenFile +@ stdcall PulseEvent(long) kernel32.PulseEvent +@ stub RaiseFailFastException +@ stdcall RegisterWaitForSingleObject(ptr long ptr ptr long long) kernel32.RegisterWaitForSingleObject +@ stdcall SetConsoleTitleA(str) kernel32.SetConsoleTitleA +@ stdcall SetFileCompletionNotificationModes(long long) kernel32.SetFileCompletionNotificationModes +@ stub SetFirmwareEnvironmentVariableW +@ stdcall SetHandleCount(long) kernel32.SetHandleCount +@ stdcall SetMailslotInfo(long long) kernel32.SetMailslotInfo +@ stdcall SetProcessAffinityMask(long long) kernel32.SetProcessAffinityMask +@ stdcall SetThreadAffinityMask(long long) kernel32.SetThreadAffinityMask +@ stdcall SetThreadIdealProcessor(long long) kernel32.SetThreadIdealProcessor +@ stdcall SetVolumeLabelW(wstr wstr) kernel32.SetVolumeLabelW +@ stdcall SwitchToFiber(ptr) kernel32.SwitchToFiber +@ stdcall UnregisterWait(long) kernel32.UnregisterWait +@ stdcall WTSGetActiveConsoleSessionId() kernel32.WTSGetActiveConsoleSessionId +@ stdcall WaitForMultipleObjects(long ptr long long) kernel32.WaitForMultipleObjects +@ stdcall WritePrivateProfileSectionA(str str str) kernel32.WritePrivateProfileSectionA +@ stdcall WritePrivateProfileSectionW(wstr wstr wstr) kernel32.WritePrivateProfileSectionW +@ stdcall WritePrivateProfileStringA(str str str str) kernel32.WritePrivateProfileStringA +@ stdcall WritePrivateProfileStringW(wstr wstr wstr wstr) kernel32.WritePrivateProfileStringW +@ stdcall lstrcatW(wstr wstr) kernel32.lstrcatW +@ stdcall lstrcmpA(str str) kernel32.lstrcmpA +@ stdcall lstrcmpW(wstr wstr) kernel32.lstrcmpW +@ stdcall lstrcmpiA(str str) kernel32.lstrcmpiA +@ stdcall lstrcmpiW(wstr wstr) kernel32.lstrcmpiW +@ stdcall lstrcpyW(ptr wstr) kernel32.lstrcpyW +@ stdcall lstrcpynA(ptr str long) kernel32.lstrcpynA +@ stdcall lstrcpynW(ptr wstr long) kernel32.lstrcpynW +@ stdcall lstrlenA(str) kernel32.lstrlenA +@ stdcall lstrlenW(wstr) kernel32.lstrlenW + diff --git a/tools/make_specfiles b/tools/make_specfiles index 6ce990c107..420d850b73 100755 --- a/tools/make_specfiles +++ b/tools/make_specfiles @@ -288,6 +288,7 @@ my @dll_groups = "api-ms-win-core-xstate-l2-1-0", "api-ms-win-core-processtopology-obsolete-l1-1-0", "api-ms-win-core-util-l1-1-0", + "api-ms-win-downlevel-kernel32-l2-1-0", "ext-ms-win-kernel32-package-current-l1-1-0", "ext-ms-win-kernel32-package-l1-1-1", ], -- 2.26.2

May 31, 2020

Re: [PATCH] winapi_test: Add/remove headers for urlmon test, in tests.dat.

by Francois Gouget

Signed-off-by: Francois Gouget <fgouget(a)free.fr>

May 30, 2020

Re: winegstreamer: Avoid Fedora and openSUSE?

by Francois Gouget

I'll use this thread to mention one last strange thing I noticed in the openSUSE packages: the case of unixODBC. There's three packages: unixODBC-devel unixODBC unixODBC-32bit So one may think that it's missing the -devel-32bit package. But not at all! unixODBC-devel only contains the headers. The .so symlinks are in the unixODBC and unixODBC-32bit packages. So as a result there is no need for a -devel-32bit package. Very non standard but it works (so no bug report). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

May 30, 2020

Re: winegstreamer: Avoid Fedora and openSUSE?

by Rosanne DiMesio

On Sat, 30 May 2020 20:42:50 +0200 (CEST) Francois Gouget <fgouget(a)free.fr> wrote: > > For reference, here are the commands it runs on openSUSE Leap 15.1. > Maybe that would be a good basis to update the wiki instructions? > (or maybe they should be simplified to leverage Emulators:Wine or > wt-install-dev more?) > That will be a big help in updating the wiki. I still want to document all the steps, but I will point to your script as an easier way to do it all. -- Rosanne DiMesio dimesio(a)earthlink.net

May 30, 2020

Re: [PATCH 1/3] makedep: Align PE sections so they can be mmapped.

by Rémi Bernon

On 5/29/20 2:57 PM, Jacek Caban wrote: > On 27.05.2020 13:49, Rémi Bernon wrote: >> On 5/25/20 5:26 PM, Jacek Caban wrote: >>> On 25.05.2020 16:32, Rémi Bernon wrote: >>>> I could also see that some CROSSDEBUG checks look for "split" prefix in >>>> makedep, and some other set the variable to dwarf. It's not clear to me >>>> what this variable is supposed to be set to (other than "pdb"). Does >>>> "dwarf" mean separate file as well? >>> >>> >>> No, "dwarf" means that debug info will be embedded in module PE >>> files, which has always been the default. "dwarf" part of >>> "split-dwarf" is important for configure script to apply >>> dwarf-specific flags. "dwarf," "split-dwarf" and "pdb" are the only >>> configs for which I know a real use, but in theory you could set it >>> to anything else as long as you take care of CROSSCFLAGS yourself. >>> "stabs" and "split-stabs" should be in theory achievable this way >>> (but I didn't try). >>> >>> >>> Jacek >>> >> >> Alright. So, "split*" means that the debug sections are extracted to a >> separate file, and, currently, this file is also a PE file, as the >> default objcopy operation is to use the same output format as the >> source file. >> >> Having the debug section in an ELF file instead in this case shouldn't >> be an issue right? Gdb and any other tool that were already able to >> parse DWARF from PE files should be able to parse DWARF from ELF >> without trouble. Using an ELF container allows perf to read it. I >> don't think there's anything that requires PE container with DWARF >> debug info, but maybe there is? >> >> Regarding the default name and location of this ELF module, I see that >> we already implement in dbghelp the same logic as gdb does, which >> includes looking for .debug/debugfile, where debugfile is the contents >> of GNU debuglink, so this should work fine as well, while at the same >> time making perf work OOTB. >> >> From a quick test, as long as the .debug folder is also copied >> alongside the dll in the prefix, both winedbg and winedbg --gdb are >> happy with the ELF container. >> >> So, in the end, although I understand the root issue is some >> limitation of perf itself, this feels much simpler to fix in Wine with >> these small tweaks that makes every tool happy, than to try >> implementing PE support in perf. I think it would require much more >> work there, and would be way harder to justify if it were to be >> upstreamed (this is clearly a Wine specific use-case and I'm not sure >> how eager perf maintainers would be to have huge code changes just for >> the sake of PE module parsing). > > > Yes, I agree that it could all work, I even made sure that dbghelp.dll > can handle it when I was adding support for debug links in PE. I'm not > against (at least part) of the patchset. But the thing is that it's > quite a lot of perf-specific tweaking. Even if we take those patches, it > would still be interesting to be better supported by perf, so why not at > least evaluate it first. Sure it's perf specific, but to be honest I'm not seeing any actual use case for this separate debug file except for perf compatibility. I'm not talking about the PDB here, just the separate PE module with DWARF debug infos. I understand why debug symbols are usually split, for instance by OS distributions, to reduce the size of the packages, but it is usually done already using build wrappers. I'm maybe not aware of all use cases but right now I don't see any use of having the DWARF debug info being split after link for normal wine builds. > > I took a quick look at perf sources and I'm not convinced that it would > be hard. It already has some abstraction, see dso_binary_type enum and > its usage. It already has special cases for things like > DSO_BINARY_TYPE__JAVA_JIT, so DSO_BINARY_TYPE__PE doesn't seem out of > place. The amount of PE understanding that perf would need to find debug > info is very minimal: it just needs to be able to enumerate sections. > Well DSO_BINARY_TYPE__JAVA_JIT is really some ugly hack to make perf a little bit more flexible and let some other tool dump a symbol list with address ranges in a "perfmap" text file at runtime. Other than that the dso_binary_type enumeration is mostly used to tell where to find the debug file, not really the format it's in. The code the assumes ELF format all over the place, even using libelf constants internally. The "perfmap" support is just some plumbing on top of it, parsing the file and inserting ELF-like symbols in the internal list. It's indeed possible to do the same thing for PE files, as implemented in the attached patches, using libbfd to parse them, but it still feels very hacky. Then I may be pessimistic but I also expect it to be a bit hard to justify such a change, as it is -in the other way this time- a wine-specific change in perf. Also, although the basic features seems to work fine (perf annotate relies on external tools for disassembly for instance), it's limited to providing the symbol list and it's not going to be well integrated with the ELF/DWARF part of the code, so it may lack features. > > The above is about two other patches. I didn't look at PE alignment fix, > but I just expect that it should be fixable upstream. With that in mind, > my comments to patches: > I'm not sure to understand, you mean fixable in perf as well? I don't think it is easily fixable there either, perf uses mmap hooks to detect which files are mapped to which memory range, and if the section aren't aligned we copy them instead, which makes it loose track. > > - PE alignment > > The patch breaks build with llvm-mingw because lld doesn't support > --file-alignment. It's also not exactly free. Note that you could just > pass CROSSLDFLAGS=... to configure instead of patching Wine. > Sure and all these patches can actually be implemented with some build system wrapper, I just think it'd be nice if perf could handle default wine builds. > > - .debug directory > > I don't have a strong opinion here. If it's indeed a standard, maybe we > should follow it. GDB documentation mentions both %s.debug and .debug/%s > and, not being a fan of hidden directories in build tree, I chose the > one that seemed nicer: > > https://sourceware.org/gdb/current/onlinedocs/gdb/Separate-Debug-Files.html > > > - symbols in ELF file > > We could do that, creating an exotic mix then building on mac, with PE, > Mach-O and ELF files. Another option would be > CROSSLDFLAGS=-Wl,--objcopy,-Oelf64-x86-64, but it doesn't seem nice... > I don't know how useful ELF or Mach-O format would be on mac, we could leave the PE format there if that's better. But again, I don't really understand the use case for this non-PDB split debug file. > > Thanks, > > Jacek > Cheers, -- Rémi Bernon <rbernon(a)codeweavers.com>

May 30, 2020

Re: [PATCH v2 07/12] quartz/tests: Fix -Wabsolute-value warnings.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020

Re: [PATCH 5/5] amstream: Add tests for IAMMediaStream::Initialize and ::JoinAMMultiMediaStream.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020

Re: [PATCH 4/5] amstream: Allow AMAudioStream and AMDirectDrawStream to be created by CoCreateInstance.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020

Re: [PATCH 3/5] amstream: Move initialization calls from *_stream_create into AMMultiMediaStream::AddMediaStream.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020