May 2020 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] amstream: Move initialization code from ddraw_stream_create into AMDirectDrawStream::Initialize and ::JoinAMMultiMediaStream.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020

Re: [PATCH 1/5] amstream: Move initialization code from audio_stream_create into AMAudioStream::Initialize and ::JoinAMMultiMediaStream.

by Zebediah Figura

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

May 30, 2020

Re: winegstreamer: Avoid Fedora and openSUSE?

by Francois Gouget

On Sat, 30 May 2020, Marcus Meissner wrote: [...] > Btw, in the Emulators:Wine I have a special sub-package "wine-32bit-build-deps" > that pulls all the build deps in. > > I have not checked it lately though, and it might need updates. Interestingly it has some of the same extra packages as the wiki's openSUSE page: freeglut-devel-32bit libglvnd-devel-32bit It's also missing some of the lesser dependencies: libnetapi, ODBC, libusb but also libunwind which seems important for 64-bit. It also does not seem to work around the missing dependencies in the -devel-32bit packages, though it looks like that will soon be a thing of the past. More importantly it's missing MinGW and vkd3d which makes sense since they are not present in the mainline packages or on the Emulators:Wine project. So there are three options for openSUSE Wine developers: * Manually add Emulators:Wine and install wine-32bit-build-deps. Provides most dependencies. zypper addrepo https://download.opensuse.org/repositories/Emulators:Wine/<you-distro-name-here>/Emulators:Wine.repo zypper refresh zypper install wine-32bit-build-deps * The wiki's openSUSE page instructions. https://wiki.winehq.org/OpenSUSE#Building_32_bit_Wine Lots of manual work and also provides most dependencies. * wt-install-dev My favorite obviously ;-), requires essentially no manual work and provides all the dependencies... at least today and on openSUSE Leap 15.1. May not work on Tumbleweed. When I say simple I really mean it. This one liner should be all you need: wget https://raw.githubusercontent.com/fgouget/wt-daily/master/wt-install-dev && sh wt-install-dev --yes For reference, here are the commands it runs on openSUSE Leap 15.1. Maybe that would be a good basis to update the wiki instructions? (or maybe they should be simplified to leverage Emulators:Wine or wt-install-dev more?) zypper addrepo https://download.opensuse.org/repositories/Emulators:Wine/openSUSE_Leap_15.… zypper addrepo https://download.opensuse.org/repositories/windows:mingw:win32/openSUSE_Lea… zypper addrepo https://download.opensuse.org/repositories/windows:mingw:win64/openSUSE_Lea… zypper addrepo https://download.opensuse.org/repositories/home:dimesio/openSUSE_Leap_15.1/… zypper refresh zypper install FAudio-devel FAudio-devel-32bit Mesa-libGL-devel \ Mesa-libGL1 Mesa-libGL1-32bit alsa-devel alsa-devel-32bit autoconf \ bison capi4linux-devel capi4linux-devel-32bit cups-devel \ cups-devel-32bit dbus-1-devel dbus-1-devel-32bit flex fontconfig fontconfig-32bit fontconfig-devel fontconfig-devel-32bit \ freetype2-devel freetype2-devel-32bit gcc gcc-32bit git glib2-devel glib2-devel-32bit glibc-devel glibc-devel-32bit glu-devel \ glu-devel-32bit gstreamer-devel gstreamer-plugins-base-devel \ gstreamer-plugins-base-devel-32bit krb5-devel krb5-devel-32bit \ libFAudio0 libFAudio0-32bit libOSMesa-devel libOSMesa-devel-32bit \ libOpenCL1 libSDL2-devel libSDL2-devel-32bit libX11-devel \ libX11-devel-32bit libXcomposite-devel libXcomposite-devel-32bit \ libXcursor-devel libXcursor-devel-32bit libXext-devel \ libXext-devel-32bit libXfixes-devel libXfixes-devel-32bit libXi-devel \ libXi-devel-32bit libXinerama-devel libXinerama-devel-32bit \ libXrandr-devel libXrandr-devel-32bit libXrender-devel \ libXrender-devel-32bit libXxf86vm-devel libXxf86vm-devel-32bit \ libcom_err-devel libcom_err-devel-32bit libexif-devel \ libexif-devel-32bit libgnutls-devel libgnutls-devel-32bit libgphoto2-6 \ libgphoto2-6-32bit libgphoto2-devel libgphoto2-devel-32bit \ libgsm-devel libgsm-devel-32bit libjpeg8-devel libjpeg8-devel-32bit \ liblcms2-devel liblcms2-devel-32bit libnetapi-devel libnetapi0 \ libnetapi0-32bit libopenal1 libopenal1-32bit libpcap-devel \ libpcap-devel-32bit libpng16-compat-devel libpng16-compat-devel-32bit \ libpulse-devel libpulse-devel-32bit libpulse0 libpulse0-32bit \ libtiff-devel libtiff-devel-32bit libudev-devel libudev-devel-32bit \ libunwind-devel libusb-1_0-devel libusb-1_0-devel-32bit libv4l-devel \ libv4l-devel-32bit libv4l2-0 libv4l2-0-32bit libvkd3d1 libvkd3d1-32bit \ libvulkan1 libvulkan1-32bit libxml2-devel libxml2-devel-32bit libxslt-devel \ libxslt-devel-32bit make mingw32-cross-gcc mingw64-cross-gcc \ mpg123-devel mpg123-devel-32bit ncurses-devel ncurses-devel-32bit \ ocl-icd-devel openal-soft-devel openal-soft-devel-32bit opencl-headers \ openldap2-devel openldap2-devel-32bit python3 sane-backends \ sane-backends-32bit sane-backends-devel sane-backends-devel-32bit \ unixODBC unixODBC-32bit unixODBC-devel unzip vkd3d-devel \ vkd3d-devel-32bit vulkan-devel vulkan-devel-32bit wget zlib-devel \ zlib-devel-32bit ln -s -f libgstbase-1.0.so.0 /usr/lib/libgstbase-1.0.so ln -s -f libgstreamer-1.0.so.0 /usr/lib/libgstreamer-1.0.so ln -s -f libnetapi.so.0 /usr/lib/libnetapi.so ln -s -f libGL.so.1 /usr/lib/libGL.so > I am working on your 15.1 bugs too. Yep. Saw that. That's great. And the good news is I think I'm done finding more things for you to fix ;-) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

May 30, 2020

Re: [PATCH] d3dcompiler: Store some builtin types in the hlsl_ctx structure.

by Matteo Bruni

On Sat, May 30, 2020 at 5:43 PM Alexandre Julliard <julliard(a)winehq.org> wrote: > > Matteo Bruni <mbruni(a)codeweavers.com> writes: > > > From: Zebediah Figura <z.figura12(a)gmail.com> > > > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > > --- > > dlls/d3dcompiler_43/d3dcompiler_private.h | 8 ++ > > dlls/d3dcompiler_43/hlsl.y | 132 +++++++++++----------- > > 2 files changed, 76 insertions(+), 64 deletions(-) > > This causes compiler warnings: > > i686-w64-mingw32-gcc -c -o utils.cross.o ../d3dcompiler_43/utils.c -I. -I../d3dcompiler_43 -I../../include \ > -I../../include/msvcrt -D__WINESRC__ -DD3D_COMPILER_VERSION=33 -D_UCRT -DWINE_CROSS_PE -Wall \ > -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ > -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \ > -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op \ > -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -Werror -g -O2 -fno-diagnostics-show-caret > ../d3dcompiler_43/utils.c: In function ‘debug_base_type’: > ../d3dcompiler_43/utils.c:1708:13: error: enumeration value ‘HLSL_SAMPLER_DIM_COUNT’ not handled in switch [-Werror=switch] > cc1: all warnings being treated as errors > make[1]: *** [Makefile:438: utils.cross.o] Error 1 Somehow I missed it, and I was looking specifically for this... Please ignore this one for now, I guess.

May 30, 2020

Re: [PATCH v3 3/3] d3dcompiler: Store some builtin types in the hlsl_ctx structure.

by Matteo Bruni

On Sat, May 30, 2020 at 5:22 PM Zebediah Figura <zfigura(a)codeweavers.com> wrote: > > > > On 5/29/20 4:32 PM, Matteo Bruni wrote: > > On Fri, May 22, 2020 at 10:46 PM Zebediah Figura <z.figura12(a)gmail.com> wrote: > >> > >> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > >> --- > >> v3: remove some earlier variable names... > >> > >> dlls/d3dcompiler_43/d3dcompiler_private.h | 8 ++ > >> dlls/d3dcompiler_43/hlsl.y | 132 +++++++++++----------- > >> 2 files changed, 76 insertions(+), 64 deletions(-) > >> > >> diff --git a/dlls/d3dcompiler_43/hlsl.y b/dlls/d3dcompiler_43/hlsl.y > >> index 058a627dc27..4d89c61ef44 100644 > >> --- a/dlls/d3dcompiler_43/hlsl.y > >> +++ b/dlls/d3dcompiler_43/hlsl.y > >> @@ -234,12 +243,23 @@ static void declare_predefined_types(struct hlsl_scope *scope) > >> sprintf(name, "%s", names[bt]); > >> type = new_hlsl_type(d3dcompiler_strdup(name), HLSL_CLASS_SCALAR, bt, x, y); > >> add_type_to_scope(scope, type); > >> + hlsl_ctx.builtin_types.scalar[bt] = type; > >> } > >> } > >> } > >> } > >> } > >> > >> + for (bt = 0; bt <= HLSL_SAMPLER_DIM_MAX; ++bt) > >> + { > >> + type = new_hlsl_type(d3dcompiler_strdup(sampler_names[bt]), HLSL_CLASS_OBJECT, HLSL_TYPE_SAMPLER, 1, 1); > >> + type->sampler_dim = bt; > >> + hlsl_ctx.builtin_types.sampler[bt] = type; > >> + } > >> + > >> + hlsl_ctx.builtin_types.Void = new_hlsl_type(d3dcompiler_strdup("void"), HLSL_CLASS_OBJECT, HLSL_TYPE_VOID, 1, 1); > >> + add_type_to_scope(scope, hlsl_ctx.builtin_types.Void); > >> + > > > > This is a sneaky tiny bugfix, right? > > > > In that void wasn't added to the scope before? Maybe, except that "void" > is uniquely a keyword for whatever reason, so I'm not sure what > difference it'd make... > > ...and I guess in that case there's no point adding it to the scope, is > there? Probably not. It might have been intentional, even.

May 30, 2020

Re: [PATCH] d3dcompiler: Store some builtin types in the hlsl_ctx structure.

by Alexandre Julliard

Matteo Bruni <mbruni(a)codeweavers.com> writes: > From: Zebediah Figura <z.figura12(a)gmail.com> > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/d3dcompiler_43/d3dcompiler_private.h | 8 ++ > dlls/d3dcompiler_43/hlsl.y | 132 +++++++++++----------- > 2 files changed, 76 insertions(+), 64 deletions(-) This causes compiler warnings: i686-w64-mingw32-gcc -c -o utils.cross.o ../d3dcompiler_43/utils.c -I. -I../d3dcompiler_43 -I../../include \ -I../../include/msvcrt -D__WINESRC__ -DD3D_COMPILER_VERSION=33 -D_UCRT -DWINE_CROSS_PE -Wall \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \ -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op \ -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -Werror -g -O2 -fno-diagnostics-show-caret ../d3dcompiler_43/utils.c: In function ‘debug_base_type’: ../d3dcompiler_43/utils.c:1708:13: error: enumeration value ‘HLSL_SAMPLER_DIM_COUNT’ not handled in switch [-Werror=switch] cc1: all warnings being treated as errors make[1]: *** [Makefile:438: utils.cross.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

May 30, 2020

Re: [PATCH v3 3/3] d3dcompiler: Store some builtin types in the hlsl_ctx structure.

by Zebediah Figura

On 5/29/20 4:32 PM, Matteo Bruni wrote: > On Fri, May 22, 2020 at 10:46 PM Zebediah Figura <z.figura12(a)gmail.com> wrote: >> >> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> >> --- >> v3: remove some earlier variable names... >> >> dlls/d3dcompiler_43/d3dcompiler_private.h | 8 ++ >> dlls/d3dcompiler_43/hlsl.y | 132 +++++++++++----------- >> 2 files changed, 76 insertions(+), 64 deletions(-) >> >> diff --git a/dlls/d3dcompiler_43/hlsl.y b/dlls/d3dcompiler_43/hlsl.y >> index 058a627dc27..4d89c61ef44 100644 >> --- a/dlls/d3dcompiler_43/hlsl.y >> +++ b/dlls/d3dcompiler_43/hlsl.y >> @@ -234,12 +243,23 @@ static void declare_predefined_types(struct hlsl_scope *scope) >> sprintf(name, "%s", names[bt]); >> type = new_hlsl_type(d3dcompiler_strdup(name), HLSL_CLASS_SCALAR, bt, x, y); >> add_type_to_scope(scope, type); >> + hlsl_ctx.builtin_types.scalar[bt] = type; >> } >> } >> } >> } >> } >> >> + for (bt = 0; bt <= HLSL_SAMPLER_DIM_MAX; ++bt) >> + { >> + type = new_hlsl_type(d3dcompiler_strdup(sampler_names[bt]), HLSL_CLASS_OBJECT, HLSL_TYPE_SAMPLER, 1, 1); >> + type->sampler_dim = bt; >> + hlsl_ctx.builtin_types.sampler[bt] = type; >> + } >> + >> + hlsl_ctx.builtin_types.Void = new_hlsl_type(d3dcompiler_strdup("void"), HLSL_CLASS_OBJECT, HLSL_TYPE_VOID, 1, 1); >> + add_type_to_scope(scope, hlsl_ctx.builtin_types.Void); >> + > > This is a sneaky tiny bugfix, right? > In that void wasn't added to the scope before? Maybe, except that "void" is uniquely a keyword for whatever reason, so I'm not sure what difference it'd make... ...and I guess in that case there's no point adding it to the scope, is there?

May 30, 2020

Re: winegstreamer: Avoid Fedora and openSUSE?

by Marcus Meissner

> > MinGW packages are available in the windows:mingw repository on the > > OBS. I've been able to build Wine with MinGW support locally and I can > > tell you what MinGW packages I have installed, but I don't know how > > many of those are actually needed--my method was to keep installing > > stuff until configure stopped complaining. > > Excellent. I have updated the script to add support for adding OBS > repositories. It now uses the Emulators:Wine, windows:mingw:win32, > windows:mingw:win64 and home:dimesio OBS 'projects' to provide FAudio, > MinGW win32, MinGW win64 and vkd3d respectively. > > https://github.com/fgouget/wt-daily/blob/master/wt-install-dev#L722 > > I hope this can make it easy for openSUSE developers to get their system > set up to work on Wine. > > > > > * A number of -devel-32bit packages don't depend on package that > > > contains the libraries, resulting in unusable dead links. The culprits > > > are: > > > fontconfig-devel-32bit > > > libgphoto2-devel-32bit > > > libpulse-devel-32bit > > > libv4l-devel-32bit > > > openal-soft-devel-32bit > > > sane-backends-devel-32bit > > > vulkan-devel-32bit > > > > > The libraries for all of those should be pulled in as dependencies by > > installing the wine-32bit package from the Emulators:Wine repository > > There is no need for Emulators:Wine here since this is all in the main > repository anyway. It's just that fontconfig-devel-32bit should depend > on fontconfig-devel but does not. vkd3d-devel-32bit has the same problem > by the way: it should depend on libvkd3d1-32bit but does not (hint). Btw, in the Emulators:Wine I have a special sub-package "wine-32bit-build-deps" that pulls all the build deps in. I have not checked it lately though, and it might need updates. I am working on your 15.1 bugs too. Ciao, Marcus

May 30, 2020

Re: winegstreamer: Avoid Fedora and openSUSE?

by Francois Gouget

On Thu, 28 May 2020, Rosanne DiMesio wrote: > On Thu, 28 May 2020 05:52:38 +0200 (CEST) > Francois Gouget <fgouget(a)free.fr> wrote: > > > > > Right, I used 'empty' in a somewhat loose sense. registry.i586.bin is > > small (<= 25kB instead of > 200kB) and running strings on it shows > > all plugins are blacklisted: > > > Both my files are over 900kB, and nothing is blacklisted: It turns out Wine has a workaround which allows it to not trigger this bug: https://www.winehq.org/pipermail/wine-devel/2020-May/166969.html (but once the registry file is broken, Wine is impacted too) > > Here are some things I found while writing / testing it on openSUSE 15.1: > > > > * MinGW does not seem to be readily available. Compiling Wine without > > MinGW is likely not to get tested much in the future so that's > > concerning. > > > MinGW packages are available in the windows:mingw repository on the > OBS. I've been able to build Wine with MinGW support locally and I can > tell you what MinGW packages I have installed, but I don't know how > many of those are actually needed--my method was to keep installing > stuff until configure stopped complaining. Excellent. I have updated the script to add support for adding OBS repositories. It now uses the Emulators:Wine, windows:mingw:win32, windows:mingw:win64 and home:dimesio OBS 'projects' to provide FAudio, MinGW win32, MinGW win64 and vkd3d respectively. https://github.com/fgouget/wt-daily/blob/master/wt-install-dev#L722 I hope this can make it easy for openSUSE developers to get their system set up to work on Wine. > > * A number of -devel-32bit packages don't depend on package that > > contains the libraries, resulting in unusable dead links. The culprits > > are: > > fontconfig-devel-32bit > > libgphoto2-devel-32bit > > libpulse-devel-32bit > > libv4l-devel-32bit > > openal-soft-devel-32bit > > sane-backends-devel-32bit > > vulkan-devel-32bit > > > The libraries for all of those should be pulled in as dependencies by > installing the wine-32bit package from the Emulators:Wine repository There is no need for Emulators:Wine here since this is all in the main repository anyway. It's just that fontconfig-devel-32bit should depend on fontconfig-devel but does not. vkd3d-devel-32bit has the same problem by the way: it should depend on libvkd3d1-32bit but does not (hint). > > * There are a couple other missing -devel-32bit packages that the script > > works around by creating the missing symlinks: > > libnetapi-devel-32bit > > Mesa-libGL-devel-32bit! > I don't have either of those packages installed, and don't have the 64 > bit libnetapi-devel package either, and configure has never complained > about either one. I do have the 32 and 64 bit libraries installed for > both. Wine's configure does not complain about libnetapi since it's a relatively minor dependency. As for Mesa-libGL-devel-32bit I suspect you have Mesa-libGL1-32bit installed and your page documents creating the needed libGL.so symlink so that's why Wine does not complain about it. > > prelink (not a lib) > > I don't have that installed at all. I vaguely remember it used to be > required, but it hasn't been needed in years. I'm not sure it's no longer needed. I believe it's more of a case where it's only needed for a few applications so one can get by without it. But maybe I'm wrong. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A man can fail many times, but he isn't a failure until he begins to blame somebody else. -- John Burroughs

May 30, 2020

[PATCH v2 resend] winapi: Update 'perl -w' to 'use warnings 'all''.

by Serge Gautherie

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- tools/winapi/c_function.pm | 1 + tools/winapi/c_parser.pm | 1 + tools/winapi/c_type.pm | 1 + tools/winapi/config.pm | 1 + tools/winapi/function.pm | 1 + tools/winapi/make_filter | 3 ++- tools/winapi/make_filter_options.pm | 4 +++- tools/winapi/make_parser.pm | 1 + tools/winapi/modules.pm | 1 + tools/winapi/msvcmaker | 3 ++- tools/winapi/msvcmaker_options.pm | 4 +++- tools/winapi/nativeapi.pm | 1 + tools/winapi/options.pm | 2 ++ tools/winapi/output.pm | 2 ++ tools/winapi/preprocessor.pm | 1 + tools/winapi/setup.pm | 1 + tools/winapi/tests.pm | 1 + tools/winapi/type.pm | 1 + tools/winapi/util.pm | 1 + tools/winapi/winapi.pm | 1 + tools/winapi/winapi_check | 3 ++- tools/winapi/winapi_check_options.pm | 8 ++++++-- tools/winapi/winapi_documentation.pm | 1 + tools/winapi/winapi_extract | 3 ++- tools/winapi/winapi_extract_options.pm | 4 +++- tools/winapi/winapi_function.pm | 4 +++- tools/winapi/winapi_global.pm | 1 + tools/winapi/winapi_local.pm | 1 + tools/winapi/winapi_module_user.pm | 1 + tools/winapi/winapi_parser.pm | 1 + tools/winapi/winapi_test | 3 ++- tools/winapi/winapi_test_options.pm | 4 +++- 32 files changed, 54 insertions(+), 12 deletions(-) diff --git a/tools/winapi/c_function.pm b/tools/winapi/c_function.pm index 773c6b2..4bef581 100644 --- a/tools/winapi/c_function.pm +++ b/tools/winapi/c_function.pm @@ -19,6 +19,7 @@ package c_function; use strict; +use warnings 'all'; sub new($) { diff --git a/tools/winapi/c_parser.pm b/tools/winapi/c_parser.pm index d42e04a..77e524f 100644 --- a/tools/winapi/c_parser.pm +++ b/tools/winapi/c_parser.pm @@ -19,6 +19,7 @@ package c_parser; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/c_type.pm b/tools/winapi/c_type.pm index c6aeb6a..ba1aec2 100644 --- a/tools/winapi/c_type.pm +++ b/tools/winapi/c_type.pm @@ -19,6 +19,7 @@ package c_type; use strict; +use warnings 'all'; use output qw($output); diff --git a/tools/winapi/config.pm b/tools/winapi/config.pm index fd45dc7..ceba90a 100644 --- a/tools/winapi/config.pm +++ b/tools/winapi/config.pm @@ -19,6 +19,7 @@ package config; use strict; +use warnings 'all'; use setup qw($current_dir $wine_dir $winapi_dir); diff --git a/tools/winapi/function.pm b/tools/winapi/function.pm index c53daa6..2bc2c4c 100644 --- a/tools/winapi/function.pm +++ b/tools/winapi/function.pm @@ -19,6 +19,7 @@ package function; use strict; +use warnings 'all'; sub new($) { my $proto = shift; diff --git a/tools/winapi/make_filter b/tools/winapi/make_filter index 45665de..f080706 100755 --- a/tools/winapi/make_filter +++ b/tools/winapi/make_filter @@ -1,4 +1,4 @@ -#! /usr/bin/perl -w +#!/usr/bin/perl # # Copyright 1999, 2000, 2001 Patrik Stridvall # @@ -18,6 +18,7 @@ # use strict; +use warnings 'all'; BEGIN { $0 =~ m%^(.*?/?tools)/winapi/make_filter$%; diff --git a/tools/winapi/make_filter_options.pm b/tools/winapi/make_filter_options.pm index 0cb81cd..7008487 100644 --- a/tools/winapi/make_filter_options.pm +++ b/tools/winapi/make_filter_options.pm @@ -17,9 +17,11 @@ # package make_filter_options; -use base qw(options); use strict; +use warnings 'all'; + +use base qw(options); use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/make_parser.pm b/tools/winapi/make_parser.pm index 773c5f3..2f5788d 100644 --- a/tools/winapi/make_parser.pm +++ b/tools/winapi/make_parser.pm @@ -19,6 +19,7 @@ package make_parser; use strict; +use warnings 'all'; use setup qw($current_dir $wine_dir $winapi_dir); diff --git a/tools/winapi/modules.pm b/tools/winapi/modules.pm index cbf1a2a..0651a7f 100644 --- a/tools/winapi/modules.pm +++ b/tools/winapi/modules.pm @@ -19,6 +19,7 @@ package modules; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index a18eb97..864b2b7 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -1,8 +1,9 @@ -#! /usr/bin/perl -w +#!/usr/bin/perl # Copyright 2002 Patrik Stridvall use strict; +use warnings 'all'; BEGIN { $0 =~ m%^(.*?/?tools)/winapi/msvcmaker$%; diff --git a/tools/winapi/msvcmaker_options.pm b/tools/winapi/msvcmaker_options.pm index 32bdffd..242dcb9 100644 --- a/tools/winapi/msvcmaker_options.pm +++ b/tools/winapi/msvcmaker_options.pm @@ -17,9 +17,11 @@ # package msvcmaker_options; -use base qw(options); use strict; +use warnings 'all'; + +use base qw(options); use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/nativeapi.pm b/tools/winapi/nativeapi.pm index 4804486..bc58d96 100644 --- a/tools/winapi/nativeapi.pm +++ b/tools/winapi/nativeapi.pm @@ -19,6 +19,7 @@ package nativeapi; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/options.pm b/tools/winapi/options.pm index 3daeb11..2254852 100644 --- a/tools/winapi/options.pm +++ b/tools/winapi/options.pm @@ -19,6 +19,7 @@ package options; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; @@ -58,6 +59,7 @@ sub parse_value($$) { package _options; use strict; +use warnings 'all'; use output qw($output); diff --git a/tools/winapi/output.pm b/tools/winapi/output.pm index f2c8d79..381570a 100644 --- a/tools/winapi/output.pm +++ b/tools/winapi/output.pm @@ -19,6 +19,7 @@ package output; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; @@ -34,6 +35,7 @@ $output = '_output'->new; package _output; use strict; +use warnings 'all'; my $stdout_isatty = -t STDOUT; my $stderr_isatty = -t STDERR; diff --git a/tools/winapi/preprocessor.pm b/tools/winapi/preprocessor.pm index 3d49773..796f7df 100644 --- a/tools/winapi/preprocessor.pm +++ b/tools/winapi/preprocessor.pm @@ -19,6 +19,7 @@ package preprocessor; use strict; +use warnings 'all'; sub new($) { my $proto = shift; diff --git a/tools/winapi/setup.pm b/tools/winapi/setup.pm index 60a35c5..ed08460 100644 --- a/tools/winapi/setup.pm +++ b/tools/winapi/setup.pm @@ -19,6 +19,7 @@ package setup; use strict; +use warnings 'all'; BEGIN { use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); diff --git a/tools/winapi/tests.pm b/tools/winapi/tests.pm index 142538c..6553da3 100644 --- a/tools/winapi/tests.pm +++ b/tools/winapi/tests.pm @@ -19,6 +19,7 @@ package tests; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/type.pm b/tools/winapi/type.pm index 8f66780..b18383a 100644 --- a/tools/winapi/type.pm +++ b/tools/winapi/type.pm @@ -19,6 +19,7 @@ package type; use strict; +use warnings 'all'; sub new($) { my $proto = shift; diff --git a/tools/winapi/util.pm b/tools/winapi/util.pm index 6697d56..8f400da 100644 --- a/tools/winapi/util.pm +++ b/tools/winapi/util.pm @@ -19,6 +19,7 @@ package util; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); require Exporter; diff --git a/tools/winapi/winapi.pm b/tools/winapi/winapi.pm index c770465..62b4311 100644 --- a/tools/winapi/winapi.pm +++ b/tools/winapi/winapi.pm @@ -19,6 +19,7 @@ package winapi; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/winapi_check b/tools/winapi/winapi_check index 61a0635..bfc9fc7 100755 --- a/tools/winapi/winapi_check +++ b/tools/winapi/winapi_check @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 1999-2002 Patrik Stridvall # @@ -28,6 +28,7 @@ # use strict; +use warnings 'all'; BEGIN { $0 =~ m%^(.*?/?tools)/winapi/winapi_check$%; diff --git a/tools/winapi/winapi_check_options.pm b/tools/winapi/winapi_check_options.pm index 23abb1f..8e17744 100644 --- a/tools/winapi/winapi_check_options.pm +++ b/tools/winapi/winapi_check_options.pm @@ -17,9 +17,11 @@ # package winapi_check_options; -use base qw(options); use strict; +use warnings 'all'; + +use base qw(options); use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; @@ -161,9 +163,11 @@ my $options_usage = "usage: winapi_check [--help] [<files>]\n"; $options = '_winapi_check_options'->new(\%options_long, \%options_short, $options_usage); package _winapi_check_options; -use base qw(_options); use strict; +use warnings 'all'; + +use base qw(_options); sub report_module($$) { my $self = shift; diff --git a/tools/winapi/winapi_documentation.pm b/tools/winapi/winapi_documentation.pm index d959e11..2be7c8c 100644 --- a/tools/winapi/winapi_documentation.pm +++ b/tools/winapi/winapi_documentation.pm @@ -19,6 +19,7 @@ package winapi_documentation; use strict; +use warnings 'all'; use config qw($current_dir $wine_dir); use modules qw($modules); diff --git a/tools/winapi/winapi_extract b/tools/winapi/winapi_extract index 1d165b9..b53fbcf 100755 --- a/tools/winapi/winapi_extract +++ b/tools/winapi/winapi_extract @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2002 Patrik Stridvall # @@ -18,6 +18,7 @@ # use strict; +use warnings 'all'; BEGIN { $0 =~ m%^(.*?/?tools)/winapi/winapi_extract$%; diff --git a/tools/winapi/winapi_extract_options.pm b/tools/winapi/winapi_extract_options.pm index 0e5754e..5126ba4 100644 --- a/tools/winapi/winapi_extract_options.pm +++ b/tools/winapi/winapi_extract_options.pm @@ -17,9 +17,11 @@ # package winapi_extract_options; -use base qw(options); use strict; +use warnings 'all'; + +use base qw(options); use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/winapi_function.pm b/tools/winapi/winapi_function.pm index 633e9ea..d4cfb72 100644 --- a/tools/winapi/winapi_function.pm +++ b/tools/winapi/winapi_function.pm @@ -17,9 +17,11 @@ # package winapi_function; -use base qw(function); use strict; +use warnings 'all'; + +use base qw(function); use config qw($current_dir $wine_dir); use util qw(normalize_set); diff --git a/tools/winapi/winapi_global.pm b/tools/winapi/winapi_global.pm index 38c0dfe..bb1403c 100644 --- a/tools/winapi/winapi_global.pm +++ b/tools/winapi/winapi_global.pm @@ -19,6 +19,7 @@ package winapi_global; use strict; +use warnings 'all'; use modules qw($modules); use nativeapi qw($nativeapi); diff --git a/tools/winapi/winapi_local.pm b/tools/winapi/winapi_local.pm index 42dd146..a9aef17 100644 --- a/tools/winapi/winapi_local.pm +++ b/tools/winapi/winapi_local.pm @@ -19,6 +19,7 @@ package winapi_local; use strict; +use warnings 'all'; use nativeapi qw($nativeapi); use options qw($options); diff --git a/tools/winapi/winapi_module_user.pm b/tools/winapi/winapi_module_user.pm index ef14453..53bce8e 100644 --- a/tools/winapi/winapi_module_user.pm +++ b/tools/winapi/winapi_module_user.pm @@ -19,6 +19,7 @@ package winapi_module_user; use strict; +use warnings 'all'; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; diff --git a/tools/winapi/winapi_parser.pm b/tools/winapi/winapi_parser.pm index 3703837..87e286f 100644 --- a/tools/winapi/winapi_parser.pm +++ b/tools/winapi/winapi_parser.pm @@ -19,6 +19,7 @@ package winapi_parser; use strict; +use warnings 'all'; use output qw($output); use options qw($options); diff --git a/tools/winapi/winapi_test b/tools/winapi/winapi_test index 8b7596f..8051591 100755 --- a/tools/winapi/winapi_test +++ b/tools/winapi/winapi_test @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2002 Patrik Stridvall # @@ -18,6 +18,7 @@ # use strict; +use warnings 'all'; BEGIN { $0 =~ m%^(.*?/?tools)/winapi/winapi_test$%; diff --git a/tools/winapi/winapi_test_options.pm b/tools/winapi/winapi_test_options.pm index 240e840..c422b65 100644 --- a/tools/winapi/winapi_test_options.pm +++ b/tools/winapi/winapi_test_options.pm @@ -17,9 +17,11 @@ # package winapi_test_options; -use base qw(options); use strict; +use warnings 'all'; + +use base qw(options); use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); require Exporter; -- 2.10.0.windows.1

May 29, 2020