July 2020 - Wine-Devel - list.winehq.org

[PATCH 1/5] include: Add xact3.h

by Vijay Kiran Kamuju

Based on work by Ethan Lee and Alistair Leslie-Hughes Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com>

July 1, 2020

Re: [PATCH] configure: Increase Wine loader address.

by Chip Davis

July 1, 2020 12:43 PM, "Paul Gofman" <pgofman(a)codeweavers.com> wrote: > On 7/1/20 20:38, Chip Davis wrote: > >> You forgot to bump the preloader on Mac OS. >> >> Chip > > As far as I could see, preloader address was already different for > Macos. Are you sure? I'm pretty sure it's at 0x7c400000, the same as Linux. The loader proper for some reason does not have a base address. > Should we bump the address anyway, given the problem I am trying > to solve is not reported for Macos? If we're not seeing this problem on macOS, I guess it's probably best to leave it be. Chip

July 1, 2020

Re: [PATCH] configure: Increase Wine loader address.

by Paul Gofman

On 7/1/20 20:38, Chip Davis wrote: > You forgot to bump the preloader on Mac OS. > > Chip > As far as I could see, preloader address was already different for Macos. Should we bump the address anyway, given the problem I am trying to solve is not reported for Macos?

July 1, 2020

Re: [PATCH] configure: Increase Wine loader address.

by Chip Davis

You forgot to bump the preloader on Mac OS. Chip

July 1, 2020

[PATCH] winegstreamer: Append a deinterlace element to the video post-processing chain.

by Zebediah Figura

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=30366 Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/winegstreamer/gstdemux.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 5697d2c0e0c..e6f00842df5 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -995,7 +995,16 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux * if (!strcmp(typename, "video/x-raw")) { - GstElement *vconv, *flip; + GstElement *vconv, *flip, *deinterlace; + + /* DirectShow can express interlaced video, but downstream filters can't + * necessarily consume it. In particular, the video renderer can't. */ + if (!(deinterlace = gst_element_factory_make("deinterlace", NULL))) + { + ERR("Failed to create deinterlace, are %u-bit GStreamer \"base\" plugins installed?\n", + 8 * (int)sizeof(void *)); + goto out; + } /* decodebin considers many YUV formats to be "raw", but some quartz * filters can't handle those. Also, videoflip can't handle all "raw" @@ -1018,14 +1027,18 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux * goto out; } - gst_bin_add(GST_BIN(This->container), vconv); /* bin takes ownership */ + /* The bin takes ownership of these elements. */ + gst_bin_add(GST_BIN(This->container), deinterlace); + gst_element_sync_state_with_parent(deinterlace); + gst_bin_add(GST_BIN(This->container), vconv); gst_element_sync_state_with_parent(vconv); - gst_bin_add(GST_BIN(This->container), flip); /* bin takes ownership */ + gst_bin_add(GST_BIN(This->container), flip); gst_element_sync_state_with_parent(flip); + gst_element_link(deinterlace, vconv); gst_element_link(vconv, flip); - pin->post_sink = gst_element_get_static_pad(vconv, "sink"); + pin->post_sink = gst_element_get_static_pad(deinterlace, "sink"); pin->post_src = gst_element_get_static_pad(flip, "src"); pin->flip = flip; } -- 2.27.0

July 1, 2020

Re: [PATCH] wininet: Increase user size to 'UNLEN + 1' in create_cookie_url().

by Serge Gautherie

https://testbot.winehq.org/JobDetails.pl?Key=74602 Not reproduced: flaky/unrelated? On 01/07/2020 16:55, Marvin wrote: > Full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=74599 > > Your paranoid android. > > > === debiant (32 bit Chinese:China report) === > > wininet: > http.c:4947: Test failed: expected 1 pending read, got 2 > http.c:5035: Test failed: expected 1 pending read, got 2 --

July 1, 2020

Re: [PATCH] wininet: Increase user size to 'UNLEN + 1' in create_cookie_url().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=74599 Your paranoid android. === debiant (32 bit Chinese:China report) === wininet: http.c:4947: Test failed: expected 1 pending read, got 2 http.c:5035: Test failed: expected 1 pending read, got 2

July 1, 2020

Re: [PATCH 4/4] kernel32: Move AllocConsole to kernelbase.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=74598 Your paranoid android. === debiant (32 bit report) === kernel32: mailslot.c:327: Test failed: timeout too short 988 === debiant (32 bit WoW report) === kernel32: mailslot.c:327: Test failed: timeout too short 985

July 1, 2020

Re: [PATCH 2/4] kernel32: Import FreeConsole from kernelbase.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=74596 Your paranoid android. === debiant (32 bit Chinese:China report) === kernel32: change.c:320: Test failed: should be ready

July 1, 2020

[PATCH] wininet: Increase user size to 'UNLEN + 1' in create_cookie_url().

by Serge Gautherie

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- dlls/wininet/cookie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c index b5f779b..4d0967b 100644 --- a/dlls/wininet/cookie.c +++ b/dlls/wininet/cookie.c @@ -147,7 +147,7 @@ static cookie_domain_t *get_cookie_domain(substr_t domain, BOOL create) static WCHAR *create_cookie_url(substr_t domain, substr_t path, substr_t *ret_path) { - WCHAR user[UNLEN], *p, *url; + WCHAR user[UNLEN + 1], *p, *url; DWORD len, user_len, i; static const WCHAR cookie_prefix[] = {'C','o','o','k','i','e',':'}; -- 2.10.0.windows.1

July 1, 2020