July 2020 - Wine-Devel - list.winehq.org

RE: [EXTERNAL] [PATCH 2/2] ntdll: Move InterlockedCompareExchange128 support to winnt.h.

by Puetz Kevin A

There's no __sync_bool_compare_and_swap_16 in ARMv8.0 (or even with ARMv8.1, support wasn't added until until GCC 10). This of course broke our builds when it was added; for now I'd been working around it with the attached patch, which substitutes the -latomic __atomic_compare_exchange_16, which is allowed to be based on a lock if there's no lockfree implementation (e.g. the specified -march or GCC lack support for the ARMv8.1 CASP* instructions). I was waiting to hear back from our BSP guys whether we'd eventually get support on the final hardware/toolchain or not before raising this upstream, to see know if I had an issue that needed a "real" fix or just a short-term impediment (in which case I had a viable workaround in the meantime). But if you're moving it into external API too, then it seems like it's time to at least point out what I've learned. Microsoft only promises InterlockedCompareExchange128 on amd64; It's nice to offer it anywhere an underlying compiler intrinsic exists, but that needs to test defined(__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16). And I think RtlInterlocked*SList needs some kind of fallback. What I did with -latomic seems sane, but should get a ./configure check since you wouldn't need to link -latomic if the compiler has the intrinsic. > -----Original Message----- > From: wine-devel <wine-devel-bounces(a)winehq.org> On Behalf Of Jacek > Caban > Sent: Friday, July 31, 2020 8:38 AM > To: wine-devel <wine-devel(a)winehq.org> > Subject: [EXTERNAL] [PATCH 2/2] ntdll: Move > InterlockedCompareExchange128 support to winnt.h. > > [EXTERNAL EMAIL]: This message was generated from an external source. Do > not follow guidance, click links, or open attachments unless you recognize > the sender and know the content is safe. > > Also properly declare intrinsic on msvc. > > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/ntdll/rtl.c | 26 ++++---------------------- > include/winnt.h | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+), 22 deletions(-) >

July 31, 2020

[PATCH] configure: Use *-windows instead of *-windows-gnu as fallback cross compiler target.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- This code path is used mostly when cross target can't be found, which means that mingw is most likely not available. *windows-gnu targets, however, require cross compiled libgcc (or compiler-rt), which is roughly a part of mingw distro, so they will most likely not work anyway. When using *-windows target (meaning msvc compatibility mode), Wine is self sufficient and doesn't need any external cross compiled bits. If someone has an unusual setup and wants the old behaviour, it's probably good idea to explicitly specify CROSSTARGET anyway. configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

July 31, 2020

[PATCH 2/2] winegcc: Try using msvc file align syntax if mingw-style is not supported.

by Jacek Caban

Allows setting file alignment on LLD 10. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- Martin already added support for mingw-style option to upstream LLD, so that it will not be needed with future versions. Supporting older versions is easy enough that I decided to send this patch, but I don't mind if it's dropped. tools/winegcc/winegcc.c | 5 +++++ 1 file changed, 5 insertions(+)

July 31, 2020

[PATCH 1/2] winegcc: Support file alignment on msvc target.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- tools/winegcc/winegcc.c | 1 + 1 file changed, 1 insertion(+)

July 31, 2020

[PATCH 2/2] ntdll: Move InterlockedCompareExchange128 support to winnt.h.

by Jacek Caban

Also properly declare intrinsic on msvc. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/ntdll/rtl.c | 26 ++++---------------------- include/winnt.h | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 22 deletions(-)

July 31, 2020

[PATCH 1/2] configure: Build with -mcx16 on x86_64.

by Jacek Caban

This is needed on clang msvc target to allow _InterlockedCompareExchange128. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

July 31, 2020

Re: [PATCH 1/2] ntdll: Read auxillary vector directly as fallback.

by Rémi Bernon

On 2020-07-31 11:51, Rémi Bernon wrote: > When getauxval isn't available we can read the auxillary vector after > environment pointers according to System V ABI. > > Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> > --- > > I'm not sure if this is very useful, but some runtimes (steamrt for > instance) have old glibc where getauxval isn't available and it then > causes SymInitializeW to fail because of NULL process image addresses. > > dlls/ntdll/unix/loader.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c > index bd3a0958757..02ffc0ca775 100644 > --- a/dlls/ntdll/unix/loader.c > +++ b/dlls/ntdll/unix/loader.c > @@ -1343,6 +1343,27 @@ ULONG_PTR get_image_address(void) > > if (task_info(mach_task_self(), TASK_DYLD_INFO, (task_info_t)&dyld_info, &size) == KERN_SUCCESS) > return dyld_info.all_image_info_addr; > +#elif defined(__linux__) > + ULONG_PTR size, num, phdr_addr; > + ElfW(Phdr) *phdr; > + Elf64_auxv_t *auxp; > + char **envp = main_envp; > + while (*envp++ != NULL); > + > + for (auxp = (Elf64_auxv_t *)envp; auxp->a_type != 0; auxp++) And this is obviously 64bit specific, please ignore it. -- Rémi Bernon <rbernon(a)codeweavers.com>

July 31, 2020

[PATCH v2] server: Fix some alt + hotkeys dont' work if the msg param is WM_SYSKEYDOWN in queue_hotkey_message function.

by Yaoyongjie

July 31, 2020

[PATCH v2] dbghelp: Ignore missing debug info in SymInitializeW.

by Rémi Bernon

When fInvadeProcess is used, we return an error if the target process is found but its debug info is not. We should only return an error if the process is not found. This fixes a SymInitializeW popup error on Hard Reset Redux startup. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- Supersedes 190026 dlls/dbghelp/dbghelp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/dbghelp/dbghelp.c b/dlls/dbghelp/dbghelp.c index a2dba4cfe3e..a2045f97455 100644 --- a/dlls/dbghelp/dbghelp.c +++ b/dlls/dbghelp/dbghelp.c @@ -354,7 +354,9 @@ static BOOL check_live_target(struct process* pcs) if (!base) return FALSE; TRACE("got debug info address %#lx from PEB %p\n", base, pbi.PebBaseAddress); - return elf_read_wine_loader_dbg_info(pcs, base) || macho_read_wine_loader_dbg_info(pcs, base); + if (!elf_read_wine_loader_dbg_info(pcs, base) && !macho_read_wine_loader_dbg_info(pcs, base)) + WARN("couldn't load process debug info at %p\n", base); + return TRUE; } /****************************************************************** @@ -456,7 +458,7 @@ BOOL WINAPI SymInitializeW(HANDLE hProcess, PCWSTR UserSearchPath, BOOL fInvadeP { if (fInvadeProcess) EnumerateLoadedModulesW64(hProcess, process_invade_cb, hProcess); - pcs->loader->synchronize_module_list(pcs); + if (pcs->loader) pcs->loader->synchronize_module_list(pcs); } else if (fInvadeProcess) { -- 2.27.0

July 31, 2020

Re: [PATCH 2/2] dbghelp: Ignore missing debug info in SymInitializeW.

by Rémi Bernon

On 2020-07-31 13:58, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > Actually I messed up the condition, it should be negated before printing the warning. -- Rémi Bernon <rbernon(a)codeweavers.com>

July 31, 2020