July 2020 - Wine-Devel - list.winehq.org

Re: [PATCH] user32: Fix return value of ScrollWindowEx for invisible windows.

by Myah Caron

These appear to be unrelated to the patch. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, July 30, 2020 7:43 AM, Marvin <testbot(a)winehq.org> wrote: > Hi, > > While running your changed tests, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > > Full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=76315 > > Your paranoid android. > > === w1064v1507 (32 bit report) === > > user32: > win.c:9485: Test failed: Timed out waiting for the child process > > === w1064v1809 (32 bit report) === > > user32: > win.c:3164: Test failed: GetActiveWindow() = 00030296 > win.c:3167: Test failed: GetFocus() = 00000000 > win.c:3179: Test failed: GetFocus() = 00000000 > win.c:3182: Test failed: GetFocus() = 00000000 > win.c:3185: Test failed: GetFocus() = 00000000 > win.c:3188: Test failed: GetActiveWindow() = 00030296 > win.c:3192: Test failed: GetFocus() = 00000000 > win.c:3195: Test failed: GetFocus() = 00000000 > win.c:3889: Test failed: hwnd 00020174/00110292 message 0737 > win.c:3894: Test failed: hwnd 00110292/00110292 message 0202 > win.c:3899: Test failed: hwnd 00110292/00110292 message 0203 > win.c:3903: Test failed: message 0202 available > > === w1064v1809_2scr (32 bit report) === > > user32: > win.c:3164: Test failed: GetActiveWindow() = 0004007C > win.c:3167: Test failed: GetFocus() = 00000000 > win.c:3179: Test failed: GetFocus() = 00000000 > win.c:3182: Test failed: GetFocus() = 00000000 > win.c:3185: Test failed: GetFocus() = 00000000 > win.c:3188: Test failed: GetActiveWindow() = 0004007C > win.c:3192: Test failed: GetFocus() = 00000000 > win.c:3195: Test failed: GetFocus() = 00000000 > win.c:3889: Test failed: hwnd 00070052/000B0322 message 0737 > win.c:3894: Test failed: hwnd 000B0322/000B0322 message 0202 > win.c:3899: Test failed: hwnd 000B0322/000B0322 message 0203 > win.c:3903: Test failed: message 0202 available > > === w1064v1809_ja (32 bit report) === > > user32: > win.c:3724: Test failed: message 0738 available > win.c:3849: Test failed: hwnd 000300D8 message 7fff > win.c:3928: Test failed: hwnd 000300D8/000F014A message 7fff > win.c:3931: Test failed: hwnd 000300D8/000F014A message 7fff > > === w1064v1809_zh_CN (32 bit report) === > > user32: > win.c:3849: Test failed: hwnd 0003018E message 0282 > win.c:3928: Test failed: hwnd 0003018E/004102DE message 0282 > win.c:3931: Test failed: hwnd 0003018E/004102DE message 0282 > > === w1064v1809 (64 bit report) === > > user32: > win.c:3164: Test failed: GetActiveWindow() = 0000000000030060 > win.c:3188: Test failed: GetActiveWindow() = 0000000000030060 > win.c:3889: Test failed: hwnd 00000000000200E4/00000000000A006E message 0737 > win.c:3894: Test failed: hwnd 00000000000A006E/00000000000A006E message 0202 > win.c:3899: Test failed: hwnd 00000000000A006E/00000000000A006E message 0203 > > === debiant (32 bit report) === > > user32: > monitor: Timeout > > === debiant (32 bit Chinese:China report) === > > user32: > clipboard.c:833: Test failed: 6: gle 5 > clipboard.c:838: Test failed: 6.0: got 0000 instead of 0008 > clipboard.c:868: Test failed: 6: gle 1418 > input.c:2514: Test failed: 4: Unexpected cursor movement > input.c:2514: Test failed: 5: Unexpected cursor movement > input.c:2514: Test failed: 6: Unexpected cursor movement > input.c:2514: Test failed: 7: Unexpected cursor movement > input.c:2514: Test failed: 8: Unexpected cursor movement > input.c:2235: Test failed: 9: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 9: Unexpected cursor movement > input.c:2235: Test failed: 10: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 10: Unexpected cursor movement > input.c:2235: Test failed: 11: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 11: Unexpected cursor movement > input.c:2235: Test failed: 12: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 12: Unexpected cursor movement > input.c:2514: Test failed: 13: Unexpected cursor movement > input.c:2514: Test failed: 14: Unexpected cursor movement > input.c:2514: Test failed: 15: Unexpected cursor movement > input.c:2514: Test failed: 16: Unexpected cursor movement > monitor: Timeout > msg: Timeout > sysparams.c:3349: Test failed: Expected ERROR_NO_MORE_FILES, ERROR_MOD_NOT_FOUND or 0xdeadbeef, got 0 > > === debiant (32 bit WoW report) === > > user32: > monitor: Timeout > win.c:10192: Test failed: Expected foreground window 000D013E, got 00E10104 > win.c:10194: Test failed: GetActiveWindow() = 00000000 > win.c:10194: Test failed: GetFocus() = 00000000 > win.c:10195: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. > win.c:10239: Test failed: Expected foreground window 009E00DC, got 00E10104 > win.c:10241: Test failed: GetActiveWindow() = 00000000 > win.c:10241: Test failed: GetFocus() = 00000000 > win.c:10242: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. > win.c:10243: Test failed: Received WM_ACTIVATEAPP(0), did not expect it. > > === debiant (64 bit WoW report) === > > user32: > clipboard.c:1383: Test failed: gle 5 > clipboard.c:1385: Test failed: gle 1418 > clipboard.c:1388: Test failed: got 00000000 > clipboard.c:1389: Test failed: expected moveable mem 00000000 > clipboard.c:1391: Test failed: got 00000000 > clipboard.c:1392: Test failed: expected moveable mem 00000000 > clipboard.c:1395: Test failed: got 00000000 > clipboard.c:1396: Test failed: expected bitmap 00000000 > clipboard.c:1398: Test failed: got 00000000 > clipboard.c:1399: Test failed: expected bitmap 00000000 > clipboard.c:1401: Test failed: got 00000000 > clipboard.c:1402: Test failed: expected bitmap 00000000 > clipboard.c:1404: Test failed: got 00000000 > clipboard.c:1405: Test failed: expected palette 00000000 > clipboard.c:1407: Test failed: got 00000000 > clipboard.c:1408: Test failed: expected moveable mem 00000000 > clipboard.c:1410: Test failed: got 00000000 > clipboard.c:1411: Test failed: expected moveable mem 00000000 > clipboard.c:1425: Test failed: got 00000000 > clipboard.c:1426: Test failed: expected fixed mem 00000000 > clipboard.c:1428: Test failed: got 00000000 > clipboard.c:1429: Test failed: expected fixed mem 00000000 > clipboard.c:1431: Test failed: got 00000000 > clipboard.c:1432: Test failed: expected moveable mem 00000000 > clipboard.c:1444: Test failed: wrong data 00000000 > clipboard.c:1445: Test failed: expected moveable mem 00000000 > clipboard.c:1448: Test failed: wrong data 00000000, cf 0000c040 > clipboard.c:1449: Test failed: expected moveable mem 00000000 > clipboard.c:1452: Test failed: wrong data 00000000 > clipboard.c:1453: Test failed: expected moveable mem 00000000 > clipboard.c:1456: Test failed: wrong data 00000000 > clipboard.c:1457: Test failed: expected moveable mem 00000000 > clipboard.c:1460: Test failed: wrong data 00000000 > clipboard.c:1461: Test failed: expected fixed mem 00000000 > clipboard.c:1464: Test failed: wrong data 00000000 > clipboard.c:1465: Test failed: expected fixed mem 00000000 > clipboard.c:1468: Test failed: wrong data 00000000 > clipboard.c:1469: Test failed: expected moveable mem 00000000 > clipboard.c:1475: Test failed: got 00000000 > clipboard.c:1476: Test failed: expected moveable mem 00000000 > clipboard.c:1477: Test failed: expected freed mem 00204462 > clipboard.c:1480: Test failed: got 00000000 > clipboard.c:1481: Test failed: expected fixed mem 00000000 > clipboard.c:1486: Test failed: gle 1418 > clipboard.c:1549: Test failed: wrong data 00000000 > clipboard.c:1552: Test failed: wrong data 00000000, cf 0000c040 > clipboard.c:1555: Test failed: wrong data 00000000 > clipboard.c:1558: Test failed: wrong data 00000000 > clipboard.c:1561: Test failed: wrong data 00000000 > clipboard.c:1564: Test failed: wrong data 00000000 > clipboard.c:1567: Test failed: wrong data 00000000 > clipboard.c:1574: Test failed: expected fixed mem 00000000 > clipboard.c:1576: Test failed: expected fixed mem 00000000 > clipboard.c:1578: Test failed: expected fixed mem 00000000 > clipboard.c:1580: Test failed: expected bitmap 00000000 > clipboard.c:1582: Test failed: expected bitmap 00000000 > clipboard.c:1584: Test failed: expected palette 00000000 > clipboard.c:1586: Test failed: expected fixed mem 00000000 > clipboard.c:1588: Test failed: expected fixed mem 00000000 > clipboard.c:1600: Test failed: expected freed mem 00BED542 > clipboard.c:1601: Test failed: expected freed mem 00BF247A > clipboard.c:1602: Test failed: expected freed mem 002043F2 > clipboard.c:1603: Test failed: expected freed mem 0020442A > clipboard.c:1604: Test failed: expected freed mem 00BF1A7A > input.c:2514: Test failed: 4: Unexpected cursor movement > input.c:2514: Test failed: 5: Unexpected cursor movement > input.c:2514: Test failed: 6: Unexpected cursor movement > input.c:2514: Test failed: 7: Unexpected cursor movement > input.c:2514: Test failed: 8: Unexpected cursor movement > input.c:2235: Test failed: 9: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 9: Unexpected cursor movement > input.c:2235: Test failed: 10: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 10: Unexpected cursor movement > input.c:2235: Test failed: 11: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 11: Unexpected cursor movement > input.c:2235: Test failed: 12: foreground process expected WM_MOUSEMOVE message > input.c:2514: Test failed: 12: Unexpected cursor movement > input.c:2514: Test failed: 13: Unexpected cursor movement > input.c:2514: Test failed: 14: Unexpected cursor movement > input.c:2514: Test failed: 15: Unexpected cursor movement > input.c:2514: Test failed: 16: Unexpected cursor movement > monitor: Timeout > msg: Timeout > sysparams.c:3349: Test failed: Expected ERROR_NO_MORE_FILES, ERROR_MOD_NOT_FOUND or 0xdeadbeef, got 0 > win.c:10166: Test failed: Expected foreground window 000D013E, got 00000000 > win.c:10173: Test failed: Expected foreground window 000D013E, got 00E10102 > win.c:10176: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. > win.c:10185: Test failed: Expected foreground window 000D013E, got 00000000

July 30, 2020

Re: [PATCH] user32: Fix return value of ScrollWindowEx for invisible windows.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76315 Your paranoid android. === w1064v1507 (32 bit report) === user32: win.c:9485: Test failed: Timed out waiting for the child process === w1064v1809 (32 bit report) === user32: win.c:3164: Test failed: GetActiveWindow() = 00030296 win.c:3167: Test failed: GetFocus() = 00000000 win.c:3179: Test failed: GetFocus() = 00000000 win.c:3182: Test failed: GetFocus() = 00000000 win.c:3185: Test failed: GetFocus() = 00000000 win.c:3188: Test failed: GetActiveWindow() = 00030296 win.c:3192: Test failed: GetFocus() = 00000000 win.c:3195: Test failed: GetFocus() = 00000000 win.c:3889: Test failed: hwnd 00020174/00110292 message 0737 win.c:3894: Test failed: hwnd 00110292/00110292 message 0202 win.c:3899: Test failed: hwnd 00110292/00110292 message 0203 win.c:3903: Test failed: message 0202 available === w1064v1809_2scr (32 bit report) === user32: win.c:3164: Test failed: GetActiveWindow() = 0004007C win.c:3167: Test failed: GetFocus() = 00000000 win.c:3179: Test failed: GetFocus() = 00000000 win.c:3182: Test failed: GetFocus() = 00000000 win.c:3185: Test failed: GetFocus() = 00000000 win.c:3188: Test failed: GetActiveWindow() = 0004007C win.c:3192: Test failed: GetFocus() = 00000000 win.c:3195: Test failed: GetFocus() = 00000000 win.c:3889: Test failed: hwnd 00070052/000B0322 message 0737 win.c:3894: Test failed: hwnd 000B0322/000B0322 message 0202 win.c:3899: Test failed: hwnd 000B0322/000B0322 message 0203 win.c:3903: Test failed: message 0202 available === w1064v1809_ja (32 bit report) === user32: win.c:3724: Test failed: message 0738 available win.c:3849: Test failed: hwnd 000300D8 message 7fff win.c:3928: Test failed: hwnd 000300D8/000F014A message 7fff win.c:3931: Test failed: hwnd 000300D8/000F014A message 7fff === w1064v1809_zh_CN (32 bit report) === user32: win.c:3849: Test failed: hwnd 0003018E message 0282 win.c:3928: Test failed: hwnd 0003018E/004102DE message 0282 win.c:3931: Test failed: hwnd 0003018E/004102DE message 0282 === w1064v1809 (64 bit report) === user32: win.c:3164: Test failed: GetActiveWindow() = 0000000000030060 win.c:3188: Test failed: GetActiveWindow() = 0000000000030060 win.c:3889: Test failed: hwnd 00000000000200E4/00000000000A006E message 0737 win.c:3894: Test failed: hwnd 00000000000A006E/00000000000A006E message 0202 win.c:3899: Test failed: hwnd 00000000000A006E/00000000000A006E message 0203 === debiant (32 bit report) === user32: monitor: Timeout === debiant (32 bit Chinese:China report) === user32: clipboard.c:833: Test failed: 6: gle 5 clipboard.c:838: Test failed: 6.0: got 0000 instead of 0008 clipboard.c:868: Test failed: 6: gle 1418 input.c:2514: Test failed: 4: Unexpected cursor movement input.c:2514: Test failed: 5: Unexpected cursor movement input.c:2514: Test failed: 6: Unexpected cursor movement input.c:2514: Test failed: 7: Unexpected cursor movement input.c:2514: Test failed: 8: Unexpected cursor movement input.c:2235: Test failed: 9: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 9: Unexpected cursor movement input.c:2235: Test failed: 10: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 10: Unexpected cursor movement input.c:2235: Test failed: 11: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 11: Unexpected cursor movement input.c:2235: Test failed: 12: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 12: Unexpected cursor movement input.c:2514: Test failed: 13: Unexpected cursor movement input.c:2514: Test failed: 14: Unexpected cursor movement input.c:2514: Test failed: 15: Unexpected cursor movement input.c:2514: Test failed: 16: Unexpected cursor movement monitor: Timeout msg: Timeout sysparams.c:3349: Test failed: Expected ERROR_NO_MORE_FILES, ERROR_MOD_NOT_FOUND or 0xdeadbeef, got 0 === debiant (32 bit WoW report) === user32: monitor: Timeout win.c:10192: Test failed: Expected foreground window 000D013E, got 00E10104 win.c:10194: Test failed: GetActiveWindow() = 00000000 win.c:10194: Test failed: GetFocus() = 00000000 win.c:10195: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. win.c:10239: Test failed: Expected foreground window 009E00DC, got 00E10104 win.c:10241: Test failed: GetActiveWindow() = 00000000 win.c:10241: Test failed: GetFocus() = 00000000 win.c:10242: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. win.c:10243: Test failed: Received WM_ACTIVATEAPP(0), did not expect it. === debiant (64 bit WoW report) === user32: clipboard.c:1383: Test failed: gle 5 clipboard.c:1385: Test failed: gle 1418 clipboard.c:1388: Test failed: got 00000000 clipboard.c:1389: Test failed: expected moveable mem 00000000 clipboard.c:1391: Test failed: got 00000000 clipboard.c:1392: Test failed: expected moveable mem 00000000 clipboard.c:1395: Test failed: got 00000000 clipboard.c:1396: Test failed: expected bitmap 00000000 clipboard.c:1398: Test failed: got 00000000 clipboard.c:1399: Test failed: expected bitmap 00000000 clipboard.c:1401: Test failed: got 00000000 clipboard.c:1402: Test failed: expected bitmap 00000000 clipboard.c:1404: Test failed: got 00000000 clipboard.c:1405: Test failed: expected palette 00000000 clipboard.c:1407: Test failed: got 00000000 clipboard.c:1408: Test failed: expected moveable mem 00000000 clipboard.c:1410: Test failed: got 00000000 clipboard.c:1411: Test failed: expected moveable mem 00000000 clipboard.c:1425: Test failed: got 00000000 clipboard.c:1426: Test failed: expected fixed mem 00000000 clipboard.c:1428: Test failed: got 00000000 clipboard.c:1429: Test failed: expected fixed mem 00000000 clipboard.c:1431: Test failed: got 00000000 clipboard.c:1432: Test failed: expected moveable mem 00000000 clipboard.c:1444: Test failed: wrong data 00000000 clipboard.c:1445: Test failed: expected moveable mem 00000000 clipboard.c:1448: Test failed: wrong data 00000000, cf 0000c040 clipboard.c:1449: Test failed: expected moveable mem 00000000 clipboard.c:1452: Test failed: wrong data 00000000 clipboard.c:1453: Test failed: expected moveable mem 00000000 clipboard.c:1456: Test failed: wrong data 00000000 clipboard.c:1457: Test failed: expected moveable mem 00000000 clipboard.c:1460: Test failed: wrong data 00000000 clipboard.c:1461: Test failed: expected fixed mem 00000000 clipboard.c:1464: Test failed: wrong data 00000000 clipboard.c:1465: Test failed: expected fixed mem 00000000 clipboard.c:1468: Test failed: wrong data 00000000 clipboard.c:1469: Test failed: expected moveable mem 00000000 clipboard.c:1475: Test failed: got 00000000 clipboard.c:1476: Test failed: expected moveable mem 00000000 clipboard.c:1477: Test failed: expected freed mem 00204462 clipboard.c:1480: Test failed: got 00000000 clipboard.c:1481: Test failed: expected fixed mem 00000000 clipboard.c:1486: Test failed: gle 1418 clipboard.c:1549: Test failed: wrong data 00000000 clipboard.c:1552: Test failed: wrong data 00000000, cf 0000c040 clipboard.c:1555: Test failed: wrong data 00000000 clipboard.c:1558: Test failed: wrong data 00000000 clipboard.c:1561: Test failed: wrong data 00000000 clipboard.c:1564: Test failed: wrong data 00000000 clipboard.c:1567: Test failed: wrong data 00000000 clipboard.c:1574: Test failed: expected fixed mem 00000000 clipboard.c:1576: Test failed: expected fixed mem 00000000 clipboard.c:1578: Test failed: expected fixed mem 00000000 clipboard.c:1580: Test failed: expected bitmap 00000000 clipboard.c:1582: Test failed: expected bitmap 00000000 clipboard.c:1584: Test failed: expected palette 00000000 clipboard.c:1586: Test failed: expected fixed mem 00000000 clipboard.c:1588: Test failed: expected fixed mem 00000000 clipboard.c:1600: Test failed: expected freed mem 00BED542 clipboard.c:1601: Test failed: expected freed mem 00BF247A clipboard.c:1602: Test failed: expected freed mem 002043F2 clipboard.c:1603: Test failed: expected freed mem 0020442A clipboard.c:1604: Test failed: expected freed mem 00BF1A7A input.c:2514: Test failed: 4: Unexpected cursor movement input.c:2514: Test failed: 5: Unexpected cursor movement input.c:2514: Test failed: 6: Unexpected cursor movement input.c:2514: Test failed: 7: Unexpected cursor movement input.c:2514: Test failed: 8: Unexpected cursor movement input.c:2235: Test failed: 9: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 9: Unexpected cursor movement input.c:2235: Test failed: 10: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 10: Unexpected cursor movement input.c:2235: Test failed: 11: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 11: Unexpected cursor movement input.c:2235: Test failed: 12: foreground process expected WM_MOUSEMOVE message input.c:2514: Test failed: 12: Unexpected cursor movement input.c:2514: Test failed: 13: Unexpected cursor movement input.c:2514: Test failed: 14: Unexpected cursor movement input.c:2514: Test failed: 15: Unexpected cursor movement input.c:2514: Test failed: 16: Unexpected cursor movement monitor: Timeout msg: Timeout sysparams.c:3349: Test failed: Expected ERROR_NO_MORE_FILES, ERROR_MOD_NOT_FOUND or 0xdeadbeef, got 0 win.c:10166: Test failed: Expected foreground window 000D013E, got 00000000 win.c:10173: Test failed: Expected foreground window 000D013E, got 00E10102 win.c:10176: Test failed: Received WM_ACTIVATEAPP(1), did not expect it. win.c:10185: Test failed: Expected foreground window 000D013E, got 00000000

July 30, 2020

[PATCH] user32: Fix return value of ScrollWindowEx for invisible windows.

by Myah Caron

From: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Myah Caron <qsniyg(a)protonmail.com> --- This is a staging patch. I've added a test, but left the patch otherwise untouched. dlls/user32/painting.c | 4 ++-- dlls/user32/tests/win.c | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c index 313c5fa1e6..2b4b7937aa 100644 --- a/dlls/user32/painting.c +++ b/dlls/user32/painting.c @@ -1484,10 +1484,10 @@ static INT scroll_window( HWND hwnd, INT dx, INT dy, const RECT *rect, const REC rdw_flags = (flags & SW_ERASE) && (flags & SW_INVALIDATE) ? RDW_INVALIDATE | RDW_ERASE : RDW_INVALIDATE ; - if (!WIN_IsWindowDrawable( hwnd, TRUE )) return ERROR; hwnd = WIN_GetFullHandle( hwnd ); - GetClientRect(hwnd, &rc); + if (!WIN_IsWindowDrawable( hwnd, TRUE )) SetRectEmpty(&rc); + else GetClientRect(hwnd, &rc); if (clipRect) IntersectRect(&cliprc,&rc,clipRect); else cliprc = rc; diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 700e60db17..354ed5a2c1 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -4920,6 +4920,7 @@ static void test_scrollwindow( HWND hwnd) HDC hdc; RECT rc, rc2, rc3; COLORREF colr; + INT ret; ShowWindow( hwnd, SW_SHOW); UpdateWindow( hwnd); @@ -4964,6 +4965,12 @@ static void test_scrollwindow( HWND hwnd) colr = GetPixel( hdc, (rc2.left+rc2.right)/ 2, rc2.bottom / 4 ); ok ( colr == 0, "pixel should be black, color is %08x\n", colr); + ShowWindow(hwnd, SW_HIDE); + UpdateWindow( hwnd); + flush_events( TRUE ); + ret = ScrollWindowEx( hwnd, 0, - rc2.top, &rc2, &rc3, NULL, NULL, SW_ERASE); + ok(ret == NULLREGION, "got ret %d\n", ret); + /* clean up */ ReleaseDC( hwnd, hdc); } -- 2.27.0

July 30, 2020

Re: [PATCH 2/3] ddraw: Return DDERR_WRONGMODE when attempting to restore surfaces of a lost device.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76310 Your paranoid android. === w1064v1809_2scr (32 bit report) === ddraw: ddraw7.c:15545: Test failed: Expected 22 surfaces, got 20. === w1064v1809_ja (32 bit report) === ddraw: ddraw7.c:4026: Test failed: Lit quad without normals has color 0x00ff0000, expected 0x00000000. ddraw7.c:4039: Test failed: Lit quad with normals has color 0x00ff0000, expected 0x00000000. ddraw7.c:4084: Test failed: Lit quad with non-affine matrix has color 0x00ff0000. === debiant (build log) === The task timed out

July 30, 2020

Re: Wine Gecko compile issues with GCC 10.1+

by Michael Cronenworth

On 7/30/20 8:29 AM, Jacek Caban wrote: > FWIW, I plan to port Wine Gecko to llvm-mingw and do my build with that for the > next release. Upstream Firefox uses clang for mingw builds for quite a while now > and it proved to be way more reliable. (GCC will obviously continue to work, at > least its non-broken versions). Thanks for the information. Fedora does not ship clang for MinGW so I will have to continue to use GCC.

July 30, 2020

Re: [PATCH 3/3] ddraw: Check the foreground window in addition to the device state in ddraw_update_lost_surfaces().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76311 Your paranoid android. === debiant (build log) === The task timed out === debiant (32 bit WoW report) === ddraw: ddraw1: Timeout === debiant (build log) === The task timed out

July 30, 2020

Re: Wine Gecko compile issues with GCC 10.1+

by Jacek Caban

Hi Michael, On 29.07.2020 20:23, Michael Cronenworth wrote: > Hi Jacek, > > I'm encountering an internal compiler error when using GCC 10.1 or > 10.2 to try and build Wine Gecko 2.47.1. Have you seen this already? > > In file included from > /builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/widget/windows/WinIMEHandler.cpp:26, > from > /builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1-x86/widget/windows/Unified_cpp_widget_windows0.cpp:110: > /usr/i686-w64-mingw32/sys-root/mingw/include/cfgmgr32.h: At global scope: > /usr/i686-w64-mingw32/sys-root/mingw/include/cfgmgr32.h:19: internal > compiler error: in linemap_compare_locations, at libcpp/line-map.c:1359 > 19 | typedef CONST VOID *PCVOID; > | > Please submit a full bug report, > with preprocessed source if appropriate. > See <http://bugzilla.redhat.com/bugzilla> for instructions. > make[3]: *** > [/builddir/build/BUILD/wine-gecko-2.47.1/wine-gecko-2.47.1/config/rules.mk:966: > Unified_cpp_widget_windows0.o] Error 1 Thanks for the report. I haven't yet updated my mingw GCC to 10 yet, so I didn't see the problem myself. Please report it to GCC, internal compiler errors are always compiler's fault and there is not much I can do. It seems that GCC support for Windows target is broken on every major release. FWIW, I plan to port Wine Gecko to llvm-mingw and do my build with that for the next release. Upstream Firefox uses clang for mingw builds for quite a while now and it proved to be way more reliable. (GCC will obviously continue to work, at least its non-broken versions). Thanks, Jacek

July 30, 2020

Re: [PATCH] wininet: Implement INTERNET_OPTION_SECURITY_CERTIFICATE flag for InternetQueryOption.

by Jacek Caban

Hi Daniel, Sorry for the delay. On 26.07.2020 03:21, Daniel Lehman wrote: > Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> > --- > dlls/wininet/http.c | 120 ++++++++++++++++++++++++++++++++++++++ > dlls/wininet/resource.h | 3 + > dlls/wininet/tests/http.c | 112 ++++++++++++++++++++++++++++++++++- > dlls/wininet/wininet.rc | 12 ++++ > 4 files changed, 245 insertions(+), 2 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 56c995805b..379455fddb 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -35,6 +35,7 @@ > #include <stdarg.h> > #include <stdio.h> > #include <time.h> > +#include <math.h> > #include <assert.h> > #include <errno.h> > #include <limits.h> > @@ -54,6 +55,7 @@ > > #include "internet.h" > #include "zlib.h" > +#include "resource.h" > #include "wine/debug.h" > #include "wine/exception.h" > > @@ -2273,6 +2275,124 @@ static DWORD HTTPREQ_QueryOption(object_header_t *hdr, DWORD option, void *buffe > } > return ERROR_NOT_SUPPORTED; > } > + case INTERNET_OPTION_SECURITY_CERTIFICATE: { > + char fmt[256]; > + const char nullA[] = "(null)"; /* always appears in English */ > + CERT_CONTEXT *context; > + char *subject = NULL; > + char *issuer = NULL; > + char *start_date = NULL; > + char *start_time = NULL; > + char *expiry_date = NULL; > + char *expiry_time = NULL; > + char strength[16]; > + int subject_len, issuer_len; > + int start_date_len, start_time_len; > + int expiry_date_len, expiry_time_len; > + SYSTEMTIME start, expiry; > + DWORD needed, keysize; > + > + if (PRIMARYLANGID(GetUserDefaultLangID()) != LANG_ENGLISH) > + FIXME("INTERNET_OPTION_SECURITY_CERTIFICATE currently English-only\n"); > + > + if(!req->netconn) > + return ERROR_INTERNET_INVALID_OPERATION; > + > + if(!size) > + return ERROR_INVALID_PARAMETER; > + > + if(!buffer) { > + *size = 1; > + return ERROR_INSUFFICIENT_BUFFER; > + } > + > + context = (CERT_CONTEXT *)NETCON_GetCert(req->netconn); > + if(!context)(Decoding strings directly to return buffer would be another option). > + return ERROR_NOT_SUPPORTED; > + > + needed = LoadStringA(WININET_hModule, IDS_CERT_FORMAT, fmt, sizeof(fmt)); > + needed += 1 - 20 * 2 + 9; /* include room for \0, subtract 20 format specifiers, add 9 \r */ > + if(needed > *size) goto error; > + > + subject_len = CertNameToStrA(context->dwCertEncodingType, &context->pCertInfo->Subject, > + CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); > + needed += subject_len - 1; /* minus \0 */ > + if(needed > *size) goto error; > + > + issuer_len = CertNameToStrA(context->dwCertEncodingType, &context->pCertInfo->Issuer, > + CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); > + needed += issuer_len - 1; > + if(needed > *size) goto error; > + > + FileTimeToSystemTime(&context->pCertInfo->NotBefore, &start); > + start_date_len = GetDateFormatA(LOCALE_USER_DEFAULT, 0, &start, NULL, NULL, 0); > + start_time_len = GetTimeFormatA(LOCALE_USER_DEFAULT, 0, &start, NULL, NULL, 0); > + needed += start_date_len + start_time_len - 2; > + if(needed > *size) goto error; > + > + FileTimeToSystemTime(&context->pCertInfo->NotAfter, &expiry); > + expiry_date_len = GetDateFormatA(LOCALE_USER_DEFAULT, 0, &expiry, NULL, NULL, 0); > + expiry_time_len = GetTimeFormatA(LOCALE_USER_DEFAULT, 0, &expiry, NULL, NULL, 0); > + needed += expiry_date_len + expiry_time_len - 2; > + if(needed > *size) goto error; > + > + needed += sizeof(nullA) * 3 - 3; /* protocol, signature type, encryption type */ > + if(needed > *size) goto error; > + > + keysize = NETCON_GetCipherStrength(req->netconn); > + needed += keysize ? floor(log10(keysize))+1 : 1; > + needed += LoadStringA(WININET_hModule, keysize >= 128 ? IDS_CERT_HIGH : IDS_CERT_LOW, > + strength, sizeof(strength)); > + if(needed > *size) goto error; > + > + if(!(subject = heap_alloc(subject_len)) || > + !(issuer = heap_alloc(issuer_len)) || > + !(start_date = heap_alloc(start_date_len)) || > + !(start_time = heap_alloc(start_time_len)) || > + !(expiry_date = heap_alloc(expiry_date_len)) || > + !(expiry_time = heap_alloc(expiry_time_len))) > + goto error; If you're using dynamic allocation anyway, you could as well move INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT to a helper and operate on INTERNET_CERTIFICATE_INFO here, maybe even combined with _cprintf for size check. It should simplify things a bit. Date and time strings should be fine with buffers on a stack. (Decoding strings directly to return buffer would be another option, but it's necessarily worth the complication). > diff --git a/dlls/wininet/wininet.rc b/dlls/wininet/wininet.rc > index b6e35629ca..7e2830e7ff 100644 > --- a/dlls/wininet/wininet.rc > +++ b/dlls/wininet/wininet.rc > @@ -29,6 +29,18 @@ STRINGTABLE > IDS_CERT_DATE_INVALID "The date on the certificate is invalid." > IDS_CERT_CN_INVALID "The name on the certificate does not match the site." > IDS_CERT_ERRORS "There is at least one unspecified security problem with this certificate." > + > + /* each %c is a \r */ > + IDS_CERT_FORMAT "Subject:%c\n%s%c\n" \ > + "Issuer:%c\n%s%c\n" \ > + "Effective Date:\t%s %s%c\n" \ > + "Expiration Date:\t%s %s%c\n" \ > + "Security Protocol:\t%s%c\n" \ > + "Signature Type:\t%s%c\n" \ > + "Encryption Type:\t%s%c\n" \ > + "Privacy Strength:\t%s (%u bits)" > + IDS_CERT_HIGH "High" > + IDS_CERT_LOW "Low" You could use \015 as \r replacement instead of %c trick. Thanks, Jacek

July 30, 2020

Re: [PATCH 1/3] ddraw/tests: Test non-primary video memory surface in test_lost_device().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76309 Your paranoid android. === w1064v1809_2scr (32 bit report) === ddraw: ddraw7.c:15533: Test failed: Expected 22 surfaces, got 20. === debiant (build log) === The task timed out

July 30, 2020

Re: [PATCH v3] vbscript: implement case insensitive comparison

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

July 30, 2020