August 2020 - Wine-Devel - list.winehq.org

[PATCH 1/2] wininet: Move INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT handling to helper.

by Daniel Lehman

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> --- dlls/wininet/http.c | 62 ++++++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 29 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 56c995805b..220493718c 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -2083,6 +2083,38 @@ static DWORD str_to_buffer(const WCHAR *str, void *buffer, DWORD *size, BOOL uni } } +static DWORD get_security_cert_struct(http_request_t *req, INTERNET_CERTIFICATE_INFOA *info) +{ + PCCERT_CONTEXT context; + DWORD len; + + context = (PCCERT_CONTEXT)NETCON_GetCert(req->netconn); + if(!context) + return ERROR_NOT_SUPPORTED; + + memset(info, 0, sizeof(*info)); + info->ftExpiry = context->pCertInfo->NotAfter; + info->ftStart = context->pCertInfo->NotBefore; + len = CertNameToStrA(context->dwCertEncodingType, + &context->pCertInfo->Subject, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); + info->lpszSubjectInfo = LocalAlloc(0, len); + if(info->lpszSubjectInfo) + CertNameToStrA(context->dwCertEncodingType, + &context->pCertInfo->Subject, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, + info->lpszSubjectInfo, len); + len = CertNameToStrA(context->dwCertEncodingType, + &context->pCertInfo->Issuer, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); + info->lpszIssuerInfo = LocalAlloc(0, len); + if(info->lpszIssuerInfo) + CertNameToStrA(context->dwCertEncodingType, + &context->pCertInfo->Issuer, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, + info->lpszIssuerInfo, len); + info->dwKeySize = NETCON_GetCipherStrength(req->netconn); + + CertFreeCertificateContext(context); + return ERROR_SUCCESS; +} + static DWORD HTTPREQ_QueryOption(object_header_t *hdr, DWORD option, void *buffer, DWORD *size, BOOL unicode) { http_request_t *req = (http_request_t*)hdr; @@ -2235,8 +2267,6 @@ static DWORD HTTPREQ_QueryOption(object_header_t *hdr, DWORD option, void *buffe } case INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT: { - PCCERT_CONTEXT context; - if(!req->netconn) return ERROR_INTERNET_INVALID_OPERATION; @@ -2245,33 +2275,7 @@ static DWORD HTTPREQ_QueryOption(object_header_t *hdr, DWORD option, void *buffe return ERROR_INSUFFICIENT_BUFFER; } - context = (PCCERT_CONTEXT)NETCON_GetCert(req->netconn); - if(context) { - INTERNET_CERTIFICATE_INFOA *info = (INTERNET_CERTIFICATE_INFOA*)buffer; - DWORD len; - - memset(info, 0, sizeof(*info)); - info->ftExpiry = context->pCertInfo->NotAfter; - info->ftStart = context->pCertInfo->NotBefore; - len = CertNameToStrA(context->dwCertEncodingType, - &context->pCertInfo->Subject, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); - info->lpszSubjectInfo = LocalAlloc(0, len); - if(info->lpszSubjectInfo) - CertNameToStrA(context->dwCertEncodingType, - &context->pCertInfo->Subject, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, - info->lpszSubjectInfo, len); - len = CertNameToStrA(context->dwCertEncodingType, - &context->pCertInfo->Issuer, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, NULL, 0); - info->lpszIssuerInfo = LocalAlloc(0, len); - if(info->lpszIssuerInfo) - CertNameToStrA(context->dwCertEncodingType, - &context->pCertInfo->Issuer, CERT_SIMPLE_NAME_STR|CERT_NAME_STR_CRLF_FLAG, - info->lpszIssuerInfo, len); - info->dwKeySize = NETCON_GetCipherStrength(req->netconn); - CertFreeCertificateContext(context); - return ERROR_SUCCESS; - } - return ERROR_NOT_SUPPORTED; + return get_security_cert_struct(req, (INTERNET_CERTIFICATE_INFOA*)buffer); } case INTERNET_OPTION_CONNECT_TIMEOUT: if (*size < sizeof(DWORD)) -- 2.25.1

Aug. 2, 2020

[PATCH] comdlg32: Filename should be filled after CDN_INITDONE (fixes bug #33590)

by Mikołaj Zalewski

Aug. 2, 2020

[PATCH] ntdll: Return from Thumb to ARM move after assembling raise_func_trampoline_thumb.

by Mikołaj Zalewski

Aug. 2, 2020

[PATCH] msi: Fix a leak (Coverity).

by Sven Baars

Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> --- dlls/msi/table.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index 612a3695973..e9d6e8804e7 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -2887,6 +2887,7 @@ UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR name, MSIV colinfo[idx - 1].colname = msi_string_lookup( st, name_id, NULL ); else ERR( "column name %s is not defined in strings table\n", wine_dbgstr_w(name) ); + msiobj_release( &rec->hdr ); } MSI_ViewClose( q ); msiobj_release( &q->hdr ); -- 2.24.0

Aug. 2, 2020

[PATCH] sechost: Free the right variable (Coverity).

by Sven Baars

Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> --- dlls/sechost/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/sechost/service.c b/dlls/sechost/service.c index 68d2b9e78e6..5beff41a164 100644 --- a/dlls/sechost/service.c +++ b/dlls/sechost/service.c @@ -1031,7 +1031,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH StartServiceA( SC_HANDLE service, DWORD argc, cons for (i = 0; i < argc; i++) heap_free( argvW[i] ); - heap_free( argv ); + heap_free( argvW ); return r; } -- 2.24.0

Aug. 2, 2020

[PATCH] wbemprox: Avoid a use after free (Coverity).

by Sven Baars

Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> --- dlls/wbemprox/builtin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index f055547a6b9..4edda854b58 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -2116,9 +2116,9 @@ static WCHAR *get_diskdrive_serialnumber( WCHAR letter ) heap_free( desc ); break; } + size = desc->Size; heap_free( desc ); - if (GetLastError() == ERROR_MORE_DATA) size = desc->Size; - else break; + if (GetLastError() != ERROR_MORE_DATA) break; } done: -- 2.24.0

Aug. 2, 2020

[PATCH] ntoskrnl.exe/tests: Add a missing argument to an ok call (Coverity).

by Sven Baars

Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> --- dlls/ntoskrnl.exe/tests/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c index d3f62879a40..7a325753d48 100644 --- a/dlls/ntoskrnl.exe/tests/driver.c +++ b/dlls/ntoskrnl.exe/tests/driver.c @@ -1614,7 +1614,7 @@ static void test_completion(void) IoSetCompletionRoutine(irp, completion_cb, NULL, TRUE, TRUE, TRUE); ret = IoCallDriver(upper_device, irp); ok(ret == STATUS_SUCCESS, "IoCallDriver returned %#x\n", ret); - ok(got_completion == 2, "got %u calls to completion routine\n"); + ok(got_completion == 2, "got %u calls to completion routine\n", got_completion); } static void test_IoAttachDeviceToDeviceStack(void) -- 2.24.0

Aug. 2, 2020

[PATCH] prntvpt: Fix a null check (Coverity).

by Sven Baars

Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> --- dlls/prntvpt/ticket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/prntvpt/ticket.c b/dlls/prntvpt/ticket.c index 132a117a249..13aaf80423f 100644 --- a/dlls/prntvpt/ticket.c +++ b/dlls/prntvpt/ticket.c @@ -740,7 +740,7 @@ HRESULT WINAPI PTConvertPrintTicketToDevMode(HPTPROVIDER provider, IStream *stre if (hr != S_OK) return hr; *dm = heap_alloc(sizeof(**dm)); - if (!dm) return E_OUTOFMEMORY; + if (!*dm) return E_OUTOFMEMORY; ticket_to_devmode(&ticket, *dm); *size = sizeof(**dm); -- 2.24.0

Aug. 2, 2020

Re: [PATCH] user32: Fix wsprintfA's buffer usage when using %S.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=76411 Your paranoid android. === debiant (32 bit report) === user32: monitor: Timeout === debiant (32 bit Chinese:China report) === user32: monitor: Timeout msg.c:13458: Test failed: MonitorFromPoint error 3735928559 msg.c:13463: Test failed: GetMonitorInfo error 1461 msg.c:13507: Test failed: 9: ShowWindow(SW_SHOWMAXIMIZED): 6: in msg 0x0047 expecting wParam 0x8160 got 0x8960 msg.c:13507: Test failed: 44: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8130 got 0x8930 msg.c:13507: Test failed: 46: ShowWindow(SW_RESTORE): 6: in msg 0x0047 expecting wParam 0x8120 got 0x8920 msg.c:11902: Test failed: wrong qstatus 00090000 msg.c:11911: Test failed: wrong qstatus 00490040 msg.c:11932: Test failed: wrong qstatus 00090000 msg.c:11940: Test failed: wrong qstatus 00490040 msg.c:11951: Test failed: wrong qstatus 00090000 msg.c:11962: Test failed: wrong qstatus 00010000 msg.c:11973: Test failed: wrong qstatus 00010000 msg.c:11978: Test failed: got 0 and 0000 instead of TRUE and WM_PAINT msg.c:11981: Test failed: WmPaint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg: Timeout static.c:114: Test failed: g_nReceivedColorStatic expected 4 got 0 static.c:114: Test failed: g_nReceivedColorStatic expected 4 got 0 static.c:112: Test failed: expected 4 got 0 static.c:112: Test failed: expected 4 got 0 static.c:112: Test failed: expected 4 got 0 sysparams.c:3176: Test failed: get_primary_adapter_name failed sysparams.c:3178: Test failed: EnumDisplaySettingsA failed, error 0x6 sysparams.c:3180: Test failed: EnumDisplaySettingsA failed, error 0x6 sysparams.c:3187: Test failed: EnumDisplaySettingsA failed, error 0x6 sysparams.c:3188: Test failed: Expect dmSize 124, got 0 sysparams.c:3190: Test failed: Expect dmFields to contain 0x7c00a0, got 0 sysparams.c:3196: Test failed: EnumDisplaySettingsA failed, error 0x6 sysparams.c:3197: Test failed: Expect dmSize 124, got 156 sysparams.c:3199: Test failed: Expect dmFields to contain 0x7c00a0, got 0 sysparams.c:3204: Test failed: EnumDisplaySettingsW failed, error 0x6 sysparams.c:3205: Test failed: Expect dmSize 188, got 0 sysparams.c:3207: Test failed: Expect dmFields to contain 0x7c00a0, got 0 sysparams.c:3213: Test failed: EnumDisplaySettingsW failed, error 0x6 sysparams.c:3214: Test failed: Expect dmSize 188, got 220 sysparams.c:3216: Test failed: Expect dmFields to contain 0x7c00a0, got 0 sysparams.c:3235: Test failed: EnumDisplaySettingsExA failed, error 0x6 sysparams.c:3236: Test succeeded inside todo block: Expect dmSize unchanged, got 40 sysparams.c:3237: Test succeeded inside todo block: Expect dmFields unchanged, got 0 sysparams.c:3242: Test failed: EnumDisplaySettingsExA failed, error 0x6 sysparams.c:3243: Test succeeded inside todo block: Expect dmSize unchanged, got 41 sysparams.c:3247: Test succeeded inside todo block: Expect dmPelsWidth unwritten sysparams.c:3252: Test failed: EnumDisplaySettingsExW failed, error 0x6 sysparams.c:3253: Test succeeded inside todo block: Expect dmSize unchanged, got 72 sysparams.c:3254: Test succeeded inside todo block: Expect dmFields unchanged, got 0 sysparams.c:3259: Test failed: EnumDisplaySettingsExW failed, error 0x6 sysparams.c:3260: Test succeeded inside todo block: Expect dmSize unchanged, got 73 sysparams.c:3264: Test succeeded inside todo block: Expect dmPelsWidth unwritten sysparams.c:3273: Test failed: EnumDisplaySettingsExA failed, error 0x6 sysparams.c:3274: Test failed: Expect dmFields to contain 0x7c00a0, got 0 sysparams.c:3276: Test failed: Expect dmBitsPerPel 32, got 0 sysparams.c:3281: Test failed: Screen bpp is 0, NUMCOLORS returned -1 sysparams.c:3495: Test failed: failed to get monitor sysparams.c:3497: Test failed: GetMonitorInfoExW failed sysparams.c:3498: Test failed: 0: wrong monitor rect (8387358,8387384)-(2121591143,1) expected (0,0)-(0,0) sysparams.c:3495: Test failed: failed to get monitor sysparams.c:3497: Test failed: GetMonitorInfoExW failed sysparams.c:3498: Test failed: 1: wrong monitor rect (8387358,8387384)-(2121591143,1) expected (0,0)-(0,0) sysparams.c:3495: Test failed: failed to get monitor sysparams.c:3497: Test failed: GetMonitorInfoExW failed sysparams.c:3498: Test failed: 2: wrong monitor rect (8387358,8387384)-(2121591143,1) expected (0,0)-(0,0) sysparams.c:3575: Test failed: 0/0: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 0/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 0/0: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 0/0: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 0/0: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 0/0: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 0/1: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 0/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 0/1: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 0/1: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 0/1: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 0/1: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 0/2: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 0/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 0/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 0/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 0/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 0/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 0/2: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 0/2: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 0/2: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 0/2: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 1/0: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 1/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 1/0: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 1/0: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 1/0: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 1/0: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 1/1: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 1/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 1/1: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 1/1: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 1/1: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 1/1: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 1/2: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 1/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 1/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 1/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 1/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 1/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 1/2: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 1/2: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 1/2: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 1/2: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 2/0: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 2/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/0/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/0/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/0/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/0/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/0/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/0/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 2/0: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 2/0: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 2/0: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 2/0: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 2/1: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 2/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/1/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/1/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/1/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/1/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/1/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/1/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 2/1: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 2/1: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 2/1: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 2/1: PhysicalToLogicalPointForPerMonitorDPI failed sysparams.c:3575: Test failed: 2/2: wrong clip box (0,0)-(0,0) expected (0,0)-(128,0) sysparams.c:3610: Test failed: 2/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3610: Test failed: 2/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3614: Test failed: 2/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/2/0: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/2/0: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/2/1: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/2/1: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3626: Test failed: 2/2/2: wrong update region (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3630: Test failed: 2/2/2: wrong update rect (0,0)-(0,0) expected (20,20)-(25,25) sysparams.c:3645: Test failed: 2/2: wrong update region (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3649: Test failed: 2/2: wrong update rect (0,0)-(0,0) expected (50,50)-(78,-50) sysparams.c:3688: Test failed: 2/2: LogicalToPhysicalPointForPerMonitorDPI failed sysparams.c:3695: Test failed: 2/2: PhysicalToLogicalPointForPerMonitorDPI failed text.c:87: Test failed: In MM_HIENGLISH, DrawText with DT_CALCRECT should return a negative rectangle bottom. (bot=0) win.c:8320: Test failed: MonitorFromPoint error 3735928559 win.c:8325: Test failed: GetMonitorInfo error 1461 win.c:8406: Test failed: 0/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0/0x1010000: window rect (0,0)-(130,21) win.c:8406: Test failed: 0x40000/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x40000/0x1010000: window rect (0,0)-(130,21) win.c:8406: Test failed: 0x80/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x80/0x1010000: window rect (0,0)-(130,21) win.c:8406: Test failed: 0/0x1c50000: window rect (0,0)-(128,19) must be in (0,0)-(0,0) win.c:8426: Test failed: 0/0x1050000: window rect (0,0)-(128,19) win.c:8406: Test failed: 0x40000/0x1c50000: window rect (0,0)-(128,19) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x40000/0x1050000: window rect (0,0)-(128,19) win.c:8406: Test failed: 0x80/0x1c50000: window rect (0,0)-(128,19) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x80/0x1050000: window rect (0,0)-(128,19) win.c:8406: Test failed: 0/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0/0x1410000: window rect (0,0)-(130,21) win.c:8406: Test failed: 0x40000/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x40000/0x1410000: window rect (0,0)-(130,21) win.c:8406: Test failed: 0x80/0x1c10000: window rect (0,0)-(130,21) must be in (0,0)-(0,0) win.c:8426: Test failed: 0x80/0x1410000: window rect (0,0)-(130,21) win.c:8455: Test failed: Expect width 100, got 12. win.c:8456: Test failed: Expect height 100, got 12. win.c:8038: Test failed: wrong window rect (100,100)-(236,127) win.c:6140: Test failed: parent client rect is empty win.c:5873: Test failed: 003F005C msg 81 wrong rect (300000,300000)-(300136,300027) / (0,0)-(12,12) win.c:5873: Test failed: 003F005C msg 1 wrong rect (300000,300000)-(300136,300027) / (0,0)-(12,12) win.c:2064: Test failed: DefWindowProc should not change WINDOWPOS: 001E00DC after 00000000, x -4, y -4, cx 136, cy 27 flags 00008030 win.c:2064: Test failed: DefWindowProc should not change WINDOWPOS: 002D00DC after 00000000, x -4, y -4, cx 136, cy 27 flags 00008030 win.c:2708: Test succeeded inside todo block: GetActiveWindow() = 00F0008E win.c:2708: Test succeeded inside todo block: GetForegroundWindow() = 00F0008E win.c:2708: Test succeeded inside todo block: GetFocus() = 00F0008E win.c:7877: Test succeeded inside todo block: Detected infinite WM_PAINT loop (401). win.c:4945: Test failed: pixel should be black, color is ffffffff win.c:4965: Test failed: pixel should be black, color is ffffffff win.c:5006: Test failed: wrong update region win.c:5021: Test failed: wrong update region win.c:5041: Test failed: unexpected update rect: (20,40)-(30,50) win.c:5055: Test failed: wrong update region win.c:5065: Test failed: wrong update region in excessive scroll win.c:5087: Test failed: wrong update region win.c:5096: Test failed: wrong update region win.c:5105: Test failed: wrong update region win.c:5120: Test failed: wrong update region win.c:5196: Test failed: pixel should be black, color is ffffffff win.c:5200: Test failed: pixel should be black, color is ffffffff win.c:5205: Test failed: rects do not match (0,0)-(0,0) / (0,0)-(100,100) win.c:5216: Test failed: wrong update region win.c:5227: Test failed: wrong update region win.c:1156: Test failed: window rect does not match: style:exstyle=0x14d00000:0x00000100, menu=0, win=(110,100)-(246,127), calc=(110,100)-(246,143) win.c:1163: Test failed: window rect does not match: style:exstyle=0x14d00000:0x00000100, menu=0, win=(110,100)-(246,127), calc=(110,100)-(246,143) win.c:5454: Test failed: Multiple unexpected WM_PAINT calls 0 win.c:5649: Test failed: window main, rect client, field right: expected 150, got 0 win.c:5649: Test failed: window main, rect client, field bottom: expected 150, got 0 win.c:5649: Test failed: window main, rect clip, field right: expected 150, got 0 win.c:5649: Test failed: window main, rect clip, field bottom: expected 150, got 0 win.c:5649: Test failed: window main, rect paint, field right: expected 150, got 0 win.c:5649: Test failed: window main, rect paint, field bottom: expected 150, got 0 win.c:5649: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5649: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5649: Test failed: window child1, rect paint, field right: expected 40, got 0 win.c:5649: Test failed: window child1, rect paint, field bottom: expected 40, got 0 win.c:5649: Test failed: window child2, rect client, field right: expected 40, got 0 win.c:5649: Test failed: window child2, rect client, field bottom: expected 40, got 0 win.c:5649: Test failed: window child2, rect paint, field right: expected 40, got 0 win.c:5649: Test failed: window child2, rect paint, field bottom: expected 40, got 0 win.c:5655: Test failed: window main, rect client, field right: expected 150, got 0 win.c:5655: Test failed: window main, rect client, field bottom: expected 150, got 0 win.c:5655: Test failed: window main, rect clip, field right: expected 50, got 0 win.c:5655: Test failed: window main, rect clip, field bottom: expected 50, got 0 win.c:5655: Test failed: window main, rect paint, field right: expected 50, got 0 win.c:5655: Test failed: window main, rect paint, field bottom: expected 50, got 0 win.c:5655: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5655: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5655: Test failed: window child1, rect clip, field right: expected 30, got 0 win.c:5655: Test failed: window child1, rect clip, field bottom: expected 30, got 0 win.c:5655: Test failed: window child1, rect paint, field right: expected 30, got 0 win.c:5655: Test failed: window child1, rect paint, field bottom: expected 30, got 0 win.c:5655: Test failed: window child2, rect client, field right: expected 40, got 0 win.c:5655: Test failed: window child2, rect client, field bottom: expected 40, got 0 win.c:5655: Test failed: window child2, rect clip, field right: expected 10, got 0 win.c:5655: Test failed: window child2, rect clip, field bottom: expected 10, got 0 win.c:5655: Test failed: window child2, rect paint, field right: expected 10, got 0 win.c:5655: Test failed: window child2, rect paint, field bottom: expected 10, got 0 win.c:5661: Test failed: window main, rect client, field right: expected 150, got 0 win.c:5661: Test failed: window main, rect client, field bottom: expected 150, got 0 win.c:5661: Test failed: window main, rect clip, field right: expected 10, got 0 win.c:5661: Test failed: window main, rect clip, field bottom: expected 10, got 0 win.c:5661: Test failed: window main, rect paint, field right: expected 10, got 0 win.c:5661: Test failed: window main, rect paint, field bottom: expected 10, got 0 win.c:5667: Test failed: window main, rect client, field right: expected 150, got 0 win.c:5667: Test failed: window main, rect client, field bottom: expected 150, got 0 win.c:5667: Test failed: window main, rect clip, field left: expected 40, got 0 win.c:5667: Test failed: window main, rect clip, field top: expected 40, got 0 win.c:5667: Test failed: window main, rect clip, field right: expected 50, got 0 win.c:5667: Test failed: window main, rect clip, field bottom: expected 50, got 0 win.c:5667: Test failed: window main, rect paint, field left: expected 40, got 0 win.c:5667: Test failed: window main, rect paint, field top: expected 40, got 0 win.c:5667: Test failed: window main, rect paint, field right: expected 50, got 0 win.c:5667: Test failed: window main, rect paint, field bottom: expected 50, got 0 win.c:5667: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5667: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5667: Test failed: window child1, rect clip, field left: expected 20, got 0 win.c:5667: Test failed: window child1, rect clip, field top: expected 20, got 0 win.c:5667: Test failed: window child1, rect clip, field right: expected 30, got 0 win.c:5667: Test failed: window child1, rect clip, field bottom: expected 30, got 0 win.c:5667: Test failed: window child1, rect paint, field left: expected 20, got 0 win.c:5667: Test failed: window child1, rect paint, field top: expected 20, got 0 win.c:5667: Test failed: window child1, rect paint, field right: expected 30, got 0 win.c:5667: Test failed: window child1, rect paint, field bottom: expected 30, got 0 win.c:5667: Test failed: window child2, rect client, field right: expected 40, got 0 win.c:5667: Test failed: window child2, rect client, field bottom: expected 40, got 0 win.c:5667: Test failed: window child2, rect clip, field right: expected 10, got 0 win.c:5667: Test failed: window child2, rect clip, field bottom: expected 10, got 0 win.c:5667: Test failed: window child2, rect paint, field right: expected 10, got 0 win.c:5667: Test failed: window child2, rect paint, field bottom: expected 10, got 0 win.c:5673: Test failed: window main, rect client, field right: expected 150, got 0 win.c:5673: Test failed: window main, rect client, field bottom: expected 150, got 0 win.c:5673: Test failed: window main, rect clip, field left: expected 20, got 0 win.c:5673: Test failed: window main, rect clip, field top: expected 20, got 0 win.c:5673: Test failed: window main, rect clip, field right: expected 60, got 0 win.c:5673: Test failed: window main, rect clip, field bottom: expected 60, got 0 win.c:5673: Test failed: window main, rect paint, field left: expected 20, got 0 win.c:5673: Test failed: window main, rect paint, field top: expected 20, got 0 win.c:5673: Test failed: window main, rect paint, field right: expected 60, got 0 win.c:5673: Test failed: window main, rect paint, field bottom: expected 60, got 0 win.c:5673: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5673: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5673: Test failed: window child1, rect paint, field right: expected 40, got 0 win.c:5673: Test failed: window child1, rect paint, field bottom: expected 40, got 0 win.c:5673: Test failed: window child2, rect client, field right: expected 40, got 0 win.c:5673: Test failed: window child2, rect client, field bottom: expected 40, got 0 win.c:5673: Test failed: window child2, rect clip, field right: expected 20, got 0 win.c:5673: Test failed: window child2, rect clip, field bottom: expected 20, got 0 win.c:5673: Test failed: window child2, rect paint, field right: expected 20, got 0 win.c:5673: Test failed: window child2, rect paint, field bottom: expected 20, got 0 win.c:5679: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5679: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5679: Test failed: window child1, rect clip, field right: expected 10, got 0 win.c:5679: Test failed: window child1, rect clip, field bottom: expected 10, got 0 win.c:5679: Test failed: window child1, rect paint, field right: expected 10, got 0 win.c:5679: Test failed: window child1, rect paint, field bottom: expected 10, got 0 win.c:5685: Test failed: window child1, rect client, field right: expected 40, got 0 win.c:5685: Test failed: window child1, rect client, field bottom: expected 40, got 0 win.c:5685: Test failed: window child1, rect paint, field right: expected 40, got 0 win.c:5685: Test failed: window child1, rect paint, field bottom: expected 40, got 0 win.c:6984: Test failed: expected (20,20)-(210,110), got (20,20)-(156,47) win.c:6995: Test failed: expected (20,20)-(210,110), got (20,20)-(156,47) win.c:7048: Test failed: expected (20,20)-(210,110), got (20,20)-(156,47) win.c:7062: Test failed: expected (-3,-3)-(3,3), got (-3,-3)-(133,24) win.c:7069: Test failed: expected (300,300)-(500,500), got (300,300)-(436,327) win.c:7080: Test failed: expected (20,20)-(210,110), got (20,20)-(156,47) win.c:7255: Test failed: expected (123,142)-(313,232), got (123,142)-(259,169) win.c:7307: Test failed: expected (123,142)-(313,232), got (123,142)-(259,169) win.c:7322: Test failed: expected (99,118)-(401,401), got (99,118)-(235,145) win.c:7330: Test failed: expected (403,422)-(603,622), got (403,422)-(539,449) win.c:7341: Test failed: expected (123,142)-(313,232), got (123,142)-(259,169) win.c:7702: Test failed: GetUpdateRect returned empty region win.c:7703: Test failed: rects do not match (0,0)-(0,0) / (10,10)-(40,40) win.c:7717: Test failed: WM_PAINT should have been received in parent win.c:7761: Test failed: GetUpdateRect returned empty region win.c:7762: Test failed: rects do not match (0,0)-(0,0) / (10,10)-(40,40) win.c:7776: Test failed: WM_PAINT should have been received in parent win.c:3372: Test succeeded inside todo block: Expected active window 00B400CC, got 00B400CC. win.c:3373: Test succeeded inside todo block: Expected focus window 00B400CC, got 00B400CC. win.c:9739: Test failed: assigned and retrieved update regions are different win.c:9762: Test failed: wrong update region win.c:9974: Test failed: pos = 00000000 win.c:9978: Test failed: pos = 00000000 win.c:9982: Test failed: pos = 00000000 win.c:9988: Test failed: pos = 00000000 win.c:9995: Test failed: pos = 00000000 win.c:10001: Test failed: pos = 00000000 win.c:10005: Test failed: pos = 00000000 win.c:10009: Test failed: pos = 00000000 win.c:10021: Test failed: pos = 00000000 win.c:10490: Test succeeded inside todo block: 0: GetPixel: got ffffffff, expected ffffffff win.c:10492: Test succeeded inside todo block: 0: GetPixel: got ffffffff, expected ffffffff win.c:10490: Test failed: 1: GetPixel: got ffffffff, expected 00111100 win.c:10492: Test failed: 1: GetPixel: got ffffffff, expected 00222200 win.c:10494: Test failed: 1: GetPixel: got ffffffff, expected 00222200 win.c:10490: Test failed: 2: GetPixel: got ffffffff, expected 00111100 win.c:10492: Test failed: 2: GetPixel: got ffffffff, expected 00222200 win.c:10494: Test failed: 2: GetPixel: got ffffffff, expected 00222200 win.c:10490: Test failed: 3: GetPixel: got ffffffff, expected 00111100 win.c:10492: Test failed: 3: GetPixel: got ffffffff, expected 00222200 win.c:10494: Test failed: 3: GetPixel: got ffffffff, expected 00222200 win.c:10490: Test succeeded inside todo block: 4: GetPixel: got ffffffff, expected ffffffff win.c:10492: Test succeeded inside todo block: 4: GetPixel: got ffffffff, expected ffffffff win.c:10490: Test failed: 5: GetPixel: got ffffffff, expected 00111100 win.c:10492: Test failed: 5: GetPixel: got ffffffff, expected 00222200 win.c:10494: Test failed: 5: GetPixel: got ffffffff, expected 00222200 win.c:10490: Test succeeded inside todo block: 6: GetPixel: got ffffffff, expected ffffffff win.c:10492: Test succeeded inside todo block: 6: GetPixel: got ffffffff, expected ffffffff win.c:10490: Test failed: 7: GetPixel: got ffffffff, expected 00111100 win.c:10492: Test failed: 7: GetPixel: got ffffffff, expected 00222200 win.c:10494: Test failed: 7: GetPixel: got ffffffff, expected 00222200 win.c:11426: Test failed: got normal pos (100,200)-(236,227) win.c:11439: Test failed: got normal pos (100,200)-(236,227) win.c:11451: Test failed: got normal pos (100,200)-(236,227) win.c:11464: Test failed: got normal pos (100,200)-(236,227) win.c:11476: Test failed: got normal pos (100,200)-(236,227) win.c:11490: Test failed: got normal pos (100,200)-(236,227) win.c:11503: Test failed: got normal pos (100,200)-(236,227) win.c:11516: Test failed: got normal pos (100,200)-(236,227) win.c:11534: Test failed: got normal pos (200,300)-(336,327) win.c:11537: Test failed: got window rect (200,300)-(336,327) win.c:11550: Test failed: got normal pos (200,300)-(336,327) win.c:11572: Test failed: got normal pos (100,200)-(236,227) win.c:11593: Test failed: got normal pos (100,200)-(236,227) win.c:11646: Test failed: hwnd 0: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 1: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 2: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 3: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 4: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 5: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 6: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 7: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 8: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11646: Test failed: hwnd 9: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 1: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 2: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 3: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 4: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 5: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 6: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 7: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 8: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11674: Test failed: hwnd 9: expected rect (204,423)-(404,623), got (204,423)-(340,450) win.c:11703: Test failed: hwnd 0: expected rect (144,253)-(250,277), got (144,226)-(250,250) win.c:11703: Test failed: hwnd 1: expected rect (144,280)-(250,304), got (144,253)-(250,277) win.c:11703: Test failed: hwnd 2: expected rect (144,307)-(250,331), got (144,280)-(250,304) win.c:11703: Test failed: hwnd 3: expected rect (144,334)-(250,358), got (144,307)-(250,331) win.c:11703: Test failed: hwnd 4: expected rect (144,361)-(250,385), got (144,334)-(250,358) win.c:11703: Test failed: hwnd 5: expected rect (144,388)-(250,412), got (144,361)-(250,385) win.c:11703: Test failed: hwnd 6: expected rect (144,415)-(250,439), got (144,388)-(250,412) win.c:11703: Test failed: hwnd 7: expected rect (144,442)-(250,466), got (144,415)-(250,439) win.c:11703: Test failed: hwnd 8: expected rect (144,469)-(250,493), got (144,442)-(250,466) win.c:11703: Test failed: hwnd 9: expected rect (144,496)-(250,520), got (144,469)-(250,493) win.c:11738: Test failed: hwnd 0: expected rect (-60,189)-(46,213), got (86,189)-(192,213) win.c:11738: Test failed: hwnd 1: expected rect (-206,189)-(-100,213), got (-60,189)-(46,213) win.c:11738: Test failed: hwnd 2: expected rect (-352,189)-(-246,213), got (-206,189)-(-100,213) win.c:11738: Test failed: hwnd 3: expected rect (-498,189)-(-392,213), got (-352,189)-(-246,213) win.c:11738: Test failed: hwnd 4: expected rect (-644,189)-(-538,213), got (-498,189)-(-392,213) win.c:11738: Test failed: hwnd 5: expected rect (-790,189)-(-684,213), got (-644,189)-(-538,213) win.c:11738: Test failed: hwnd 6: expected rect (-936,189)-(-830,213), got (-790,189)-(-684,213) win.c:11738: Test failed: hwnd 7: expected rect (-1082,189)-(-976,213), got (-936,189)-(-830,213) win.c:11738: Test failed: hwnd 8: expected rect (-1228,189)-(-1122,213), got (-1082,189)-(-976,213) win.c:11738: Test failed: hwnd 9: expected rect (-1374,189)-(-1268,213), got (-1228,189)-(-1122,213) win.c:11834: Test failed: rect.left = 99 win.c:11835: Test failed: rect.top = 99 win.c:11836: Test failed: rect.right = 199 win.c:11837: Test failed: rect.bottom = 199 Report validation errors: user32:win prints too much data (36002 bytes) === debiant (32 bit WoW report) === user32: monitor: Timeout === debiant (64 bit WoW report) === user32: monitor: Timeout win.c:8455: Test failed: Expect width 100, got 1926. win.c:8456: Test failed: Expect height 100, got 1086.

Aug. 2, 2020

[PATCH] user32: Fix wsprintfA's buffer usage when using %S.

by Akihiro Sagawa

This fixes a regression introduced by 08bf605acb4d319e016a7eafe0c675509445bd4a. It could lead to stack corruption because ret can be negative when the output position, p, doesn't point the beginning of the buffer before the inner loop. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/user32/wsprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Aug. 2, 2020