January 2021 - Wine-Devel - list.winehq.org

[PATCH] mmdevapi: Correct reference count

by Alistair Leslie-Hughes

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/mmdevapi/devenum.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c index 9e4a29816ce..3060724d54c 100644 --- a/dlls/mmdevapi/devenum.c +++ b/dlls/mmdevapi/devenum.c @@ -856,6 +856,7 @@ static const IMMDeviceCollectionVtbl MMDevColVtbl = HRESULT MMDevEnum_Create(REFIID riid, void **ppv) { MMDevEnumImpl *This = MMDevEnumerator; + HRESULT hr; if (!This) { @@ -871,7 +872,9 @@ HRESULT MMDevEnum_Create(REFIID riid, void **ppv) load_driver_devices(eRender); load_driver_devices(eCapture); } - return IMMDeviceEnumerator_QueryInterface(&This->IMMDeviceEnumerator_iface, riid, ppv); + hr = IMMDeviceEnumerator_QueryInterface(&This->IMMDeviceEnumerator_iface, riid, ppv); + IMMDeviceEnumerator_Release(&This->IMMDeviceEnumerator_iface); + return hr; } void MMDevEnum_Free(void) -- 2.29.2

Jan. 5, 2021

[PATCH] dsound: IDirectSoundBuffer8 GetStatus return DSBSTATUS_LOCSOFTWARE for deferred buffers

by Alistair Leslie-Hughes

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=21014 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/dsound/buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c index bc30a8a5448..fafa6fc6015 100644 --- a/dlls/dsound/buffer.c +++ b/dlls/dsound/buffer.c @@ -420,6 +420,8 @@ static HRESULT WINAPI IDirectSoundBufferImpl_GetStatus(IDirectSoundBuffer8 *ifac if (This->playflags & DSBPLAY_LOOPING) *status |= DSBSTATUS_LOOPING; } + if (This->dsbd.dwFlags & DSBCAPS_LOCDEFER) + *status |= DSBSTATUS_LOCSOFTWARE; ReleaseSRWLockShared(&This->lock); TRACE("status=%x\n", *status); -- 2.29.2

Jan. 5, 2021

Re: [PATCH] winex11.drv: Check that there are connected outputs before using XRandR 1.4.

by Zhiyi Zhang

On 1/5/21 12:41 AM, Henri Verbeet wrote: > On Fri, 1 Jan 2021 at 06:01, Zhiyi Zhang <zzhang(a)codeweavers.com> wrote: >> On headless systems, Wine can still run through a VNC connection even though no outputs are >> connected. Fallback to using the Xinerama display device handler in this case to report at least >> one monitor. >> >> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49500 > Mostly out of curiosity, how does that work on Windows? Also, what > happens if the display is removed after the application has already > been started? I haven't tried it on real hardware. But I am guessing without a connected output, a VNC client/server won't be able to display anything on Windows. Using Remote Desktop service, Windows will report an emulated display using remote desktop client dimensions. If the only display is removed after the application has already started, Wine will send a WM_DISPLAYCHANGE message with a fallback emulated display of size 640x480 and report the the real size once the display is reconnected. Thanks, Zhiyi

Jan. 5, 2021

Re: [PATCH v3 3/3] winegstreamer: Split audio data to fit in the sample buffer.

by Zebediah Figura (she/her)

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>

Jan. 4, 2021

Re: [PATCH v3 2/3] winegstreamer: Move sample sending to a helper function.

by Zebediah Figura (she/her)

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> [Sorry for the slow review...]

Jan. 4, 2021

[PATCH] jscript/tests: Silence noisy debug trace.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/jscript/tests/api.js | 1 - 1 file changed, 1 deletion(-)

Jan. 4, 2021

[PATCH] conhost: Fix wripping search in edit_line_find_in_history.

by Jacek Caban

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50000 Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/conhost/conhost.c | 45 +++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 22 deletions(-)

Jan. 4, 2021

Re: [PATCH] comctl32: Remove the masked background also when adding alpha images.

by Nikolay Sivov

Is it possible to test this?

Jan. 4, 2021

[PATCH] comctl32: Remove the masked background also when adding alpha images.

by Gabriel Ivăncescu

Fixes a regression introduced by 61b9209221d28d5d02379791ac1316c1fc2ca3b7. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50454 Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/comctl32/imagelist.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index a6d9c73..170320c 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -290,6 +290,24 @@ static BOOL add_with_alpha( HIMAGELIST himl, HDC hdc, int pos, int count, } add_dib_bits( himl, pos, count, width, height, info, mask_info, bits, mask_bits ); + + if (hbmMask && himl->hbmMask) + { + HDC hdcTemp = CreateCompatibleDC(0); + POINT pt; + INT i; + + SelectObject(hdcTemp, hbmMask); + for (i = 0; i < count; i++) + { + imagelist_point_from_index( himl, pos + i, &pt ); + BitBlt( himl->hdcMask, pt.x, pt.y, width, height, hdcTemp, i * width, 0, SRCCOPY ); + + /* Remove the background from the image */ + BitBlt( himl->hdcImage, pt.x, pt.y, width, height, himl->hdcMask, pt.x, pt.y, 0x220326 ); /* NOTSRCAND */ + } + DeleteDC(hdcTemp); + } ret = TRUE; done: -- 2.29.2

Jan. 4, 2021

Re: [PATCH] include: Check whether the ms_abi attribute is supported on aarch64.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

Jan. 4, 2021