November 2021 - Wine-Devel - list.winehq.org

Re: [PATCH vkd3d 2/7] vkd3d-shader/hlsl: Generate synthetic temps for object uniforms as well.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH vkd3d v2 07/10] vkd3d-shader/hlsl: Add helpers for binary arithmetic operations.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH vkd3d v2 08/10] vkd3d-shader/hlsl: Add a helper for unary arithmetic operations.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH vkd3d v2 09/10] vkd3d-shader/hlsl: Do not cast types in add_expr.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH vkd3d v2 10/10] vkd3d-shader/hlsl: Add a helper for comparison operations.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH 2/7] jscript: Implement Object.prototype.isPrototypeOf method.

by Jacek Caban

On 10/25/21 3:30 PM, Gabriel Ivăncescu wrote: > Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> > --- > dlls/jscript/object.c | 13 +++++++++++-- > dlls/jscript/tests/lang.js | 13 +++++++++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/dlls/jscript/object.c b/dlls/jscript/object.c > index 169b47c..8da0ff4 100644 > --- a/dlls/jscript/object.c > +++ b/dlls/jscript/object.c > @@ -196,8 +196,17 @@ static HRESULT Object_propertyIsEnumerable(script_ctx_t *ctx, vdisp_t *jsthis, W > static HRESULT Object_isPrototypeOf(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, unsigned argc, jsval_t *argv, > jsval_t *r) > { > - FIXME("\n"); > - return E_NOTIMPL; > + jsdisp_t *jsdisp; > + BOOL ret = FALSE; > + > + if(!r) > + return S_OK; > + > + if(argc && is_jsdisp(jsthis) && is_object_instance(argv[0]) && (jsdisp = to_jsdisp(get_object(argv[0])))) > + ret = (jsdisp->prototype == jsthis->u.jsdisp); That's not what spec says we should do. > diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js > index ad1217d..bcfe88b 100644 > --- a/dlls/jscript/tests/lang.js > +++ b/dlls/jscript/tests/lang.js > @@ -1679,14 +1679,27 @@ tmp = new instanceOfTest(); > ok((tmp instanceof instanceOfTest) === true, "tmp is not instance of instanceOfTest"); > ok((tmp instanceof Object) === true, "tmp is not instance of Object"); > ok((tmp instanceof String) === false, "tmp is instance of String"); > +ok(Object.prototype.isPrototypeOf.call(instanceOfTest, tmp) === false, "instanceOfTest is prototype of tmp"); > +ok(Object.prototype.isPrototypeOf.call(instanceOfTest.prototype, tmp) === true, "instanceOfTest.prototype is not prototype of tmp"); Why do you use call() instead of doing regular calls? Thanks, Jacek

Nov. 1, 2021

Re: [PATCH 1/7] jscript: Fix some refcount leaks.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

Nov. 1, 2021

Re: [PATCH] vbscript: Avoid negating SUCCEEDED()

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>

Nov. 1, 2021

[PATCH] winhttp: Handle TLS close notify in netconn_is_alive().

by Paul Gofman

Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- Server may decide to close the connection that we have cached. In that case it may send 'Close notify' encrypted alert and then close the connection. Gnutls processes that [1] and returns zero length record from gnutls_record_recv(). We currently check for EOF on socket in netconn_is_alive(). But in that case the socket has 31 byte of data in the buffer while the socket is de facto closed already. read_ssl_chunk() will process this message leaving the socket in the EOF state. If there is some unrelated message it should stay in peek_msg buffer. read_ssl_chunk() should not block on receiving the data as the socket is in the non blocking state. 1. https://gitlab.com/gnutls/gnutls/-/blob/3.7.2/lib/record.c#L881 dlls/winhttp/net.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c index 8597179dc3e..3016608404a 100644 --- a/dlls/winhttp/net.c +++ b/dlls/winhttp/net.c @@ -616,11 +616,31 @@ DWORD netconn_set_timeout( struct netconn *netconn, BOOL send, int value ) BOOL netconn_is_alive( struct netconn *netconn ) { + SIZE_T size; int len; char b; DWORD err; + BOOL eof; set_blocking( netconn, FALSE ); + if (netconn->secure) + { + while (!netconn->peek_msg && !(err = read_ssl_chunk( netconn, NULL, 0, &size, &eof )) && !eof) + ; + + TRACE("Checking secure connection, err %d.\n", err); + + if (netconn->peek_msg || err == WSAEWOULDBLOCK) + { + set_blocking( netconn, TRUE ); + return TRUE; + } + if (err != SEC_E_OK && err != SEC_E_INCOMPLETE_MESSAGE) + { + set_blocking( netconn, TRUE ); + return FALSE; + } + } len = sock_recv( netconn->socket, &b, 1, MSG_PEEK ); err = WSAGetLastError(); set_blocking( netconn, TRUE ); -- 2.31.1

Nov. 1, 2021

[PATCH 3/3] winegstreamer: Set MF_MT_AUDIO_BLOCK_ALIGNMENT attribute on wg_format derived media types.

by Derek Lesho

Signed-off-by: Derek Lesho <dlesho(a)codeweavers.com> --- dlls/winegstreamer/mfplat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winegstreamer/mfplat.c b/dlls/winegstreamer/mfplat.c index 58200dc409a..2784a3ca130 100644 --- a/dlls/winegstreamer/mfplat.c +++ b/dlls/winegstreamer/mfplat.c @@ -563,6 +563,7 @@ static IMFMediaType *mf_media_type_from_wg_format_audio(const struct wg_format * IMFMediaType_SetUINT32(type, &MF_MT_AUDIO_SAMPLES_PER_SECOND, format->u.audio.rate); IMFMediaType_SetUINT32(type, &MF_MT_AUDIO_NUM_CHANNELS, format->u.audio.channels); IMFMediaType_SetUINT32(type, &MF_MT_AUDIO_CHANNEL_MASK, format->u.audio.channel_mask); + IMFMediaType_SetUINT32(type, &MF_MT_AUDIO_BLOCK_ALIGNMENT, format->u.audio.channels * audio_formats[i].depth / 8); IMFMediaType_SetUINT32(type, &MF_MT_ALL_SAMPLES_INDEPENDENT, TRUE); return type; -- 2.33.1

Nov. 1, 2021